Page MenuHomeWildfire Games

Prevent using privileged ports on *nix from the GUI
ClosedPublic

Authored by DynamoFox on Feb 16 2021, 2:21 PM.

Details

Reviewers
wraitii
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP24949: Prevent using privileged ports on *nix from the GUI
Summary

On *nix privileged ports range between 1 to 1023 included, currently the code checking for them doesn't account for GUI ports entered by the user.
This patch aims to change the minimum allowed port number used by 'getValidPort(port)'.

Test Plan
  • Try hosting a match by with a port < 1024 --> The GUI should notify the user about 1024 being the minimum port
  • Try hosting a match with port >= 1024 --> The match should be setup just fine.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

DynamoFox requested review of this revision.Feb 16 2021, 2:21 PM
DynamoFox updated this revision to Diff 15983.
DynamoFox created this revision.
  • Added TODO
Silier added a reviewer: Restricted Owners Package.Feb 16 2021, 2:40 PM
Stan added a subscriber: Stan.Feb 16 2021, 5:02 PM

Can you add yourself to the credits? :)

DynamoFox updated this revision to Diff 15985.Feb 16 2021, 5:11 PM
  • Added nickname to credits
wraitii accepted this revision.Feb 17 2021, 9:58 AM
wraitii added a subscriber: wraitii.

Should be merged once A24 is released :)

This revision is now accepted and ready to land.Feb 17 2021, 9:58 AM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Feb 27 2021, 5:41 PM