Differential D3754

Fix hotkeypage missing translation (translateWithContext)
ClosedPublic
Actions

Authored by nwtour on Mar 27 2021, 12:53 PM.

Details

Reviewers

wraitii

Commits

rP25148: Fix missing context in hotkey page translations.

Summary

In public-gui-other.po translation of hotkeys marked with "hotkey metadata" context

After the patch was applied, the translation appeared

parent: https://code.wildfiregames.com/D3641

Test Plan

Visually looks clean
During the day I will test additionally

Снимок экрана от 2021-03-27 14-46-33.png (778×788 px, 687 KB)

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nwtour requested review of this revision.Mar 27 2021, 12:53 PM

nwtour created this revision.

nwtour edited the summary of this revision. (Show Details)Mar 27 2021, 12:57 PM

add l10n with context -> hotkey category

Thanks for the patch, looks to be complete (for hotkeys anyways) from my testing.

This revision is now accepted and ready to land.Mar 28 2021, 9:45 AM

Closed by commit rP25148: Fix missing context in hotkey page translations. (authored by wraitii). · Explain WhyMar 28 2021, 10:00 AM

This revision was automatically updated to reflect the committed changes.

wraitii added a commit: rP25148: Fix missing context in hotkey page translations..

Owners added a subscriber: Restricted Owners Package.Mar 28 2021, 10:00 AM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

hotkeys/

HotkeyPicker.js

4 lines

HotkeysPage.js

13 lines

Diff 16792

View Options

ps/trunk/binaries/data/mods/public/gui/hotkeys/HotkeyPicker.js