Page MenuHomeWildfire Games

[Petra] Remove global constant from queueplanBuilding.js
ClosedPublic

Authored by Silier on Oct 10 2021, 2:03 PM.

Details

Reviewers
Freagarach
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Owners Package(Owns No Changed Paths)
Commits
rP25957: [Petra] Remove global constant from queueplanBuilding.js
Summary

If someone would try to copy petra and use it as base of own ai, one would not be able to run both ais at the same time and had to fix that global constant anyway.

Test Plan

Play games with petra

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Silier published this revision for review.Oct 10 2021, 2:03 PM
Silier created this revision.
Herald added a reviewer: Restricted Owners Package. · View Herald TranscriptOct 10 2021, 2:03 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/5057/display/redirect

Freagarach accepted this revision.Oct 10 2021, 8:36 PM
Freagarach added a subscriber: Freagarach.

Correct, having these kind of globals around is bad.
It is not used anywhere else (which would have been really bad).

One may please the linter whilst at it.

This revision is now accepted and ready to land.Oct 10 2021, 8:36 PM
This revision was landed with ongoing or failed builds.Oct 10 2021, 9:02 PM
This revision was automatically updated to reflect the committed changes.