If someone would try to copy petra and use it as base of own ai, one would not be able to run both ais at the same time and had to fix that global constant anyway.
Details
Details
- Reviewers
Freagarach - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Owners Package (Owns No Changed Paths) - Commits
- rP25957: [Petra] Remove global constant from queueplanBuilding.js
Play games with petra
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint Passed Severity Location Code Message Warning binaries/data/mods/public/simulation/ai/petra/queueplanBuilding.js:762 ESLINT prefer-const Warning binaries/data/mods/public/simulation/ai/petra/queueplanBuilding.js:806 ESLINT prefer-const - Unit
No Test Coverage - Build Status
Buildable 18536 Build 43768: Vulcan Build Jenkins Build 43767: Vulcan Build (macOS) Jenkins Build 43766: Vulcan Build (Windows) Build 43765: arc lint + arc unit
Event Timeline
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/5057/display/redirect
Comment Actions
Correct, having these kind of globals around is bad.
It is not used anywhere else (which would have been really bad).
One may please the linter whilst at it.