Page MenuHomeWildfire Games

new chat messages where they might be most needed
ClosedPublic

Authored by abian on Aug 13 2023, 7:59 PM.

Details

Reviewers
Freagarach
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP27832: Add some chat messages to PetraAI.
Summary

Add new chat messages where they might be most needed: PETRA.launchAttackMessages, PETRA.answerDiplomacyRequestMessages.ally.decline and PETRA.emergencyMessages (see D4645).

Test Plan

Tested in the game.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

abian created this revision.Aug 13 2023, 7:59 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/8871/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7200/display/redirect

Freagarach published this revision for review.Aug 14 2023, 10:47 AM
Herald added a reviewer: Restricted Owners Package. · View Herald TranscriptAug 14 2023, 10:47 AM
Herald added a subscriber: Silier. · View Herald Transcript

Nice additions. :)

/home/abian/0ad/binaries/data/mods/public/simulation/ai/petra/chatHelper.js
62 ↗(On Diff #22133)

Perhaps? (in my plans sounds a bit weird to me, since if it would be in its plans the offer would be from the AI to the player, not the other way around?)

abian updated this revision to Diff 22135.Aug 14 2023, 2:57 PM

Sounds better. Thanks!

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/8873/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7202/display/redirect

Freagarach accepted this revision.Aug 16 2023, 1:04 PM

Read fine.

This revision is now accepted and ready to land.Aug 16 2023, 1:04 PM
This revision was landed with ongoing or failed builds.Sep 8 2023, 11:23 AM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Sep 8 2023, 11:23 AM