In D5166#221807, @vladislavbelov wrote:

The patch changes behavior for heroes and treasures (also maybe researchers) which isn't mentioned. When a hero is moving the camera follows (without the patch it just goes to that position at the time and stays still).

Done, @wowgetoffyourcellphone. Looks good to me.
I didn't receive notification of your ping by email but I happened to log in and read your comment.

Thanks for your work. If you don't mind me criticizing a couple of things (hopefully constructive), I now see the chickens too big, I think a middle ground would be nice, and in the current state the chicken looks like it slips when walking, as now the "stride" of the animation doesn't match the movement.

Thanks for the work, @phosit. I've barely had time to test anything, but hopefully I'll make time for it in the next few weeks (only at a functional level, I won't yet be familiar enough with the code to review it properly).

Okay, Follow then (for units) and no player restrictions. Would you make F focus structures as well?
On "Click"/"Left-click", the latter is more explicit but we don't use it anywhere else except in a few explanations in the tutorials, in the rest of the cases we have "Click". We can leave it as "Left-click" for now, but it's not clear to me which is better in this case.
Single or double click? I would say single click because it has no other action defined and would also make double click work.
Should we also Follow by double-clicking on a hero icon? I would be okay with that.

In D5115#219400, @vladislavbelov wrote:

Could you attach screenshots for long translations?

Thanks for your comments! I think this will do the trick.

I'm leaving aside "Cartography" for lack of references.

Thank you both! Now the comparison is specified with "false" and the format is documented.

Okay! Sounds good.

Great! Keeping alertRaiser, now a dictionary. In any case, feel free to let me know if at any point you see that I'm throwing too much on your plate.

@Freagarach, what are your thoughts? I tend to assign you to review pretty much everything GUI-related by default, but feel free to tell me if you're too busy and think I should diversify a bit. :-)

In D5111#218411, @wowgetoffyourcellphone wrote:

Is this the actual Koine Greek? (Doric Greek may be used for the Spartans, while Koine for the others)

@sera: Yeah. :/ I hope the examples are enough. Thanks!
@Freagarach: Thanks too! I've changed the quotation marks, they look good in the game and I don't have to escape them. :D

Thanks as always, @Freagarach. In the end I've specified the classes of units affected, because otherwise the behavior is very confusing. Hopefully we're closer to the commit. :-)

In D5115#217268, @vladislavbelov wrote:

Have you checked other languages? There is a script to generate a special localization with longest words: source/tools/i18n/generateDebugTranslation.py.

Thanks, @Freagarach!

Fixed.

Useful feedback as well. Thanks!

Sounds better. Thanks!

Thanks! Done.

In D5094#216625, @sera wrote:

In D5094#216608, @Freagarach wrote:

Nice feature!
We may need to take into account that this leaks information to enemies.

While true, the borders reveal the same info already. Also AoE even sends a message to inform everyone of phase ups.

I'd argue that without being told it's hard to realize that this is supposed to indicate current phase, maybe take inspiration from AoE and boonGui on how to be more explicit if phase information is deemed worth showing.

@Freagarach: Thanks! Now this is ready for review.

@Freagarach: I looked for ways to contact you privately but didn't found any (which is reasonable in any case). Where's the best place within the forums to ask about small changes like this?

Sure! Added my nickname in the credits.

All suggestions applied. Thank you!

New changes in line with your comments:

• <DisabledTooltip>Infantry Hoplites only, requires at least 10.</DisabledTooltip> → <DisabledTooltip>Requires at least 10 Infantry Hoplites.</DisabledTooltip>, and similar cases in binaries/data/mods/public/simulation/templates/special/formations/*.xml.
• Insufficient resources → Requires more resources, in binaries/data/mods/public/simulation/components/Player.js.
• Removed all requirementsTooltips from binaries/data/mods/public/simulation/data/technologies/*.json. They'll now be generated automatically.

Please don't hate me for this, but I do find the "Trained by" useful. The "Builds" is also useful to check for example if a unit that you haven't trained yet will be able to build a certain structure. I certainly wouldn't be happy with the format, as that brick of plain text doesn't make it easy to find the information you may be looking for.

I've renamed it to 'objection', I think 'warning' might be too general (not everything that could be considered a warning should appear in red), but I came up with the name thanks to your suggestion. I hope I have now changed the coloredText(..., "red") where needed. Thanks!

In D4899#209226, @Freagarach wrote:

Thank you for the patch! I have one comment, which should be easy to do because of the function you used. :)
Also, @Stan has added you to the contributors group, so next time you upload a patch our linter will be run against your diff.

Use g_TooltipTextFormats.