Page MenuHomeWildfire Games

abian
User

Projects

User Details

User Since
Jan 18 2023, 10:22 PM (69 w, 3 d)

Recent Activity

Dec 13 2023

abian added a comment to D5166: follow the selected entity by clicking on its portrait or double-clicking on its icon.

The patch changes behavior for heroes and treasures (also maybe researchers) which isn't mentioned. When a hero is moving the camera follows (without the patch it just goes to that position at the time and stays still).

Dec 13 2023, 12:31 AM
abian retitled D5166: follow the selected entity by clicking on its portrait or double-clicking on its icon from center view on the selected entity by left-clicking on its portrait to follow the selected entity by clicking on its portrait or double-clicking on its icon.
Dec 13 2023, 12:16 AM

Dec 12 2023

abian added a reviewer for D5166: follow the selected entity by clicking on its portrait or double-clicking on its icon: wowgetoffyourcellphone.
Dec 12 2023, 5:15 PM
abian added reviewers for D5142: disable "cutoff distance" slider when "cover whole map" is on: vladislavbelov, sera.
Dec 12 2023, 5:03 PM
abian updated the diff for D5166: follow the selected entity by clicking on its portrait or double-clicking on its icon.

Done, @wowgetoffyourcellphone. Looks good to me.
I didn't receive notification of your ping by email but I happened to log in and read your comment.

Dec 12 2023, 2:56 PM

Oct 30 2023

abian added a comment to D5177: [Art] affecting [Gameplay] A 20% larger Chicken model.

Thanks for your work. If you don't mind me criticizing a couple of things (hopefully constructive), I now see the chickens too big, I think a middle ground would be nice, and in the current state the chicken looks like it slips when walking, as now the "stride" of the animation doesn't match the movement.

Oct 30 2023, 4:04 PM

Oct 23 2023

wowgetoffyourcellphone awarded D5166: follow the selected entity by clicking on its portrait or double-clicking on its icon a Dat Boi token.
Oct 23 2023, 5:24 AM

Oct 22 2023

abian added a comment to D4770: Multiplayer saved games.

Thanks for the work, @phosit. I've barely had time to test anything, but hopefully I'll make time for it in the next few weeks (only at a functional level, I won't yet be familiar enough with the code to review it properly).

Oct 22 2023, 12:24 AM

Oct 18 2023

abian added a comment to D5166: follow the selected entity by clicking on its portrait or double-clicking on its icon.

Okay, Follow then (for units) and no player restrictions. Would you make F focus structures as well?
On "Click"/"Left-click", the latter is more explicit but we don't use it anywhere else except in a few explanations in the tutorials, in the rest of the cases we have "Click". We can leave it as "Left-click" for now, but it's not clear to me which is better in this case.
Single or double click? I would say single click because it has no other action defined and would also make double click work.
Should we also Follow by double-clicking on a hero icon? I would be okay with that.

Oct 18 2023, 6:52 PM

Oct 17 2023

abian requested review of D5166: follow the selected entity by clicking on its portrait or double-clicking on its icon.
Oct 17 2023, 10:53 PM

Oct 15 2023

abian planned changes to D5115: fix vertical misalignment of text "Victory:" on save game screen.

Could you attach screenshots for long translations?

Oct 15 2023, 10:28 PM
abian updated the diff for D5151: avoid suggesting non-functional actions for Gaia entities.
Oct 15 2023, 9:54 PM
abian added inline comments to D5151: avoid suggesting non-functional actions for Gaia entities.
Oct 15 2023, 9:52 PM

Oct 12 2023

abian updated the summary of D5151: avoid suggesting non-functional actions for Gaia entities.
Oct 12 2023, 12:39 PM
abian updated the diff for D5151: avoid suggesting non-functional actions for Gaia entities.

Thanks for your comments! I think this will do the trick.

Oct 12 2023, 12:34 PM

Oct 8 2023

abian updated the diff for D5111: add specific names in Ancient Greek for Iron Weapons.

I'm leaving aside "Cartography" for lack of references.

Oct 8 2023, 7:26 PM

Oct 6 2023

abian requested review of D5151: avoid suggesting non-functional actions for Gaia entities.
Oct 6 2023, 8:28 PM

Sep 30 2023

abian updated the diff for D5142: disable "cutoff distance" slider when "cover whole map" is on.

Thank you both! Now the comparison is specified with "false" and the format is documented.

Sep 30 2023, 3:32 PM

Sep 27 2023

abian published D5142: disable "cutoff distance" slider when "cover whole map" is on for review.
Sep 27 2023, 6:24 PM

Sep 26 2023

abian added a comment to D5135: [WIP] Adds VK_EXT_memory_budget to Vulkan backend.

Okay! Sounds good.

Sep 26 2023, 7:37 PM
abian updated the diff for D5095: add brief explanations to the tooltips of the alert buttons.

Great! Keeping alertRaiser, now a dictionary. In any case, feel free to let me know if at any point you see that I'm throwing too much on your plate.

Sep 26 2023, 7:32 PM

Sep 24 2023

abian added a comment to D5095: add brief explanations to the tooltips of the alert buttons.

@Freagarach, what are your thoughts? I tend to assign you to review pretty much everything GUI-related by default, but feel free to tell me if you're too busy and think I should diversify a bit. :-)

Sep 24 2023, 4:08 PM
abian added a comment to D5111: add specific names in Ancient Greek for Iron Weapons.

Is this the actual Koine Greek? (Doric Greek may be used for the Spartans, while Koine for the others)

Sep 24 2023, 4:01 PM

Sep 13 2023

abian updated the diff for D5126: standardize game option names, minor changes.

@sera: Yeah. :/ I hope the examples are enough. Thanks!
@Freagarach: Thanks too! I've changed the quotation marks, they look good in the game and I don't have to escape them. :D

Sep 13 2023, 5:50 PM

Sep 12 2023

abian published D5126: standardize game option names, minor changes for review.
Sep 12 2023, 7:46 PM

Sep 8 2023

abian updated the diff for D5095: add brief explanations to the tooltips of the alert buttons.

Thanks as always, @Freagarach. In the end I've specified the classes of units affected, because otherwise the behavior is very confusing. Hopefully we're closer to the commit. :-)

Sep 8 2023, 5:37 PM

Aug 27 2023

abian updated the diff for D5115: fix vertical misalignment of text "Victory:" on save game screen.
Aug 27 2023, 10:27 PM
abian added a comment to D5115: fix vertical misalignment of text "Victory:" on save game screen.

Have you checked other languages? There is a script to generate a special localization with longest words: source/tools/i18n/generateDebugTranslation.py.

Aug 27 2023, 10:02 PM
abian published D5115: fix vertical misalignment of text "Victory:" on save game screen for review.
Aug 27 2023, 12:51 PM

Aug 26 2023

abian published D5111: add specific names in Ancient Greek for Iron Weapons for review.
Aug 26 2023, 6:41 PM

Aug 25 2023

abian added a comment to D5095: add brief explanations to the tooltips of the alert buttons.

Thanks, @Freagarach!

Aug 25 2023, 4:23 PM

Aug 20 2023

abian updated the diff for D5097: change isUndeletable to getDeletionPolicy and hide deletion option for animals.

Fixed.

Aug 20 2023, 7:43 PM

Aug 19 2023

abian closed D5102: improve color of repair icon.
Aug 19 2023, 1:16 PM

Aug 15 2023

abian published D5102: improve color of repair icon for review.
Aug 15 2023, 1:46 PM
abian updated the diff for D5101: don't show the option to abort order when there's no order to abort.
Aug 15 2023, 12:48 PM
abian published D5101: don't show the option to abort order when there's no order to abort for review.
Aug 15 2023, 12:02 AM

Aug 14 2023

abian published D5095: add brief explanations to the tooltips of the alert buttons for review.
Aug 14 2023, 10:34 PM
abian updated the diff for D5097: change isUndeletable to getDeletionPolicy and hide deletion option for animals.

Useful feedback as well. Thanks!

Aug 14 2023, 10:25 PM
abian updated the diff for D5100: new chat messages where they might be most needed.

Sounds better. Thanks!

Aug 14 2023, 2:57 PM
abian updated the diff for D5097: change isUndeletable to getDeletionPolicy and hide deletion option for animals.

Thanks! Done.

Aug 14 2023, 2:51 PM

Aug 9 2023

abian added a comment to D5094: introduce badge to indicate the phase.
In D5094#216625, @sera wrote:

Nice feature!
We may need to take into account that this leaks information to enemies.

While true, the borders reveal the same info already. Also AoE even sends a message to inform everyone of phase ups.

I'd argue that without being told it's hard to realize that this is supposed to indicate current phase, maybe take inspiration from AoE and boonGui on how to be more explicit if phase information is deemed worth showing.

Aug 9 2023, 1:02 AM

Aug 8 2023

abian updated the diff for D5094: introduce badge to indicate the phase.

@Freagarach: Thanks! Now this is ready for review.

Aug 8 2023, 6:26 PM
abian updated the diff for D5094: introduce badge to indicate the phase.
Aug 8 2023, 4:37 PM

Aug 7 2023

abian requested review of D5094: introduce badge to indicate the phase.
Aug 7 2023, 6:53 PM

Aug 5 2023

abian added a comment to D5075: when only one entity of a type is selected/garrisoned, don't show the number.

@Freagarach: I looked for ways to contact you privately but didn't found any (which is reasonable in any case). Where's the best place within the forums to ask about small changes like this?

Aug 5 2023, 5:30 PM

Jul 22 2023

abian awarded D5042: Fix performance drop and memory leak on network games with AI a Yellow Medal token.
Jul 22 2023, 5:44 PM
abian updated the diff for D5075: when only one entity of a type is selected/garrisoned, don't show the number.

Sure! Added my nickname in the credits.

Jul 22 2023, 4:37 PM

Jul 10 2023

abian updated the diff for D5074: include military formation descriptions .

All suggestions applied. Thank you!

Jul 10 2023, 3:18 PM

Jul 9 2023

abian requested review of D5074: include military formation descriptions .
Jul 9 2023, 9:21 PM

Apr 15 2023

abian added inline comments to D4963: improve messages of unmet requirements.
Apr 15 2023, 4:02 PM

Apr 5 2023

defc0n awarded D4963: improve messages of unmet requirements a Like token.
Apr 5 2023, 5:33 PM
abian updated the diff for D4963: improve messages of unmet requirements.

New changes in line with your comments:

  • <DisabledTooltip>Infantry Hoplites only, requires at least 10.</DisabledTooltip> โ†’ <DisabledTooltip>Requires at least 10 Infantry Hoplites.</DisabledTooltip>, and similar cases in binaries/data/mods/public/simulation/templates/special/formations/*.xml.
  • Insufficient resources โ†’ Requires more resources, in binaries/data/mods/public/simulation/components/Player.js.
  • Removed all requirementsTooltips from binaries/data/mods/public/simulation/data/technologies/*.json. They'll now be generated automatically.
Apr 5 2023, 5:27 PM

Mar 11 2023

abian added a comment to D4762: [gui] remove the 'trained by' and 'builds' string from the extended tooltip.

Please don't hate me for this, but I do find the "Trained by" useful. The "Builds" is also useful to check for example if a unit that you haven't trained yet will be able to build a certain structure. I certainly wouldn't be happy with the format, as that brick of plain text doesn't make it easy to find the information you may be looking for.

Mar 11 2023, 2:44 PM

Mar 8 2023

asterix awarded D4963: improve messages of unmet requirements a Love token.
Mar 8 2023, 11:01 PM
abian added a reviewer for D4963: improve messages of unmet requirements: Freagarach.
Mar 8 2023, 7:49 PM
abian requested review of D4963: improve messages of unmet requirements.
Mar 8 2023, 7:31 PM

Jan 20 2023

abian updated the diff for D4899: consistent style (red, bold) for tooltips on unmet requirements.

I've renamed it to 'objection', I think 'warning' might be too general (not everything that could be considered a warning should appear in red), but I came up with the name thanks to your suggestion. I hope I have now changed the coloredText(..., "red") where needed. Thanks!

Jan 20 2023, 9:47 PM

Jan 19 2023

abian updated the summary of D4899: consistent style (red, bold) for tooltips on unmet requirements.
Jan 19 2023, 12:40 PM
abian added a comment to D4899: consistent style (red, bold) for tooltips on unmet requirements.

Thank you for the patch! I have one comment, which should be easy to do because of the function you used. :)
Also, @Stan has added you to the contributors group, so next time you upload a patch our linter will be run against your diff.

Jan 19 2023, 12:34 PM
abian updated the diff for D4899: consistent style (red, bold) for tooltips on unmet requirements.

Use g_TooltipTextFormats.

Jan 19 2023, 12:32 PM
abian requested review of D4899: consistent style (red, bold) for tooltips on unmet requirements.
Jan 19 2023, 12:01 AM