Page MenuHomeWildfire Games

abian
User

Projects

User Details

User Since
Jan 18 2023, 10:22 PM (19 w, 4 d)

Recent Activity

Apr 15 2023

abian added inline comments to D4963: improve messages of unmet requirements.
Apr 15 2023, 4:02 PM

Apr 5 2023

defc0n awarded D4963: improve messages of unmet requirements a Like token.
Apr 5 2023, 5:33 PM
abian updated the diff for D4963: improve messages of unmet requirements.

New changes in line with your comments:

  • <DisabledTooltip>Infantry Hoplites only, requires at least 10.</DisabledTooltip> โ†’ <DisabledTooltip>Requires at least 10 Infantry Hoplites.</DisabledTooltip>, and similar cases in binaries/data/mods/public/simulation/templates/special/formations/*.xml.
  • Insufficient resources โ†’ Requires more resources, in binaries/data/mods/public/simulation/components/Player.js.
  • Removed all requirementsTooltips from binaries/data/mods/public/simulation/data/technologies/*.json. They'll now be generated automatically.
Apr 5 2023, 5:27 PM

Mar 11 2023

abian added a comment to D4762: [gui] remove the 'trained by' and 'builds' string from the extended tooltip.

Please don't hate me for this, but I do find the "Trained by" useful. The "Builds" is also useful to check for example if a unit that you haven't trained yet will be able to build a certain structure. I certainly wouldn't be happy with the format, as that brick of plain text doesn't make it easy to find the information you may be looking for.

Mar 11 2023, 2:44 PM

Mar 8 2023

asterix awarded D4963: improve messages of unmet requirements a Love token.
Mar 8 2023, 11:01 PM
abian added a reviewer for D4963: improve messages of unmet requirements: Freagarach.
Mar 8 2023, 7:49 PM
abian requested review of D4963: improve messages of unmet requirements.
Mar 8 2023, 7:31 PM

Jan 20 2023

abian updated the diff for D4899: consistent style (red, bold) for tooltips on unmet requirements.

I've renamed it to 'objection', I think 'warning' might be too general (not everything that could be considered a warning should appear in red), but I came up with the name thanks to your suggestion. I hope I have now changed the coloredText(..., "red") where needed. Thanks!

Jan 20 2023, 9:47 PM

Jan 19 2023

abian updated the summary of D4899: consistent style (red, bold) for tooltips on unmet requirements.
Jan 19 2023, 12:40 PM
abian added a comment to D4899: consistent style (red, bold) for tooltips on unmet requirements.

Thank you for the patch! I have one comment, which should be easy to do because of the function you used. :)
Also, @Stan has added you to the contributors group, so next time you upload a patch our linter will be run against your diff.

Jan 19 2023, 12:34 PM
abian updated the diff for D4899: consistent style (red, bold) for tooltips on unmet requirements.

Use g_TooltipTextFormats.

Jan 19 2023, 12:32 PM
abian requested review of D4899: consistent style (red, bold) for tooltips on unmet requirements.
Jan 19 2023, 12:01 AM