Page MenuHomeWildfire Games

[Art] Fixes an oversight in the variant files
ClosedPublic

Authored by wowgetoffyourcellphone on Oct 5 2023, 3:17 AM.

Details

Summary

Adds prop attachpoint="weapon_bow" to the list to remove bows from the hands of units while they gather resources. This is a long-time oversight, now corrected.

Test Plan
  1. Apply patch
  2. please test bow-wielding units on gathering resources, etc. and make sure this works and there are no bugs.
  3. Test units with capes as well to see if more work needs done in the cape actors (or not, maybe not)

Normally, I would just commit this art patch on my own without review, but it is a large number of files with a possibility of visual bugs

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Vulcan added a comment.Oct 5 2023, 3:17 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7364/display/redirect

Vulcan added a comment.Oct 5 2023, 3:20 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8453/display/redirect

wowgetoffyourcellphone requested review of this revision.Oct 5 2023, 3:46 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 6 2023, 5:40 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.