Default many of CFsm's special functions and remove virtual specifires
ClosedPublic
Actions

Authored by phosit on Feb 26 2024, 6:56 PM.

Details

Reviewers

vladislavbelov

Commits

rP28053: Default many of CFsm's special functions and remove virtual specifires

Summary

The virtual functions are never overriden.
Initialize is never used.
Shutdown is only used in the destructor. The default destructor does the same thing.
CFsm is now "semiregular".

Test Plan

Host a game.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

phosit created this revision.Feb 26 2024, 6:56 PM

phosit published this revision for review.Feb 26 2024, 8:59 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 21 2024, 6:48 PM

This revision was landed with ongoing or failed builds.

Closed by commit rP28053: Default many of CFsm's special functions and remove virtual specifires (authored by phosit). · Explain Why

This revision was automatically updated to reflect the committed changes.

phosit added a commit: rP28053: Default many of CFsm's special functions and remove virtual specifires.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

source/

network/

FSM.h

27 lines

FSM.cpp

29 lines

Diff 22833

View Options

ps/trunk/source/network/FSM.h