Page MenuHomeWildfire Games

Small palisade rubble fix
ClosedPublic

Authored by temple on Jun 29 2017, 2:40 AM.

Details

Summary

Currently many palisades show foundation when you destroy them instead of rubble. There is no custom rubble art for palisades, so this patch uses rubble_stone_2x2 which should be close enough for the time being.

You can test some of the palisades on the new map Danubius (switch to Gaia and delete the palisades). I noticed the hut on that map had rubble that was too large, so I changed it to rubble_stone_2x2 as well.

Test Plan

There are 14 palisade_* items, and they should all show 2x2 rubble now (besides fort, which uses the tower rubble, which is similar).
I changed template_structure_defense_wall to be 2x2 rubble (easier than modifying each of the other files). Besides palisades it's only called by the three stone walls, each of which has its own rubble. So I think it should be fine.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

temple created this revision.Jun 29 2017, 2:40 AM
temple added a reviewer: elexis.
elexis accepted this revision.Jun 30 2017, 9:51 PM

It is correct, 14 palisade*xml files indeed, four of them inherit template_structure_defense_wall_gate, so they indeed have to replace the SpawnEntityOnDeath.
The rest of them can just inherit the entry of template_structure_defense_wall.xml, even though no template_structure_defense_wall_foo.xml uses that entry.
An alternative would be to remove it from the parent and add it to every child, but that doesn't make a significant difference.

The size 2x2 is definitely too much and very apparent ingame, but it's still better than using foundations.

As with D643, we should delete the now unused and still unusable files in the same patch that made them unused.

Thanks for the patch! Those foundations have been annoying me since I saw destroyed foundations the first time! (Didn't even notice it for other buildings).
Also thanks for fixing the other item on Danubius :-)

This revision is now accepted and ready to land.Jun 30 2017, 9:51 PM
This revision was automatically updated to reflect the committed changes.