Differential D773

[WIP] Test resource logic in Player component
AbandonedPublic
Actions

Authored by fatherbushido on Aug 8 2017, 1:36 PM.

Details

Reviewers: None

Summary

Test the different method in Player.js.
Not intend to be reviewed right now.

Test Plan

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 2726
Build 4649: Vulcan Build (Windows)	Jenkins
Build 4648: Vulcan Build	Jenkins
Build 4646: arc lint + arc unit

Event Timeline

fatherbushido created this revision.Aug 8 2017, 1:36 PM

Executing section Default...
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (dot-notation):
|    | ["wood"] is better written in dot notation.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/simulation/components/tests/test_Player.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/simulation/components/tests/test_Player.js
|  78|  78| 
|  79|  79| let startingResources = { "food": 200, "metal": 200, "stone": 100, "wood": 100 }
|  80|  80| cmpPlayer.SetResourceCounts(startingResources);
|  81|    |-TS_ASSERT_EQUALS(cmpPlayer.resourceCount["wood"], 100);
|    |  81|+TS_ASSERT_EQUALS(cmpPlayer.resourceCount.wood, 100);
|  82|  82| TS_ASSERT_UNEVAL_EQUALS(cmpPlayer.GetResourceCounts(), startingResources);
|  83|  83| 
|  84|  84| let amounts = { "stone": 150, "metal": 150 }

binaries/data/mods/public/simulation/components/tests/test_Player.js
|  72| »   "GetPlayerByID":·id·=>·1·?·10·:·11,
|    | [NORMAL] ESLintBear (no-constant-condition):
|    | Unexpected constant condition.

binaries/data/mods/public/simulation/components/tests/test_Player.js
|  79| let·startingResources·=·{·"food":·200,·"metal":·200,·"stone":·100,·"wood":·100·}
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/tests/test_Player.js
|  81| TS_ASSERT_EQUALS(cmpPlayer.resourceCount["wood"],·100);
|    | [NORMAL] JSHintBear:
|    | ['wood'] is better written in dot notation.

binaries/data/mods/public/simulation/components/tests/test_Player.js
|  84| let·amounts·=·{·"stone":·150,·"metal":·150·}
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/tests/test_Player.js
|  89| amounts·=·{·"stone":·100,·"metal":·100·}
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/tests/test_Player.js
|  94| amounts·=·{·"stone":·0.2·}
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/tests/test_Player.js
|  99| amounts·=·{·"food":·9.2,·"metal":·9.8·}
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/tests/test_Player.js
| 105| amounts·=·{·"metal":·-10·}
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/tests/test_Player.js
| 110| startingResources·=·{·"food":·200,·"metal":·200,·"stone":·100,·"wood":·100·}
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/tests/test_Player.js
| 112| amounts·=·{·"metal":·50·}
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/363/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1816/ for more details.

Harbormaster completed remote builds in B2726: Diff 3040.Aug 8 2017, 7:36 PM

fatherbushido abandoned this revision.Aug 30 2017, 11:24 PM

fatherbushido reclaimed this revision.Oct 1 2017, 8:45 AM

fatherbushido planned changes to this revision.

fatherbushido abandoned this revision.Nov 12 2017, 5:33 PM