Page MenuHomeWildfire Games

fatherbushido
User

Projects

User Details

User Since
Dec 21 2016, 3:21 PM (113 w, 3 h)

Recent Activity

Mon, Feb 18

fatherbushido added a comment to rP22081: Rome Testudo & Anti-Cavalry formations animations:.

I'd first to salute the artwork.
So I hesitated to post something here and I wondered if I was the only one to notice some weird visual.
Is there something wrong in the animation (or in the code?), I have the anti_cavalry formation walking then sometimes putting knees on the ground and standing up doing some kind of squat.

Mon, Feb 18, 11:17 AM
fatherbushido added a comment to D1780: legionnaire → legionary.

And those two ones (are those good sources?) doesn't restrict legionary to romans:
https://www.collinsdictionary.com/dictionary/english/legionary
https://www.merriam-webster.com/dictionary/legionary

Mon, Feb 18, 10:52 AM
fatherbushido added a comment to D1780: legionnaire → legionary.

The fact that one is used doesn't mean that the other is not correct :D
I don't know if those electronic dictionnaries are ok but:
It's explictly in https://en.oxforddictionaries.com/definition/legionnaire
It's in the examples in https://www.merriam-webster.com/dictionary/legionnaire#examples
Only the general meaning without explicit mention to antiquity is in https://www.collinsdictionary.com/dictionary/english/legionnaire
It's not in https://dictionary.cambridge.org/spellcheck/english/?q=legionnaire
(I am not an expert in english - euphemism - not in the position to discuss if this is good or not! Just take that as discussing about things ;-))

Mon, Feb 18, 9:29 AM
fatherbushido added a comment to rP22082: Rome helmets (Also reverting a deleted song in rome civ template):.

Fixed in rP22090 (rome_helmet_agen)

Mon, Feb 18, 8:55 AM
fatherbushido added a comment to rP22079: Remove old naming schema of Celtic helmets..

Fixed in rP22090

Mon, Feb 18, 8:53 AM
fatherbushido added a comment to rP22074: Add pig animation source files..

fixed in rP22089

Mon, Feb 18, 8:51 AM
fatherbushido added a comment to rP22062: Hele Phrygian Helmet commit.

fixed in rP22091 and rP22092

Mon, Feb 18, 8:50 AM

Sat, Feb 16

fatherbushido added a comment to D1472: Grouped civ bonuses into a single folder.
In D1472#72081, @Nescio wrote:

Grouping generic and special technologies together makes sense. In that case we might also consider moving advanced_unit_bonus.json, elite_unit_bonus.json, and phase_village.json into the civbonuses folder and renaming it to autoresearched.

Sat, Feb 16, 9:39 AM

Fri, Feb 15

fatherbushido added a comment to D1472: Grouped civ bonuses into a single folder.
In D1472#72079, @Nescio wrote:

True; I'm willing to update D888 to do that, but before that, two things have to be decided first:

  • should we keep unused technologies that were deprecated years ago (D1775)?
  • should special technologies (e.g. siege_bolt_accuracy.json) be grouped together in a special directory or should they be grouped alongside ordinary technologies?
Fri, Feb 15, 10:49 PM

Thu, Feb 14

fatherbushido added a comment to D1472: Grouped civ bonuses into a single folder.
In D1472#71402, @Nescio wrote:

How I understand things:

  • civbonuses are free and automatically researched and are available to one or more factions, but not all
  • special technologies cost resources and are available to one or more factions, but not all
  • general technologies cost resources and are available to all factions
  • advanced_unit_bonus.json, elite_unit_bonus.json, and phase_village.json are free and automatically researched and are available to all factions What to do with the special technologies can be decided later; they could be grouped together under special/ (see (D888 (outdated)) or mixed with the general technologies (see siege_bolt_accuracy.json). This patch only groups the civbonuses.
Thu, Feb 14, 11:48 AM

Tue, Jan 29

fatherbushido added a comment to D1472: Grouped civ bonuses into a single folder.
In D1472#71391, @Nescio wrote:

It's much easier for modders if all civ-bonuses for all factions are simply grouped together in a single directory, hence this proposal.

Tue, Jan 29, 8:38 PM
fatherbushido added a comment to D1472: Grouped civ bonuses into a single folder.
In D1472#61121, @Nescio wrote:
Tue, Jan 29, 5:42 PM

Jan 20 2019

fatherbushido added a comment to D1734: Merge entity templates.
In D1734#70659, @Nescio wrote:

Serendipity?

Jan 20 2019, 6:11 PM
fatherbushido added a comment to D1734: Merge entity templates.
In D1734#70655, @Stan wrote:

Of course you said it had deeper meaning in the code so I had assumed you had a hint.

Shirt is just my way to swear it replaces another word.

Jan 20 2019, 5:55 PM
fatherbushido added a comment to D1734: Merge entity templates.
In D1734#70653, @Stan wrote:

Ah... shirt.

Jan 20 2019, 5:45 PM
fatherbushido added a comment to D1734: Merge entity templates.

If I ask, it's that I don't know.

Jan 20 2019, 5:14 PM
fatherbushido added a comment to D1734: Merge entity templates.

Perhaps one could have taken the opportunity to explain where did it come from.
Basically, it had code implications and wasn't only cosmetic (a long time ago).

Jan 20 2019, 5:06 PM

Jan 6 2019

fatherbushido added a comment to D1523: Fauna names and other corrections.

The idea is more: what are those things?

Jan 6 2019, 12:28 PM

Jan 3 2019

fatherbushido added inline comments to D1523: Fauna names and other corrections.
Jan 3 2019, 12:54 PM
fatherbushido added a comment to D1523: Fauna names and other corrections.
In D1523#62158, @Stan wrote:

I always have been wondering though what the real purpose of the specific name is. Is it like dog mastiff or mastiff (Insert Latin name here)

Jan 3 2019, 12:22 PM
fatherbushido added a comment to D1460: Add an experience status bar.

I feel a bit stupid.
That bar is displayed when you click on a unit? But currently, there is already such a bar at another place isn't it?
Or is it relevant only for group selection of units?

Jan 3 2019, 11:53 AM

Jan 1 2019

fatherbushido added a comment to D1725: Fix missing refs in sound files..
In D1725#68444, @Stan wrote:

Should I say Patch by:
Fork 0AD then ?

Jan 1 2019, 8:27 PM
fatherbushido added a comment to D1725: Fix missing refs in sound files..

You are welcome.

Jan 1 2019, 8:16 PM
smiley awarded D1725: Fix missing refs in sound files. a Like token.
Jan 1 2019, 8:07 PM
fatherbushido created D1725: Fix missing refs in sound files..
Jan 1 2019, 8:03 PM
fatherbushido added inline comments to rP21997: New Texture: Ptolemaic Royal Agema and Royal Companion.
Jan 1 2019, 9:34 AM

Dec 31 2018

fatherbushido added a comment to D1009: Template organization: flora and fauna.

moves gaia/fauna_* to gaia/fauna/*
moves gaia/flora_* to gaia/flora/*

Dec 31 2018, 4:27 PM
fatherbushido added a comment to D1719: manual/intro.txt corrections.

(I had personnaly never heard/read ForwardSlash before reading that diff :-). I didn't know the concept of hypercorrection, thanks.)
My main interrogation is was it considered to change in those other places refering to the same thing?
I guess there is a good argument to not have done it, the commiter may know better than us. (I can see a good reason).

Dec 31 2018, 1:07 PM
fatherbushido added a comment to D1719: manual/intro.txt corrections.
Dec 31 2018, 12:08 PM
fatherbushido added a comment to D1707: Hard-counter tooltips.

The proposal is about adding a tooltip to something existing. If I was in position to attribute adjectives, I would qualify that of nice and desired (#4130).
I wonder what is the link between an AI and a tooltip.
Did the new AI read tooltip?

Dec 31 2018, 11:53 AM

Dec 28 2018

fatherbushido added a comment to D1342: Corrected Mauryans into Mauryas.

np
edit: The question had to be asked (as it had been asked: https://wildfiregames.com/forum/index.php?/topic/24732-de-alpha-24/&tab=comments#comment-361505).

Dec 28 2018, 6:57 PM
fatherbushido added a comment to D1342: Corrected Mauryans into Mauryas.

For the dictionnary advice, you should give that to the guys who write that on the internet, not to me.
And I also read books like "History of Early India From the Origins to AD 1300" and indeed in chapter 6, we can read "The Emergence of Empire: Mauryan India" followed by "The Mauryas and their World".

Dec 28 2018, 6:50 PM
fatherbushido added a comment to D1342: Corrected Mauryans into Mauryas.

Mauryans is not a proper word.

Dec 28 2018, 5:08 PM

Jun 11 2018

fatherbushido added a comment to rP20393: Move out of world promoted, packed and upgraded entity as they are not….

(I wonder if the concern shouldn't be removed, as the pointed bug was not really related to that patch)

Jun 11 2018, 8:19 AM
fatherbushido added a comment to rP19694: Allow walls and fields to be captured by territory but not by capture attack….

(I wonder if the concern shouldn't be removed now?)

Jun 11 2018, 8:18 AM

May 19 2018

fatherbushido updated subscribers of D1502: Remove some unused functions.

(About SoundGroup there is in soundmanager/SoundManager.(cpp/h) and soundmanager/scripting/SoundGroup.(cpp/h) an entity_id_t source parsed all over the place which is unused everywhere iirc. The end leaf is ItemForEntity but one had to climb the tree.
By the way I have strange things when typing @leper, is it a phabricator formatting issue?)

May 19 2018, 4:16 PM
fatherbushido created D1505: Add kush refs at some places.
May 19 2018, 3:59 PM

May 14 2018

fatherbushido added a comment to D1245: Experience trickle.

ref https://wildfiregames.com/forum/index.php?/topic/21146-officers/

May 14 2018, 7:16 PM
fatherbushido added a comment to D1472: Grouped civ bonuses into a single folder.

https://wildfiregames.com/forum/index.php?/topic/21563-subfolders-in-simulationdatatechnologies/

May 14 2018, 3:04 PM

Apr 26 2018

fatherbushido added a comment to rP21785: Stop some auras from being applied extra times, don't apply player auras to….

(I wonder why that thing https://trac.wildfiregames.com/wiki/SubmittingPatches#Makingsomechanges was written ; I post that randomly here)

Apr 26 2018, 9:41 AM

Apr 24 2018

fatherbushido added a comment to D1453: Update auras of entites of non-defeated players that affect defeated players.

GetAffectedPlayers did a strike

Apr 24 2018, 3:19 PM
fatherbushido added inline comments to rP19601: Buff elephant archer after rP18286 made it slow, rP18363 removed the capturing….
Apr 24 2018, 12:14 PM

Apr 23 2018

fatherbushido added a comment to rP21623: Remove an ancient unused placeholder template..

(if l16 of the deleted file was a hint, l29 is another)
So for future readers there are related dummy cmp and interfaces (js and cpp) related to that template.

Apr 23 2018, 11:20 PM
fatherbushido added a comment to D1430: Fix some auras not being removed.

I guess moving one line is something bad and it s better to keep that obvious broken loop.

Apr 23 2018, 11:09 PM
fatherbushido added a comment to rP21623: Remove an ancient unused placeholder template..

It was mainly here since the beggining (sim 1) as something for the original territory idea. There were even some map using that templates (latium iirc).
#41 is one of the entry point for that
All those grounds were copied when sim 2 was commited.

Apr 23 2018, 3:40 PM
fatherbushido added a comment to rP21284: Give spear cavalry an anti-cav bonus.

For geologists. (Not that I care about those things (anymore).)

Apr 23 2018, 3:15 PM
fatherbushido added a comment to rP19950: Splash damage on death. When an entity dies, it can do a splash damage. Fire….

refs #4783 for tooltip
refs D388 for the previous 'balance' tweak

Apr 23 2018, 2:04 PM
fatherbushido added a comment to D1452: Nerf BoltShooter massing.

Just for archeologists

Apr 23 2018, 12:49 PM

Apr 20 2018

fatherbushido added a comment to D1430: Fix some auras not being removed.

The bug fix is
https://code.wildfiregames.com/rP19092#29903
It was an obvious 'copy paste' error I did (mixing two ways of writing things). Straightforward.

Apr 20 2018, 4:47 PM

Apr 19 2018

fatherbushido added a comment to D1453: Update auras of entites of non-defeated players that affect defeated players.
Apr 19 2018, 2:38 PM
fatherbushido added a comment to D1453: Update auras of entites of non-defeated players that affect defeated players.
  • so it looks that the relevant case (about that useless clean call) is when the aura source owner is defeated. If so, there is several solutions.
Apr 19 2018, 12:49 PM
fatherbushido added a comment to D1453: Update auras of entites of non-defeated players that affect defeated players.

Wonders are cleaned twice if a player resigns doesn't look like an ownership / defeated one.

Apr 19 2018, 12:23 PM
fatherbushido added a comment to D1453: Update auras of entites of non-defeated players that affect defeated players.

(((One source of redundant clean is that they are done for all auras of a given entity. Clean(name) was a possibility, but it didn't seem worth the value)))
In the context of that diff, I wonder which situation trigger a (true) duplicate Ownership / Defeated call to clean. If so, there exists a (clean?) way to avoid it.

Apr 19 2018, 11:52 AM

Apr 16 2018

fatherbushido added a comment to rP21713: Don't apply team bonuses to defeated players, counterpart to rP19093 / D12..

The global listening was perhaps not needed in rP21712

Apr 16 2018, 5:15 PM

Apr 14 2018

fatherbushido added a comment to rP21713: Don't apply team bonuses to defeated players, counterpart to rP19093 / D12..

Unit tests:

Apr 14 2018, 2:50 PM
fatherbushido added a comment to D1430: Fix some auras not being removed.

capsule time:
when the typo/copypaste/bug fix and another thing can be split, perhaps could they be split.

Apr 14 2018, 7:57 AM
fatherbushido added a comment to rP21713: Don't apply team bonuses to defeated players, counterpart to rP19093 / D12..

(To be more explicit, it doesn't solve the issue it aimed to solve)

Apr 14 2018, 7:54 AM

Apr 13 2018

fatherbushido added a comment to rP21713: Don't apply team bonuses to defeated players, counterpart to rP19093 / D12..

For any android reading that:

Apr 13 2018, 7:32 PM
fatherbushido added inline comments to rP21711: Don't recompute auras of each and every entity globally upon playerdefeat, but….
Apr 13 2018, 7:13 PM
fatherbushido added inline comments to D1430: Fix some auras not being removed.
Apr 13 2018, 6:59 PM

Apr 11 2018

fatherbushido added inline comments to rP19093: Remove team bonus when the source player is defeated. Reviewed by wraitii..
Apr 11 2018, 7:10 PM
fatherbushido added inline comments to D1426: Reduce aura defeat lag by avoiding useless recomputation of all auras globally.
Apr 11 2018, 6:38 PM
fatherbushido added inline comments to rP19093: Remove team bonus when the source player is defeated. Reviewed by wraitii..
Apr 11 2018, 6:26 PM

Apr 7 2018

fatherbushido added a comment to rP21667: Add an IsInWorld check to Formation.

\begin{noteforwhoneedsit}
don't forget the other missing isinworld checks in that file when calling getposition
\end{noteforwhoneedsit}

Apr 7 2018, 8:29 PM

Apr 4 2018

fatherbushido added inline comments to D1430: Fix some auras not being removed.
Apr 4 2018, 5:28 PM

Apr 3 2018

fatherbushido added a comment to D1430: Fix some auras not being removed.

Doing that first could have been an option:

Apr 3 2018, 6:21 PM
fatherbushido added a comment to rP19092: Don't use range queries for global auras. Fix related team bonus. Add Mauryan….

if one would want to start its dev from this rev, here is the fix:

Apr 3 2018, 7:20 AM

Apr 2 2018

fatherbushido added inline comments to rP19092: Don't use range queries for global auras. Fix related team bonus. Add Mauryan….
Apr 2 2018, 11:13 PM
fatherbushido added a comment to rP19092: Don't use range queries for global auras. Fix related team bonus. Add Mauryan….

(The author of the patch (edit: and of this line) should have done the unit tests he promised to do and never completed.)
Regression : team bonus (at least for 'template' change) are messed with diplomacy changes (with the proper amount of players)

Apr 2 2018, 9:35 PM
fatherbushido added inline comments to rP19093: Remove team bonus when the source player is defeated. Reviewed by wraitii..
Apr 2 2018, 9:33 PM
fatherbushido added a comment to D1426: Reduce aura defeat lag by avoiding useless recomputation of all auras globally.

The Iberian cheap skirm bonus isn't removed,
That's a problem with rP19093.

Apr 2 2018, 5:19 PM
fatherbushido added inline comments to rP19093: Remove team bonus when the source player is defeated. Reviewed by wraitii..
Apr 2 2018, 5:17 PM

Nov 12 2017

fatherbushido removed a reviewer for D438: Change Run Speed into a Run multiplier: fatherbushido.
Nov 12 2017, 6:31 PM
fatherbushido removed a reviewer for D834: Adjust accuracy (spread multiplier) in technologies: fatherbushido.
Nov 12 2017, 6:30 PM
fatherbushido removed a reviewer for D747: Fix sounds inheritance of template_unit_hero_{unit}.xml: fatherbushido.
Nov 12 2017, 6:30 PM
fatherbushido removed reviewers for D781: Elevation attack bonus for ranged units: sanderd17, fatherbushido.
Nov 12 2017, 6:30 PM
fatherbushido removed a reviewer for D880: Ballistics: fatherbushido.
Nov 12 2017, 6:29 PM
fatherbushido added a comment to rP20428: Add Vector3D crossproduct and Vector2D perpendicular function..

Some comments to a 2 years old friend as I was cleaning my stuffs ;-)
I don't understand the purpose of the comments.
We can just say that it returns the dot or the cross product, it's simpler ;-)

Nov 12 2017, 5:51 PM
fatherbushido added a comment to D939: [WIP]Test rotations function in Position component.

(good luck with +Pi stuff)

Nov 12 2017, 5:34 PM
fatherbushido abandoned D939: [WIP]Test rotations function in Position component.
Nov 12 2017, 5:34 PM
fatherbushido abandoned D924: {WIP]Add an option to checkrefs script to not list unused refs.
Nov 12 2017, 5:34 PM
fatherbushido abandoned D773: [WIP] Test resource logic in Player component.
Nov 12 2017, 5:33 PM
fatherbushido abandoned D704: Don't early return but actually update an active query (and send the RangeUpdate message) when the query source is out of world.
Nov 12 2017, 5:33 PM
fatherbushido abandoned D597: Don't early return in MissileHit when the main target has no position anymore..
Nov 12 2017, 5:33 PM

Nov 3 2017

fatherbushido added a comment to D1007: Template organization: the plane.
In D1007#39556, @leper wrote:

As for where to move things, I don't know. Everything not starting with template_ or special/ is placeable, how to organize things should be done according to some logic (that might be nice to describe in some readme file so people can find things more easily, and know where to place them) that might want to take being createable by a normal player, being specific to certain modes, nice layout for maybe the AI (though that should just construct the list of entities similarly to the structree), and possibly more.

Nov 3 2017, 7:41 PM
fatherbushido added a comment to D1007: Template organization: the plane.

Another input, for the eyes it's better to have civ_ files in units/
plane doesn't fit well that scheme (same for noldor, viking, samnite and so on things).

Nov 3 2017, 7:07 PM
fatherbushido added a comment to D1007: Template organization: the plane.
In D1007#39547, @Nescio wrote:

Furthermore, I understood (#4770) that units etc were to be removed from the other/ folder.

Nov 3 2017, 6:57 PM
fatherbushido added a comment to D1007: Template organization: the plane.

You are at least missing the cheat data file.

Sorry, I'm unaware of its existence. Which file?

Nov 3 2017, 6:56 PM
fatherbushido added a comment to D1007: Template organization: the plane.

something like structures/other/ or structures_other/ ?

Nov 3 2017, 6:55 PM
fatherbushido added a comment to D1007: Template organization: the plane.

Then again I somewhat consider moving certain templates to structures/ or units/ to be somewhat strange since those shouldn't be created by default.

Nov 3 2017, 6:46 PM
fatherbushido committed rP20404: Remove duplicated builder list..
Remove duplicated builder list.
Nov 3 2017, 6:24 PM
fatherbushido closed D1008: removed wonder duplicates from building lists.
Nov 3 2017, 6:24 PM
fatherbushido added a comment to D1008: removed wonder duplicates from building lists.

(thx for the patch)

Nov 3 2017, 6:24 PM
fatherbushido accepted D1008: removed wonder duplicates from building lists.
  • complete
  • tested (validation...)
Nov 3 2017, 6:20 PM
fatherbushido added a comment to D1008: removed wonder duplicates from building lists.
In D1008#39526, @Nescio wrote:

structures/{civ}_library for example

In A22 that still caused an error if the civ-specific template didn't exist. This is no longer the case in A23? Good to know!

Nov 3 2017, 6:13 PM
fatherbushido added a comment to D1006: Template organization: embassy.
In D1006#39518, @Nescio wrote:

Now you mention it, aren't the non-royal hellenic royal stoas actually embassies? (Limited to two per player; town phase; trains mercenaries; etc.) If so, maybe they could be merged into the embassy.

Nov 3 2017, 5:57 PM
fatherbushido added a comment to D1008: removed wonder duplicates from building lists.

following r19952

Nov 3 2017, 5:54 PM
fatherbushido planned changes to D924: {WIP]Add an option to checkrefs script to not list unused refs.
Nov 3 2017, 5:51 PM
fatherbushido added a comment to D1008: removed wonder duplicates from building lists.

Nice :)
(You can even use a builder list in top of all structures with the {civ} replacement. So you don't have to put things like (/sele_library) in all specific template.)

Nov 3 2017, 5:08 PM
fatherbushido added a comment to D1006: Template organization: embassy.
In D1006#39493, @Nescio wrote:

Furthermore, the Athenian gymnasion, Gaul tavern, Persian hall, and Spartan syssition are fundamentally one and the same structure: a structure which trains some of a faction's champions; so perhaps they could be merged and have a template_structure_military_hall.xml as their shared parent instead?

Nov 3 2017, 5:04 PM