Page MenuHomeWildfire Games

fatherbushido
User

Projects

User Details

User Since
Dec 21 2016, 3:21 PM (102 w, 5 d)

Recent Activity

Jun 11 2018

fatherbushido added a comment to rP20393: Move out of world promoted, packed and upgraded entity as they are not….

(I wonder if the concern shouldn't be removed, as the pointed bug was not really related to that patch)

Jun 11 2018, 8:19 AM
fatherbushido added a comment to rP19694: Allow walls and fields to be captured by territory but not by capture attack….

(I wonder if the concern shouldn't be removed now?)

Jun 11 2018, 8:18 AM

May 19 2018

fatherbushido updated subscribers of D1502: Remove some unused functions.

(About SoundGroup there is in soundmanager/SoundManager.(cpp/h) and soundmanager/scripting/SoundGroup.(cpp/h) an entity_id_t source parsed all over the place which is unused everywhere iirc. The end leaf is ItemForEntity but one had to climb the tree.
By the way I have strange things when typing @leper, is it a phabricator formatting issue?)

May 19 2018, 4:16 PM
fatherbushido created D1505: Add kush refs at some places.
May 19 2018, 3:59 PM

May 14 2018

fatherbushido added a comment to D1245: Experience trickle.

ref https://wildfiregames.com/forum/index.php?/topic/21146-officers/

May 14 2018, 7:16 PM
fatherbushido added a comment to D1472: Grouped civ bonuses into a single folder.

https://wildfiregames.com/forum/index.php?/topic/21563-subfolders-in-simulationdatatechnologies/

May 14 2018, 3:04 PM

Apr 26 2018

fatherbushido added a comment to rP21785: Stop some auras from being applied extra times, don't apply player auras to….

(I wonder why that thing https://trac.wildfiregames.com/wiki/SubmittingPatches#Makingsomechanges was written ; I post that randomly here)

Apr 26 2018, 9:41 AM

Apr 24 2018

fatherbushido added a comment to D1453: Update auras of entites of non-defeated players that affect defeated players.

GetAffectedPlayers did a strike

Apr 24 2018, 3:19 PM
fatherbushido added inline comments to rP19601: Buff elephant archer after rP18286 made it slow, rP18363 removed the capturing….
Apr 24 2018, 12:14 PM

Apr 23 2018

fatherbushido added a comment to rP21623: Remove an ancient unused placeholder template..

(if l16 of the deleted file was a hint, l29 is another)
So for future readers there are related dummy cmp and interfaces (js and cpp) related to that template.

Apr 23 2018, 11:20 PM
fatherbushido added a comment to D1430: Fix some auras not being removed.

I guess moving one line is something bad and it s better to keep that obvious broken loop.

Apr 23 2018, 11:09 PM
fatherbushido added a comment to rP21623: Remove an ancient unused placeholder template..

It was mainly here since the beggining (sim 1) as something for the original territory idea. There were even some map using that templates (latium iirc).
#41 is one of the entry point for that
All those grounds were copied when sim 2 was commited.

Apr 23 2018, 3:40 PM
fatherbushido added a comment to rP21284: Give spear cavalry an anti-cav bonus.

For geologists. (Not that I care about those things (anymore).)

Apr 23 2018, 3:15 PM
fatherbushido added a comment to rP19950: Splash damage on death. When an entity dies, it can do a splash damage. Fire….

refs #4783 for tooltip
refs D388 for the previous 'balance' tweak

Apr 23 2018, 2:04 PM
fatherbushido added a comment to D1452: Nerf BoltShooter massing.

Just for archeologists

Apr 23 2018, 12:49 PM

Apr 20 2018

fatherbushido added a comment to D1430: Fix some auras not being removed.

The bug fix is
https://code.wildfiregames.com/rP19092#29903
It was an obvious 'copy paste' error I did (mixing two ways of writing things). Straightforward.

Apr 20 2018, 4:47 PM

Apr 19 2018

fatherbushido added a comment to D1453: Update auras of entites of non-defeated players that affect defeated players.
Apr 19 2018, 2:38 PM
fatherbushido added a comment to D1453: Update auras of entites of non-defeated players that affect defeated players.
  • so it looks that the relevant case (about that useless clean call) is when the aura source owner is defeated. If so, there is several solutions.
Apr 19 2018, 12:49 PM
fatherbushido added a comment to D1453: Update auras of entites of non-defeated players that affect defeated players.

Wonders are cleaned twice if a player resigns doesn't look like an ownership / defeated one.

Apr 19 2018, 12:23 PM
fatherbushido added a comment to D1453: Update auras of entites of non-defeated players that affect defeated players.

(((One source of redundant clean is that they are done for all auras of a given entity. Clean(name) was a possibility, but it didn't seem worth the value)))
In the context of that diff, I wonder which situation trigger a (true) duplicate Ownership / Defeated call to clean. If so, there exists a (clean?) way to avoid it.

Apr 19 2018, 11:52 AM

Apr 16 2018

fatherbushido added a comment to rP21713: Don't apply team bonuses to defeated players, counterpart to rP19093 / D12..

The global listening was perhaps not needed in rP21712

Apr 16 2018, 5:15 PM

Apr 14 2018

fatherbushido added a comment to rP21713: Don't apply team bonuses to defeated players, counterpart to rP19093 / D12..

Unit tests:

Apr 14 2018, 2:50 PM
fatherbushido added a comment to D1430: Fix some auras not being removed.

capsule time:
when the typo/copypaste/bug fix and another thing can be split, perhaps could they be split.

Apr 14 2018, 7:57 AM
fatherbushido added a comment to rP21713: Don't apply team bonuses to defeated players, counterpart to rP19093 / D12..

(To be more explicit, it doesn't solve the issue it aimed to solve)

Apr 14 2018, 7:54 AM

Apr 13 2018

fatherbushido added a comment to rP21713: Don't apply team bonuses to defeated players, counterpart to rP19093 / D12..

For any android reading that:

Apr 13 2018, 7:32 PM
fatherbushido added inline comments to rP21711: Don't recompute auras of each and every entity globally upon playerdefeat, but….
Apr 13 2018, 7:13 PM
fatherbushido added inline comments to D1430: Fix some auras not being removed.
Apr 13 2018, 6:59 PM

Apr 11 2018

fatherbushido added inline comments to rP19093: Remove team bonus when the source player is defeated. Reviewed by wraitii..
Apr 11 2018, 7:10 PM
fatherbushido added inline comments to D1426: Reduce aura defeat lag by avoiding useless recomputation of all auras globally.
Apr 11 2018, 6:38 PM
fatherbushido added inline comments to rP19093: Remove team bonus when the source player is defeated. Reviewed by wraitii..
Apr 11 2018, 6:26 PM

Apr 7 2018

fatherbushido added a comment to rP21667: Add an IsInWorld check to Formation.

\begin{noteforwhoneedsit}
don't forget the other missing isinworld checks in that file when calling getposition
\end{noteforwhoneedsit}

Apr 7 2018, 8:29 PM

Apr 4 2018

fatherbushido added inline comments to D1430: Fix some auras not being removed.
Apr 4 2018, 5:28 PM

Apr 3 2018

fatherbushido added a comment to D1430: Fix some auras not being removed.

Doing that first could have been an option:

Apr 3 2018, 6:21 PM
fatherbushido added a comment to rP19092: Don't use range queries for global auras. Fix related team bonus. Add Mauryan….

if one would want to start its dev from this rev, here is the fix:

Apr 3 2018, 7:20 AM

Apr 2 2018

fatherbushido added inline comments to rP19092: Don't use range queries for global auras. Fix related team bonus. Add Mauryan….
Apr 2 2018, 11:13 PM
fatherbushido added a comment to rP19092: Don't use range queries for global auras. Fix related team bonus. Add Mauryan….

(The author of the patch (edit: and of this line) should have done the unit tests he promised to do and never completed.)
Regression : team bonus (at least for 'template' change) are messed with diplomacy changes (with the proper amount of players)

Apr 2 2018, 9:35 PM
fatherbushido added inline comments to rP19093: Remove team bonus when the source player is defeated. Reviewed by wraitii..
Apr 2 2018, 9:33 PM
fatherbushido added a comment to D1426: Reduce aura defeat lag by avoiding useless recomputation of all auras globally.

The Iberian cheap skirm bonus isn't removed,
That's a problem with rP19093.

Apr 2 2018, 5:19 PM
fatherbushido added inline comments to rP19093: Remove team bonus when the source player is defeated. Reviewed by wraitii..
Apr 2 2018, 5:17 PM

Nov 12 2017

fatherbushido removed a reviewer for D438: D13 prereq 1 : change Run Speed into a Run multiplier: fatherbushido.
Nov 12 2017, 6:31 PM
fatherbushido removed a reviewer for D834: Adjust accuracy (spread multiplier) in technologies: fatherbushido.
Nov 12 2017, 6:30 PM
fatherbushido removed a reviewer for D747: Fix sounds inheritance of template_unit_hero_{unit}.xml: fatherbushido.
Nov 12 2017, 6:30 PM
fatherbushido removed reviewers for D781: Elevation attack bonus for ranged units: sanderd17, fatherbushido.
Nov 12 2017, 6:30 PM
fatherbushido removed a reviewer for D880: Ballistics: fatherbushido.
Nov 12 2017, 6:29 PM
fatherbushido added a comment to rP20428: Add Vector3D crossproduct and Vector2D perpendicular function..

Some comments to a 2 years old friend as I was cleaning my stuffs ;-)
I don't understand the purpose of the comments.
We can just say that it returns the dot or the cross product, it's simpler ;-)

Nov 12 2017, 5:51 PM
fatherbushido added a comment to D939: [WIP]Test rotations function in Position component.

(good luck with +Pi stuff)

Nov 12 2017, 5:34 PM
fatherbushido abandoned D939: [WIP]Test rotations function in Position component.
Nov 12 2017, 5:34 PM
fatherbushido abandoned D924: {WIP]Add an option to checkrefs script to not list unused refs.
Nov 12 2017, 5:34 PM
fatherbushido abandoned D773: [WIP] Test resource logic in Player component.
Nov 12 2017, 5:33 PM
fatherbushido abandoned D704: Don't early return but actually update an active query (and send the RangeUpdate message) when the query source is out of world.
Nov 12 2017, 5:33 PM
fatherbushido abandoned D597: Don't early return in MissileHit when the main target has no position anymore..
Nov 12 2017, 5:33 PM

Nov 3 2017

fatherbushido added a comment to D1007: Template organization: the plane.
In D1007#39556, @leper wrote:

As for where to move things, I don't know. Everything not starting with template_ or special/ is placeable, how to organize things should be done according to some logic (that might be nice to describe in some readme file so people can find things more easily, and know where to place them) that might want to take being createable by a normal player, being specific to certain modes, nice layout for maybe the AI (though that should just construct the list of entities similarly to the structree), and possibly more.

Nov 3 2017, 7:41 PM
fatherbushido added a comment to D1007: Template organization: the plane.

Another input, for the eyes it's better to have civ_ files in units/
plane doesn't fit well that scheme (same for noldor, viking, samnite and so on things).

Nov 3 2017, 7:07 PM
fatherbushido added a comment to D1007: Template organization: the plane.
In D1007#39547, @Nescio wrote:

Furthermore, I understood (#4770) that units etc were to be removed from the other/ folder.

Nov 3 2017, 6:57 PM
fatherbushido added a comment to D1007: Template organization: the plane.

You are at least missing the cheat data file.

Sorry, I'm unaware of its existence. Which file?

Nov 3 2017, 6:56 PM
fatherbushido added a comment to D1007: Template organization: the plane.

something like structures/other/ or structures_other/ ?

Nov 3 2017, 6:55 PM
fatherbushido added a comment to D1007: Template organization: the plane.

Then again I somewhat consider moving certain templates to structures/ or units/ to be somewhat strange since those shouldn't be created by default.

Nov 3 2017, 6:46 PM
fatherbushido committed rP20404: Remove duplicated builder list..
Remove duplicated builder list.
Nov 3 2017, 6:24 PM
fatherbushido closed D1008: removed wonder duplicates from building lists.
Nov 3 2017, 6:24 PM
fatherbushido added a comment to D1008: removed wonder duplicates from building lists.

(thx for the patch)

Nov 3 2017, 6:24 PM
fatherbushido accepted D1008: removed wonder duplicates from building lists.
  • complete
  • tested (validation...)
Nov 3 2017, 6:20 PM
fatherbushido added a comment to D1008: removed wonder duplicates from building lists.
In D1008#39526, @Nescio wrote:

structures/{civ}_library for example

In A22 that still caused an error if the civ-specific template didn't exist. This is no longer the case in A23? Good to know!

Nov 3 2017, 6:13 PM
fatherbushido added a comment to D1006: Template organization: embassy.
In D1006#39518, @Nescio wrote:

Now you mention it, aren't the non-royal hellenic royal stoas actually embassies? (Limited to two per player; town phase; trains mercenaries; etc.) If so, maybe they could be merged into the embassy.

Nov 3 2017, 5:57 PM
fatherbushido added a comment to D1008: removed wonder duplicates from building lists.

following r19952

Nov 3 2017, 5:54 PM
fatherbushido planned changes to D924: {WIP]Add an option to checkrefs script to not list unused refs.
Nov 3 2017, 5:51 PM
fatherbushido added a comment to D1008: removed wonder duplicates from building lists.

Nice :)
(You can even use a builder list in top of all structures with the {civ} replacement. So you don't have to put things like (/sele_library) in all specific template.)

Nov 3 2017, 5:08 PM
fatherbushido added a comment to D1006: Template organization: embassy.
In D1006#39493, @Nescio wrote:

Furthermore, the Athenian gymnasion, Gaul tavern, Persian hall, and Spartan syssition are fundamentally one and the same structure: a structure which trains some of a faction's champions; so perhaps they could be merged and have a template_structure_military_hall.xml as their shared parent instead?

Nov 3 2017, 5:04 PM
fatherbushido added a comment to D989: template organization: treasures, ruins, and the plane (1/5).

Actually I wouldn't mind to move fauna_* to fauna/*, flora_* to flora/*, and geology_* to geology/* as well, such a patch would be easy to create.

Nov 3 2017, 4:58 PM
fatherbushido added a comment to D1006: Template organization: embassy.
In D1006#39489, @Nescio wrote:

Personally I don't think it's really needed, but that probably should be decided on a case by case basis per template.

Nov 3 2017, 4:52 PM
fatherbushido added a comment to D1006: Template organization: embassy.

You point out something, is the special template still needed? (before there was something like every civs had sb1 and sb2).

Nov 3 2017, 4:29 PM
fatherbushido added a comment to D597: Don't early return in MissileHit when the main target has no position anymore..

Anectdote:
in source/simulation/Collision.h?rev=4437

Nov 3 2017, 4:24 PM
fatherbushido committed rP20403: Template organization: move some structures from other/ to structures/.
Template organization: move some structures from other/ to structures/
Nov 3 2017, 12:00 PM
fatherbushido closed D1002: template organization: other/{civ}_* to structures/{civ}_*.
Nov 3 2017, 12:00 PM
fatherbushido accepted D1002: template organization: other/{civ}_* to structures/{civ}_*.

Makes sense.
I launch the maps.
I test validation of all templates.
I launch the checkrefs script.

Nov 3 2017, 11:58 AM
fatherbushido committed rP20402: Fix a typo..
Fix a typo.
Nov 3 2017, 11:22 AM
fatherbushido closed D1005: typo in rP20376.
Nov 3 2017, 11:22 AM
fatherbushido added a comment to rP20376: Consistently use utf8 instead of iso-8859-1 encoding in XML files..

(as I needed it locally, I uploaded it at D1005)

Nov 3 2017, 10:12 AM
fatherbushido created D1005: typo in rP20376.
Nov 3 2017, 10:11 AM

Nov 2 2017

fatherbushido added a comment to rP20376: Consistently use utf8 instead of iso-8859-1 encoding in XML files..

:-)

Nov 2 2017, 7:11 PM
fatherbushido added a comment to rP20376: Consistently use utf8 instead of iso-8859-1 encoding in XML files..

I don't know why but it break the checkrefs script on my config.

Nov 2 2017, 6:39 PM
fatherbushido added a comment to D989: template organization: treasures, ruins, and the plane (1/5).

@Nescio
you really don't make me thing easy ;-)
I will need hours to go with that and people will be mad :o
Moreover I really think the gaia/treasure/ and gaia/ruins/ should have been postponed in another patch. As now we get in the gaia folder things in a subfolder and things not in a subfolder.
The plane doesn't need to be in that patch :)
Don't bother with adressing those things it will be too much time consuming, I will try to split all that.

Nov 2 2017, 5:20 PM
fatherbushido added a comment to D924: {WIP]Add an option to checkrefs script to not list unused refs.
In D924#39409, @elexis wrote:

An option to not list unused refs as the patch does that I could possibly accept or planning some change?

Nov 2 2017, 5:00 PM
fatherbushido reclaimed D924: {WIP]Add an option to checkrefs script to not list unused refs.

(an option to not display them could be better in fact)

Nov 2 2017, 2:29 PM
fatherbushido retitled D924: {WIP]Add an option to checkrefs script to not list unused refs from Add an option to checkrefs script to not list unused refs to {WIP]Add an option to checkrefs script to not list unused refs.
Nov 2 2017, 2:29 PM
fatherbushido added a comment to D274: Add a separate manager to handle modifications..

What do you expect exactly of the review here?

Nov 2 2017, 2:25 PM
fatherbushido added a comment to rP20394: Remove wrong tension comment from rP20383 and mention that this functon can….

The only part I don't understand is the labeling, i.e. if tension != 0.5 is a Catmull Rom spline too (in their words, not ours) or only a cardinal spline.

Nov 2 2017, 9:34 AM

Nov 1 2017

fatherbushido added a comment to rP20394: Remove wrong tension comment from rP20383 and mention that this functon can….

(Its presumably well defined in the unavailable paper from 1974. Actually I didn't see a definition, just some incomplete property descriptions.)
(Besides every of these using a custom definition of "tension", it is not clear to me if the tension must be 0.5 in our implementation to be labeled a CR or if the splines with tension != 0.5 can be labeled as CR too according to a definition we can read)

Nov 1 2017, 10:30 PM
fatherbushido added a comment to rP20394: Remove wrong tension comment from rP20383 and mention that this functon can….

(it's not ambiguous ;-))

Nov 1 2017, 9:46 PM
fatherbushido added a comment to D268: Add "mul_round" op to template parsing to support multiplying with integer types..

(imul sounds better than mul_round.)
/me won the useless comment award.

Nov 1 2017, 5:21 PM
fatherbushido added a comment to D1001: template organization: elephant stables.

I've no strong feelings about that, so if other people have opinions, it's time to speak :)

Nov 1 2017, 5:14 PM
fatherbushido accepted D1003: Correct cubicInterpolation cardinal / Catmull-Rom spline comment.
Nov 1 2017, 4:52 PM
fatherbushido added inline comments to D1003: Correct cubicInterpolation cardinal / Catmull-Rom spline comment.
Nov 1 2017, 4:52 PM
fatherbushido added a comment to D1003: Correct cubicInterpolation cardinal / Catmull-Rom spline comment.
In D1003#39281, @elexis wrote:

(I took the statement that tension = 0 resluts in the Catmull-Rom spline and that the tension must be in the interval [0, 1] from here.
I guess if it is a mistake,

Nov 1 2017, 4:51 PM
fatherbushido added a comment to rP20393: Move out of world promoted, packed and upgraded entity as they are not….

(and fix a space issue noticed by elexis)

Nov 1 2017, 3:56 PM
fatherbushido committed rP20393: Move out of world promoted, packed and upgraded entity as they are not….
Move out of world promoted, packed and upgraded entity as they are not…
Nov 1 2017, 3:55 PM
fatherbushido closed D590: Move out world promoted, packed or upgraded before destroying..
Nov 1 2017, 3:55 PM
fatherbushido abandoned D961: Let some heros upgrade to mount or unmount..
Nov 1 2017, 3:37 PM
fatherbushido added inline comments to rP20383: Extend the cubicInterpolation function to consume a tension argument allowing….
Nov 1 2017, 3:15 PM
fatherbushido added a comment to D438: D13 prereq 1 : change Run Speed into a Run multiplier.

(the atlas change is missing)
(edit: that's strange that the bot didn't notice, ?)

Nov 1 2017, 2:48 PM
fatherbushido added a comment to D1003: Correct cubicInterpolation cardinal / Catmull-Rom spline comment.

You can check straightly with the provided function defined by f(x)=((P * x + Q) * x + R) * x + S that:
f(0) = p1
f(1) = p2
df/dx (0) = tension * (p2-p0)
df/dx((1) = tension * (p3-p1)
Then one can understand that for tension = 1/2, the slope in p1 is well given by the slope of the line (p0,p2) and the slope in p2 is well given by the slope of the line (p1, p3), which are the requested things.
(tension 0 is something which should be rarely desirable)

Nov 1 2017, 2:16 PM