- User Since
- Dec 21 2016, 3:21 PM (122 w, 1 d)
Mar 19 2019
Those palisades_foo models and templates are not really well defined in my mind.
Mar 18 2019
(I never intend to commit that or to use that. It was lines to help me think about that.
Neither plan I to have two things doing the same thing.)
Why do you think that tree is better? (I didn't remember how it is done for the roman walls). It's a true question ;-)
Feb 25 2019
@Alexandermb: that's exactly what I wanted to know!
I will assume I am not the only one to have test it so it's probably my computer which does something weird.
Feb 18 2019
I'd first salute the artwork.
So I hesitated to post something here and I wondered if I was the only one to notice some weird visual.
Is there something wrong in the animation (or in the code?), I have the anti_cavalry formation walking then sometimes putting knees on the ground and standing up doing some kind of squat.
And those two ones (are those good sources?) doesn't restrict legionary to romans:
The fact that one is used doesn't mean that the other is not correct :D
I don't know if those electronic dictionnaries are ok but:
It's explictly in https://en.oxforddictionaries.com/definition/legionnaire
It's in the examples in https://www.merriam-webster.com/dictionary/legionnaire#examples
Only the general meaning without explicit mention to antiquity is in https://www.collinsdictionary.com/dictionary/english/legionnaire
It's not in https://dictionary.cambridge.org/spellcheck/english/?q=legionnaire
(I am not an expert in english - euphemism - not in the position to discuss if this is good or not! Just take that as discussing about things ;-))
Fixed in rP22090 (rome_helmet_agen)
Fixed in rP22090
Fixed in rP22089
Feb 16 2019
Feb 15 2019
Feb 14 2019
Jan 29 2019
Jan 20 2019
If I ask, it's that I don't know.
Perhaps one could have taken the opportunity to explain where did it come from.
Basically, it had code implications and wasn't only cosmetic (a long time ago).
Jan 6 2019
The idea is more: what are those things?
Jan 3 2019
I feel a bit stupid.
That bar is displayed when you click on a unit? But currently, there is already such a bar at another place isn't it?
Or is it relevant only for group selection of units?
Jan 1 2019
You are welcome.
Dec 31 2018
moves gaia/fauna_* to gaia/fauna/*
moves gaia/flora_* to gaia/flora/*
(I had personnaly never heard/read ForwardSlash before reading that diff :-). I didn't know the concept of hypercorrection, thanks.)
My main interrogation is was it considered to change in those other places refering to the same thing?
I guess there is a good argument to not have done it, the commiter may know better than us. (I can see a good reason).
The proposal is about adding a tooltip to something existing. If I was in position to attribute adjectives, I would qualify that of nice and desired (#4130).
I wonder what is the link between an AI and a tooltip.
Did the new AI read tooltip?
Dec 28 2018
edit: The question had to be asked (as it had been asked: https://wildfiregames.com/forum/index.php?/topic/24732-de-alpha-24/&tab=comments#comment-361505).
For the dictionnary advice, you should give that to the guys who write that on the internet, not to me.
And I also read books like "History of Early India From the Origins to AD 1300" and indeed in chapter 6, we can read "The Emergence of Empire: Mauryan India" followed by "The Mauryas and their World".
Mauryans is not a proper word.
Jun 11 2018
(I wonder if the concern shouldn't be removed, as the pointed bug was not really related to that patch)
(I wonder if the concern shouldn't be removed now?)
May 19 2018
(About SoundGroup there is in soundmanager/SoundManager.(cpp/h) and soundmanager/scripting/SoundGroup.(cpp/h) an entity_id_t source parsed all over the place which is unused everywhere iirc. The end leaf is ItemForEntity but one had to climb the tree.
By the way I have strange things when typing @leper, is it a phabricator formatting issue?)
May 14 2018
Apr 26 2018
(I wonder why that thing https://trac.wildfiregames.com/wiki/SubmittingPatches#Makingsomechanges was written ; I post that randomly here)
Apr 24 2018
GetAffectedPlayers did a strike
Apr 23 2018
(if l16 of the deleted file was a hint, l29 is another)
So for future readers there are related dummy cmp and interfaces (js and cpp) related to that template.
I guess moving one line is something bad and it s better to keep that obvious broken loop.
It was mainly here since the beggining (sim 1) as something for the original territory idea. There were even some map using that templates (latium iirc).
#41 is one of the entry point for that
All those grounds were copied when sim 2 was commited.
For geologists. (Not that I care about those things (anymore).)
Just for archeologists
Apr 20 2018
The bug fix is
It was an obvious 'copy paste' error I did (mixing two ways of writing things). Straightforward.
Apr 19 2018
- so it looks that the relevant case (about that useless clean call) is when the aura source owner is defeated. If so, there is several solutions.
Wonders are cleaned twice if a player resigns doesn't look like an ownership / defeated one.
(((One source of redundant clean is that they are done for all auras of a given entity. Clean(name) was a possibility, but it didn't seem worth the value)))
In the context of that diff, I wonder which situation trigger a (true) duplicate Ownership / Defeated call to clean. If so, there exists a (clean?) way to avoid it.
Apr 16 2018
The global listening was perhaps not needed in rP21712
Apr 14 2018
when the typo/copypaste/bug fix and another thing can be split, perhaps could they be split.
(To be more explicit, it doesn't solve the issue it aimed to solve)
Apr 13 2018
For any android reading that:
Apr 11 2018
Apr 7 2018
don't forget the other missing isinworld checks in that file when calling getposition
Apr 4 2018
Apr 3 2018
Doing that first could have been an option:
if one would want to start its dev from this rev, here is the fix:
Apr 2 2018
(The author of the patch (edit: and of this line) should have done the unit tests he promised to do and never completed.)
Regression : team bonus (at least for 'template' change) are messed with diplomacy changes (with the proper amount of players)
The Iberian cheap skirm bonus isn't removed,
That's a problem with rP19093.
Nov 12 2017
Some comments to a 2 years old friend as I was cleaning my stuffs ;-)
I don't understand the purpose of the comments.
We can just say that it returns the dot or the cross product, it's simpler ;-)
(good luck with +Pi stuff)
Nov 3 2017
Another input, for the eyes it's better to have civ_ files in units/
plane doesn't fit well that scheme (same for noldor, viking, samnite and so on things).
You are at least missing the cheat data file.
Sorry, I'm unaware of its existence. Which file?
something like structures/other/ or structures_other/ ?
Then again I somewhat consider moving certain templates to structures/ or units/ to be somewhat strange since those shouldn't be created by default.