Changeset View
Standalone View
binaries/data/mods/public/campaigns/example.json
- This file was added.
| { | |||||
elexis: This sounds like a candidate for the hypothetic pyrogenesis-examples mod #5366. Otherwise I'd… | |||||
| "Name": "Example Campaign", | |||||
| "Description": "Lorem Ipsum and so on and so on", | |||||
Done Inline ActionsCoding_Conventions: We don't add a space before the colon (instead "foo": "bar",). elexis: [[ http://trac.wildfiregames.com/wiki/Coding_Conventions#JavaScript | Coding_Conventions ]]: We… | |||||
Not Done Inline ActionsBroken translation: No entry for messages.json. elexis: **Broken translation:** No entry for `messages.json`. | |||||
Not Done Inline ActionsStill misses messages.json diff so that its translated. elexis: Still misses `messages.json` diff so that its translated.
(I wouldn't mind to have this json… | |||||
Not Done Inline ActionsDid someone say messages.json? (Also some exotic transifex file if new directory IIRC) elexis: Did someone say `messages.json`? (Also some exotic transifex file if new directory IIRC) | |||||
elexisUnsubmitted Not Done Inline Actions"This shows map authors how to create campaign" or similar elexis: "This shows map authors how to create campaign" or similar | |||||
| "Interface": "simple_campaign", | |||||
Not Done Inline ActionsExtension: An optional DescriptionLocked property could be added. elexis: **Extension:** An optional `DescriptionLocked` property could be added. | |||||
| "Levels": { | |||||
Not Done Inline ActionsMisleading name: That's not really an interface, but a GUI Page. Might use "Page" as a property name. elexis: **Misleading name:** That's not really an interface, but a GUI Page. Might use "Page" as a… | |||||
Not Done Inline ActionsActually this should just be "simple_campaign" for the value and then the Interface moniker would be fine. leper: Actually this should just be `"simple_campaign"` for the value and then the Interface moniker… | |||||
| "Example_1": { | |||||
| "Name": "Example 1", | |||||
| "Map": "scenarios/Serengeti.xml", | |||||
| "Description": "Whatever" | |||||
| }, | |||||
Not Done Inline ActionsWhat values can this take? Freagarach: What values can this take? | |||||
| "Example_2": { | |||||
| "Name": "Example 2", | |||||
| "Map": "", | |||||
elexisUnsubmitted Not Done Inline ActionsSomething nonempty elexis: Something nonempty | |||||
| "Description": "None", | |||||
| "Requires": "Example_1" | |||||
| }, | |||||
Not Done Inline ActionsRequirement Extension: It were great if we could not only pass level names, but also custom variables. Can be done in a follow-up ticket. Use case: For example a binary or ternary, campaign relevant decision in some RPG-like quest. elexis: **Requirement Extension:** It were great if we could not only pass level names, but also… | |||||
Not Done Inline ActionsYes, this is one of the things I've had in mind when I proposed using MatchesClassList (which should probably be renamed as this usage is not according to that name, proably in another patch). However the current architecture should support just setting a few values after a match was played and adding them to the list that is matched against. Could be a nice simple ticket once this is merged. leper: Yes, this is one of the things I've had in mind when I proposed using `MatchesClassList` (which… | |||||
| "Example_3": { | |||||
| "Name": "This one requires 1 and 2", | |||||
| "Map": "", | |||||
| "Description": "None", | |||||
| "Requires": "Example_1+Example_2" | |||||
| }, | |||||
| "Example_4": { | |||||
| "Name": "This one requires 2 or 3", | |||||
| "Map": "", | |||||
| "Description": "None", | |||||
| "Requires": "Example_2 Example_3" | |||||
| }, | |||||
| "Example_5": { | |||||
| "Name": "This one unavailable if 1 isn't completed", | |||||
| "Map": "", | |||||
Not Done Inline ActionsString: "This one is unavailable if level 1 wasn't completed" elexis: **String: **"This one is unavailable if level 1 wasn't completed" | |||||
| "Description": "None", | |||||
| "Requires": "!Example_1" | |||||
| } | |||||
| }, | |||||
| "Order": ["Example_1", "Example_2", "Example_3", "Example_4", "Example_5"], | |||||
| "ShowUnavailable": true | |||||
| } | |||||
Not Done Inline ActionsCoding Style: Newlines at the end of files is a good practice, even if just for consistency and to mute these warnings in git and phabricator. elexis: **Coding Style:** Newlines at the end of files is a good practice, even if just for consistency… | |||||
Not Done Inline ActionsOn some platforms (that we sort of support) not having a trailing newline in a cpp (or h) file emits a compiler warning. Also some tools could fail if that is omitted, even though most just warn or even silently ignore it. Maybe we should have a lint test for this (@Itms). leper: On some platforms (that we sort of support) not having a trailing newline in a cpp (or h) file… | |||||
This sounds like a candidate for the hypothetic pyrogenesis-examples mod #5366. Otherwise I'd recommend not to commit this as it will be translated. Otherwise, campaign authors can also take an example at the tutorial map.