Page MenuHomeWildfire Games

Itms (Nicolas Auvray)
User

User Details

User Since
Dec 19 2016, 10:38 PM (378 w, 5 h)

Recent Activity

Jul 31 2023

Itms added inline comments to D5088: Move the CCmpTemplateManager inside the ComponentManager.
Jul 31 2023, 9:38 AM

Jul 30 2023

Itms requested changes to D5088: Move the CCmpTemplateManager inside the ComponentManager.

gah, I was not reactive enough to your message on IRC. I don't think the check for an existing instance of the component prevents you from decoupling construction and attachment of the component. Instead, I suggest you move the check to the component attachment. Maybe another check can be added somewhere else to reduce the risks of memory leaks in future modifications of the code.

Jul 30 2023, 7:02 PM

Jul 24 2023

Itms added a comment to D4842: [POC] Static SystemComponents.

I had a voice call with phosit in order to move forward with this review. We chose to work with a unique_ptr. phosit will write a couple incremental patches for eased review, without interface removal to avoid mocking issues, and with minimal boilerplate changes in callers.

Jul 24 2023, 12:09 PM

Jul 17 2023

Itms accepted D5065: Fixes solution introduced in rP17658.

(actually this request doesn't warrant a blocking ❌)

Jul 17 2023, 9:56 PM
Itms requested changes to D5065: Fixes solution introduced in rP17658.

Very nice patch. It works on Windows. I agree with the changes proposed πŸ‘πŸ»

Jul 17 2023, 9:54 PM

Jun 29 2023

Itms changed the edit policy for Terms Of Use.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Terms Of Service.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Forum.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Privacy Policy.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Lobby.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Public.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Xmpp.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Gdpr Request.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Gdpr.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Gdpr.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Ejabberd.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Ratings.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Mnesia.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Lobby.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Lobby.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Best Practice.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Data.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Documents.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Knowledge Base.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Document.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Sections.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Glossary.
Jun 29 2023, 11:55 AM
Itms changed the edit policy for Knowledge Base Home.
Jun 29 2023, 11:55 AM

May 22 2023

Itms accepted D5003: Disables framebuffer invalidating by default for GL as some drivers perform it incorrectly.

This fixes the issue πŸ‘πŸ»

May 22 2023, 10:52 PM

May 18 2023

Itms added a reviewer for D4842: [POC] Static SystemComponents: Itms.

I took a first look at this and gave some feedback to phosit on IRC (starting at 14:34).

May 18 2023, 10:48 PM
Itms committed rP27647: Check the validity of a couple pointers in low-level tests, refs #5288..
Check the validity of a couple pointers in low-level tests, refs #5288.
May 18 2023, 6:54 PM
Itms closed D4994: N9_N10_N11 - asserting for nullptr argument..
May 18 2023, 6:54 PM

May 16 2023

Itms added a comment to D4996: Disable all logging of network messages in release mode.
In D4996#213057, @Stan wrote:

@Itms any opinion on this?

May 16 2023, 7:00 PM

Apr 19 2023

Itms committed rP27612: Ignore broken symlinks instead of crashing on them, fixes #6586..
Ignore broken symlinks instead of crashing on them, fixes #6586.
Apr 19 2023, 6:39 PM
Itms closed D4743: Ignore broken symlinks.
Apr 19 2023, 6:39 PM
Itms accepted D4743: Ignore broken symlinks.
Apr 19 2023, 6:21 PM
Itms requested changes to D4743: Ignore broken symlinks.

Great, consensus reached! You can perform the changes and I'll commit πŸ™‚

Apr 19 2023, 2:12 PM
Itms added a comment to D4743: Ignore broken symlinks.

@Itms I think the the warning messages are too specific, as the checked error codes can happen not only for a dangling symbolic link.

Apr 19 2023, 12:18 PM

Apr 18 2023

Itms accepted D4743: Ignore broken symlinks.

This also works well on Windows. EDIT: and also on Linux πŸ‘πŸ»

Apr 18 2023, 12:51 PM

Apr 10 2023

Itms committed rP27599: Use a lower default MTU for ENet hosts, and make it configurable..
Use a lower default MTU for ENet hosts, and make it configurable.
Apr 10 2023, 10:21 AM
Itms closed D4967: Lower enet packet fragment max size to support certain VPN.
Apr 10 2023, 10:21 AM
Itms added a comment to D4967: Lower enet packet fragment max size to support certain VPN.

I could not reproduce the Jenkins bug πŸ€·πŸ»β€β™‚οΈ

Apr 10 2023, 10:20 AM

Apr 1 2023

Itms added a comment to D4967: Lower enet packet fragment max size to support certain VPN.
Debug:
    23>network_dbg.lib(NetEnet.obj) : fatal error LNK1236: corrupt or invalid COFF sections [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\test.vcxproj]
Apr 1 2023, 3:38 PM
Itms accepted D4967: Lower enet packet fragment max size to support certain VPN.

Thanks for the patch! I'm waiting for the Windows build and I'm committing it with minor style fixes.

Apr 1 2023, 3:30 PM

Mar 27 2023

Itms added a comment to D4967: Lower enet packet fragment max size to support certain VPN.
In D4967#212059, @sera wrote:

I thought about adding it to default.cfg but I feel users really shouldn't touch it unless really really required. So I'm on the fence whether it's a good idea or not to "tell" users it exist instead of it being an emergency workaround. So I let you make the call here.

Mar 27 2023, 3:46 PM

Mar 26 2023

Itms edited reviewers for D4967: Lower enet packet fragment max size to support certain VPN, added: Itms; removed: Restricted Owners Package.

Hello, this looks nice and clean, thanks for the work!

Mar 26 2023, 9:22 PM

Feb 20 2023

Itms committed rP27555: Fixes --with-system-premake5, fixes #6710, refs rP23675..
Fixes --with-system-premake5, fixes #6710, refs rP23675.
Feb 20 2023, 4:07 PM

Feb 16 2023

Itms added a comment to D4871: Moderation system improvements - mute, helper and allowlist only.

Here is my work-in-progress rewrite of this feature: https://gitlab.com/na-Itms/0ad/-/commit/b51f29d9e1ff5f2e14e271de9155c9f3a31728cd

Feb 16 2023, 4:29 PM

Feb 13 2023

Itms added a comment to D4871: Moderation system improvements - mute, helper and allowlist only.

Would you plan to move the m_MutedUsers and m_HelperUsers [...]
Would you plan to move the validity testing of the moderation commands [...]

No, those should be in the server indeed. Sorry if I wasn't clear.

Feb 13 2023, 9:57 PM
Itms added a comment to D4871: Moderation system improvements - mute, helper and allowlist only.

Thank you for your answer!

Feb 13 2023, 12:47 PM

Feb 6 2023

Itms edited reviewers for D4753: Fix VS2022 build, added: Itms; removed: Restricted Owners Package.
In D4753#210384, @Stan wrote:
Feb 6 2023, 10:05 AM

Feb 5 2023

Itms requested changes to D4871: Moderation system improvements - mute, helper and allowlist only.

Hi Norse_Harold, I went through this very big patch. First of all thank you again for working on this essential feature. πŸ‘πŸ»

Feb 5 2023, 11:55 PM

Jan 31 2023

Itms added a comment to rP27490: Upgrade gloox to the development trunk version on Windows, refs #3004. This….

I went with the const-correct fix and sent it upstream.

Jan 31 2023, 7:53 PM
Itms committed rP27517: Fix a warning in gloox headers on Windows after rP27490, refs #3004..
Fix a warning in gloox headers on Windows after rP27490, refs #3004.
Jan 31 2023, 7:52 PM

Jan 27 2023

Itms added a comment to rP27490: Upgrade gloox to the development trunk version on Windows, refs #3004. This….

Ah shoot, the fix was in D4910, but it got lost when I copied all the headers again before committing. I am actually hesitating between two fixes:

Jan 27 2023, 11:21 AM

Jan 26 2023

Itms closed D4910: Upgrade gloox to trunk version on Windows.

rP27490

Jan 26 2023, 4:54 PM
Itms committed rP27490: Upgrade gloox to the development trunk version on Windows, refs #3004. This….
Upgrade gloox to the development trunk version on Windows, refs #3004. This…
Jan 26 2023, 4:44 PM

Jan 25 2023

Itms added inline comments to D4910: Upgrade gloox to trunk version on Windows.
Jan 25 2023, 11:54 AM
Itms added a comment to D4910: Upgrade gloox to trunk version on Windows.
In D4910#209709, @Stan wrote:

On what Windows OS(es) did you test this?

Jan 25 2023, 11:38 AM
Itms added a comment to D4910: Upgrade gloox to trunk version on Windows.

Obviously, testers will be smarter than Jenkins, and will rebuild with --build-shared-glooxwrapper.

Jan 25 2023, 11:03 AM
Itms published D4910: Upgrade gloox to trunk version on Windows for review.
Jan 25 2023, 11:01 AM

Jan 24 2023

Itms committed rP27485: Set Windows gloox include files to native EOL..
Set Windows gloox include files to native EOL.
Jan 24 2023, 11:49 AM

Jan 21 2023

Itms published D4906: Move some needed shaders from the public mod to the modmod for review.
Jan 21 2023, 5:39 PM
Itms requested changes to D2747: Make password hashing case-insensitive to comply with jabberd specification..

Note that a disruption in this method has been planned for quite some time and it would be good to perform both changes at once.

Jan 21 2023, 5:19 PM
Itms accepted D4892: Fixes DisplayVersion in NSIS on Windows.

This looks good to me and works.

Jan 21 2023, 4:58 PM

Jan 20 2023

Itms added inline comments to rP27470: Follow proper Shutdown sequence when using -dumpSchema, fixes #6696..
Jan 20 2023, 8:17 AM

Jan 19 2023

Itms added a reviewer for D4892: Fixes DisplayVersion in NSIS on Windows: Itms.
Jan 19 2023, 11:51 PM
Itms committed rP27470: Follow proper Shutdown sequence when using -dumpSchema, fixes #6696..
Follow proper Shutdown sequence when using -dumpSchema, fixes #6696.
Jan 19 2023, 11:35 PM
Itms closed D4903: Follow proper Shutdown sequence when using -dumpSchema.
Jan 19 2023, 11:35 PM
Itms updated the diff for D4903: Follow proper Shutdown sequence when using -dumpSchema.

πŸ™ƒ

Jan 19 2023, 6:23 PM
Itms published D4903: Follow proper Shutdown sequence when using -dumpSchema for review.
Jan 19 2023, 6:03 PM

Jan 17 2023

Itms committed rP27460: Fix and cleanup the SM91 build, fixes #6676..
Fix and cleanup the SM91 build, fixes #6676.
Jan 17 2023, 9:49 PM
Itms closed D4893: Fix and cleanup the SM91 build, fixes #6676.
Jan 17 2023, 9:49 PM
Itms updated the summary of D4893: Fix and cleanup the SM91 build, fixes #6676.
Jan 17 2023, 6:23 PM
Itms updated the diff for D4893: Fix and cleanup the SM91 build, fixes #6676.

This is a complete fix for #6676, written by @s0600204, including previous cleanups and a part of the upstream fix to Bug 1739486.

Jan 17 2023, 6:22 PM

Jan 16 2023

Itms updated the diff for D4893: Fix and cleanup the SM91 build, fixes #6676.

Forgot a file
Fix indentation
Don't patch this issue outside of Linux, it conflicts with wraitii's fix for the virtualenv on Mac and is not needed on Windows

Jan 16 2023, 11:33 PM
Itms updated the diff for D4893: Fix and cleanup the SM91 build, fixes #6676.

Extra cleanup (correct EOLs and move a build environment variable introduced in D4776 to a better place).

Jan 16 2023, 10:56 PM
Itms published D4893: Fix and cleanup the SM91 build, fixes #6676 for review.

I have no idea what failed!

Jan 16 2023, 11:53 AM

Aug 26 2021

Itms added a comment to D4215: Bump version to A26.

Here is a key for signing A26 mods.

Aug 26 2021, 3:06 PM

Jun 14 2021

Itms committed rP25798: New key for signing A25-compatible mods..
New key for signing A25-compatible mods.
Jun 14 2021, 9:42 PM

Mar 4 2021

Itms added a comment to D3634: Remove JSHint, update eslint to latest..

I'm OK with removing JSHint. Originally the linters were supposed to be complementary, one for the style, one for the logic. But nowadays both detect both kinds of issues, and there is a risk of conflict.

Mar 4 2021, 6:48 PM

Feb 12 2021

Itms committed rP24892: Port remaining python2 helper scripts to python3, fixes #5694..
Port remaining python2 helper scripts to python3, fixes #5694.
Feb 12 2021, 10:25 PM
Itms closed D2501: Port scripts to python 3 before doomsday.
Feb 12 2021, 10:25 PM

Jan 25 2021

Itms committed rP24789: Fix svn:ignore path after r24286..
Fix svn:ignore path after r24286.
Jan 25 2021, 6:37 PM
Itms closed D3470: Fix svn:ignore path after r24286.
Jan 25 2021, 6:37 PM
Itms committed rP24788: New public key for A24 mods..
New public key for A24 mods.
Jan 25 2021, 6:31 PM
Itms closed D3471: New public key for A24 mods.
Jan 25 2021, 6:31 PM
Itms abandoned D2881: Update ObjectToIDMap before upgrading SpiderMonkey to 52.

Superseded by SM upgrades.

Jan 25 2021, 6:11 PM
Itms requested review of D3471: New public key for A24 mods.
Jan 25 2021, 10:41 AM
Itms requested review of D3470: Fix svn:ignore path after r24286.
Jan 25 2021, 10:35 AM
Itms raised a concern with rP24286: Drop support for compiling with Visual Studio 2015.

This change needs D3470 πŸ™‚

Jan 25 2021, 10:14 AM

Nov 14 2020

Itms requested changes to D3100: Jenkins autobuild fixes.

The SVN change is wrong. If SVN is broken, the differential pipeline should try to build upon a working version, so you must not run svn up. If you want to change the paradigm and always build upon the latest SVN, the pipelines should be entirely rewritten.

Nov 14 2020, 10:01 PM

Nov 5 2020

Itms requested changes to D3061: Avoid overflow in UnitMotion.

Very nice improvement, some major comments though ??

Nov 5 2020, 9:17 PM

Oct 29 2020

Itms committed rP24114: Make PlayerHasMarket event-based..
Make PlayerHasMarket event-based.
Oct 29 2020, 10:23 AM
Itms closed D2919: Make PlayerHasMarket event-based.
Oct 29 2020, 10:22 AM
Itms added a comment to D2919: Make PlayerHasMarket event-based.

Thanks a lot for the quick review!

Oct 29 2020, 10:12 AM

Oct 28 2020

Itms updated the diff for D2919: Make PlayerHasMarket event-based.

Address Freagarach's comments.

Oct 28 2020, 9:41 PM
Itms accepted D2922: Fix a compartment mismatch in XmppClient / Possibly fix semi-random lobby / in game JS crash.

The code change is correct and, apparently, works under SM45 and SM52.

Oct 28 2020, 6:55 PM
Itms added a comment to D2743: [WP] MesonBuild support.

Yo Stan, I don't see the need for MesonBuild support, I would recommend creating a Trac ticket with "If Time Permits" urgency, a link to this diff in the Patch field, and then abandon this diff for the time being.

Oct 28 2020, 6:25 PM
Itms added a comment to D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

Hi @wraitii! I will need this to perform the SM 52->60 migration (see #1389510 on Bugzilla). The ideal route would be to include this under SM52, but if SM60 adds nice code to handle proxy privates, I am fine with doing this as part of the 52->60 code fixes.

Oct 28 2020, 3:30 PM