Page MenuHomeWildfire Games

Itms (Nicolas Auvray)
User

User Details

User Since
Dec 19 2016, 10:38 PM (151 w, 3 d)

Recent Activity

Sep 17 2019

Itms requested changes to D2021: Fix AtlasUI.dll windows autobuild.

I patched the Jenkins script, but this robocopy call is broken, I had to manually copy files on the slave. This needs to be fixed before committing.

Sep 17 2019, 10:13 PM
Itms committed rP22917: Fix rP22909 on Windows..
Fix rP22909 on Windows.
Sep 17 2019, 9:27 PM
Itms closed D2299: Fix test.exe build failing with --jenkins-tests flag.
Sep 17 2019, 9:27 PM
Itms accepted D2299: Fix test.exe build failing with --jenkins-tests flag.

This works on Jenkins and locally. The build failures above are mostly failed tests of the latest iteration of D1946 🙂

Sep 17 2019, 9:21 PM
Itms planned changes to D1910: Version the GCC Jenkins scripts.

This is completely outdated, now that the build uses Docker. I will upload the current version of scripts here.

Sep 17 2019, 8:57 PM
Itms added a member for Contributors: kenny.
Sep 17 2019, 7:05 PM

Sep 1 2019

Itms updated subscribers of rP22823: legionnaire → legionary (3).

@Stan the error in checkrefs.pl is really strange on Jenkins... 😕 (https://jenkins.wildfiregames.com/blue/organizations/jenkins/docker-svn/detail/docker-svn/319/pipeline) it's saying it parses units/rome_centurio_imperial, what is this file, I can't find it? Is this a bug in the perl script caused by the empty file here?

Sep 1 2019, 3:52 PM
Itms created D2244: Patch SM45 against bug 1266366.
Sep 1 2019, 3:38 PM

Aug 30 2019

Itms edited reviewers for D2114: Do not fail if some mod is broken [Mod Io], added: Itms; removed: Restricted Owners Package.

Hello! I had not noticed the patch when you created it 🙂 I think it's a good idea.

Aug 30 2019, 5:01 PM

Aug 19 2019

Itms added a comment to D2193: Stop copying color every draw call for every GUI object using colors ffs.
In D2193#91271, @elexis wrote:

It can only be closed if it is accepted.

Aug 19 2019, 4:45 PM

Aug 18 2019

Itms committed rP22690: Simplify the translations maintenance script..
Simplify the translations maintenance script.
Aug 18 2019, 8:13 PM
Itms closed D2078: Simplify the translations maintenance script.
Aug 18 2019, 8:13 PM
Itms added a comment to D2078: Simplify the translations maintenance script.

Thanks for taking a look 🙂

Aug 18 2019, 8:12 PM

Aug 8 2019

Stan awarded rP22629: Revert use of the `isRunOnce` flag after removal in rP22627 of compile'n go… a Love token.
Aug 8 2019, 3:29 PM
Itms committed rP22629: Revert use of the `isRunOnce` flag after removal in rP22627 of compile'n go….
Revert use of the `isRunOnce` flag after removal in rP22627 of compile'n go…
Aug 8 2019, 11:06 AM
Itms added a comment to rP22627: Upgrade SpiderMonkey to version 45.0.2, refs #4893..

The setIsRunOnce addition must be reverted.

Aug 8 2019, 10:56 AM
Itms committed rP22628: Precompiled SpiderMonkey 45 and nspr 4.12 for Windows..
Precompiled SpiderMonkey 45 and nspr 4.12 for Windows.
Aug 8 2019, 12:45 AM
elexis awarded rP22627: Upgrade SpiderMonkey to version 45.0.2, refs #4893. a Party Time token.
Aug 8 2019, 12:39 AM
Itms committed rP22627: Upgrade SpiderMonkey to version 45.0.2, refs #4893..
Upgrade SpiderMonkey to version 45.0.2, refs #4893.
Aug 8 2019, 12:38 AM
Itms closed D1510: Update to Spidermonkey 45.0.2.
Aug 8 2019, 12:38 AM

Aug 7 2019

Itms updated the diff for D1510: Update to Spidermonkey 45.0.2.

Updated RC following comments by historic_bruno, wraitii and elexis.

Aug 7 2019, 5:04 PM
Itms accepted D2152: Remove erroneous ErrorReporter.

This looks fine to me, works with SM38 and without any change with SM45, and so much hacky code is removed that I can only be happy 😄 The autorequest looks needed to me.

Aug 7 2019, 12:03 AM

Aug 6 2019

Itms committed rP22620: Improve Roman specific names..
Improve Roman specific names.
Aug 6 2019, 7:59 PM
Itms closed D1999: correct Roman specific names.
Aug 6 2019, 7:59 PM
Itms accepted D1999: correct Roman specific names.
Aug 6 2019, 7:53 PM
Itms added a comment to D1999: correct Roman specific names.

Alright, everything is cleared up then! Thanks again for the work :)

Aug 6 2019, 7:53 PM
Itms added a comment to D1999: correct Roman specific names.

Thanks for the answers! Indeed my dictionary must be marking only the vowels where confusion can happen. I still have one word where I do have a short vowel.

Aug 6 2019, 3:04 PM
Itms accepted D2102: Fix gcc 7 ModIo.cpp compile warning - aligned-new / extended alignment 64.

This is good now!

Aug 6 2019, 2:24 PM

Aug 5 2019

Itms requested changes to D1999: correct Roman specific names.

Thanks for the work! I went through my own dictionary for these changes (Latin-French by Gaffiot & Flobert, 2001) and I have a few differences. A lot of them are vowel lengths differing. Note that sometimes, my dictionary only says that the vowel is not always long, not that it is always short.

Aug 5 2019, 6:08 PM
Itms requested changes to D2102: Fix gcc 7 ModIo.cpp compile warning - aligned-new / extended alignment 64.

Thanks for looking into this! The concept looks good to me and works, but it has a memory leak. The fix is easy 🙂

Aug 5 2019, 12:24 PM
Itms added a comment to D1510: Update to Spidermonkey 45.0.2.

I rebased my branch and added a commit addressing comments: https://github.com/na-Itms/0ad/tree/sm45.

Aug 5 2019, 12:13 PM

Jul 20 2019

Itms updated the diff for D1510: Update to Spidermonkey 45.0.2.

Rebased; this is a RC.

Jul 20 2019, 4:50 AM

Jul 19 2019

Itms committed rP22516: Improvements to simulation hotloading before the SM upgrade, refs #4893..
Improvements to simulation hotloading before the SM upgrade, refs #4893.
Jul 19 2019, 11:59 PM
Itms closed D1844: Improvements to simulation hotloading before the SM upgrade.
Jul 19 2019, 11:59 PM
Itms updated the diff for D1844: Improvements to simulation hotloading before the SM upgrade.

Rebased.

Jul 19 2019, 11:18 PM
Itms accepted D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.
Jul 19 2019, 9:48 PM
Itms added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.

The code looks almost perfect to me (I had too many >> problems in the past, it became an obsession), and this works on SM38 and on SM45. Thanks a lot!

Jul 19 2019, 9:48 PM
Itms committed rP22513: Update of the scripting tests. Test some modding features and update JS::Value….
Update of the scripting tests. Test some modding features and update JS::Value…
Jul 19 2019, 5:41 PM
Itms closed D1850: Scripting tests update.
Jul 19 2019, 5:41 PM
Itms updated the diff for D1850: Scripting tests update.

Fix an integer overflow.

Jul 19 2019, 5:29 PM

Jul 17 2019

Itms committed rP22499: Improvements to the translators credits script..
Improvements to the translators credits script.
Jul 17 2019, 11:32 PM
Itms closed D1810: Improvements to the translators credits script.
Jul 17 2019, 11:32 PM
Itms added a comment to D1810: Improvements to the translators credits script.

Thanks for the review 🙂

Jul 17 2019, 11:12 PM
Itms added a comment to D2030: Update wxWidgets readme [VS2013 -> VS2015].

I used the latest one (probably vc12) with the compiler I wanted to build the game with. Recent versions of visual studio can open slightly older solutions without issue 🙂

Jul 17 2019, 6:52 PM
Itms added inline comments to D1810: Improvements to the translators credits script.
Jul 17 2019, 2:37 PM
Itms updated the diff for D1810: Improvements to the translators credits script.

You were right, there are a few bogus names here! I tracked them down, they are users who deleted their Transifex account. I added a regex to remove them from the credits.

Jul 17 2019, 2:36 PM
Itms abandoned D1026: Run Jenkins build with both GCC and Clang.

This is superseded by our new CI system which is using Docker to build the game under clang-only or gcc-only environments.

Jul 17 2019, 2:15 PM
Itms added a comment to D1932: Update to premake Alpha 14.

This will be useful to start supporting VS2019. I would be against updating premake if we have no bugs or missing features in our version though, because that makes heavy commits. What is your opinion? If you agree, we should wait for when we actually enable 2019, at that time maybe that will be a more recent alpha version of premake.

Jul 17 2019, 11:28 AM

Jul 16 2019

Itms updated subscribers of rP22485: [Windows] Automated build..

@elexis, in the future, if you want to manually start an autobuild, it's better to use the helper job that triggers the autobuilder. Else, that helper job will start an autobuild as planned on the next day and create an extra commit. The helper job has "timeguard" in its name. If you run a build through it, it will reset its internal state.

Jul 16 2019, 6:00 PM
Itms added a comment to rP18656: SpiderMonkey 38 upgrade: 02/35.

Oh, well, I don't know. I usually license my stuff under GPL and it would make sense to put it under GPLv2+ like most of the 0ad code. However, seeing how barebones and easy to adapt this snippet is, maybe MIT would make more sense.

Jul 16 2019, 5:50 PM

Jul 14 2019

Itms created D2078: Simplify the translations maintenance script.
Jul 14 2019, 5:04 PM

Jul 9 2019

Itms updated the diff for D1850: Scripting tests update.

Address comments and use the opportunity to test the new Jenkins setup.

Jul 9 2019, 8:16 PM

Jun 29 2019

Itms added a comment to rP22096: Improve and fix checkrefs.pl, add a readme for usage, add mod support, add….

@Stan The script always returns 0, which makes Jenkins not complain about anything. See for instance https://jenkins.wildfiregames.com/blue/rest/organizations/jenkins/pipelines/svn/runs/1085/nodes/46/log/?start=0.

Jun 29 2019, 10:18 PM
Itms added inline comments to D1946: Windows Differential testing.
Jun 29 2019, 6:48 PM
Itms added a comment to D1946: Windows Differential testing.

I experimentally added this pipeline to Jenkins with the fix to arc patch, and made Phabricator run it on differentials. We'll see if there are unexpected issues. In the meantime, a few comments...

Jun 29 2019, 11:05 AM

Jun 28 2019

Itms requested verification of rP22348: Delete old redistributables for VS 2010, and add new ones for VS 2015. Refs….

Vorbis was compiled with VS2010 and still depended on the redistributables I deleted. I upgraded and recompiled libogg and libvorbis in rP22406, which fixes the issue for me. Other libs might create the same issue if built with VS2010 still.

Jun 28 2019, 12:40 AM
Itms committed rP22406: Update precompiled win32 libogg to 1.3.3 and libvorbis to 1.3.6, building them….
Update precompiled win32 libogg to 1.3.3 and libvorbis to 1.3.6, building them…
Jun 28 2019, 12:37 AM

Jun 16 2019

Itms committed rP22380: Define variables before mentioning them in scripted component tests, and add a….
Define variables before mentioning them in scripted component tests, and add a…
Jun 16 2019, 10:48 PM
Itms closed D1986: simulation tests: eslint fixes for no-use-before-define.
Jun 16 2019, 10:48 PM
Itms accepted D1986: simulation tests: eslint fixes for no-use-before-define.

Thanks for the patch!

Jun 16 2019, 10:42 PM

Jun 8 2019

Itms committed rP22348: Delete old redistributables for VS 2010, and add new ones for VS 2015. Refs….
Delete old redistributables for VS 2010, and add new ones for VS 2015. Refs…
Jun 8 2019, 9:46 AM
Itms awarded D1955: Support "phenotype"-tag in VisualActor. a Like token.
Jun 8 2019, 9:25 AM

Jun 4 2019

Itms committed rP22338: Version and update the Windows autobuilder script, refs #5379..
Version and update the Windows autobuilder script, refs #5379.
Jun 4 2019, 6:48 PM
Itms closed D1909: Version and update the Windows autobuilder script.
Jun 4 2019, 6:48 PM
Itms updated the diff for D1909: Version and update the Windows autobuilder script.

Final version currently in place on Jenkins.

Jun 4 2019, 4:37 PM
Itms commandeered D1909: Version and update the Windows autobuilder script.
Jun 4 2019, 4:34 PM
Itms awarded rP22335: Improve UTF-8 character handling in Atlas a Love token.
Jun 4 2019, 11:12 AM
Itms committed rP22336: Fix a m_JumpPointCache assertion failure in debug mode, refs rP22219..
Fix a m_JumpPointCache assertion failure in debug mode, refs rP22219.
Jun 4 2019, 10:30 AM
Itms closed D1942: Fix a m_JumpPointCache assertion failure in debug mode.
Jun 4 2019, 10:30 AM
Itms accepted D1942: Fix a m_JumpPointCache assertion failure in debug mode.
Jun 4 2019, 10:27 AM

Jun 3 2019

Itms added a comment to D1942: Fix a m_JumpPointCache assertion failure in debug mode.

Alright, then the release code is wrong too imo. UB shouldn't be called, for one thing, but also I worked under the assumption that m_JumpPointCache.find(passClass) would always return a valid, if empty, vector. That's what the code in the Hierarchical Pathfinder does. IMO we should change this code to initialise the jump point cache with the passibility classes, instead of doing two bounds checks.

Jun 3 2019, 10:08 AM

Jun 2 2019

Itms added a comment to D1942: Fix a m_JumpPointCache assertion failure in debug mode.

Mh, this is weird. I would gladly add an "ENSURE" there that there is a possibility class for the C++ code, this means we do something differently in release and debug mode and I don't like it.

Jun 2 2019, 10:11 PM
Itms added inline comments to D1909: Version and update the Windows autobuilder script.
Jun 2 2019, 9:53 PM
Itms added inline comments to D1942: Fix a m_JumpPointCache assertion failure in debug mode.
Jun 2 2019, 3:44 PM
Itms added inline comments to D1942: Fix a m_JumpPointCache assertion failure in debug mode.
Jun 2 2019, 3:23 PM
Itms requested changes to D1942: Fix a m_JumpPointCache assertion failure in debug mode.

Well well well fixes always need more fixes it seems. Dead code is the worst.

Jun 2 2019, 3:02 PM
Itms added a comment to D1909: Version and update the Windows autobuilder script.

Good work! I am currently testing the pipeline on the autobuilder with the following changes.

Jun 2 2019, 8:40 AM

May 31 2019

Itms added a comment to D1935: Anatolian → Lydian; correct Persian specific names.
In D1935#80249, @Nescio wrote:

Then let's use š in Old Persian.
Also, could you create a page https://trac.wildfiregames.com/wiki/SpecificNames, so I could write down a few things there?

May 31 2019, 1:17 PM
Itms added a comment to D1935: Anatolian → Lydian; correct Persian specific names.

There are no rules yet. For Latin I find the diacritics for vowels pretty, and since it's a transliteration I guess we should put them. For Sanskrit I am used to ś, sh doesn't bother me though.

May 31 2019, 12:47 PM
Itms added a comment to D1935: Anatolian → Lydian; correct Persian specific names.
In D1935#80241, @Nescio wrote:

The specific names are specifically non-English, so I'm not sure that style guide would be the appropiate place. I vaguely recall @Itms stating he wanted to write a page on transliterations months ago, but undoubtedly he's busy with other things.

May 31 2019, 12:29 PM
Itms added a comment to D1909: Version and update the Windows autobuilder script.

You can upload with Planned Changes and I'll test.

May 31 2019, 7:27 AM

May 30 2019

Itms added inline comments to D1909: Version and update the Windows autobuilder script.
May 30 2019, 10:14 PM
Itms added inline comments to D1910: Version the GCC Jenkins scripts.
May 30 2019, 8:52 PM

May 29 2019

Itms requested changes to D1909: Version and update the Windows autobuilder script.

Very nice! I'm proposing the following changes. They are either changes from the scripted pipeline syntax to declarative, or improvements that we could make to the current bat script (so, not a criticism towards your work). The only bug/puzzling thing is the absence of the repo address, which makes me think like this pipeline shouldn't work? Unless you checked the repo out manually once?

May 29 2019, 9:14 PM

May 28 2019

Itms accepted D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.

This works perfectly from me now, and the code still looks good 👍 I think the build error comes from the fact that the premake change makes the pch files invalid. I should improve Jenkins so that it performs cleanups when premake scripts are touched, but this is not trivial. I have an alternative fix in mind that I am implementing these days. Anyway, thanks for the great work on this!

May 28 2019, 7:16 PM

May 26 2019

Itms requested changes to D1835: Hierarchical Pathfinder - Add Global Regions / Optimise MakeGoalReachable (D53 outtake).

There is your issue. I haven't fully reviewed the rest yet.

May 26 2019, 2:57 PM
Itms added a comment to D1700: Use JS::Heap instead of JS::PersistentRooted in IGUIObject.

Regardless of the future merge between runtimes and context, I think we should use persistent rooteds as little as possible, so conceptually I agree with the patch.

May 26 2019, 2:23 PM

May 25 2019

Itms accepted rP22225: Fix D1491 which introduced an ENSURE that should not have been there..

Thanks for the fix.

May 25 2019, 6:07 PM
Itms accepted D1875: JPS - make the JPC cache usable again (rP22225 fix).

Wait for the build, but yes from me.

May 25 2019, 5:21 PM
Itms accepted D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

Let's just wait for the build to finish: spoiler alert: it will warn about the copyright years 😛

May 25 2019, 5:19 PM
Itms added inline comments to D1875: JPS - make the JPC cache usable again (rP22225 fix).
May 25 2019, 5:04 PM
Itms added inline comments to D1875: JPS - make the JPC cache usable again (rP22225 fix).
May 25 2019, 4:42 PM
Itms added a comment to D1835: Hierarchical Pathfinder - Add Global Regions / Optimise MakeGoalReachable (D53 outtake).

I restarted the build, let's see.

May 25 2019, 11:55 AM
Itms added a reviewer for D1829: Fix Pathgoal::RectContainsGoal family of function for SQUARE goals, reduce ambiguities, improve coherence among the different functions.: Itms.
May 25 2019, 11:53 AM
Itms requested changes to D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.

Sorry, my reproduction steps were not correct. What I actually tried was adding a char that is outside the first block (ξ, i.e. U+03BE). From my research, this doesn't fail in Atlas, but in CSimulation2::GetMapSettingsString(), so this is a SpiderMonkey bug, not related to your patch. It should be fixed later, I'll try to have a look as part of the SM update.

May 25 2019, 11:52 AM
Itms added a comment to D1875: JPS - make the JPC cache usable again (rP22225 fix).

What Stan said, unless the complete type is actually very long (not on desktop, I can't check).

May 25 2019, 10:10 AM

May 23 2019

Itms accepted D1611: Use pkg-config instead of hard-coding or library-specific programs.

This is working on my macOS VM and on Linux, and the code looks perfect. 👍

May 23 2019, 10:57 PM

May 21 2019

Itms committed rDD2a0785d71397: Replace non-breaking space with normal space. (authored by Nescio).
Replace non-breaking space with normal space.
May 21 2019, 9:41 PM
Itms closed D1913: DD: replace non-breaking space with normal space.
May 21 2019, 9:41 PM
Itms accepted D1913: DD: replace non-breaking space with normal space.

Very nice, thanks for the work 👍

May 21 2019, 9:36 PM