Page MenuHomeWildfire Games

Itms (Nicolas Auvray)
User

User Details

User Since
Dec 19 2016, 10:38 PM (172 w, 2 d)

Recent Activity

Wed, Apr 1

Itms committed rP23562: Update cppformat from v0.11.0 to v1.1.0, fixes #5646, refs #3190..
Update cppformat from v0.11.0 to v1.1.0, fixes #5646, refs #3190.
Wed, Apr 1, 9:32 AM
Itms closed D2613: Updated cppformat.
Wed, Apr 1, 9:32 AM

Tue, Mar 31

Itms accepted D2613: Updated cppformat.

I will commit this today. Thanks adrian for the patch and s0600204 for the help!

Tue, Mar 31, 10:24 AM

Sat, Mar 28

Itms added a comment to D2671: Build: include libexecinfo on musl system.

Else at the very least I'd prefer to test the need for execinfo once at the beginning, so that we don't have calls to the compiler in the middle of our (already complex) prebuild logic.

Why would it matter?

Sat, Mar 28, 7:42 PM
Itms added a comment to D2671: Build: include libexecinfo on musl system.

I see. In that case I suppose this is OK (I find it rather ugly but that's personal taste).

Sat, Mar 28, 7:34 PM
Itms requested changes to D2671: Build: include libexecinfo on musl system.

Hi! Thanks for your contribution.

Sat, Mar 28, 7:09 PM
Itms requested changes to D2613: Updated cppformat.

Thanks for the rebase @s0600204! Jenkins is indeed broken when source files are deleted (or moved) but there is still a build error on a clean build due to the test file.

Sat, Mar 28, 6:52 PM

Mar 9 2020

Itms added a comment to D2650: let "0ad.app" appear as "0 A.D." in Finder.

I see! Thanks for the info. I'll include your changes in the other patch then 👍

Mar 9 2020, 8:37 PM · macOS Developers
Itms abandoned D2650: let "0ad.app" appear as "0 A.D." in Finder.

Hello, thanks for the contribution! This should be already fixed by D2523, which is not yet committed. Could you take a look and check that it works? Else I'll update that other diff.

Mar 9 2020, 7:18 PM · macOS Developers

Mar 5 2020

Itms added a comment to D2613: Updated cppformat.

Thank you! 👍

Mar 5 2020, 10:13 AM

Mar 1 2020

Itms added a comment to D2563: NVTT build fixes.
In D2563#111168, @Stan wrote:
Mar 1 2020, 7:30 PM

Feb 17 2020

Itms requested changes to D2613: Updated cppformat.

Hi! Things look good to me 👍

Feb 17 2020, 8:05 PM

Feb 16 2020

Itms changed the edit policy for D2630: Major improvements to the lobby bots XpartaMuPP and EcheLOn. .
Feb 16 2020, 11:52 AM
Itms added a comment to D2630: Major improvements to the lobby bots XpartaMuPP and EcheLOn. .

Do you plan to run the tests manually, or would you be interested in having Jenkins run the tests when a patch touches source/tools/lobbybots?

Feb 16 2020, 10:40 AM
Itms awarded D2630: Major improvements to the lobby bots XpartaMuPP and EcheLOn. a Love token.
Feb 16 2020, 10:37 AM

Feb 12 2020

Itms added a comment to D2613: Updated cppformat.

I will test this and hopefully commit it during the upcoming weekend. I am a bit short on free time these days, so unfortunately when things are related to libraries some of the steps include waiting for me. Don't hesitate to contribute to other areas of the code in the meantime. Or if you want you can start working on the future cppformat upgrade steps since they seem to involve a lot of work.

Feb 12 2020, 9:29 PM

Feb 10 2020

Itms added a comment to D2613: Updated cppformat.

(you also needed to specify the repository in order to trigger a build, I fixed that)

Feb 10 2020, 7:05 PM
Itms set the repository for D2613: Updated cppformat to rP 0 A.D. Public Repository.
Feb 10 2020, 7:04 PM

Feb 9 2020

Itms added a comment to D2613: Updated cppformat.

I propose to merge this changes into codebase (I can restore old cppformat name) and create another ticket to update fmt to version 6.x. Unfortunately I'm not sure how much time I will have in the future, so I think better option is to not "lock" this issue further.

I agree, and actually I think it's very nice to use this small upgrade to rename the lib, so you can leave it like this.

Feb 9 2020, 10:24 PM

Feb 4 2020

Itms updated the diff for D2563: NVTT build fixes.

Fix for GCC.

Feb 4 2020, 10:03 PM
Krinkle awarded D2563: NVTT build fixes a Orange Medal token.
Feb 4 2020, 9:23 PM

Feb 3 2020

Itms added a comment to D2613: Updated cppformat.

Thank you for the patch! We've been meaning to update cppformat (now fmtlib) for some time now. I had a half-finished patch for going to 2.1.1 (which was the last update before the renaming) in #3190, then was planning to update to the newest version in #4148.

Feb 3 2020, 2:25 PM

Feb 1 2020

Itms added inline comments to D2563: NVTT build fixes.
Feb 1 2020, 4:49 PM
Itms added a comment to D2420: Fix OS hardware detection on windows..

Just a note since I see the patch only now:

Feb 1 2020, 4:25 PM

Jan 13 2020

Itms added a comment to D2563: NVTT build fixes.

Can you attach the dds generated by nvtt that it doesn't manage to load? Thanks :)

Jan 13 2020, 11:38 PM
Itms added a comment to D2566: Fixes debug build on macOS.

Hey! This is already in D2523.

Jan 13 2020, 7:35 PM
Itms closed D2524: Drop Visual Studio 2013 support.

No problem, thank you!

Jan 13 2020, 8:49 AM
Itms committed rP23385: Credit Inari in the credits instead of the commit message of rP23383..
Credit Inari in the credits instead of the commit message of rP23383.
Jan 13 2020, 8:48 AM
Itms added a comment to D2563: NVTT build fixes.
In D2563#107181, @Stan wrote:

This fixes NVTT build however I still get for some images:

Jan 13 2020, 8:44 AM
Itms planned changes to D2523: Jenkins scripts and tweaks for OSX.
Jan 13 2020, 8:35 AM · macOS Developers

Jan 12 2020

Itms updated the diff for D2519: Add --with-system-premake5 option to update-workspaces.sh.

Remove the macOS change that is out of place and is likely to create issues.

Jan 12 2020, 9:30 PM
Itms committed rP23383: Set source and executable character sets to UTF-8 on Windows, removes a….
Set source and executable character sets to UTF-8 on Windows, removes a…
Jan 12 2020, 9:20 PM
Itms closed D1411: Add commandline flag to set source and execution charsets to utf-8.
Jan 12 2020, 9:20 PM
Itms added a comment to D2524: Drop Visual Studio 2013 support.

@Angen I forgot to close the diff in rP23382 😫

Jan 12 2020, 9:09 PM
Itms committed rP23382: Officially drop support for Visual Studio 2013, which stopped working after….
Officially drop support for Visual Studio 2013, which stopped working after…
Jan 12 2020, 9:04 PM
Itms committed rP23381: Commit concrt140.dll, dependency of the new NVTT dll. Fixes #5527, refs #4549….
Commit concrt140.dll, dependency of the new NVTT dll. Fixes #5527, refs #4549…
Jan 12 2020, 7:19 PM
Itms added a comment to D2563: NVTT build fixes.

and check that the new va_list initializer works on other compilers

Jan 12 2020, 6:19 PM
Itms created D2563: NVTT build fixes.
Jan 12 2020, 6:15 PM
Itms committed rP23380: Fix utf-8 in the NVTT source code. This is mostly to please arcanist..
Fix utf-8 in the NVTT source code. This is mostly to please arcanist.
Jan 12 2020, 6:02 PM
Itms added a comment to D2548: Do not face point after movement for formation walk.
In D2548#107040, @Stan wrote:

@Itms can you close it?

Jan 12 2020, 11:14 AM

Jan 10 2020

Itms added a comment to D2557: Significantly improves Atlas terrain elevation performance.

(A commit reference would be useful to ease commit traversal while reviewing, auditing or revisioning)

It was rP16824. And that is funny: looking at the commit, I had written a TODO, so I knew! I then removed the TODO in rP16827, just three revisions later, when I thought the improvements I made were enough.

Jan 10 2020, 11:17 PM
Itms accepted D2557: Significantly improves Atlas terrain elevation performance.

Excluding the in-game terrain updates, which are not actually implemented, everything works fine for me and the code looks good.

Jan 10 2020, 8:15 PM
Itms added inline comments to D2557: Significantly improves Atlas terrain elevation performance.
Jan 10 2020, 4:41 PM
Itms added inline comments to D2557: Significantly improves Atlas terrain elevation performance.
Jan 10 2020, 4:35 PM
Itms added a comment to D2557: Significantly improves Atlas terrain elevation performance.

I think it's not enough, because it has only water level changes. That means the whole grid will be updated (no partial update).

Jan 10 2020, 1:15 PM
Itms edited reviewers for D2557: Significantly improves Atlas terrain elevation performance, added: Itms; removed: Restricted Owners Package.

Hey, this looks great! I didn't realize the message had that terrain information when I wrote the code!

Jan 10 2020, 11:09 AM

Jan 7 2020

Itms added a comment to rP23305: Upgrade NVTT to version 2.1.1, fixes #4549..

Also, I was expecting the script to track the version of lib it built instead of boolean. Seems simple to implement, will consider that later.

Ideally we would do the same as for SpiderMonkey (see libraries/source/spidermonkey/build.sh):

if [ -e .already-built -a .already-built -nt README.txt ]

so that changes to the README trigger a rebuild. However, this is bypassed (including for SM) by build-osx-libs.sh. There is a big discrepancy between macOS and other unixes with respect to the process followed to build bundled libs.

Jan 7 2020, 12:28 PM
Itms updated subscribers of D2523: Jenkins scripts and tweaks for OSX.
Jan 7 2020, 12:14 PM · macOS Developers
Itms added inline comments to D2524: Drop Visual Studio 2013 support.
Jan 7 2020, 12:11 PM

Jan 6 2020

Itms added a comment to rP23305: Upgrade NVTT to version 2.1.1, fixes #4549..

@Krinkle

rm -f libraries/source/nvtt/.already-built

in order to actually build the new nvtt version with build-osx-libs.sh.

Jan 6 2020, 8:24 AM

Jan 3 2020

Itms added inline comments to D2523: Jenkins scripts and tweaks for OSX.
Jan 3 2020, 6:28 PM · macOS Developers

Dec 31 2019

Itms added a comment to D2491: Fix musl build.
In D2491#104180, @Itms wrote:

There is already this PR by a friend

While I appreciate the work on the software, calling leper your friend is a punch in the face and I will not go down in history as someone who read it and left it uncommented.

Dec 31 2019, 4:45 PM
Itms accepted D1380: Build: precompiled logic update.

Also builds and runs --without-pch on Linux (gcc 7). 👍

Dec 31 2019, 1:37 PM

Dec 30 2019

Itms accepted D1396: Remove not needed checks and code for VS2015 [VS2013 -> VS2015].

This is good for me! I think you can commit this just after I commit D2524.

Dec 30 2019, 6:35 PM
Itms updated the diff for D1411: Add commandline flag to set source and execution charsets to utf-8.

Tests fixed.

Dec 30 2019, 6:26 PM
Itms commandeered D1411: Add commandline flag to set source and execution charsets to utf-8.

Thanks again for the patch Inari. I am commandeering it to fix the tests as well. I will commit this just after D2524.

Dec 30 2019, 6:24 PM
Itms created D2524: Drop Visual Studio 2013 support.
Dec 30 2019, 6:19 PM
Itms added a comment to D1380: Build: precompiled logic update.

Right now our precompiled headers also act as global include files, when they probably shouldn't.

Dec 30 2019, 5:58 PM
Itms accepted D1380: Build: precompiled logic update.

Thanks for the patch and I owe you a beer or something for the delay 😅 The changes look perfect. Let's get them in before the copyright year becomes wrong...

Dec 30 2019, 5:56 PM
Itms accepted rP23215: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original….

Thanks!

Dec 30 2019, 12:17 PM
Itms added inline comments to D2522: Fix logic issue with the DXT1a texture format.
Dec 30 2019, 11:37 AM
Itms updated the diff for D2522: Fix logic issue with the DXT1a texture format.

This is mainly to test the new macOS patch building. Sorry in advance for the noise...

Dec 30 2019, 11:35 AM
Itms created D2523: Jenkins scripts and tweaks for OSX.
Dec 30 2019, 11:08 AM · macOS Developers
Itms raised a concern with rP23215: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original….

Could you set svn:ignore to *.cpp on source/third_party/ogre3d_preprocessor/tests (like we do in other tests folders)? That would be great for upcoming svn sts 😉

Dec 30 2019, 10:32 AM
Itms added inline comments to D2522: Fix logic issue with the DXT1a texture format.
Dec 30 2019, 10:09 AM
Itms removed a reviewer for D2522: Fix logic issue with the DXT1a texture format: Vulcan.
Dec 30 2019, 12:25 AM

Dec 29 2019

Itms added a comment to D2522: Fix logic issue with the DXT1a texture format.
In D2522#105360, @Stan wrote:

Maybe we could have such a file and a test?

Dec 29 2019, 8:39 PM
Stan awarded D2522: Fix logic issue with the DXT1a texture format a Love token.
Dec 29 2019, 8:34 PM
Itms added a reviewer for D2522: Fix logic issue with the DXT1a texture format: vladislavbelov.
Dec 29 2019, 8:33 PM
Itms created D2522: Fix logic issue with the DXT1a texture format.
Dec 29 2019, 8:31 PM
Itms requested verification of rP22348: Delete old redistributables for VS 2010, and add new ones for VS 2015. Refs….

Should be good after rP23305.

Dec 29 2019, 12:27 PM
Itms closed D2475: Update NVTT to 2.1.1.
Dec 29 2019, 12:22 PM
Itms committed rP23305: Upgrade NVTT to version 2.1.1, fixes #4549..
Upgrade NVTT to version 2.1.1, fixes #4549.
Dec 29 2019, 12:22 PM
Itms abandoned D2491: Fix musl build.
Dec 29 2019, 11:59 AM

Dec 28 2019

Itms committed rP23302: Update libsodium to 1.0.18, built on Windows with toolset v140_xp..
Update libsodium to 1.0.18, built on Windows with toolset v140_xp.
Dec 28 2019, 7:13 PM
Itms added a comment to D2491: Fix musl build.

Thanks for your patch, I have included the first part (with the other one you needed) in our upgraded NVTT.

Dec 28 2019, 6:54 PM
Itms created D2519: Add --with-system-premake5 option to update-workspaces.sh.
Dec 28 2019, 5:48 PM

Dec 24 2019

Itms added a comment to D2427: Alphabetize credits.

Hm I just checked on Trac and I was probably confused. The Phab revisions are all from the lobby moderator and references on Trac all point to him as well. I was thinking we had a H_Baraq contributor way back then, in the 2013s or something, but I'm wrong.

Dec 24 2019, 10:29 AM
Itms added a comment to D2427: Alphabetize credits.

Thanks for the work!

Dec 24 2019, 10:01 AM

Dec 22 2019

Itms added a comment to D2501: Port scripts to python 3 before doomsday.

See also D506?

Dec 22 2019, 10:26 PM
Stan awarded D2501: Port scripts to python 3 before doomsday a Like token.
Dec 22 2019, 8:26 PM
Itms created D2501: Port scripts to python 3 before doomsday.
Dec 22 2019, 8:19 PM

Dec 20 2019

Itms added a comment to D2491: Fix musl build.

@voroskoi Maybe you should send a pull request upstream. There is already this PR by a friend but it looks like the NVTT maintainer doesn't want it, maybe they'd rather like your solution.

Dec 20 2019, 4:52 PM
Itms added a comment to D2491: Fix musl build.

Like Vlad said, I have just uploaded a NVTT upgrade, so it would be better if you'd test the branch (and I would happily include your patch in my upgrade if it's still needed).

Dec 20 2019, 4:46 PM

Dec 16 2019

Itms added a comment to D2475: Update NVTT to 2.1.1.

I'm uploading it here for Jenkins, though arcanist may have botched the job, we'll see.

Welp, it definitely did...

Dec 16 2019, 11:43 PM
Itms added a comment to rP22348: Delete old redistributables for VS 2010, and add new ones for VS 2015. Refs….

nvtt will be rebuilt in D2475. nspr was rebuilt with the SM45 upgrade. I used the tool https://github.com/lucasg/Dependencies to ensure that all the other DLLs do not depend on the 2010 runtime.

Dec 16 2019, 11:39 PM
Itms created D2475: Update NVTT to 2.1.1.
Dec 16 2019, 11:33 PM
Itms committed rP23250: Update the Jenkins scripts to match the current state, which uses Jenkins….
Update the Jenkins scripts to match the current state, which uses Jenkins…
Dec 16 2019, 10:53 PM
Itms closed D1910: Version the GCC Jenkins scripts.
Dec 16 2019, 10:52 PM
Itms committed rP23249: Put the Windows patch testing Jenkins pipeline, written by Angen, under source….
Put the Windows patch testing Jenkins pipeline, written by Angen, under source…
Dec 16 2019, 10:35 PM
Itms closed D1946: Windows Differential testing.
Dec 16 2019, 10:35 PM
Itms accepted D1946: Windows Differential testing.

I'm committing this with a license header and some whitespace fixes. Thanks for all the work!

Dec 16 2019, 10:34 PM

Dec 7 2019

Itms added inline comments to D1910: Version the GCC Jenkins scripts.
Dec 7 2019, 7:02 PM
Itms updated the diff for D1910: Version the GCC Jenkins scripts.

Updated version using Docker (in place since months now).

Dec 7 2019, 5:35 PM
Itms committed rP23214: Patch SpiderMonkey 45 against bug https://bugzilla.mozilla.org/show_bug.cgi?.
Patch SpiderMonkey 45 against bug https://bugzilla.mozilla.org/show_bug.cgi?
Dec 7 2019, 10:05 AM
Itms closed D2244: Patch SM45 against bug 1266366.
Dec 7 2019, 10:05 AM
Itms added a comment to D2021: Fix AtlasUI.dll windows autobuild.

Ach, I forgot to accept first, too late now. I applied this to Jenkins, everything works 👍

Dec 7 2019, 9:56 AM
Itms committed rP23213: Fix the Atlas build in the Windows autobuilder pipeline, refs #5574..
Fix the Atlas build in the Windows autobuilder pipeline, refs #5574.
Dec 7 2019, 9:54 AM
Itms closed D2021: Fix AtlasUI.dll windows autobuild.
Dec 7 2019, 9:54 AM

Dec 1 2019

Itms added a member for Windows Developers: Angen.
Dec 1 2019, 6:48 PM