- User Since
- Dec 19 2016, 10:38 PM (172 w, 2 d)
Wed, Apr 1
Tue, Mar 31
I will commit this today. Thanks adrian for the patch and s0600204 for the help!
Sat, Mar 28
I see. In that case I suppose this is OK (I find it rather ugly but that's personal taste).
Hi! Thanks for your contribution.
Thanks for the rebase @s0600204! Jenkins is indeed broken when source files are deleted (or moved) but there is still a build error on a clean build due to the test file.
Mar 9 2020
I see! Thanks for the info. I'll include your changes in the other patch then 👍
Hello, thanks for the contribution! This should be already fixed by D2523, which is not yet committed. Could you take a look and check that it works? Else I'll update that other diff.
Mar 5 2020
Mar 1 2020
Feb 17 2020
Feb 16 2020
Do you plan to run the tests manually, or would you be interested in having Jenkins run the tests when a patch touches source/tools/lobbybots?
Feb 12 2020
I will test this and hopefully commit it during the upcoming weekend. I am a bit short on free time these days, so unfortunately when things are related to libraries some of the steps include waiting for me. Don't hesitate to contribute to other areas of the code in the meantime. Or if you want you can start working on the future cppformat upgrade steps since they seem to involve a lot of work.
Feb 10 2020
(you also needed to specify the repository in order to trigger a build, I fixed that)
Feb 9 2020
I agree, and actually I think it's very nice to use this small upgrade to rename the lib, so you can leave it like this.
Feb 4 2020
Feb 3 2020
Thank you for the patch! We've been meaning to update cppformat (now fmtlib) for some time now. I had a half-finished patch for going to 2.1.1 (which was the last update before the renaming) in #3190, then was planning to update to the newest version in #4148.
Feb 1 2020
Just a note since I see the patch only now:
Jan 13 2020
Can you attach the dds generated by nvtt that it doesn't manage to load? Thanks :)
Hey! This is already in D2523.
Jan 12 2020
Remove the macOS change that is out of place and is likely to create issues.
and check that the new va_list initializer works on other compilers
Jan 10 2020
It was rP16824. And that is funny: looking at the commit, I had written a TODO, so I knew! I then removed the TODO in rP16827, just three revisions later, when I thought the improvements I made were enough.
Excluding the in-game terrain updates, which are not actually implemented, everything works fine for me and the code looks good.
Hey, this looks great! I didn't realize the message had that terrain information when I wrote the code!
Jan 7 2020
Ideally we would do the same as for SpiderMonkey (see libraries/source/spidermonkey/build.sh):
if [ -e .already-built -a .already-built -nt README.txt ]
so that changes to the README trigger a rebuild. However, this is bypassed (including for SM) by build-osx-libs.sh. There is a big discrepancy between macOS and other unixes with respect to the process followed to build bundled libs.
Jan 6 2020
rm -f libraries/source/nvtt/.already-built
in order to actually build the new nvtt version with build-osx-libs.sh.
Jan 3 2020
Dec 31 2019
Also builds and runs --without-pch on Linux (gcc 7). 👍
Dec 30 2019
This is good for me! I think you can commit this just after I commit D2524.
Thanks again for the patch Inari. I am commandeering it to fix the tests as well. I will commit this just after D2524.
Thanks for the patch and I owe you a beer or something for the delay 😅 The changes look perfect. Let's get them in before the copyright year becomes wrong...
This is mainly to test the new macOS patch building. Sorry in advance for the noise...
Could you set svn:ignore to *.cpp on source/third_party/ogre3d_preprocessor/tests (like we do in other tests folders)? That would be great for upcoming svn sts 😉
Dec 29 2019
Should be good after rP23305.
Dec 28 2019
Thanks for your patch, I have included the first part (with the other one you needed) in our upgraded NVTT.
Dec 24 2019
Hm I just checked on Trac and I was probably confused. The Phab revisions are all from the lobby moderator and references on Trac all point to him as well. I was thinking we had a H_Baraq contributor way back then, in the 2013s or something, but I'm wrong.
Dec 22 2019
Dec 20 2019
Like Vlad said, I have just uploaded a NVTT upgrade, so it would be better if you'd test the branch (and I would happily include your patch in my upgrade if it's still needed).
Dec 16 2019
I'm uploading it here for Jenkins, though arcanist may have botched the job, we'll see.
Welp, it definitely did...
I'm committing this with a license header and some whitespace fixes. Thanks for all the work!
Dec 7 2019
Updated version using Docker (in place since months now).
Ach, I forgot to accept first, too late now. I applied this to Jenkins, everything works 👍