- User Since
- Dec 19 2016, 10:38 PM (161 w, 1 d)
Mon, Jan 13
Can you attach the dds generated by nvtt that it doesn't manage to load? Thanks :)
Hey! This is already in D2523.
Sun, Jan 12
Remove the macOS change that is out of place and is likely to create issues.
and check that the new va_list initializer works on other compilers
Fri, Jan 10
It was rP16824. And that is funny: looking at the commit, I had written a TODO, so I knew! I then removed the TODO in rP16827, just three revisions later, when I thought the improvements I made were enough.
Excluding the in-game terrain updates, which are not actually implemented, everything works fine for me and the code looks good.
Hey, this looks great! I didn't realize the message had that terrain information when I wrote the code!
Tue, Jan 7
Ideally we would do the same as for SpiderMonkey (see libraries/source/spidermonkey/build.sh):
if [ -e .already-built -a .already-built -nt README.txt ]
so that changes to the README trigger a rebuild. However, this is bypassed (including for SM) by build-osx-libs.sh. There is a big discrepancy between macOS and other unixes with respect to the process followed to build bundled libs.
Mon, Jan 6
rm -f libraries/source/nvtt/.already-built
in order to actually build the new nvtt version with build-osx-libs.sh.
Fri, Jan 3
Tue, Dec 31
Also builds and runs --without-pch on Linux (gcc 7). 👍
Mon, Dec 30
This is good for me! I think you can commit this just after I commit D2524.
Thanks again for the patch Inari. I am commandeering it to fix the tests as well. I will commit this just after D2524.
Thanks for the patch and I owe you a beer or something for the delay 😅 The changes look perfect. Let's get them in before the copyright year becomes wrong...
This is mainly to test the new macOS patch building. Sorry in advance for the noise...
Could you set svn:ignore to *.cpp on source/third_party/ogre3d_preprocessor/tests (like we do in other tests folders)? That would be great for upcoming svn sts 😉
Sun, Dec 29
Should be good after rP23305.
Sat, Dec 28
Thanks for your patch, I have included the first part (with the other one you needed) in our upgraded NVTT.
Tue, Dec 24
Hm I just checked on Trac and I was probably confused. The Phab revisions are all from the lobby moderator and references on Trac all point to him as well. I was thinking we had a H_Baraq contributor way back then, in the 2013s or something, but I'm wrong.
Dec 22 2019
Dec 20 2019
Like Vlad said, I have just uploaded a NVTT upgrade, so it would be better if you'd test the branch (and I would happily include your patch in my upgrade if it's still needed).
Dec 16 2019
I'm uploading it here for Jenkins, though arcanist may have botched the job, we'll see.
Welp, it definitely did...
I'm committing this with a license header and some whitespace fixes. Thanks for all the work!
Dec 7 2019
Updated version using Docker (in place since months now).
Ach, I forgot to accept first, too late now. I applied this to Jenkins, everything works 👍
Dec 1 2019
Sep 17 2019
I patched the Jenkins script, but this robocopy call is broken, I had to manually copy files on the slave. This needs to be fixed before committing.
This works on Jenkins and locally. The build failures above are mostly failed tests of the latest iteration of D1946 🙂
This is completely outdated, now that the build uses Docker. I will upload the current version of scripts here.
Sep 1 2019
@Stan the error in checkrefs.pl is really strange on Jenkins... 😕 (https://jenkins.wildfiregames.com/blue/organizations/jenkins/docker-svn/detail/docker-svn/319/pipeline) it's saying it parses units/rome_centurio_imperial, what is this file, I can't find it? Is this a bug in the perl script caused by the empty file here?
Aug 30 2019
Hello! I had not noticed the patch when you created it 🙂 I think it's a good idea.
Aug 19 2019
Aug 18 2019
Thanks for taking a look 🙂
Aug 8 2019
The setIsRunOnce addition must be reverted.
Aug 7 2019
Updated RC following comments by historic_bruno, wraitii and elexis.
This looks fine to me, works with SM38 and without any change with SM45, and so much hacky code is removed that I can only be happy 😄 The autorequest looks needed to me.