- User Since
- Dec 19 2016, 10:38 PM (352 w, 2 d)
Jul 31 2023
Jul 30 2023
gah, I was not reactive enough to your message on IRC. I don't think the check for an existing instance of the component prevents you from decoupling construction and attachment of the component. Instead, I suggest you move the check to the component attachment. Maybe another check can be added somewhere else to reduce the risks of memory leaks in future modifications of the code.
Jul 24 2023
I had a voice call with phosit in order to move forward with this review. We chose to work with a unique_ptr. phosit will write a couple incremental patches for eased review, without interface removal to avoid mocking issues, and with minimal boilerplate changes in callers.
Jul 17 2023
(actually this request doesn't warrant a blocking ❌)
Very nice patch. It works on Windows. I agree with the changes proposed 👍🏻
Jun 29 2023
May 22 2023
This fixes the issue 👍🏻
May 18 2023
I took a first look at this and gave some feedback to phosit on IRC (starting at 14:34).
May 16 2023
Apr 19 2023
Great, consensus reached! You can perform the changes and I'll commit 🙂
Apr 18 2023
This also works well on Windows. EDIT: and also on Linux 👍🏻
Apr 10 2023
I could not reproduce the Jenkins bug 🤷🏻♂️
Apr 1 2023
Thanks for the patch! I'm waiting for the Windows build and I'm committing it with minor style fixes.
Mar 27 2023
Mar 26 2023
Hello, this looks nice and clean, thanks for the work!
Feb 20 2023
Feb 16 2023
Here is my work-in-progress rewrite of this feature: https://gitlab.com/na-Itms/0ad/-/commit/b51f29d9e1ff5f2e14e271de9155c9f3a31728cd
Feb 13 2023
Would you plan to move the m_MutedUsers and m_HelperUsers [...]
Would you plan to move the validity testing of the moderation commands [...]
No, those should be in the server indeed. Sorry if I wasn't clear.
Thank you for your answer!
Feb 6 2023
Feb 5 2023
Hi Norse_Harold, I went through this very big patch. First of all thank you again for working on this essential feature. 👍🏻
Jan 31 2023
I went with the const-correct fix and sent it upstream.
Jan 27 2023
Ah shoot, the fix was in D4910, but it got lost when I copied all the headers again before committing. I am actually hesitating between two fixes:
Jan 26 2023
Jan 25 2023
Obviously, testers will be smarter than Jenkins, and will rebuild with --build-shared-glooxwrapper.
Jan 24 2023
Jan 21 2023
Note that a disruption in this method has been planned for quite some time and it would be good to perform both changes at once.
This looks good to me and works.
Jan 20 2023
Jan 19 2023
Jan 17 2023
Jan 16 2023
Forgot a file
Don't patch this issue outside of Linux, it conflicts with wraitii's fix for the virtualenv on Mac and is not needed on Windows
Extra cleanup (correct EOLs and move a build environment variable introduced in D4776 to a better place).
I have no idea what failed!
Aug 26 2021
Here is a key for signing A26 mods.
Jun 14 2021
Mar 4 2021
I'm OK with removing JSHint. Originally the linters were supposed to be complementary, one for the style, one for the logic. But nowadays both detect both kinds of issues, and there is a risk of conflict.
Feb 12 2021
Jan 25 2021
Superseded by SM upgrades.
This change needs D3470 🙂
Nov 14 2020
The SVN change is wrong. If SVN is broken, the differential pipeline should try to build upon a working version, so you must not run svn up. If you want to change the paradigm and always build upon the latest SVN, the pipelines should be entirely rewritten.
Nov 5 2020
Very nice improvement, some major comments though ??
Oct 29 2020
Thanks a lot for the quick review!
Oct 28 2020
Address Freagarach's comments.
The code change is correct and, apparently, works under SM45 and SM52.
Yo Stan, I don't see the need for MesonBuild support, I would recommend creating a Trac ticket with "If Time Permits" urgency, a link to this diff in the Patch field, and then abandon this diff for the time being.
Hi @wraitii! I will need this to perform the SM 52->60 migration (see #1389510 on Bugzilla). The ideal route would be to include this under SM52, but if SM60 adds nice code to handle proxy privates, I am fine with doing this as part of the 52->60 code fixes.