Page MenuHomeWildfire Games

Itms (Nicolas Auvray)
User

User Details

User Since
Dec 19 2016, 10:38 PM (103 w, 8 h)

Recent Activity

Yesterday

Itms added a member for Contributors: cpc.
Mon, Dec 10, 10:09 PM

Sat, Dec 8

Itms committed rP21946: [i18n] Last manual update of the translations and associated credits..
[i18n] Last manual update of the translations and associated credits.
Sat, Dec 8, 11:04 PM
Itms committed rP21945: Correctly choose DarwinSSL TLS backend on macOS for libcurl..
Correctly choose DarwinSSL TLS backend on macOS for libcurl.
Sat, Dec 8, 10:09 PM
Itms closed D1687: Fix build on OSX 10.9.5 Mavericks.
Sat, Dec 8, 10:09 PM
Itms committed rP21944: New mod signing key for A23b..
New mod signing key for A23b.
Sat, Dec 8, 9:52 PM
Itms closed D1686: New mod signing key for A23b.
Sat, Dec 8, 9:52 PM
Itms added a comment to D1687: Fix build on OSX 10.9.5 Mavericks.
In D1687#66940, @elexis wrote:

Not few flags, libCURLs ./configure --help | grep without yields

Sat, Dec 8, 1:26 PM

Fri, Dec 7

Itms added a comment to D1687: Fix build on OSX 10.9.5 Mavericks.

@trompetin17 It looks like you have yet another system lib which tries to sneak into the build 😠 Can you try --without-brotli? Just like we did with nghttp2.

Fri, Dec 7, 9:00 PM
Itms added a comment to rP21940: Build gloox with GnuTLS on macOS, refs #4705..

Clarifying a small thing in Stan's answer (which is correct): when D1687 is committed (tonight probably, as trompetin is testing it as we speak), mod.io will work for everyone, regardless of who built the game.

Fri, Dec 7, 5:57 PM
Itms added a comment to rP21940: Build gloox with GnuTLS on macOS, refs #4705..

@elexis Yeah, it's the clock_gettime thing...

Fri, Dec 7, 2:55 PM
Itms added a comment to rP21943: Update client\'s default.cfg for the new muc room `arena23b`.

@vladislavbelov In the staff discussions, it seemed that we had reached a consensus on creating this new room, but leaving the other version numbers intact (in order to push people into upgrading, without forcing them). On top of what elexis said, we are legally obliged to push the lobby users into using A23b, so that they can accept the new terms.
The consensus in that topic is the reason why I asked user1 to commit this, but if you want I can formally accept this revision.

Fri, Dec 7, 2:47 PM
elexis awarded rP21941: Import part of commit https://github.com/premake/premake… a Like token.
Fri, Dec 7, 2:09 PM

Mon, Dec 3

Itms committed rP21942: Target 10.9 as minimal OSX version in all scripts, in order to match the….
Target 10.9 as minimal OSX version in all scripts, in order to match the…
Mon, Dec 3, 12:08 PM
Itms closed D1685: Target 10.9 as minimal OSX version.
Mon, Dec 3, 12:08 PM
Itms requested changes to D1482: Target build version explicitly for Xcode.

The patch is currently useless, because xcodebuildsettings was added in premake5 alpha12 (we have alpha10): see https://github.com/premake/premake-core/wiki/xcodebuildsettings.

Mon, Dec 3, 11:56 AM

Sun, Dec 2

Itms committed rP21941: Import part of commit https://github.com/premake/premake….
Import part of commit https://github.com/premake/premake…
Sun, Dec 2, 9:58 PM
Itms closed D1669: Remove hardcoded minimum OSX version in premake5.
Sun, Dec 2, 9:58 PM
Itms committed rP21940: Build gloox with GnuTLS on macOS, refs #4705..
Build gloox with GnuTLS on macOS, refs #4705.
Sun, Dec 2, 9:53 PM
Itms closed D1654: Build gloox with GnuTLS on macOS.
Sun, Dec 2, 9:52 PM
Itms committed rP21939: Minor change to the libcurl macOS compilation..
Minor change to the libcurl macOS compilation.
Sun, Dec 2, 9:42 PM
Itms closed D1487: curl OSX build script fix.
Sun, Dec 2, 9:42 PM
Itms requested changes to D1482: Target build version explicitly for Xcode.

I agree, but I think you didn't test this? The option must be accessed with _OPTIONS (see the other use of it in the file for an example) and I suggest running the whole premake script with and without the parameter passed.

Sun, Dec 2, 9:11 PM
Itms added a comment to D1669: Remove hardcoded minimum OSX version in premake5.
In D1669#66853, @Stan wrote:

I see. Won't be hard to keep track of all the patches we apply ? For now we only have one but we might have more in the future, no ?

Sun, Dec 2, 8:40 PM
Itms added a comment to D1669: Remove hardcoded minimum OSX version in premake5.
In D1669#66846, @Stan wrote:

Might I suggest to save this as a patch and apply it on premake when updating update workspaces on OsX ?

Sun, Dec 2, 8:04 PM
Itms added inline comments to D1685: Target 10.9 as minimal OSX version.
Sun, Dec 2, 8:03 PM
Itms committed rP21938: Credit translators for A23b..
Credit translators for A23b.
Sun, Dec 2, 6:56 PM
Itms committed rP21937: [i18n] Manual update of the translations..
[i18n] Manual update of the translations.
Sun, Dec 2, 6:52 PM
Itms created D1686: New mod signing key for A23b.
Sun, Dec 2, 6:17 PM
Itms updated the diff for D1487: curl OSX build script fix.

Yet another lib that might be detected by configure even though we don't have it and we don't need it. Disabling it explicitly is needed to link pyrogenesis.

Sun, Dec 2, 3:13 PM
Itms commandeered D1487: curl OSX build script fix.

Instead of abandoning this revision which was superseded by D1610, D1609 and D1685 (in order of committing), I take the liberty to commandeer it to include yet another manual disabling of a library we do not use.

Sun, Dec 2, 3:08 PM
Itms requested changes to D1482: Target build version explicitly for Xcode.

This should use premake5.lua's macosx-version-min variable in order to avoid hardcoding. With D1685, this will actually be 10.9.

Sun, Dec 2, 3:04 PM
Itms created D1685: Target 10.9 as minimal OSX version.
Sun, Dec 2, 3:01 PM
Itms updated the diff for D1669: Remove hardcoded minimum OSX version in premake5.

Final version.

Sun, Dec 2, 2:42 PM
Itms commandeered D1669: Remove hardcoded minimum OSX version in premake5.
Sun, Dec 2, 2:40 PM
Itms updated the diff for D1654: Build gloox with GnuTLS on macOS.

Final version.

Sun, Dec 2, 2:28 PM

Mon, Nov 26

Itms added a comment to D1679: Add an option to allow players to circumvent TLS bugs.
In D1679#66719, @Stan wrote:

I understand your point. My concern was mainly about people who don't report bugs because it's not a common thing to do :)

Mon, Nov 26, 6:06 PM
Itms added a comment to D1679: Add an option to allow players to circumvent TLS bugs.

First of all, I can reproduce the crash on Fedora, and the current patch does fix it when the TLS box is unticked. So the C++ change is good 👍

Mon, Nov 26, 2:08 PM

Sun, Nov 25

Itms added a comment to D1679: Add an option to allow players to circumvent TLS bugs.

Looks good to me! Please commit it if this allows Fedora users to work around the crash.

Sun, Nov 25, 1:56 PM

Sat, Nov 24

Itms added inline comments to D1679: Add an option to allow players to circumvent TLS bugs.
Sat, Nov 24, 11:16 AM
Itms created D1679: Add an option to allow players to circumvent TLS bugs.
Sat, Nov 24, 11:14 AM

Thu, Nov 22

Itms updated the diff for D1654: Build gloox with GnuTLS on macOS.

With this fix, the detection from gnutls' configure script will be overridden.

Thu, Nov 22, 11:41 PM

Wed, Nov 21

Itms added a comment to D1674: Check translations for sprintf errors.

So the big flaw of rP19669 is that the Phabricator Jenkins plugin has this issue: https://github.com/uber/phabricator-jenkins-plugin/issues/224

Wed, Nov 21, 10:41 AM

Mon, Nov 19

Itms added a comment to D1674: Check translations for sprintf errors.

Thank you for the patch! Unfortunately those checks are the same as what is checked by build/jenkins/lint-translations.sh. The thing that is missing from this is a check for broken custom tags (like [font] ones, typically).

Mon, Nov 19, 10:21 PM
Itms added a comment to D1676: Embed zpl-c's version of enet library.

Isn't the flag needed in the premake4.lua too?

Mon, Nov 19, 7:30 PM

Sat, Nov 17

Itms updated the diff for D1654: Build gloox with GnuTLS on macOS.

@trompetin17 Could you test this? I added -UCLOCK_REALTIME, this should work (see this piece of the GnuTLS code).

Sat, Nov 17, 1:06 PM

Tue, Nov 13

Itms requested changes to D1669: Remove hardcoded minimum OSX version in premake5.

Regarding the premake5 change, it looks good, you could remove the offending line from build/premake/premake5/premake5.lua for completeness. I hope to get a quick answer on issue 1154.

Tue, Nov 13, 9:44 PM
Itms added a comment to D1654: Build gloox with GnuTLS on macOS.
In D1654#66152, @elexis wrote:

It was just that it shouldn't be possible to obtain the stacktrace that Tobbi received, where the macro says 10.8 and the compiler says 10.7:

Couldn't it come from what @trompetin17 has discovered, that premake5 itself has a hardcoded 10.4 minimum version? See this line and others, all coming from this code in p5 a10.

Tue, Nov 13, 6:01 PM
Itms committed rP21931: Small changes to the macOS build scripts..
Small changes to the macOS build scripts.
Tue, Nov 13, 5:12 PM
Itms committed rP21930: [i18n] Manual update of the translations during our autobuilder downtime..
[i18n] Manual update of the translations during our autobuilder downtime.
Tue, Nov 13, 5:12 PM
Itms closed D1609: Small changes to the macOS scripts.
Tue, Nov 13, 5:12 PM

Nov 10 2018

Itms planned changes to D1671: Workaround for the SDL bug on macOS Mojave.
Nov 10 2018, 3:13 PM
Itms added a comment to D1671: Workaround for the SDL bug on macOS Mojave.

Itms, could you point me where do you see about drop 10.9 to 10.11, because when i tried sdl2.0.9 i didnt change minimal osx version and builded normally

Nov 10 2018, 2:41 AM

Nov 9 2018

Itms created D1671: Workaround for the SDL bug on macOS Mojave.
Nov 9 2018, 10:03 PM
Itms requested changes to D1669: Remove hardcoded minimum OSX version in premake5.

Yes, like Vlad says, we should change our own defaults in the premake scripts, but we mustn't touch premake source (it's easier to maintain when we match upstream).

Nov 9 2018, 8:48 PM
Itms updated the diff for D1609: Small changes to the macOS scripts.

Small changes to the macOS scripts.

  • date update based on previous patch
  • the --enable-64bit flag is needed for nspr when developing on recent versions (we are already building 64bit only)
  • the --without-libpsl precision is needed to avoid issues when libpsl is installed and detected
Nov 9 2018, 8:46 PM
Itms commandeered D1609: Small changes to the macOS scripts.

@Stan If you don't mind, I'm commandeering this one to have all the small changes to macOS scripts in one diff! :slight_smile:

Nov 9 2018, 8:40 PM
Itms added a comment to D1654: Build gloox with GnuTLS on macOS.

Apart from that, I cannot reproduce my mod.io bug, so this patch should be fine (tested on a clean repo).

Nov 9 2018, 8:38 PM
Itms added a comment to D1654: Build gloox with GnuTLS on macOS.

@elexis: I have looked around about this issue, and I might have misunderstood a few remarks from you that were unclear to me, but I think I know what is bugging you. I also know why certain version numbers are 8, others 9, and why the reason for dropping 7 was unclear (thanks to some attempts by trompetin).

Nov 9 2018, 8:37 PM

Nov 7 2018

Itms added a comment to D1659: Correct and complete lobby server readme.
In D1659#65921, @Vulcan wrote:

Build failure - The Moirai have given mortals hearts that can endure.

Nov 7 2018, 4:31 PM

Oct 31 2018

Itms accepted rP21913: Update macOS libcurl --without-libidn flag to --without-libidn2 following https….

After a more careful testing, indeed this commit doesn't introduce the issue. It might come from D1654 after all. However,

Oct 31 2018, 6:57 PM

Oct 24 2018

Itms added a comment to D1654: Build gloox with GnuTLS on macOS.
In D1654#65543, @Itms wrote:

Yes, I think we should have 10.9 in the bundle generation script, and we should add a comment "keep in sync with build-libs" in build-bundle.

Oct 24 2018, 12:18 PM
Itms added a comment to D1654: Build gloox with GnuTLS on macOS.
In rP21913#31478, @Stan wrote:

I'm pretty sure we can't have letters in mod versions.

Wrong place? 😛 This is unrelated to mods, but if the bundle version cannot have letters, it should still be 23, not 24.

Oct 24 2018, 12:15 PM
Itms added a comment to rP21913: Update macOS libcurl --without-libidn flag to --without-libidn2 following https….

It does ask for ssl since it complains about ssl not being available. (It should ask for ssl if and only if the default.cfg mod.io url starts with https://)

I was talking about the compilation of curl, not the request made to mod.io.

Oct 24 2018, 12:02 PM
Itms added a comment to D1654: Build gloox with GnuTLS on macOS.
In D1654#65539, @elexis wrote:

sw_vers -productVersion yields 10.13.6

Should we commit the 10.7 drop

I really don't have a clue about the share of our users (both players and people who build the game) who use a given version of macOS. If Tobbi needs to drop 10.7 to build on his machine, I think we have to do that. If somebody has 10.7 and wants to play, we can help them build it themselves.

Oct 24 2018, 11:27 AM
Itms added a comment to rP21913: Update macOS libcurl --without-libidn flag to --without-libidn2 following https….
  • What is the error message?
  • Sure it is this commit and not rP21914, or a forgotton cleaning of buildfiles, if so how do you know?
Oct 24 2018, 11:15 AM

Oct 23 2018

Itms raised a concern with rP21913: Update macOS libcurl --without-libidn flag to --without-libidn2 following https….

It looks like this commit breaks mod.io on macOS (no https support anymore, whereas it worked on the previous revision), but I can't understand why.

Oct 23 2018, 11:08 PM
Itms updated the diff for D1654: Build gloox with GnuTLS on macOS.

This builds and works!

Oct 23 2018, 8:53 PM

Oct 22 2018

Itms commandeered D1654: Build gloox with GnuTLS on macOS.

I am progressing on this but not there yet. Hopefully tomorrow!

Oct 22 2018, 10:31 PM

Oct 20 2018

Itms added a reviewer for D1654: Build gloox with GnuTLS on macOS: macOS Developers.
Oct 20 2018, 10:47 PM
Itms requested changes to D1654: Build gloox with GnuTLS on macOS.

The build fails on OSX: gnutls needs libnettle. 🙁

Oct 20 2018, 10:47 PM
Itms awarded rP21913: Update macOS libcurl --without-libidn flag to --without-libidn2 following https… a Like token.
Oct 20 2018, 12:07 PM

Oct 17 2018

Itms committed rP21911: Allow the translation scripts to pull the new resource (rP21905)..
Allow the translation scripts to pull the new resource (rP21905).
Oct 17 2018, 11:16 PM

Oct 15 2018

Itms accepted D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.

Sorry, I just googled what it is! Balancing test assessments are not called like this in GDPR itself, are they? I believe the missing piece is not a comma, but a "through" then.

Oct 15 2018, 10:02 PM
Itms added a comment to D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.

Apart from the point 14 (actually 13) of WFG obligations, which I believe needs a rephrasing, I am on board with this document! Thanks for all the hard work.

Oct 15 2018, 9:58 PM

Oct 12 2018

Itms accepted D1647: Create gui-userreport.pot translation resource.

Yes this is good! As soon as it's committed, I'll run the translation bot.

Oct 12 2018, 9:56 PM

Oct 5 2018

Itms added a comment to D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
In D1598#65212, @elexis wrote:

Currently at 40 of maybe 80 inline comments, seeking to commit an updated version of the UserReporter terms, unless you want to review it again.

As I said, I was happy with the terms I made a pull request on, so I trust you to commit something that I'm happy with. It's up to you to ask a review from me if you want one 🙂 I'll let you know if I have remarks anyways.

Oct 5 2018, 4:22 PM
Itms added a comment to D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.

About https://github.com/elexis1/0ad/pull/1, do you have any comments on my suggestions? I really liked this iteration, with generalized mention of the relevant GDPR articles, so I tried to make improvements where I saw fit, but the work was definitely good enough to replace the different Phabricator patches, if you want to finish the review here rather than on GitHub.

Oct 5 2018, 3:22 PM

Sep 4 2018

Itms added a comment to D1617: implement Travis code integration testing.

I tried. Travis apparently has a 50-minute limit on tests. It terminates the build.

Sep 4 2018, 6:28 PM

Aug 31 2018

Itms requested changes to D1617: implement Travis code integration testing.
Aug 31 2018, 4:18 PM
Itms removed reviewers for D1617: implement Travis code integration testing: s0600204, elexis.

Hi @andy5995, thanks for the proposal!

Aug 31 2018, 4:18 PM

Aug 10 2018

Itms resigned from D1500: #5046 - Unify User.cfg, Local.cfg, Mod.cfg.

Posted some input on the Trac ticket, but I am not reviewing this code :)

Aug 10 2018, 4:12 PM

Aug 9 2018

Itms added a comment to D1601: Link users with mod.io's privacy policy and terms of use..
In D1601#64362, @elexis wrote:

Hold on,

bb wrote a patch to add a terms UI that works for all 3 current online services. This way this patch doesnt have to introduce a new file.

All current active revision proposals with regards to GDPR are currently in https://github.com/bb-bb/0ad/tree/terms (except D1590, but that will come later)

Aug 9 2018, 4:35 PM
Itms added a reviewer for D1601: Link users with mod.io's privacy policy and terms of use.: Itms.

On it!

Aug 9 2018, 3:41 PM

Aug 5 2018

Itms added a comment to D1604: Make capturing optional.

ERROR: JavaScript error: simulation/components/Capturable.js line 28
ReferenceError: IID_CaptureManager is not defined
Capturable.prototype.GetCapturePoints@simulation/components/Capturable.js:28:6
@simulation/components/tests/test_Capturable.js:96:26
testCapturable@simulation/components/tests/test_Capturable.js:86:2
@simulation/components/tests/test_Capturable.js:91:1

Aug 5 2018, 7:18 PM
Itms added a comment to D1462: Enforce formation required member count.

ERROR: JavaScript error: simulation/components/GuiInterface.js line 246
TypeError: cmpIdentity.CanUseSomeFormation is not a function
GuiInterface.prototype.GetEntityState@simulation/components/GuiInterface.js:246:23
@simulation/components/tests/test_GuiInterface.js:566:25

Aug 5 2018, 7:06 PM

Jul 26 2018

Itms added a comment to D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.
In D1598#64094, @Vulcan wrote:

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/687/display/redirect

Jul 26 2018, 5:01 PM
Itms requested changes to D1598: 0 A.D. Empires Ascendant UserReporter Privacy Policy.

Here are a couple comments on the privacy policy itself. I haven't tested the code, I can find some time for that if needed.

Jul 26 2018, 3:49 PM

Jul 23 2018

Itms added a reviewer for D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy: Itms.
Jul 23 2018, 4:03 PM
Itms added a comment to D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.

One more batch of comments :) Thanks again for the work on that.

Jul 23 2018, 4:03 PM

Jun 4 2018

Itms added a comment to D1559: Disable AIInterface earlier.

One extra thing that should be tested on that patch is whether a saved game with AIs can be re-loaded without issues.

Jun 4 2018, 8:51 PM

May 27 2018

Itms added 1 auditor(s) for rP21675: Properly handle map resizes in Atlas, fixes #4800.: temple.

Damnit. I cannot look into fixing this in the immediate future. Based on the things this commit changes, there is a very small chance that the wrong simulation state is the one of the rejoining player, i.e. fixing/reverting this would not change the sim state, and people with the bug and people without would not go OOS. If that is the case re-releasing with the fix would be less of a problem.

May 27 2018, 10:09 AM

May 12 2018

Itms added a comment to D1487: curl OSX build script fix.

Updated: https://github.com/na-Itms/0ad/tree/osx-fix.

May 12 2018, 4:04 PM

May 2 2018

Itms added a comment to rP21814: Fix rP21113 compatibility with zipped mods, refs #5018..

The code in rP21131 calling CFileUnpacker::Read in FileIo.cpp, implementing rmgen being able to load terrain pmp files fixing #4816 looks like it should be compatible, but can someone (ping @Imarok @Itms) verify that Jebel Barkal starts up too with the release candidate? (hint: chose tiny mapsize)

May 2 2018, 2:25 PM

May 1 2018

Itms requested changes to D1479: Lobby: Ignore games with no valid modentry.

Not really accepted by elexis, and since you seem to be AFK I restarted packaging for a second RC.

May 1 2018, 11:33 PM
Itms accepted D1480: Fix VFS loading of map heightmap images.
May 1 2018, 10:43 PM
Itms added a comment to rP20067: Add an icon to pyrogenesis' application window.

rP21812

May 1 2018, 10:30 PM
Itms committed rP21812: Fix the window icon that cannot be loaded in release packages, refs r20067..
Fix the window icon that cannot be loaded in release packages, refs r20067.
May 1 2018, 10:29 PM
Itms added a comment to D1479: Lobby: Ignore games with no valid modentry.

What I mean is: if you really think this patch is half-baked and shouldn't be committed in a hurry, let's just not commit it and yell at the people who use outdated SVNs without a clue. I wouldn't disagree.

May 1 2018, 10:09 PM
Itms added a comment to D1479: Lobby: Ignore games with no valid modentry.

To be fair I'm not sure how someone managed to log in the lobby with an outdated SVN by mistake. Probably using the development PPA, but once again, who would install that by mistake? What are the odds...

May 1 2018, 10:08 PM
Itms accepted D1479: Lobby: Ignore games with no valid modentry.
May 1 2018, 10:02 PM