- User Since
- Dec 19 2016, 10:38 PM (186 w, 1 d)
Sorry, yes you can abandon this one, I'll include it as planned when I'm looking at NVTT again.
Sun, Jul 12
Sat, Jul 11
Fri, Jul 10
Thu, Jul 9
Wed, Jul 8
This looks really nice at first sight. I'm keeping forward on the SM upgrade work and I'll let you know if I prefer get this in before or after a specific version.
Mon, Jul 6
As reported on Trac, the patch works for me, I have no news of GunChleoc. If someone with an Ubuntu, or derived, could test this... I am also interested in users of various distributions where the system nvtt creates the issue.
Sun, Jul 5
I am slowly wrapping my head around this patch, but I find it very complicated. I wrote down a few comments but this is just a first pass. In general I find that the code comments you wrote add more confusion.
Looks good to me! I will look into fixing the issues you pointed out in your audit of the original commit.
Sat, Jul 4
Really like the patch and the new UX with broken mods, it's a big improvement 👍🏻
Wed, Jul 1
Even as admin, I am blocked by the policy @borg- set! borg, you have to click "Edit Revision" at the top right of the diff description, then change "Editable By" to become "All Users".
Tue, Jun 30
I'll fix those myself and commit, as proposed by wraitii on IRC.
OK, everything good for me 👍🏻
Sat, Jun 27
This looks good, I will test it later! 👍🏻
This looks good to me apart from the roundtrip change. Additionally I am fine with believing that SM uses UTF16 internally but what is the source of this affirmation? Is it still true with recent versions of SM?
Fri, Jun 26
Wed, Jun 24
This quote is both sexist by modern standards, and not about combat (even loosely). That is all. If there are other quotes with those two issues, we could definitely add them to the diff.
I think what was meant by Not a vital quote is that we are developing a strategy game of combat and thus quotes that are not related to war are not useful.
Tue, Jun 23
I'm going to include it in D2563!
(Upon committing, I am only adding -o /dev/null to the cc call, in order not to generate an unneeded a.out file)
This works well on GCC 10 and clang 10.
Hi nephele, sorry for the delay in reacting. I was away finishing writing my PhD thesis. I am going to commit this fix. Thanks a lot for your work! 👍🏻
I am not sure I like this change... 😕 I feel like grouping the association between XML names and C++ classes in a single place is neater.
This looks fine, I can test it.
Mon, Jun 22
The two new files should have the svn:eol-style property set to native like all other source files 🙏🏻
May 27 2020
GunChleoc reports it doesn't correctly detect an old NVTT version.
May 24 2020
May 22 2020
This sounds like a good idea 👍
May 21 2020
Update after rP23686, so that the mac slave builds the new version.
I am going to commit this, but with a suffix for spidermonkey, as well as using numbers (instead of tentative dates) for the suffixes.
May 19 2020
Make the preprocessor change minimal.
May 17 2020
Thanks! I'll try to commit this during the week, we have some bank holidays...
And one final idea: maybe the nvtt version should have a wildfiregames suffix so that it gets rebuilt when we add some patches, like I will do in D2563.
Additionally I had this idea: P203
Hi Krinkle, very nice patch! It will help the CI considerably.
May 9 2020
Apr 1 2020
Mar 31 2020
I will commit this today. Thanks adrian for the patch and s0600204 for the help!
Mar 28 2020
I see. In that case I suppose this is OK (I find it rather ugly but that's personal taste).
Hi! Thanks for your contribution.
Thanks for the rebase @s0600204! Jenkins is indeed broken when source files are deleted (or moved) but there is still a build error on a clean build due to the test file.
Mar 9 2020
I see! Thanks for the info. I'll include your changes in the other patch then 👍
Hello, thanks for the contribution! This should be already fixed by D2523, which is not yet committed. Could you take a look and check that it works? Else I'll update that other diff.
Mar 5 2020
Mar 1 2020
Feb 17 2020
Feb 16 2020
Do you plan to run the tests manually, or would you be interested in having Jenkins run the tests when a patch touches source/tools/lobbybots?
Feb 12 2020
I will test this and hopefully commit it during the upcoming weekend. I am a bit short on free time these days, so unfortunately when things are related to libraries some of the steps include waiting for me. Don't hesitate to contribute to other areas of the code in the meantime. Or if you want you can start working on the future cppformat upgrade steps since they seem to involve a lot of work.
Feb 10 2020
(you also needed to specify the repository in order to trigger a build, I fixed that)
Feb 9 2020
I agree, and actually I think it's very nice to use this small upgrade to rename the lib, so you can leave it like this.
Feb 4 2020
Feb 3 2020
Thank you for the patch! We've been meaning to update cppformat (now fmtlib) for some time now. I had a half-finished patch for going to 2.1.1 (which was the last update before the renaming) in #3190, then was planning to update to the newest version in #4148.
Feb 1 2020
Just a note since I see the patch only now:
Jan 13 2020
Can you attach the dds generated by nvtt that it doesn't manage to load? Thanks :)
Hey! This is already in D2523.
Jan 12 2020
Remove the macOS change that is out of place and is likely to create issues.