- User Since
- Dec 19 2016, 10:38 PM (103 w, 8 h)
Sat, Dec 8
Fri, Dec 7
@trompetin17 It looks like you have yet another system lib which tries to sneak into the build 😠 Can you try --without-brotli? Just like we did with nghttp2.
Clarifying a small thing in Stan's answer (which is correct): when D1687 is committed (tonight probably, as trompetin is testing it as we speak), mod.io will work for everyone, regardless of who built the game.
@elexis Yeah, it's the clock_gettime thing...
@vladislavbelov In the staff discussions, it seemed that we had reached a consensus on creating this new room, but leaving the other version numbers intact (in order to push people into upgrading, without forcing them). On top of what elexis said, we are legally obliged to push the lobby users into using A23b, so that they can accept the new terms.
The consensus in that topic is the reason why I asked user1 to commit this, but if you want I can formally accept this revision.
Mon, Dec 3
The patch is currently useless, because xcodebuildsettings was added in premake5 alpha12 (we have alpha10): see https://github.com/premake/premake-core/wiki/xcodebuildsettings.
Sun, Dec 2
I agree, but I think you didn't test this? The option must be accessed with _OPTIONS (see the other use of it in the file for an example) and I suggest running the whole premake script with and without the parameter passed.
Yet another lib that might be detected by configure even though we don't have it and we don't need it. Disabling it explicitly is needed to link pyrogenesis.
Instead of abandoning this revision which was superseded by D1610, D1609 and D1685 (in order of committing), I take the liberty to commandeer it to include yet another manual disabling of a library we do not use.
This should use premake5.lua's macosx-version-min variable in order to avoid hardcoding. With D1685, this will actually be 10.9.
Mon, Nov 26
First of all, I can reproduce the crash on Fedora, and the current patch does fix it when the TLS box is unticked. So the C++ change is good 👍
Sun, Nov 25
Looks good to me! Please commit it if this allows Fedora users to work around the crash.
Sat, Nov 24
Thu, Nov 22
With this fix, the detection from gnutls' configure script will be overridden.
Wed, Nov 21
So the big flaw of rP19669 is that the Phabricator Jenkins plugin has this issue: https://github.com/uber/phabricator-jenkins-plugin/issues/224
Mon, Nov 19
Thank you for the patch! Unfortunately those checks are the same as what is checked by build/jenkins/lint-translations.sh. The thing that is missing from this is a check for broken custom tags (like [font] ones, typically).
Sat, Nov 17
Tue, Nov 13
Regarding the premake5 change, it looks good, you could remove the offending line from build/premake/premake5/premake5.lua for completeness. I hope to get a quick answer on issue 1154.
Nov 10 2018
Nov 9 2018
Yes, like Vlad says, we should change our own defaults in the premake scripts, but we mustn't touch premake source (it's easier to maintain when we match upstream).
Small changes to the macOS scripts.
- date update based on previous patch
- the --enable-64bit flag is needed for nspr when developing on recent versions (we are already building 64bit only)
- the --without-libpsl precision is needed to avoid issues when libpsl is installed and detected
@Stan If you don't mind, I'm commandeering this one to have all the small changes to macOS scripts in one diff! :slight_smile:
Apart from that, I cannot reproduce my mod.io bug, so this patch should be fine (tested on a clean repo).
@elexis: I have looked around about this issue, and I might have misunderstood a few remarks from you that were unclear to me, but I think I know what is bugging you. I also know why certain version numbers are 8, others 9, and why the reason for dropping 7 was unclear (thanks to some attempts by trompetin).
Nov 7 2018
Oct 31 2018
After a more careful testing, indeed this commit doesn't introduce the issue. It might come from D1654 after all. However,
Oct 24 2018
Wrong place? 😛 This is unrelated to mods, but if the bundle version cannot have letters, it should still be 23, not 24.
I was talking about the compilation of curl, not the request made to mod.io.
I really don't have a clue about the share of our users (both players and people who build the game) who use a given version of macOS. If Tobbi needs to drop 10.7 to build on his machine, I think we have to do that. If somebody has 10.7 and wants to play, we can help them build it themselves.
Oct 23 2018
It looks like this commit breaks mod.io on macOS (no https support anymore, whereas it worked on the previous revision), but I can't understand why.
This builds and works!
Oct 22 2018
I am progressing on this but not there yet. Hopefully tomorrow!
Oct 20 2018
The build fails on OSX: gnutls needs libnettle. 🙁
Oct 17 2018
Oct 15 2018
Sorry, I just googled what it is! Balancing test assessments are not called like this in GDPR itself, are they? I believe the missing piece is not a comma, but a "through" then.
Apart from the point 14 (actually 13) of WFG obligations, which I believe needs a rephrasing, I am on board with this document! Thanks for all the hard work.
Oct 12 2018
Yes this is good! As soon as it's committed, I'll run the translation bot.
Oct 5 2018
As I said, I was happy with the terms I made a pull request on, so I trust you to commit something that I'm happy with. It's up to you to ask a review from me if you want one 🙂 I'll let you know if I have remarks anyways.
About https://github.com/elexis1/0ad/pull/1, do you have any comments on my suggestions? I really liked this iteration, with generalized mention of the relevant GDPR articles, so I tried to make improvements where I saw fit, but the work was definitely good enough to replace the different Phabricator patches, if you want to finish the review here rather than on GitHub.
Sep 4 2018
Aug 31 2018
Hi @andy5995, thanks for the proposal!
Aug 10 2018
Posted some input on the Trac ticket, but I am not reviewing this code :)
Aug 9 2018
Aug 5 2018
ReferenceError: IID_CaptureManager is not defined
TypeError: cmpIdentity.CanUseSomeFormation is not a function
Jul 26 2018
Jul 23 2018
One more batch of comments :) Thanks again for the work on that.
Jun 4 2018
One extra thing that should be tested on that patch is whether a saved game with AIs can be re-loaded without issues.
May 27 2018
Damnit. I cannot look into fixing this in the immediate future. Based on the things this commit changes, there is a very small chance that the wrong simulation state is the one of the rejoining player, i.e. fixing/reverting this would not change the sim state, and people with the bug and people without would not go OOS. If that is the case re-releasing with the fix would be less of a problem.
May 12 2018
May 2 2018
May 1 2018
Not really accepted by elexis, and since you seem to be AFK I restarted packaging for a second RC.
What I mean is: if you really think this patch is half-baked and shouldn't be committed in a hurry, let's just not commit it and yell at the people who use outdated SVNs without a clue. I wouldn't disagree.
To be fair I'm not sure how someone managed to log in the lobby with an outdated SVN by mistake. Probably using the development PPA, but once again, who would install that by mistake? What are the odds...