Page MenuHomeWildfire Games

Itms (Nicolas Auvray)
User

User Details

User Since
Dec 19 2016, 10:38 PM (122 w, 3 d)

Recent Activity

Yesterday

Itms added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.
In D1754#76083, @elexis wrote:

(Also am I the only one using libboost 1.69.0-2 or am I just the only one too stupid to resolve the build errors? I better get them resolved if I want to commit my own patches)

Thu, Apr 25, 7:44 PM
Itms raised a concern with rP22225: Fix D1491 which introduced an ENSURE that should not have been there..

This is removing state.jpc = m_JumpPointCache[passClass].get(); when it != m_JumpPointCache.end(), no?

Thu, Apr 25, 9:15 AM

Wed, Apr 24

Itms added inline comments to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.
Wed, Apr 24, 10:49 PM
Itms added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.

This looks very good to me, and it works both on SM38 and SM45.

Wed, Apr 24, 10:32 PM

Tue, Apr 23

Itms accepted rP22207: Actually add the test file for rP22205..
Tue, Apr 23, 10:56 PM
Itms committed rP22216: Fix tests on Visual Studio 2013, which doesn't deduce types when using std::map….
Fix tests on Visual Studio 2013, which doesn't deduce types when using std::map…
Tue, Apr 23, 10:56 PM
Itms closed D1845: Fix VS2013 Build.
Tue, Apr 23, 10:56 PM
Itms changed the repository for D1845: Fix VS2013 Build from rDD 0 A.D. Design Document to rP 0 A.D. Public Repository.
Tue, Apr 23, 10:50 PM
Itms accepted D1845: Fix VS2013 Build.

I concur 🙂 I am committing this myself now, and lifting the concern I raised.

Tue, Apr 23, 10:49 PM
Itms added a comment to D1772: Fix TLS Segfault on various mac versions.
In D1772#75866, @elexis wrote:

Mostly I'm wondering what Itms had to say about this patch, as Stan, Itms and Tobbi had created the release candidate, but this patch was somehow not committed with the others.

Tue, Apr 23, 1:49 PM
Itms awarded D1845: Fix VS2013 Build a Like token.
Tue, Apr 23, 12:01 PM
Itms added inline comments to D1845: Fix VS2013 Build.
Tue, Apr 23, 12:01 PM
Itms added a comment to rP22207: Actually add the test file for rP22205..

I'm at work so I only have Linux, but if Stan doesn't get around to it I can test tonight.

Tue, Apr 23, 11:01 AM
Itms raised a concern with rP22207: Actually add the test file for rP22205..
Tue, Apr 23, 8:58 AM
Itms added a comment to D1784: Fixed assert fails in Actor Editor.

I think that if we keep supporting 2.8 we need to build patches with it, else we will commit a lot of 3.0+ changes without noticing. I believe the overwhelming majority of distributions used by our devs and contributors ships 3+.

Tue, Apr 23, 8:30 AM · Windows Developers
Itms added a comment to rP22207: Actually add the test file for rP22205..

It's indeed planned (but not effective yet so we should fix this or we won't have autobuild). The actual measure that I should take is to put into place patch testing on the Windows autobuilder. Will post a related message on the forums later today.

Tue, Apr 23, 8:22 AM

Mon, Apr 22

Itms added a comment to D1844: Improvements to simulation hotloading before the SM upgrade.

Thanks for the quick comments!

Mon, Apr 22, 11:37 PM
Itms added a comment to D1844: Improvements to simulation hotloading before the SM upgrade.

Some comments for helping the reviewers ❤

Mon, Apr 22, 10:34 PM
Itms created D1844: Improvements to simulation hotloading before the SM upgrade.
Mon, Apr 22, 10:25 PM
Itms added a comment to rP22204: Rename generic ballista template to boltshooter and onager to stonethrower to….
In rP22204#32955, @Stan wrote:

No problem, I believe Itms will add it to the automatic scripts.

Mon, Apr 22, 7:27 PM

Sat, Apr 20

Itms added a comment to D1760: Remove template_unit_mechanical.xml.

I think the patch doesn't apply because of the spaces in file names. Nescio is working on a fix for the latter (D1042), if you have some time to steal the review from me that would be a perfect "thank you" to Nescio for reviewing this one 😉

Sat, Apr 20, 11:37 AM

Thu, Apr 18

Itms added a member for Contributors: happyconcepts.
Thu, Apr 18, 11:35 AM
Itms committed rDDfd7e49d4e5a3: Corrected Mauryans* into Mauryas. (authored by Itms).
Corrected Mauryans* into Mauryas.
Thu, Apr 18, 11:10 AM

Tue, Apr 16

Itms added a comment to D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

This new method should be const. But apart from that this looks good to me.

Tue, Apr 16, 4:38 PM

Mon, Apr 15

Itms added a comment to D1772: Fix TLS Segfault on various mac versions.

I don't actually care enough to understand why this is required.

Mon, Apr 15, 2:05 PM

Sat, Apr 13

Itms added a comment to rP22184: Move more things in the projectile part of the Attack/Ranged component.
In rP22184#32826, @Itms wrote:

If the math isn't trivial, it should be done somewhere, so people don't have to rely on trusting you (especially in a few years when they stumble on the code).

Sat, Apr 13, 12:31 PM
Itms added a comment to rP22184: Move more things in the projectile part of the Attack/Ranged component.

As commented, left as an exercise to the reader. The math isn't trivial.

Sat, Apr 13, 12:26 PM
Itms added a comment to rP22184: Move more things in the projectile part of the Attack/Ranged component.

@Itms Any idea why this failed? Compiled fine and ran on my machine.

Sat, Apr 13, 12:24 PM
Itms added a comment to rDD090add709894: Port the Design Document to MkDocs, following GitBook's decision to stop….

Yes, both changes are coming in different patches, probably this weekend. This is a very early WIP, you can ignore it 🙂

Sat, Apr 13, 12:01 PM
Itms committed rDD090add709894: Port the Design Document to MkDocs, following GitBook's decision to stop… (authored by Itms).
Port the Design Document to MkDocs, following GitBook's decision to stop…
Sat, Apr 13, 11:48 AM
Itms accepted rP22182: Add ConquestCritical to structures that want it, instead of removing it from….

Fixed by Nescio in rP22183.

Sat, Apr 13, 11:28 AM
Itms committed rP22183: Fix issue in rP22182, detected by the checkrefs.pl script..
Fix issue in rP22182, detected by the checkrefs.pl script.
Sat, Apr 13, 11:22 AM
Itms closed D1824: merge spart_syssiton.xml classes.
Sat, Apr 13, 11:22 AM
Itms accepted D1824: merge spart_syssiton.xml classes.

Thanks for the quick fix! 👍

Sat, Apr 13, 11:17 AM
Itms requested changes to D1482: Target build version explicitly for Xcode.

Hi Lancelot 🙂 Let's not change the minimum version, we worked hard enough during the rerelease to make sure we could keep 10.9 as the minimum. Apart from that, if it works for you I can accept.

Sat, Apr 13, 11:16 AM
Itms raised a concern with rP22182: Add ConquestCritical to structures that want it, instead of removing it from….

While trying to add the nice improvements from rP22096 to Jenkins, I got this error:

Error parsing structures/spart_syssiton: Duplicate child node 'Classes' at Entity.pm line 45.
Sat, Apr 13, 12:50 AM

Wed, Apr 10

Itms added inline comments to D1763: Removes duplication of Clamp function.
Wed, Apr 10, 9:38 PM
Itms reopened D1584: Seed random sounds.
Wed, Apr 10, 9:21 PM
Itms added a reviewer for D1547: typography corrections in quotes: Gallaecio.

I am afraid using those correct typography symbols (which cannot be found easily on the majority of PC keyboards) is going to cause big issues for translators, and cause inconsistencies when developers keep using the usual ascii symbols. On the other hand, using correct typography would be nice, and we have indeed no technical limitations here.

Wed, Apr 10, 10:50 AM

Tue, Apr 9

Itms committed rP22174: Corrections in game loading quotes..
Corrections in game loading quotes.
Tue, Apr 9, 9:58 PM
Itms closed D1818: quotes corrections.
Tue, Apr 9, 9:58 PM
Itms accepted D1818: quotes corrections.

Looks good! 👍

Tue, Apr 9, 9:43 PM
Itms committed rDDffd470c0f7cc: Design Document edits for spelling (US English). Expanded an acronym on first… (authored by Itms).
Design Document edits for spelling (US English). Expanded an acronym on first…
Tue, Apr 9, 9:08 PM

Sun, Apr 7

Itms added a comment to D1810: Improvements to the translators credits script.

@bb Thanks for the remarks! Regarding the name disappearing or changing too stupidly:

  • If users want to use very strange nicknames on Transifex, we can't do a lot.... It's worth noting that in Transifex the username is used by default, but you can choose to supply a different name to appear in the po files ("Nicolas Auvray" instead of "Itms" typically). So some of the changes might be from people deleting this extra information.
  • If all translations of a user have been overwritten over time, they will disappear from the po file. If that is the case for all resources, we will loose trace of them. I agree that in theory we should keep them in the credits (for code or art, even if all changes from someone are superseded later, we thank them for contributing). However, we have no possibility to automatically detect if a name removal is a name change, or all translations from a user obsolete. So we would have, for instance, both Nicolas Auvray and Itms in the credits (stupid). There is also a privacy issue: if someone wants to remove their real name from the credits, they will do so on Transifex, but they won't be warned that we keep old names in the credits, and they won't know they should contact us.
Sun, Apr 7, 7:50 PM
Itms accepted D1482: Target build version explicitly for Xcode.

This looks good to me now. Can somebody test on XCode (I don't have it on my VMs) and commit if it works as expected?

Sun, Apr 7, 7:31 PM

Thu, Apr 4

Itms committed rP22157: Improve the error window on Windows by adding a link to https://trac..
Improve the error window on Windows by adding a link to https://trac.
Thu, Apr 4, 10:34 PM
Itms closed D1799: [Windows] Add information about data paths to error window.
Thu, Apr 4, 10:33 PM
Itms added a comment to D1799: [Windows] Add information about data paths to error window.

If you want go ahead! Else I can commit it in an hour or two

Thu, Apr 4, 8:33 PM

Wed, Apr 3

Itms accepted D1799: [Windows] Add information about data paths to error window.

Still good after testing! The text improvement is a good idea yeah 🙂

Wed, Apr 3, 10:53 PM
Itms added a comment to D1799: [Windows] Add information about data paths to error window.

The message looks good to me 👍 Maybe use https in the first URL for consistency, but that's a nitpick.

Wed, Apr 3, 9:18 PM
Itms added inline comments to D1682: Cleanup RallyPointRenderer.
Wed, Apr 3, 11:10 AM
Itms added inline comments to D1682: Cleanup RallyPointRenderer.
Wed, Apr 3, 9:29 AM

Tue, Apr 2

Itms added a comment to D1380: Build: precompiled logic update.

Oof this one is old. Many sorries for the awful queue 🙁

Tue, Apr 2, 11:57 PM
Itms removed reviewers for D1741: Fix some warning for vs2015 in Atlas: Itms, Restricted Owners Package.
In D1741#73409, @Stan wrote:

@Itms any concerns with this patch ?

Tue, Apr 2, 11:50 PM
Itms added a comment to D1810: Improvements to the translators credits script.

Some inline details.

Tue, Apr 2, 11:19 PM
Itms created D1810: Improvements to the translators credits script.
Tue, Apr 2, 11:12 PM

Mar 27 2019

Itms added inline comments to D1789: Handle unknown APIC IDs in the ACPI SRAT.
Mar 27 2019, 12:08 PM

Mar 17 2019

Itms updated the Trac tickets for D227: New concept for fields.
Mar 17 2019, 5:14 PM
Itms added a comment to D1509: Page Down / Page Up Rotates Entities in Editor Even Without Focus.

Oops I forgot to accept first. Seems like I can't now :(

Mar 17 2019, 5:05 PM
Itms committed rP22125: Rotate entities during placement in Atlas with the keyboard only when the….
Rotate entities during placement in Atlas with the keyboard only when the…
Mar 17 2019, 5:04 PM
Itms closed D1509: Page Down / Page Up Rotates Entities in Editor Even Without Focus.
Mar 17 2019, 5:04 PM
Itms requested changes to D1509: Page Down / Page Up Rotates Entities in Editor Even Without Focus.

The patch works for me! And I agree with the implementation. May I suggest that, instead of adding those two new booleans, you make the local dir variable in RotateTick an attribute of the class? You can rename it m_RotationDirection and modify it directly in OnKeyOverride. That would make the patch shorter and the code cleaner.

Mar 17 2019, 3:45 PM
Itms created D1789: Handle unknown APIC IDs in the ACPI SRAT.
Mar 17 2019, 11:28 AM

Mar 16 2019

Itms committed rP22117: Add particle support to the Actor Editor, fixes #1590..
Add particle support to the Actor Editor, fixes #1590.
Mar 16 2019, 10:16 PM
Itms closed D1783: Add particle support to actor editor.
Mar 16 2019, 10:16 PM · Windows Developers
Itms accepted D1783: Add particle support to actor editor.

Works for me, thanks for this patch!

Mar 16 2019, 10:10 PM · Windows Developers
Itms updated subscribers of D1217: Pause renderer option for unfocused window.

Related to D1495, so you might want to take a look @Angen.

Mar 16 2019, 1:50 PM

Mar 10 2019

Itms added a reviewer for D1764: Dynamically sizes the dataCounter overlay: Restricted Owners Package.
Mar 10 2019, 7:31 PM

Feb 25 2019

Itms added a comment to D1753: Script to auto update year for all modified files.

It's a nice script, but is it useful now that the linter detects those wrong license dates? What would be the use case?

Feb 25 2019, 10:14 AM

Feb 24 2019

Itms accepted D1381: Improve and fix checkrefs.pl.

Looks good to me, just fix the Frankenstein sentence in the readme before committing 🙂

Feb 24 2019, 9:25 PM
Itms requested changes to D1381: Improve and fix checkrefs.pl.

Some small improvements needed, sorry...

Feb 24 2019, 8:55 PM
Itms accepted D1364: Linting: allow constant condition in loops.

Finally tested it 😅 It works on the Jenkins slave, you can commit it!

Feb 24 2019, 6:18 PM
Itms removed a reviewer for D86: Cleanup of hwdetect.js and its test.: Itms.
Feb 24 2019, 5:34 PM
Itms resigned from D86: Cleanup of hwdetect.js and its test..

I'm letting Vlad handle this patch after the revamp of the feedback page 🙂 I'm still subscribed here.

Feb 24 2019, 5:34 PM
Itms added a comment to D1381: Improve and fix checkrefs.pl.

Just tested it and it still seems to work pretty well 🙂

Feb 24 2019, 5:31 PM

Feb 7 2019

Itms added a comment to D1042: rename maps/ file names to use underscores (instead of spaces and capitalization).
In D1042#71075, @Nescio wrote:

Still to be decided:
1 what to do with the scenarios/Height Map *.png files
2 what to do with the three Azure Coast scenarios (identical maps, different player numbers)
3 what to do with the two Flight_demo scenarios (different maps, similar function)
4 what to do with the two Sandbox - Ptolemies scenarios (different maps, similar function; all other factions have only one sandbox)
5 how to differentiate similary named skirmishes, e.g. Corinthian Isthmus (different maps, similar names)

How about the following?

  • 2, 3, 4: keep only one version, delete the others
  • 5: rename them to _small and _large
Feb 7 2019, 10:50 PM

Jan 15 2019

Itms added a comment to D1745: Allow loading Icons at runtime.

@elexis I sent you a forum PM, please let me know if you want to use a different place for discussion.

Jan 15 2019, 1:39 PM

Jan 13 2019

Itms added a comment to D1743: Fix UnitAI infinite loop following rP22023.

It would be nice to have something that detects such infinite loops and creates JS errors instead of engine crashes.

Jan 13 2019, 8:24 PM
Itms planned changes to D1510: Update to Spidermonkey 45.0.2.

I'm rebasing this one, and I'll try to include the binaries for Windows in the diff.

Jan 13 2019, 5:39 PM
Itms committed rP22052: SpiderMonkey-related changes in preparation for the upgrade to SpiderMonkey 45….
SpiderMonkey-related changes in preparation for the upgrade to SpiderMonkey 45…
Jan 13 2019, 5:37 PM
Itms closed D1716: SpiderMonkey changes in preparation for the SM45 upgrade.
Jan 13 2019, 5:37 PM
Itms added a comment to rP22023: Always leave/reenter the top-most FSM state when SetNextState is called with….

@Itms no logs no dump files, no errors. Just crash.

Jan 13 2019, 11:31 AM
Itms added a comment to rP22023: Always leave/reenter the top-most FSM state when SetNextState is called with….

That's wild! This commit should not be able to create a segfault, so it probably just reveals a bug in the engine. The commands file should be enough to find the bug and fix it.

Jan 13 2019, 11:26 AM

Jan 12 2019

Itms added a comment to D1741: Fix some warning for vs2015 in Atlas.

I think _p or m_p would be acceptable names since it's one letter.
This might conflict with D1395, which I should prioritize.
The other warnings shall be fixed by upgrading Boost and/or deleting old unneeded dlls.

Jan 12 2019, 1:56 PM
Itms accepted D1678: Fix Warnings of VS2015 .

Okay, you're right. Go ahead and thanks for the patch!

Jan 12 2019, 1:48 PM · Windows Developers
Itms requested changes to D1691: Remove boost "system" from Mac OS build system..

I think we do not need to include boost::system because we don't use anything from it, but we need to link it because boost::filesystem depends on it. I think only the build-osx change should be kept, as bootstrap is clever enough to build the boost::system lib while now excluding it from distributed includes.

Jan 12 2019, 10:17 AM
Itms added a comment to D1691: Remove boost "system" from Mac OS build system..

This doesn't work for me. Linking of pyrogenesis fails with undefined references to boost::system stuff. I will retry tomorrow with a clean checkout.

Jan 12 2019, 1:04 AM
Itms requested changes to D1678: Fix Warnings of VS2015 .

The patch looks good and it works for me too! However, I tested building Atlas and got the following warnings:

  • C4458 in AtlasObjectImpl.cpp line 292 and in AtlasUI/Object.cpp:547
  • C4456 in MapDialog.cpp:173 and in ScenarioEditor.cpp:742
Jan 12 2019, 12:37 AM · Windows Developers

Jan 6 2019

Itms requested review of D1716: SpiderMonkey changes in preparation for the SM45 upgrade.
Jan 6 2019, 10:27 PM
Itms added inline comments to D1716: SpiderMonkey changes in preparation for the SM45 upgrade.
Jan 6 2019, 10:27 PM
Itms updated the diff for D1716: SpiderMonkey changes in preparation for the SM45 upgrade.

Addressed comments above, and tested the JSPROP_PERMANENT thing.

Jan 6 2019, 10:26 PM
Itms requested changes to D1737: Slight cleanup of fogging OnDestroy and some comments.
Jan 6 2019, 9:05 PM
Itms added a comment to D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

Ah right, sorry. But I'd be interested in knowing how much of the cases are actually ent == INVALID_ENTITY. It doesn't sound like there are a lot of cases where an entity would be deleted several times?

Jan 6 2019, 6:50 PM
Itms added a comment to D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

I really think all the things that happen after this early return are inexpensive. In particular, when posting messages, if the entity is actually fully destroyed, no component subscribed to the message will be found, so there won't be a lot of overhead. If it's not actually fully destroyed, the patch is wrong (I do not think that's the case, but I might be wrong).

Jan 6 2019, 6:24 PM

Jan 5 2019

Itms added a comment to D14: Thread the pathfinder computations to reduce latency.
In D14#69171, @Kuba386 wrote:

Well, button said "resign as reviewer". I've only intended to cancel my old review that is not correct anymore.
I'm still working on this.

Jan 5 2019, 10:37 AM

Jan 4 2019

Itms accepted D1488: Always use SetNextStateAlwaysEntering when processing an order in UnitAI.

I think this is a good change and I share the opinion that removing the "always entering"/"not always entering" distinction would help tracking down some subtle bugs.

Jan 4 2019, 11:19 PM
Itms added a comment to rP22021: Upgrade premake5 from alpha12 to alpha13, refs #3729..

I could not send this commit on Phabricator for automated testing, so please report here if any bug related to that is found.

Jan 4 2019, 10:23 PM
Itms committed rP22021: Upgrade premake5 from alpha12 to alpha13, refs #3729..
Upgrade premake5 from alpha12 to alpha13, refs #3729.
Jan 4 2019, 10:20 PM
Itms added a comment to rP21941: Import part of commit https://github.com/premake/premake….

I do not know why I thought we were using alpha10 of premake5: we are using alpha 12. The fix above was included in alpha13, that is correct.

Jan 4 2019, 10:10 PM
Itms added a comment to D1381: Improve and fix checkrefs.pl.

This still works for me, with the same results. I didn't test a mod but the cli flag seems to work for the public mod as advertised.

Jan 4 2019, 10:04 PM