Page MenuHomeWildfire Games

Itms (Nicolas Auvray)
User

User Details

User Since
Dec 19 2016, 10:38 PM (186 w, 1 d)

Recent Activity

Yesterday

Itms added a comment to D2691: Fix NVTT warning when building on some linux platforms.

Sorry, yes you can abandon this one, I'll include it as planned when I'm looking at NVTT again.

Tue, Jul 14, 2:51 PM
Itms updated subscribers of D665: Make ship pickup nicer.

I'm planning to commit this sometimes in July. Testing & reviewing obviously appreciated until then.

Tue, Jul 14, 10:40 AM
Itms added a reviewer for D2785: Switch range manager from unsigned integers to a proper data structure: Itms.
Tue, Jul 14, 10:12 AM
Itms accepted rP23774: Move LOS to a los helper header and cleanup Grid.h includes..
Tue, Jul 14, 10:10 AM

Sun, Jul 12

Itms awarded rP23821: Stop failing if mod is broken and display invalid mods in downloader [Mod Io] a Love token.
Sun, Jul 12, 12:11 PM

Sat, Jul 11

Itms committed rP23815: Fix rooting mistake in CGame::ReallyStartGame, detected by Bellaz89, fixes….
Fix rooting mistake in CGame::ReallyStartGame, detected by Bellaz89, fixes…
Sat, Jul 11, 4:24 PM
Itms closed D2869: Fix rooting mistake in CGame::ReallyStartGame.
Sat, Jul 11, 4:24 PM
Itms committed rP23814: Rebuild zlib 1.2.11 and upgrade libpng to 1.6.37, on Windows, with toolset….
Rebuild zlib 1.2.11 and upgrade libpng to 1.6.37, on Windows, with toolset…
Sat, Jul 11, 4:18 PM
Bellaz89 awarded D2869: Fix rooting mistake in CGame::ReallyStartGame a Like token.
Sat, Jul 11, 4:14 PM

Fri, Jul 10

Angen awarded D2869: Fix rooting mistake in CGame::ReallyStartGame a Love token.
Fri, Jul 10, 1:24 PM

Thu, Jul 9

Itms created D2869: Fix rooting mistake in CGame::ReallyStartGame.
Thu, Jul 9, 7:55 PM

Wed, Jul 8

Itms added a comment to D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

This looks really nice at first sight. I'm keeping forward on the SM upgrade work and I'll let you know if I prefer get this in before or after a specific version.

Wed, Jul 8, 3:55 PM

Mon, Jul 6

Itms requested review of D2765: Add a safeguard for users trying to use an old system NVTT.

As reported on Trac, the patch works for me, I have no news of GunChleoc. If someone with an Ubuntu, or derived, could test this... I am also interested in users of various distributions where the system nvtt creates the issue.

Mon, Jul 6, 10:31 AM

Sun, Jul 5

Itms added a comment to D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

I am slowly wrapping my head around this patch, but I find it very complicated. I wrote down a few comments but this is just a first pass. In general I find that the code comments you wrote add more confusion.

Sun, Jul 5, 11:15 AM
Itms accepted D2114: Do not fail if some mod is broken [Mod Io].

Looks good to me! I will look into fixing the issues you pointed out in your audit of the original commit.

Sun, Jul 5, 10:39 AM

Sat, Jul 4

Itms requested changes to D2114: Do not fail if some mod is broken [Mod Io].

Really like the patch and the new UX with broken mods, it's a big improvement 👍🏻

Sat, Jul 4, 7:09 PM

Wed, Jul 1

Itms added a comment to D2782: [Gameplay] make ram less effective.

Even as admin, I am blocked by the policy @borg- set! borg, you have to click "Edit Revision" at the top right of the diff description, then change "Editable By" to become "All Users".

Wed, Jul 1, 4:49 PM · Restricted Project, Contributors

Tue, Jun 30

Itms committed rP23795: Fix conversion of UTF8 strings between the scripts and the engine..
Fix conversion of UTF8 strings between the scripts and the engine.
Tue, Jun 30, 12:46 PM
Itms closed D2838: Fix string conversion to/from Spidermonkey.
Tue, Jun 30, 12:46 PM
Itms updated subscribers of rP23794: Fix building on GCC 10, fixes #5709, #5756..

Perhaps you could also fix the line endings in all of the libraries/source/fcollada/** files?

Tue, Jun 30, 12:38 PM
Itms committed rP23794: Fix building on GCC 10, fixes #5709, #5756..
Fix building on GCC 10, fixes #5709, #5756.
Tue, Jun 30, 12:25 PM
Itms closed D2745: #5709 fcollada build fix for gcc 10 (WritePhysicsRigidBodyInstance) by @pcpa..
Tue, Jun 30, 12:25 PM
Itms accepted D2838: Fix string conversion to/from Spidermonkey.

I'll fix those myself and commit, as proposed by wraitii on IRC.

Tue, Jun 30, 12:16 PM
Itms requested changes to D2838: Fix string conversion to/from Spidermonkey.

OK, everything good for me 👍🏻

Tue, Jun 30, 12:13 PM

Sat, Jun 27

Itms added a comment to D2838: Fix string conversion to/from Spidermonkey.

This looks good, I will test it later! 👍🏻

Sat, Jun 27, 12:49 PM
Itms requested changes to D2838: Fix string conversion to/from Spidermonkey.

This looks good to me apart from the roundtrip change. Additionally I am fine with believing that SM uses UTF16 internally but what is the source of this affirmation? Is it still true with recent versions of SM?

Sat, Jun 27, 12:04 PM

Fri, Jun 26

Itms added inline comments to D2114: Do not fail if some mod is broken [Mod Io].
Fri, Jun 26, 12:34 PM

Wed, Jun 24

Itms added a comment to D2832: Remove inappropriate quote about women.

This quote is both sexist by modern standards, and not about combat (even loosely). That is all. If there are other quotes with those two issues, we could definitely add them to the diff.

Wed, Jun 24, 9:37 PM
Itms added a comment to D2832: Remove inappropriate quote about women.

I think what was meant by Not a vital quote is that we are developing a strategy game of combat and thus quotes that are not related to war are not useful.

Wed, Jun 24, 9:55 AM

Tue, Jun 23

Itms edited reviewers for D2691: Fix NVTT warning when building on some linux platforms, added: Itms; removed: Restricted Owners Package.

I'm going to include it in D2563!

Tue, Jun 23, 6:31 PM
Itms committed rP23787: Detect the need for libexecinfo in premake. This is mostly useful for musl….
Detect the need for libexecinfo in premake. This is mostly useful for musl…
Tue, Jun 23, 5:07 PM
Itms closed D2671: Build: include libexecinfo on musl system.
Tue, Jun 23, 5:07 PM
Itms added a comment to D2671: Build: include libexecinfo on musl system.

(Upon committing, I am only adding -o /dev/null to the cc call, in order not to generate an unneeded a.out file)

Tue, Jun 23, 5:00 PM
Itms committed rP23786: Stop downloading boost from sourceforge on macOS, as it is not the official….
Stop downloading boost from sourceforge on macOS, as it is not the official…
Tue, Jun 23, 4:44 PM
Itms closed D2766: Stop downloading boost from sourceforge.
Tue, Jun 23, 4:44 PM
Itms accepted D2745: #5709 fcollada build fix for gcc 10 (WritePhysicsRigidBodyInstance) by @pcpa..

This works well on GCC 10 and clang 10.

Tue, Jun 23, 4:34 PM
Itms accepted D2671: Build: include libexecinfo on musl system.

Hi nephele, sorry for the delay in reacting. I was away finishing writing my PhD thesis. I am going to commit this fix. Thanks a lot for your work! 👍🏻

Tue, Jun 23, 4:05 PM
Itms added a reviewer for D2817: Slight AddObjectType cleanup: Itms.

I am not sure I like this change... 😕 I feel like grouping the association between XML names and C++ classes in a single place is neater.

Tue, Jun 23, 3:22 PM
Itms added a reviewer for D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition.: Itms.
Tue, Jun 23, 10:56 AM
Itms added a comment to D2745: #5709 fcollada build fix for gcc 10 (WritePhysicsRigidBodyInstance) by @pcpa..

This looks fine, I can test it.

Tue, Jun 23, 10:13 AM

Mon, Jun 22

Itms raised a concern with rP23774: Move LOS to a los helper header and cleanup Grid.h includes..

The two new files should have the svn:eol-style property set to native like all other source files 🙏🏻

Mon, Jun 22, 8:16 PM

May 27 2020

Itms planned changes to D2765: Add a safeguard for users trying to use an old system NVTT.

GunChleoc reports it doesn't correctly detect an old NVTT version.

May 27 2020, 8:37 AM

May 24 2020

Itms added a comment to D2766: Stop downloading boost from sourceforge.
In D2766#116849, @Stan wrote:

I mean that the proposed link has more chances to go down than GitHub :) https://github.com/boostorg/boost/releases but after a second look it seems they only provide the source there, not a preconfigured version so nvm I guess.

May 24 2020, 7:21 PM
Itms added a comment to D2766: Stop downloading boost from sourceforge.
In D2766#116846, @Stan wrote:

Isn't it safer to use the github mirror?

May 24 2020, 7:12 PM
Itms created D2766: Stop downloading boost from sourceforge.
May 24 2020, 7:05 PM
Itms created D2765: Add a safeguard for users trying to use an old system NVTT.
May 24 2020, 6:51 PM

May 22 2020

Itms added a comment to D2757: i18n scripts - switch from pology to Babel for .POT generation and update to python3.

Haven't done the long-translation thing yet because I don't really understand what it is supposed to be doing.

May 22 2020, 3:48 PM
Itms added reviewers for D2757: i18n scripts - switch from pology to Babel for .POT generation and update to python3: Itms, Gallaecio.

This sounds like a good idea 👍

May 22 2020, 1:30 PM

May 21 2020

Itms updated the diff for D2563: NVTT build fixes.

Update after rP23686, so that the mac slave builds the new version.

May 21 2020, 7:13 PM
Itms committed rP23686: Check the library version instead of the mtime of the already-built guard file….
Check the library version instead of the mtime of the already-built guard file…
May 21 2020, 5:29 PM
Itms closed D2649: build-osx-libs: Compare lib version instead of dir mtime.
May 21 2020, 5:29 PM · macOS Developers
Itms accepted D2649: build-osx-libs: Compare lib version instead of dir mtime.

I am going to commit this, but with a suffix for spidermonkey, as well as using numbers (instead of tentative dates) for the suffixes.

May 21 2020, 5:06 PM · macOS Developers

May 19 2020

Itms updated the diff for D2563: NVTT build fixes.

Make the preprocessor change minimal.

May 19 2020, 10:37 AM

May 17 2020

Itms added a comment to D2649: build-osx-libs: Compare lib version instead of dir mtime.

Thanks! I'll try to commit this during the week, we have some bank holidays...

May 17 2020, 10:33 PM · macOS Developers
Itms added a comment to D2649: build-osx-libs: Compare lib version instead of dir mtime.

And one final idea: maybe the nvtt version should have a wildfiregames suffix so that it gets rebuilt when we add some patches, like I will do in D2563.

May 17 2020, 4:27 PM · macOS Developers
Itms committed rP23676: macOS build fixes and Jenkins pipelines..
macOS build fixes and Jenkins pipelines.
May 17 2020, 4:13 PM
Itms closed D2523: Jenkins scripts and tweaks for OSX.
May 17 2020, 4:12 PM · macOS Developers
Itms updated the diff for D2563: NVTT build fixes.

Include suggested changes

May 17 2020, 2:16 PM
Itms committed rP23675: Allow using system premake5 (with the flag --with-system-premake5) when running….
Allow using system premake5 (with the flag --with-system-premake5) when running…
May 17 2020, 1:44 PM
Itms closed D2519: Add --with-system-premake5 option to update-workspaces.sh.
May 17 2020, 1:43 PM
Itms added a comment to D2649: build-osx-libs: Compare lib version instead of dir mtime.

Additionally I had this idea: P203

May 17 2020, 12:30 PM · macOS Developers
Itms added a comment to D2649: build-osx-libs: Compare lib version instead of dir mtime.

Hi Krinkle, very nice patch! It will help the CI considerably.

May 17 2020, 11:44 AM · macOS Developers

May 9 2020

Itms accepted D2717: build-osx-libs: Unbreak ICU 59 build (upstream URL changed).
May 9 2020, 12:06 PM

Apr 1 2020

Itms committed rP23562: Update cppformat from v0.11.0 to v1.1.0, fixes #5646, refs #3190..
Update cppformat from v0.11.0 to v1.1.0, fixes #5646, refs #3190.
Apr 1 2020, 9:32 AM
Itms closed D2613: Updated cppformat.
Apr 1 2020, 9:32 AM

Mar 31 2020

Itms accepted D2613: Updated cppformat.

I will commit this today. Thanks adrian for the patch and s0600204 for the help!

Mar 31 2020, 10:24 AM

Mar 28 2020

Itms added a comment to D2671: Build: include libexecinfo on musl system.

Else at the very least I'd prefer to test the need for execinfo once at the beginning, so that we don't have calls to the compiler in the middle of our (already complex) prebuild logic.

Why would it matter?

Mar 28 2020, 7:42 PM
Itms added a comment to D2671: Build: include libexecinfo on musl system.

I see. In that case I suppose this is OK (I find it rather ugly but that's personal taste).

Mar 28 2020, 7:34 PM
Itms requested changes to D2671: Build: include libexecinfo on musl system.

Hi! Thanks for your contribution.

Mar 28 2020, 7:09 PM
Itms requested changes to D2613: Updated cppformat.

Thanks for the rebase @s0600204! Jenkins is indeed broken when source files are deleted (or moved) but there is still a build error on a clean build due to the test file.

Mar 28 2020, 6:52 PM

Mar 9 2020

Itms added a comment to D2650: let "0ad.app" appear as "0 A.D." in Finder.

I see! Thanks for the info. I'll include your changes in the other patch then 👍

Mar 9 2020, 8:37 PM · macOS Developers
Itms abandoned D2650: let "0ad.app" appear as "0 A.D." in Finder.

Hello, thanks for the contribution! This should be already fixed by D2523, which is not yet committed. Could you take a look and check that it works? Else I'll update that other diff.

Mar 9 2020, 7:18 PM · macOS Developers

Mar 5 2020

Itms added a comment to D2613: Updated cppformat.

Thank you! 👍

Mar 5 2020, 10:13 AM

Mar 1 2020

Itms added a comment to D2563: NVTT build fixes.
In D2563#111168, @Stan wrote:
Mar 1 2020, 7:30 PM

Feb 17 2020

Itms requested changes to D2613: Updated cppformat.

Hi! Things look good to me 👍

Feb 17 2020, 8:05 PM

Feb 16 2020

Itms changed the edit policy for D2630: Major improvements to the lobby bots XpartaMuPP and EcheLOn. .
Feb 16 2020, 11:52 AM
Itms added a comment to D2630: Major improvements to the lobby bots XpartaMuPP and EcheLOn. .

Do you plan to run the tests manually, or would you be interested in having Jenkins run the tests when a patch touches source/tools/lobbybots?

Feb 16 2020, 10:40 AM
Itms awarded D2630: Major improvements to the lobby bots XpartaMuPP and EcheLOn. a Love token.
Feb 16 2020, 10:37 AM

Feb 12 2020

Itms added a comment to D2613: Updated cppformat.

I will test this and hopefully commit it during the upcoming weekend. I am a bit short on free time these days, so unfortunately when things are related to libraries some of the steps include waiting for me. Don't hesitate to contribute to other areas of the code in the meantime. Or if you want you can start working on the future cppformat upgrade steps since they seem to involve a lot of work.

Feb 12 2020, 9:29 PM

Feb 10 2020

Itms added a comment to D2613: Updated cppformat.

(you also needed to specify the repository in order to trigger a build, I fixed that)

Feb 10 2020, 7:05 PM
Itms set the repository for D2613: Updated cppformat to rP 0 A.D. Public Repository.
Feb 10 2020, 7:04 PM

Feb 9 2020

Itms added a comment to D2613: Updated cppformat.

I propose to merge this changes into codebase (I can restore old cppformat name) and create another ticket to update fmt to version 6.x. Unfortunately I'm not sure how much time I will have in the future, so I think better option is to not "lock" this issue further.

I agree, and actually I think it's very nice to use this small upgrade to rename the lib, so you can leave it like this.

Feb 9 2020, 10:24 PM

Feb 4 2020

Itms updated the diff for D2563: NVTT build fixes.

Fix for GCC.

Feb 4 2020, 10:03 PM
Krinkle awarded D2563: NVTT build fixes a Orange Medal token.
Feb 4 2020, 9:23 PM

Feb 3 2020

Itms added a comment to D2613: Updated cppformat.

Thank you for the patch! We've been meaning to update cppformat (now fmtlib) for some time now. I had a half-finished patch for going to 2.1.1 (which was the last update before the renaming) in #3190, then was planning to update to the newest version in #4148.

Feb 3 2020, 2:25 PM

Feb 1 2020

Itms added inline comments to D2563: NVTT build fixes.
Feb 1 2020, 4:49 PM
Itms added a comment to D2420: Fix OS hardware detection on windows..

Just a note since I see the patch only now:

Feb 1 2020, 4:25 PM

Jan 13 2020

Itms added a comment to D2563: NVTT build fixes.

Can you attach the dds generated by nvtt that it doesn't manage to load? Thanks :)

Jan 13 2020, 11:38 PM
Itms added a comment to D2566: Fixes debug build on macOS.

Hey! This is already in D2523.

Jan 13 2020, 7:35 PM
Itms closed D2524: Drop Visual Studio 2013 support.

No problem, thank you!

Jan 13 2020, 8:49 AM
Itms committed rP23385: Credit Inari in the credits instead of the commit message of rP23383..
Credit Inari in the credits instead of the commit message of rP23383.
Jan 13 2020, 8:48 AM
Itms added a comment to D2563: NVTT build fixes.
In D2563#107181, @Stan wrote:

This fixes NVTT build however I still get for some images:

Jan 13 2020, 8:44 AM
Itms planned changes to D2523: Jenkins scripts and tweaks for OSX.
Jan 13 2020, 8:35 AM · macOS Developers

Jan 12 2020

Itms updated the diff for D2519: Add --with-system-premake5 option to update-workspaces.sh.

Remove the macOS change that is out of place and is likely to create issues.

Jan 12 2020, 9:30 PM
Itms committed rP23383: Set source and executable character sets to UTF-8 on Windows, removes a….
Set source and executable character sets to UTF-8 on Windows, removes a…
Jan 12 2020, 9:20 PM
Itms closed D1411: Add commandline flag to set source and execution charsets to utf-8.
Jan 12 2020, 9:20 PM
Itms added a comment to D2524: Drop Visual Studio 2013 support.

@Angen I forgot to close the diff in rP23382 😫

Jan 12 2020, 9:09 PM
Itms committed rP23382: Officially drop support for Visual Studio 2013, which stopped working after….
Officially drop support for Visual Studio 2013, which stopped working after…
Jan 12 2020, 9:04 PM
Itms committed rP23381: Commit concrt140.dll, dependency of the new NVTT dll. Fixes #5527, refs #4549….
Commit concrt140.dll, dependency of the new NVTT dll. Fixes #5527, refs #4549…
Jan 12 2020, 7:19 PM
Itms added a comment to D2563: NVTT build fixes.

and check that the new va_list initializer works on other compilers

Jan 12 2020, 6:19 PM