Page MenuHomeWildfire Games

Itms (Nicolas Auvray)
User

User Details

User Since
Dec 19 2016, 10:38 PM (161 w, 1 d)

Recent Activity

Mon, Jan 13

Itms added a comment to D2563: NVTT build fixes.

Can you attach the dds generated by nvtt that it doesn't manage to load? Thanks :)

Mon, Jan 13, 11:38 PM
Itms added a comment to D2566: Fixes debug build on macOS.

Hey! This is already in D2523.

Mon, Jan 13, 7:35 PM
Itms closed D2524: Drop Visual Studio 2013 support.

No problem, thank you!

Mon, Jan 13, 8:49 AM
Itms committed rP23385: Credit Inari in the credits instead of the commit message of rP23383..
Credit Inari in the credits instead of the commit message of rP23383.
Mon, Jan 13, 8:48 AM
Itms added a comment to D2563: NVTT build fixes.
In D2563#107181, @Stan wrote:

This fixes NVTT build however I still get for some images:

Mon, Jan 13, 8:44 AM
Itms planned changes to D2523: Jenkins scripts and tweaks for OSX.
Mon, Jan 13, 8:35 AM · macOS Developers

Sun, Jan 12

Itms updated the diff for D2519: Add --with-system-premake5 option to update-workspaces.sh.

Remove the macOS change that is out of place and is likely to create issues.

Sun, Jan 12, 9:30 PM
Itms committed rP23383: Set source and executable character sets to UTF-8 on Windows, removes a….
Set source and executable character sets to UTF-8 on Windows, removes a…
Sun, Jan 12, 9:20 PM
Itms closed D1411: Add commandline flag to set source and execution charsets to utf-8.
Sun, Jan 12, 9:20 PM
Itms added a comment to D2524: Drop Visual Studio 2013 support.

@Angen I forgot to close the diff in rP23382 😫

Sun, Jan 12, 9:09 PM
Itms committed rP23382: Officially drop support for Visual Studio 2013, which stopped working after….
Officially drop support for Visual Studio 2013, which stopped working after…
Sun, Jan 12, 9:04 PM
Itms committed rP23381: Commit concrt140.dll, dependency of the new NVTT dll. Fixes #5527, refs #4549….
Commit concrt140.dll, dependency of the new NVTT dll. Fixes #5527, refs #4549…
Sun, Jan 12, 7:19 PM
Itms added a comment to D2563: NVTT build fixes.

and check that the new va_list initializer works on other compilers

Sun, Jan 12, 6:19 PM
Itms created D2563: NVTT build fixes.
Sun, Jan 12, 6:15 PM
Itms committed rP23380: Fix utf-8 in the NVTT source code. This is mostly to please arcanist..
Fix utf-8 in the NVTT source code. This is mostly to please arcanist.
Sun, Jan 12, 6:02 PM
Itms added a comment to D2548: Do not face point after movement for formation walk.
In D2548#107040, @Stan wrote:

@Itms can you close it?

Sun, Jan 12, 11:14 AM

Fri, Jan 10

Itms added a comment to D2557: Significantly improves Atlas terrain elevation performance.

(A commit reference would be useful to ease commit traversal while reviewing, auditing or revisioning)

It was rP16824. And that is funny: looking at the commit, I had written a TODO, so I knew! I then removed the TODO in rP16827, just three revisions later, when I thought the improvements I made were enough.

Fri, Jan 10, 11:17 PM
Itms accepted D2557: Significantly improves Atlas terrain elevation performance.

Excluding the in-game terrain updates, which are not actually implemented, everything works fine for me and the code looks good.

Fri, Jan 10, 8:15 PM
Itms added inline comments to D2557: Significantly improves Atlas terrain elevation performance.
Fri, Jan 10, 4:41 PM
Itms added inline comments to D2557: Significantly improves Atlas terrain elevation performance.
Fri, Jan 10, 4:35 PM
Itms added a comment to D2557: Significantly improves Atlas terrain elevation performance.

I think it's not enough, because it has only water level changes. That means the whole grid will be updated (no partial update).

Fri, Jan 10, 1:15 PM
Itms edited reviewers for D2557: Significantly improves Atlas terrain elevation performance, added: Itms; removed: Restricted Owners Package.

Hey, this looks great! I didn't realize the message had that terrain information when I wrote the code!

Fri, Jan 10, 11:09 AM

Tue, Jan 7

Itms added a comment to rP23305: Upgrade NVTT to version 2.1.1, fixes #4549..

Also, I was expecting the script to track the version of lib it built instead of boolean. Seems simple to implement, will consider that later.

Ideally we would do the same as for SpiderMonkey (see libraries/source/spidermonkey/build.sh):

if [ -e .already-built -a .already-built -nt README.txt ]

so that changes to the README trigger a rebuild. However, this is bypassed (including for SM) by build-osx-libs.sh. There is a big discrepancy between macOS and other unixes with respect to the process followed to build bundled libs.

Tue, Jan 7, 12:28 PM
Itms updated subscribers of D2523: Jenkins scripts and tweaks for OSX.
Tue, Jan 7, 12:14 PM · macOS Developers
Itms added inline comments to D2524: Drop Visual Studio 2013 support.
Tue, Jan 7, 12:11 PM

Mon, Jan 6

Itms added a comment to rP23305: Upgrade NVTT to version 2.1.1, fixes #4549..

@Krinkle

rm -f libraries/source/nvtt/.already-built

in order to actually build the new nvtt version with build-osx-libs.sh.

Mon, Jan 6, 8:24 AM

Fri, Jan 3

Itms added inline comments to D2523: Jenkins scripts and tweaks for OSX.
Fri, Jan 3, 6:28 PM · macOS Developers

Tue, Dec 31

Itms added a comment to D2491: Fix musl build.
In D2491#104180, @Itms wrote:

There is already this PR by a friend

While I appreciate the work on the software, calling leper your friend is a punch in the face and I will not go down in history as someone who read it and left it uncommented.

Tue, Dec 31, 4:45 PM
Itms accepted D1380: Build: precompiled logic update.

Also builds and runs --without-pch on Linux (gcc 7). 👍

Tue, Dec 31, 1:37 PM

Mon, Dec 30

Itms accepted D1396: Remove not needed checks and code for VS2015 [VS2013 -> VS2015].

This is good for me! I think you can commit this just after I commit D2524.

Mon, Dec 30, 6:35 PM
Itms updated the diff for D1411: Add commandline flag to set source and execution charsets to utf-8.

Tests fixed.

Mon, Dec 30, 6:26 PM
Itms commandeered D1411: Add commandline flag to set source and execution charsets to utf-8.

Thanks again for the patch Inari. I am commandeering it to fix the tests as well. I will commit this just after D2524.

Mon, Dec 30, 6:24 PM
Itms created D2524: Drop Visual Studio 2013 support.
Mon, Dec 30, 6:19 PM
Itms added a comment to D1380: Build: precompiled logic update.

Right now our precompiled headers also act as global include files, when they probably shouldn't.

Mon, Dec 30, 5:58 PM
Itms accepted D1380: Build: precompiled logic update.

Thanks for the patch and I owe you a beer or something for the delay 😅 The changes look perfect. Let's get them in before the copyright year becomes wrong...

Mon, Dec 30, 5:56 PM
Itms accepted rP23215: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original….

Thanks!

Mon, Dec 30, 12:17 PM
Itms added inline comments to D2522: Fix logic issue with the DXT1a texture format.
Mon, Dec 30, 11:37 AM
Itms updated the diff for D2522: Fix logic issue with the DXT1a texture format.

This is mainly to test the new macOS patch building. Sorry in advance for the noise...

Mon, Dec 30, 11:35 AM
Itms created D2523: Jenkins scripts and tweaks for OSX.
Mon, Dec 30, 11:08 AM · macOS Developers
Itms raised a concern with rP23215: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original….

Could you set svn:ignore to *.cpp on source/third_party/ogre3d_preprocessor/tests (like we do in other tests folders)? That would be great for upcoming svn sts 😉

Mon, Dec 30, 10:32 AM
Itms added inline comments to D2522: Fix logic issue with the DXT1a texture format.
Mon, Dec 30, 10:09 AM
Itms removed a reviewer for D2522: Fix logic issue with the DXT1a texture format: Vulcan.
Mon, Dec 30, 12:25 AM

Sun, Dec 29

Itms added a comment to D2522: Fix logic issue with the DXT1a texture format.
In D2522#105360, @Stan wrote:

Maybe we could have such a file and a test?

Sun, Dec 29, 8:39 PM
Stan awarded D2522: Fix logic issue with the DXT1a texture format a Love token.
Sun, Dec 29, 8:34 PM
Itms added a reviewer for D2522: Fix logic issue with the DXT1a texture format: vladislavbelov.
Sun, Dec 29, 8:33 PM
Itms created D2522: Fix logic issue with the DXT1a texture format.
Sun, Dec 29, 8:31 PM
Itms requested verification of rP22348: Delete old redistributables for VS 2010, and add new ones for VS 2015. Refs….

Should be good after rP23305.

Sun, Dec 29, 12:27 PM
Itms closed D2475: Update NVTT to 2.1.1.
Sun, Dec 29, 12:22 PM
Itms committed rP23305: Upgrade NVTT to version 2.1.1, fixes #4549..
Upgrade NVTT to version 2.1.1, fixes #4549.
Sun, Dec 29, 12:22 PM
Itms abandoned D2491: Fix musl build.
Sun, Dec 29, 11:59 AM

Sat, Dec 28

Itms committed rP23302: Update libsodium to 1.0.18, built on Windows with toolset v140_xp..
Update libsodium to 1.0.18, built on Windows with toolset v140_xp.
Sat, Dec 28, 7:13 PM
Itms added a comment to D2491: Fix musl build.

Thanks for your patch, I have included the first part (with the other one you needed) in our upgraded NVTT.

Sat, Dec 28, 6:54 PM
Itms created D2519: Add --with-system-premake5 option to update-workspaces.sh.
Sat, Dec 28, 5:48 PM

Tue, Dec 24

Itms added a comment to D2427: Alphabetize credits.

Hm I just checked on Trac and I was probably confused. The Phab revisions are all from the lobby moderator and references on Trac all point to him as well. I was thinking we had a H_Baraq contributor way back then, in the 2013s or something, but I'm wrong.

Tue, Dec 24, 10:29 AM
Itms added a comment to D2427: Alphabetize credits.

Thanks for the work!

Tue, Dec 24, 10:01 AM

Dec 22 2019

Itms added a comment to D2501: Port scripts to python 3 before doomsday.

See also D506?

Dec 22 2019, 10:26 PM
Stan awarded D2501: Port scripts to python 3 before doomsday a Like token.
Dec 22 2019, 8:26 PM
Itms created D2501: Port scripts to python 3 before doomsday.
Dec 22 2019, 8:19 PM

Dec 20 2019

Itms added a comment to D2491: Fix musl build.

@voroskoi Maybe you should send a pull request upstream. There is already this PR by a friend but it looks like the NVTT maintainer doesn't want it, maybe they'd rather like your solution.

Dec 20 2019, 4:52 PM
Itms added a comment to D2491: Fix musl build.

Like Vlad said, I have just uploaded a NVTT upgrade, so it would be better if you'd test the branch (and I would happily include your patch in my upgrade if it's still needed).

Dec 20 2019, 4:46 PM

Dec 16 2019

Itms added a comment to D2475: Update NVTT to 2.1.1.

I'm uploading it here for Jenkins, though arcanist may have botched the job, we'll see.

Welp, it definitely did...

Dec 16 2019, 11:43 PM
Itms added a comment to rP22348: Delete old redistributables for VS 2010, and add new ones for VS 2015. Refs….

nvtt will be rebuilt in D2475. nspr was rebuilt with the SM45 upgrade. I used the tool https://github.com/lucasg/Dependencies to ensure that all the other DLLs do not depend on the 2010 runtime.

Dec 16 2019, 11:39 PM
Itms created D2475: Update NVTT to 2.1.1.
Dec 16 2019, 11:33 PM
Itms committed rP23250: Update the Jenkins scripts to match the current state, which uses Jenkins….
Update the Jenkins scripts to match the current state, which uses Jenkins…
Dec 16 2019, 10:53 PM
Itms closed D1910: Version the GCC Jenkins scripts.
Dec 16 2019, 10:52 PM
Itms committed rP23249: Put the Windows patch testing Jenkins pipeline, written by Angen, under source….
Put the Windows patch testing Jenkins pipeline, written by Angen, under source…
Dec 16 2019, 10:35 PM
Itms closed D1946: Windows Differential testing.
Dec 16 2019, 10:35 PM
Itms accepted D1946: Windows Differential testing.

I'm committing this with a license header and some whitespace fixes. Thanks for all the work!

Dec 16 2019, 10:34 PM

Dec 7 2019

Itms added inline comments to D1910: Version the GCC Jenkins scripts.
Dec 7 2019, 7:02 PM
Itms updated the diff for D1910: Version the GCC Jenkins scripts.

Updated version using Docker (in place since months now).

Dec 7 2019, 5:35 PM
Itms committed rP23214: Patch SpiderMonkey 45 against bug https://bugzilla.mozilla.org/show_bug.cgi?.
Patch SpiderMonkey 45 against bug https://bugzilla.mozilla.org/show_bug.cgi?
Dec 7 2019, 10:05 AM
Itms closed D2244: Patch SM45 against bug 1266366.
Dec 7 2019, 10:05 AM
Itms added a comment to D2021: Fix AtlasUI.dll windows autobuild.

Ach, I forgot to accept first, too late now. I applied this to Jenkins, everything works 👍

Dec 7 2019, 9:56 AM
Itms committed rP23213: Fix the Atlas build in the Windows autobuilder pipeline, refs #5574..
Fix the Atlas build in the Windows autobuilder pipeline, refs #5574.
Dec 7 2019, 9:54 AM
Itms closed D2021: Fix AtlasUI.dll windows autobuild.
Dec 7 2019, 9:54 AM

Dec 1 2019

Itms added a member for Windows Developers: Angen.
Dec 1 2019, 6:48 PM

Sep 17 2019

Itms requested changes to D2021: Fix AtlasUI.dll windows autobuild.

I patched the Jenkins script, but this robocopy call is broken, I had to manually copy files on the slave. This needs to be fixed before committing.

Sep 17 2019, 10:13 PM
Itms committed rP22917: Fix rP22909 on Windows..
Fix rP22909 on Windows.
Sep 17 2019, 9:27 PM
Itms closed D2299: Fix test.exe build failing with --jenkins-tests flag.
Sep 17 2019, 9:27 PM
Itms accepted D2299: Fix test.exe build failing with --jenkins-tests flag.

This works on Jenkins and locally. The build failures above are mostly failed tests of the latest iteration of D1946 🙂

Sep 17 2019, 9:21 PM
Itms planned changes to D1910: Version the GCC Jenkins scripts.

This is completely outdated, now that the build uses Docker. I will upload the current version of scripts here.

Sep 17 2019, 8:57 PM
Itms added a member for Contributors: kenny.
Sep 17 2019, 7:05 PM

Sep 1 2019

Itms updated subscribers of rP22823: legionnaire → legionary (3).

@Stan the error in checkrefs.pl is really strange on Jenkins... 😕 (https://jenkins.wildfiregames.com/blue/organizations/jenkins/docker-svn/detail/docker-svn/319/pipeline) it's saying it parses units/rome_centurio_imperial, what is this file, I can't find it? Is this a bug in the perl script caused by the empty file here?

Sep 1 2019, 3:52 PM
Itms created D2244: Patch SM45 against bug 1266366.
Sep 1 2019, 3:38 PM

Aug 30 2019

Itms edited reviewers for D2114: Do not fail if some mod is broken [Mod Io], added: Itms; removed: Restricted Owners Package.

Hello! I had not noticed the patch when you created it 🙂 I think it's a good idea.

Aug 30 2019, 5:01 PM

Aug 19 2019

Itms added a comment to D2193: Stop copying color every draw call for every GUI object using colors ffs.
In D2193#91271, @elexis wrote:

It can only be closed if it is accepted.

Aug 19 2019, 4:45 PM

Aug 18 2019

Itms committed rP22690: Simplify the translations maintenance script..
Simplify the translations maintenance script.
Aug 18 2019, 8:13 PM
Itms closed D2078: Simplify the translations maintenance script.
Aug 18 2019, 8:13 PM
Itms added a comment to D2078: Simplify the translations maintenance script.

Thanks for taking a look 🙂

Aug 18 2019, 8:12 PM

Aug 8 2019

Stan awarded rP22629: Revert use of the `isRunOnce` flag after removal in rP22627 of compile'n go… a Love token.
Aug 8 2019, 3:29 PM
Itms committed rP22629: Revert use of the `isRunOnce` flag after removal in rP22627 of compile'n go….
Revert use of the `isRunOnce` flag after removal in rP22627 of compile'n go…
Aug 8 2019, 11:06 AM
Itms added a comment to rP22627: Upgrade SpiderMonkey to version 45.0.2, refs #4893..

The setIsRunOnce addition must be reverted.

Aug 8 2019, 10:56 AM
Itms committed rP22628: Precompiled SpiderMonkey 45 and nspr 4.12 for Windows..
Precompiled SpiderMonkey 45 and nspr 4.12 for Windows.
Aug 8 2019, 12:45 AM
elexis awarded rP22627: Upgrade SpiderMonkey to version 45.0.2, refs #4893. a Party Time token.
Aug 8 2019, 12:39 AM
Itms committed rP22627: Upgrade SpiderMonkey to version 45.0.2, refs #4893..
Upgrade SpiderMonkey to version 45.0.2, refs #4893.
Aug 8 2019, 12:38 AM
Itms closed D1510: Update to Spidermonkey 45.0.2.
Aug 8 2019, 12:38 AM

Aug 7 2019

Itms updated the diff for D1510: Update to Spidermonkey 45.0.2.

Updated RC following comments by historic_bruno, wraitii and elexis.

Aug 7 2019, 5:04 PM
Itms accepted D2152: Remove erroneous ErrorReporter.

This looks fine to me, works with SM38 and without any change with SM45, and so much hacky code is removed that I can only be happy 😄 The autorequest looks needed to me.

Aug 7 2019, 12:03 AM

Aug 6 2019

Itms committed rP22620: Improve Roman specific names..
Improve Roman specific names.
Aug 6 2019, 7:59 PM
Itms closed D1999: correct Roman specific names.
Aug 6 2019, 7:59 PM