Page MenuHomeWildfire Games

Itms (Nicolas Auvray)
User

User Details

User Since
Dec 19 2016, 10:38 PM (197 w, 18 h)

Recent Activity

Thu, Sep 17

Itms added a comment to D2922: Fix a compartment mismatch in XmppClient / Possibly fix semi-random lobby / in game JS crash.

Hi there! I rebased https://github.com/na-Itms/0ad/tree/spidermonkey upon this. Please test it, along SM52 ๐Ÿ™‚ I'll update the forum post whenever I have the chance.

Thu, Sep 17, 2:39 PM

Sat, Sep 5

Itms added a comment to D2925: deprecate campaigns/ folder.

I disagree with the change for the same reasons as Angen and Freagarach. IMO the only meaningful change we should make is: as part of D11, move the files we use to a new relevant place, and delete the others (moving them to the art repo). For instance the campaign test map should become an actual test campaign within the new campaign framework.

Sat, Sep 5, 11:14 AM
Itms added a comment to D2752: Do not thread the game in Atlas.

It does look like threading Atlas adds unwanted complexity. Atlas still freezes when the simulation hangs (for instance when changing the terrain with the pathfinder upgrade, we had to figure out a way to improve performance so that Atlas wouldn't lag). So it doesn't seem like the threading is useful. If it adds bugs on top, removing it sounds sensible to me.

Sat, Sep 5, 11:09 AM

Aug 18 2020

Itms committed rP23974: Add a NVTT version check at compile-time, fixes #5757, refs #5804..
Add a NVTT version check at compile-time, fixes #5757, refs #5804.
Aug 18 2020, 7:31 PM
Itms closed D2765: Add a safeguard for users trying to use an old system NVTT.
Aug 18 2020, 7:30 PM
Itms committed rP23973: Fix logic issue with the DXT1a texture format, refs #4549..
Fix logic issue with the DXT1a texture format, refs #4549.
Aug 18 2020, 6:46 PM
Itms closed D2522: Fix logic issue with the DXT1a texture format.
Aug 18 2020, 6:46 PM
Itms updated the diff for D2490: Style linting in c++ with Artistic Style.

Rebase

Aug 18 2020, 3:48 PM
Itms planned changes to D2946: [wip] Improvements to the Windows CI pipeline.
Aug 18 2020, 3:00 PM
Itms updated the diff for D2946: [wip] Improvements to the Windows CI pipeline.

Debug tests do work, I closed #3753. The current diff is now running on Jenkins, I still have some planned work for posting build warnings as comments.

Aug 18 2020, 3:00 PM
Itms committed rP23971: Fixes and improvements to the CI pipelines..
Fixes and improvements to the CI pipelines.
Aug 18 2020, 2:47 PM
Itms closed D2931: Fixes and improvements to the CI pipelines.
Aug 18 2020, 2:47 PM

Aug 17 2020

Itms updated subscribers of D2455: Add clang-format configuration for auto-formatting C++ code.

@wraitii, @vladislavbelov, what do you think about the spaces-around-operators issue? If you agree with me, I will move forward with D2490 (see some discussion there) and try to find a way to fix this one issue with clang-format. If you both think spaces everywhere are better, I can activate this instead.

Aug 17 2020, 10:01 AM
Itms added a comment to D2797: Check references from inside the engine [proof of concept].

Just like the others, it would be nice to have that functionality in-engine (mod validation could even happen as part of the archivebuilder workflow!)

Aug 17 2020, 9:44 AM

Aug 16 2020

Itms accepted D2945: Implements correct distance to edge for building snapping.

The code is good and it fixes a TODO. I also tested it in game and the snapping along the sides now work ๐Ÿ‘๐Ÿป

Aug 16 2020, 8:08 PM

Aug 15 2020

Itms added members for Balancing: badosu, ValihrAnt, Feldfeld, Stockfish0ad, borg-.
Aug 15 2020, 6:58 PM

Aug 11 2020

Itms added a comment to D2945: Implements correct distance to edge for building snapping.

Ha sorry! I really have to test it, then ๐Ÿ˜‰

Aug 11 2020, 5:31 PM
Itms added a reviewer for D2726: AMD Ryzen fix: Itms.
In D2726#115102, @Stan wrote:

I will post the discussion with @janwas after cleaning it a bit.

Aug 11 2020, 5:29 PM
Itms removed a reviewer for D2945: Implements correct distance to edge for building snapping: Restricted Owners Package.
Aug 11 2020, 5:26 PM
Itms requested changes to D2945: Implements correct distance to edge for building snapping.

Nice addition. I only reviewed the math/code, didn't test yet.

Aug 11 2020, 5:25 PM
Itms added a comment to rP23917: Add an interface for Reinforcement Learning..

In this case, I think it is preferable to make the setup as easy as possible and installing the mods automatically when spinning up the RL interface seems like it could remove a step in the process.

Aug 11 2020, 4:33 PM
Itms added a comment to rP23917: Add an interface for Reinforcement Learning..

I believe there was also a discussion around the loading of mods in the RL interface. This could be related to my limited experience with mods but I figured that if there are mods that edit units or create new maps, these should also be available when running 0 AD as an RL environment. It looks like there are some mods that add/modify civilizations which would certainly be relevant when using 0 AD as an RL environment. Most GUI mods would likely not be important.

Aug 11 2020, 2:53 PM
Itms added a comment to D2490: Style linting in c++ with Artistic Style.
In D2490#128449, @Stan wrote:

I think @vladislavbelov might have better input.

I think so too. As Vlad told me yesterday, the style linter will not manage to detect enforce everything in our coding conventions (for instance proper naming of variables).

For my part if it does the trick why not. Why do we need spaces around binary operators?

You misunderstood. Sometimes we need to NOT have spaces. For instance, for calculating a 2D distance, x*x + y*y is more readable than x * x + y * y (the relevant binary operator is * in this case). However, clang-format forces the use of spaces, and there is no option to change that, as of today. The detection of missing spaces is optional in astyle.

Aug 11 2020, 2:35 PM

Aug 10 2020

Itms updated the diff for D2490: Style linting in c++ with Artistic Style.

Proposal to use Artistic Style instead of clang-format.

Aug 10 2020, 4:51 PM
Itms planned changes to D2455: Add clang-format configuration for auto-formatting C++ code.
Aug 10 2020, 4:51 PM
Itms updated the diff for D2455: Add clang-format configuration for auto-formatting C++ code.

Here is a working version using Coala (not enabled in .coafile here).

Aug 10 2020, 4:50 PM
Itms commandeered D2455: Add clang-format configuration for auto-formatting C++ code.
Aug 10 2020, 4:25 PM
Itms removed a reviewer for D2931: Fixes and improvements to the CI pipelines: Vulcan.
Aug 10 2020, 2:58 PM
Itms updated subscribers of rP23917: Add an interface for Reinforcement Learning..

@irishninja, could you take a look at the issues Vlad mentions? We should have detected them before, sorry ๐Ÿ™ You can read the IRC logs for a few more details.

Aug 10 2020, 2:30 PM
Itms requested review of D2946: [wip] Improvements to the Windows CI pipeline.
Aug 10 2020, 11:09 AM
Itms updated the diff for D2931: Fixes and improvements to the CI pipelines.

Slight fixes.
Post build warnings as Phabricator comments, so that they are not missed in case of a successful build.
Post lint as inline comments.

Aug 10 2020, 10:43 AM

Aug 7 2020

Itms added a comment to D2919: Make PlayerHasMarket event-based.

I am testing a few Jenkins improvements on this diff, sorry for the noise!

Aug 7 2020, 12:36 PM
Itms added a comment to D2881: Update ObjectToIDMap before upgrading SpiderMonkey to 52.

I am testing a few Jenkins improvements on this diff, sorry for the noise!

Aug 7 2020, 11:05 AM

Aug 6 2020

Itms updated the diff for D2931: Fixes and improvements to the CI pipelines.

Adapt LicenseYearBear to the current version of the python package svn.

Aug 6 2020, 6:06 PM
Itms commandeered D2490: Style linting in c++ with Artistic Style.
Aug 6 2020, 5:32 PM
Itms added a comment to D2490: Style linting in c++ with Artistic Style.

Can I commandeer this? ๐Ÿ™‚

Aug 6 2020, 5:28 PM
Itms edited reviewers for D14: [RC] Thread the pathfinder computations, added: Itms, vladislavbelov; removed: Restricted Owners Package.
Aug 6 2020, 5:23 PM
Itms added a comment to D2528: Performance improvements to VertexBuffer.

I am restarting the build here to pass the fixed cppcheck on this. Sorry in advance if there is a false negative..

Aug 6 2020, 4:50 PM
Itms updated the diff for D2931: Fixes and improvements to the CI pipelines.

Obviously.

Aug 6 2020, 4:41 PM
Itms updated the diff for D2931: Fixes and improvements to the CI pipelines.

Fix on Python 3.8 (sent upstream https://github.com/coala/coala-bears/pull/2976)
Fix caching in a docker container (not sent yet)
Display file name of cppcheck results

Aug 6 2020, 4:29 PM
Itms abandoned D2924: Use local label in inline asm, avoid symbol duplication.

Hi Stefan, thanks for this patch. Indeed, we are merely providing a bundled version of premake, and we try to keep it as close as possible from upstream.

Aug 6 2020, 10:07 AM

Aug 5 2020

Itms updated the diff for D2931: Fixes and improvements to the CI pipelines.

Address coala warnings.

Aug 5 2020, 3:41 PM

Aug 4 2020

Itms updated the diff for D2931: Fixes and improvements to the CI pipelines.

Correct dockerfile.

Aug 4 2020, 11:46 PM
Itms updated the diff for D2931: Fixes and improvements to the CI pipelines.

Move files in a way that arcanist understands.

Aug 4 2020, 7:34 PM
Itms requested review of D2931: Fixes and improvements to the CI pipelines.
Aug 4 2020, 7:21 PM
Itms added a reviewer for D2928: Fix reported compilation error on arch introduced by rP23917: irishninja.

Wouldn't it be better to include it in RLInterface.cpp? It is when compiling that file that the inclusion is missing. I am a bit confused by the issue, just as I was confused during the review ๐Ÿค”

Aug 4 2020, 12:00 PM

Aug 3 2020

Itms added a comment to rP22604: Implement IGUIObject settings as a template class and IGUIObject::AddSetting asโ€ฆ.

That's interesting, but IMO, if this is a C++17 feature, we shouldn't use it (yet) regardless of what the MSVC documentation says. It's not always trustworthy. Of course, if the bug is present in current Visual Studio, it is an issue. But I am totally fine with the current code after rP22617 and rP22636 ๐Ÿ™‚

Aug 3 2020, 6:49 PM
Itms removed a reviewer for D2788: Fix 1 general and 3 OSX-specific issues in Atlas: Itms.
Aug 3 2020, 11:50 AM
Itms added a comment to D2788: Fix 1 general and 3 OSX-specific issues in Atlas.

I really have no idea why we get this failure. This is supposed to be defined in Appkit.h, which I do include -_- .

@Itms would you have an idea maybe? We might need to link against appkit ?

Aug 3 2020, 9:41 AM

Aug 2 2020

Itms added a comment to D2922: Fix a compartment mismatch in XmppClient / Possibly fix semi-random lobby / in game JS crash.

Yes, the more I look at it the more I'm convinced this is the issue. I really can't do the rebase today but should be possible to see whether the crash is fixed in the upcoming days. ๐Ÿ™‚

Aug 2 2020, 1:16 PM
Itms added a comment to D2922: Fix a compartment mismatch in XmppClient / Possibly fix semi-random lobby / in game JS crash.

By the way, a better name for the diff and for a future commit would be Fix rooting mistake in GuiPoll{New,Historic}Messages. But it would be great to add a fixes #5655, of course ๐Ÿ˜‰ I'll rebase the branch upon this commit so that we can test if the crash is fixed.

Aug 2 2020, 1:10 PM
Itms added a comment to D2922: Fix a compartment mismatch in XmppClient / Possibly fix semi-random lobby / in game JS crash.

Ha, this makes far more sense, thank you! ๐Ÿ™‚

Aug 2 2020, 1:05 PM
Itms added a comment to D2922: Fix a compartment mismatch in XmppClient / Possibly fix semi-random lobby / in game JS crash.

The root of the issue might be around this part of the code, but I'm not convinced with the patch.

Aug 2 2020, 12:27 PM

Aug 1 2020

Itms added a comment to D2911: Allow women citizen to lay the same foundations as citizen soldiers..

At the moment I don't think we plan on stopping citizen soldiers from being soldiers, so that's a likely no for now.

Aug 1 2020, 8:20 PM
Itms updated the Trac tickets for D2897: Remove dead AI manager serializablePrototype code.
Aug 1 2020, 7:21 PM
Itms updated the diff for D2897: Remove dead AI manager serializablePrototype code.

Update with the version from the SM52 git migration branch.

Aug 1 2020, 7:20 PM
Itms commandeered D2897: Remove dead AI manager serializablePrototype code.
Aug 1 2020, 7:19 PM
Itms awarded rP23917: Add an interface for Reinforcement Learning. a 100 token.
Aug 1 2020, 1:09 PM

Jul 31 2020

Itms accepted D2199: Add RL interface for Reinforcement Learning.

Thanks again for the great work ๐Ÿ™‚

Jul 31 2020, 9:30 AM

Jul 30 2020

Itms added inline comments to D2199: Add RL interface for Reinforcement Learning.
Jul 30 2020, 10:10 PM
Itms added a comment to D665: Make ship pickup nicer.

Fix the map!

Jul 30 2020, 8:43 PM
Itms added a comment to D665: Make ship pickup nicer.

I do not know the current unit motion as well as wraitii and Freagarach do, so I'm trusting Freagarach's review here ๐Ÿ™‚ The C++ changes do not seem problematic at first sight.

Jul 30 2020, 8:25 PM
Itms added inline comments to D2199: Add RL interface for Reinforcement Learning.
Jul 30 2020, 7:44 PM
Itms requested changes to D2199: Add RL interface for Reinforcement Learning.

Very fun tool to play with, great job! And the code looks pretty nice, it's self-contained and easy to read.

Jul 30 2020, 12:23 PM

Jul 29 2020

Itms updated the diff for D2919: Make PlayerHasMarket event-based.

Use CanBarter rather than HasMarket.
Test cmpPlayer and add a unit test for cmpPlayer.SetPlayerID while I'm at it.

Jul 29 2020, 2:09 PM

Jul 28 2020

Itms updated the diff for D2919: Make PlayerHasMarket event-based.

Fixed Jenkins lint.

Jul 28 2020, 5:51 PM
Imarok awarded D2919: Make PlayerHasMarket event-based a The World Burns token.
Jul 28 2020, 5:41 PM
Itms created D2919: Make PlayerHasMarket event-based.
Jul 28 2020, 5:20 PM

Jul 25 2020

Itms added a comment to D2902: Fix entdocs generation.

Hey! I'm the one at fault here.

Jul 25 2020, 6:52 PM

Jul 20 2020

Itms added a reviewer for D2897: Remove dead AI manager serializablePrototype code: Itms.
Jul 20 2020, 5:56 PM
Itms added a comment to D2897: Remove dead AI manager serializablePrototype code.

I believe that you can also delete the SetSerializablePrototypes and IsSerializablePrototypefrom the (de)serializer, as you don't replace them by anything. They were only called by this AI code.

Jul 20 2020, 5:55 PM
Itms added a comment to D2746: Correctly serialize/deserialize user-defined JS objects..

Currently, if one stores a Vector2D in a component, it generally will OOS when deserializing since it is deserialised as a dict.

Jul 20 2020, 5:03 PM
Itms added a comment to D2746: Correctly serialize/deserialize user-defined JS objects..

Hi wraitii, while I was looking into those serializable prototypes the other day, I discovered that most of this code is currently dead. I do not know if you noticed, I didn't see this mentioned above.

Jul 20 2020, 2:34 PM
Itms awarded rP23856: Move the ability to hold a turret to a separate file. a Party Time token.
Jul 20 2020, 2:31 PM

Jul 17 2020

Itms added a reviewer for D2746: Correctly serialize/deserialize user-defined JS objects.: Itms.
Jul 17 2020, 11:09 AM
Itms removed reviewers for D2881: Update ObjectToIDMap before upgrading SpiderMonkey to 52: wraitii, Bellaz89.

Thanks for the help asterix but this is not reviewable, I just uploaded it to be able to show it to other devs. In his branch, Bellaz changed the key type slightly, which could be a possible fix but does not match upstream. I am going to try a different way based on my discussion with SM devs.

Jul 17 2020, 9:17 AM

Jul 16 2020

Itms planned changes to D2881: Update ObjectToIDMap before upgrading SpiderMonkey to 52.
Jul 16 2020, 9:51 PM
Itms created D2881: Update ObjectToIDMap before upgrading SpiderMonkey to 52.
Jul 16 2020, 9:51 PM

Jul 14 2020

Itms added a comment to D2691: Fix NVTT warning when building on some linux platforms.

Sorry, yes you can abandon this one, I'll include it as planned when I'm looking at NVTT again.

Jul 14 2020, 2:51 PM
Itms updated subscribers of D665: Make ship pickup nicer.

I'm planning to commit this sometimes in July. Testing & reviewing obviously appreciated until then.

Jul 14 2020, 10:40 AM
Itms added a reviewer for D2785: Switch range manager from unsigned integers to a proper data structure: Itms.
Jul 14 2020, 10:12 AM
Itms accepted rP23774: Move LOS to a los helper header and cleanup Grid.h includes..
Jul 14 2020, 10:10 AM

Jul 12 2020

Itms awarded rP23821: Stop failing if mod is broken and display invalid mods in downloader [Mod Io] a Love token.
Jul 12 2020, 12:11 PM

Jul 11 2020

Itms committed rP23815: Fix rooting mistake in CGame::ReallyStartGame, detected by Bellaz89, fixesโ€ฆ.
Fix rooting mistake in CGame::ReallyStartGame, detected by Bellaz89, fixesโ€ฆ
Jul 11 2020, 4:24 PM
Itms closed D2869: Fix rooting mistake in CGame::ReallyStartGame.
Jul 11 2020, 4:24 PM
Itms committed rP23814: Rebuild zlib 1.2.11 and upgrade libpng to 1.6.37, on Windows, with toolsetโ€ฆ.
Rebuild zlib 1.2.11 and upgrade libpng to 1.6.37, on Windows, with toolsetโ€ฆ
Jul 11 2020, 4:18 PM
Bellaz89 awarded D2869: Fix rooting mistake in CGame::ReallyStartGame a Like token.
Jul 11 2020, 4:14 PM

Jul 10 2020

Angen awarded D2869: Fix rooting mistake in CGame::ReallyStartGame a Love token.
Jul 10 2020, 1:24 PM

Jul 9 2020

Itms created D2869: Fix rooting mistake in CGame::ReallyStartGame.
Jul 9 2020, 7:55 PM

Jul 8 2020

Itms added a comment to D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

This looks really nice at first sight. I'm keeping forward on the SM upgrade work and I'll let you know if I prefer get this in before or after a specific version.

Jul 8 2020, 3:55 PM

Jul 6 2020

Itms requested review of D2765: Add a safeguard for users trying to use an old system NVTT.

As reported on Trac, the patch works for me, I have no news of GunChleoc. If someone with an Ubuntu, or derived, could test this... I am also interested in users of various distributions where the system nvtt creates the issue.

Jul 6 2020, 10:31 AM

Jul 5 2020

Itms added a comment to D2768: Switch JS GUI Objects to a Proxy class, cleaning custom function definition..

I am slowly wrapping my head around this patch, but I find it very complicated. I wrote down a few comments but this is just a first pass. In general I find that the code comments you wrote add more confusion.

Jul 5 2020, 11:15 AM
Itms accepted D2114: Do not fail if some mod is broken [Mod Io].

Looks good to me! I will look into fixing the issues you pointed out in your audit of the original commit.

Jul 5 2020, 10:39 AM

Jul 4 2020

Itms requested changes to D2114: Do not fail if some mod is broken [Mod Io].

Really like the patch and the new UX with broken mods, it's a big improvement ๐Ÿ‘๐Ÿป

Jul 4 2020, 7:09 PM

Jul 1 2020

Itms added a comment to D2782: [Gameplay] make ram less effective.

Even as admin, I am blocked by the policy @borg- set! borg, you have to click "Edit Revision" at the top right of the diff description, then change "Editable By" to become "All Users".

Jul 1 2020, 4:49 PM ยท Unknown Object (Project), Contributors

Jun 30 2020

Itms committed rP23795: Fix conversion of UTF8 strings between the scripts and the engine..
Fix conversion of UTF8 strings between the scripts and the engine.
Jun 30 2020, 12:46 PM
Itms closed D2838: Fix string conversion to/from Spidermonkey.
Jun 30 2020, 12:46 PM
Itms updated subscribers of rP23794: Fix building on GCC 10, fixes #5709, #5756..

Perhaps you could also fix the line endings in all of the libraries/source/fcollada/** files?

Jun 30 2020, 12:38 PM
Itms committed rP23794: Fix building on GCC 10, fixes #5709, #5756..
Fix building on GCC 10, fixes #5709, #5756.
Jun 30 2020, 12:25 PM
Itms closed D2745: #5709 fcollada build fix for gcc 10 (WritePhysicsRigidBodyInstance) by @pcpa..
Jun 30 2020, 12:25 PM