Page MenuHomeWildfire Games

Itms (Nicolas Auvray)
User

User Details

User Since
Dec 19 2016, 10:38 PM (113 w, 1 d)

Recent Activity

Thu, Feb 7

Itms added a comment to D1042: rename maps/ file names to use underscores (instead of spaces and capitalization).
In D1042#71075, @Nescio wrote:

Still to be decided:
1 what to do with the scenarios/Height Map *.png files
2 what to do with the three Azure Coast scenarios (identical maps, different player numbers)
3 what to do with the two Flight_demo scenarios (different maps, similar function)
4 what to do with the two Sandbox - Ptolemies scenarios (different maps, similar function; all other factions have only one sandbox)
5 how to differentiate similary named skirmishes, e.g. Corinthian Isthmus (different maps, similar names)

How about the following?

  • 2, 3, 4: keep only one version, delete the others
  • 5: rename them to _small and _large
Thu, Feb 7, 10:50 PM

Jan 15 2019

Itms added a comment to D1745: Allow loading Icons at runtime.

@elexis I sent you a forum PM, please let me know if you want to use a different place for discussion.

Jan 15 2019, 1:39 PM

Jan 13 2019

Itms added a comment to D1743: Fix UnitAI infinite loop following rP22023.

It would be nice to have something that detects such infinite loops and creates JS errors instead of engine crashes.

Jan 13 2019, 8:24 PM
Itms planned changes to D1510: Update to Spidermonkey 45.0.2.

I'm rebasing this one, and I'll try to include the binaries for Windows in the diff.

Jan 13 2019, 5:39 PM
Itms committed rP22052: SpiderMonkey-related changes in preparation for the upgrade to SpiderMonkey 45….
SpiderMonkey-related changes in preparation for the upgrade to SpiderMonkey 45…
Jan 13 2019, 5:37 PM
Itms closed D1716: SpiderMonkey changes in preparation for the SM45 upgrade.
Jan 13 2019, 5:37 PM
Itms added a comment to rP22023: Always leave/reenter the top-most FSM state when SetNextState is called with….

@Itms no logs no dump files, no errors. Just crash.

Jan 13 2019, 11:31 AM
Itms added a comment to rP22023: Always leave/reenter the top-most FSM state when SetNextState is called with….

That's wild! This commit should not be able to create a segfault, so it probably just reveals a bug in the engine. The commands file should be enough to find the bug and fix it.

Jan 13 2019, 11:26 AM

Jan 12 2019

Itms added a comment to D1741: Fix some warning for vs2015 in Atlas.

I think _p or m_p would be acceptable names since it's one letter.
This might conflict with D1395, which I should prioritize.
The other warnings shall be fixed by upgrading Boost and/or deleting old unneeded dlls.

Jan 12 2019, 1:56 PM
Itms accepted D1678: Fix Warnings of VS2015 .

Okay, you're right. Go ahead and thanks for the patch!

Jan 12 2019, 1:48 PM · Windows Developers
Itms requested changes to D1691: Remove boost "system" from Mac OS build system..

I think we do not need to include boost::system because we don't use anything from it, but we need to link it because boost::filesystem depends on it. I think only the build-osx change should be kept, as bootstrap is clever enough to build the boost::system lib while now excluding it from distributed includes.

Jan 12 2019, 10:17 AM
Itms added a comment to D1691: Remove boost "system" from Mac OS build system..

This doesn't work for me. Linking of pyrogenesis fails with undefined references to boost::system stuff. I will retry tomorrow with a clean checkout.

Jan 12 2019, 1:04 AM
Itms requested changes to D1678: Fix Warnings of VS2015 .

The patch looks good and it works for me too! However, I tested building Atlas and got the following warnings:

  • C4458 in AtlasObjectImpl.cpp line 292 and in AtlasUI/Object.cpp:547
  • C4456 in MapDialog.cpp:173 and in ScenarioEditor.cpp:742
Jan 12 2019, 12:37 AM · Windows Developers

Jan 6 2019

Itms requested review of D1716: SpiderMonkey changes in preparation for the SM45 upgrade.
Jan 6 2019, 10:27 PM
Itms added inline comments to D1716: SpiderMonkey changes in preparation for the SM45 upgrade.
Jan 6 2019, 10:27 PM
Itms updated the diff for D1716: SpiderMonkey changes in preparation for the SM45 upgrade.

Addressed comments above, and tested the JSPROP_PERMANENT thing.

Jan 6 2019, 10:26 PM
Itms requested changes to D1737: Slight cleanup of fogging OnDestroy and some comments.
Jan 6 2019, 9:05 PM
Itms added a comment to D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

Ah right, sorry. But I'd be interested in knowing how much of the cases are actually ent == INVALID_ENTITY. It doesn't sound like there are a lot of cases where an entity would be deleted several times?

Jan 6 2019, 6:50 PM
Itms added a comment to D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

I really think all the things that happen after this early return are inexpensive. In particular, when posting messages, if the entity is actually fully destroyed, no component subscribed to the message will be found, so there won't be a lot of overhead. If it's not actually fully destroyed, the patch is wrong (I do not think that's the case, but I might be wrong).

Jan 6 2019, 6:24 PM

Jan 5 2019

Itms added a comment to D14: Thread the pathfinder computations to reduce latency.
In D14#69171, @Kuba386 wrote:

Well, button said "resign as reviewer". I've only intended to cancel my old review that is not correct anymore.
I'm still working on this.

Jan 5 2019, 10:37 AM

Jan 4 2019

Itms accepted D1488: Always use SetNextStateAlwaysEntering when processing an order in UnitAI.

I think this is a good change and I share the opinion that removing the "always entering"/"not always entering" distinction would help tracking down some subtle bugs.

Jan 4 2019, 11:19 PM
Itms added a comment to rP22021: Upgrade premake5 from alpha12 to alpha13, refs #3729..

I could not send this commit on Phabricator for automated testing, so please report here if any bug related to that is found.

Jan 4 2019, 10:23 PM
Itms committed rP22021: Upgrade premake5 from alpha12 to alpha13, refs #3729..
Upgrade premake5 from alpha12 to alpha13, refs #3729.
Jan 4 2019, 10:20 PM
Itms added a comment to rP21941: Import part of commit https://github.com/premake/premake….

I do not know why I thought we were using alpha10 of premake5: we are using alpha 12. The fix above was included in alpha13, that is correct.

Jan 4 2019, 10:10 PM
Itms added a comment to D1381: Improve and fix checkrefs.pl.

This still works for me, with the same results. I didn't test a mod but the cli flag seems to work for the public mod as advertised.

Jan 4 2019, 10:04 PM
Itms added a comment to D14: Thread the pathfinder computations to reduce latency.
In D14#69094, @Vulcan wrote:

Build was aborted.

Jan 4 2019, 10:00 PM
Itms added a reviewer for D1674: Check translations for sprintf errors: Itms.

Hey! Yes I'll find the time. I haven't focused much on DevOps during the holidays but I'll be back to that.

Jan 4 2019, 11:50 AM
Itms awarded rP22014: Fix inconsistencies between specific name and generic name a Love token.
Jan 4 2019, 11:39 AM

Jan 3 2019

Itms committed rP22011: Rename the Viking longboat into longship, and fix the form of the specific name….
Rename the Viking longboat into longship, and fix the form of the specific name…
Jan 3 2019, 12:35 AM
Itms closed D507: fixed spelling errors for ships: Liburnus -> Liburna, Longboat -> Longship, Penteconter -> Pentekonter and correct capitalisation.
Jan 3 2019, 12:35 AM
Itms requested review of D507: fixed spelling errors for ships: Liburnus -> Liburna, Longboat -> Longship, Penteconter -> Pentekonter and correct capitalisation.

Cannot update this quickly because of https://secure.phabricator.com/T10608

Jan 3 2019, 12:27 AM
Itms accepted D404: Add Coala Bear for the license header check.

🎉

Jan 3 2019, 12:01 AM

Jan 2 2019

Itms requested changes to D404: Add Coala Bear for the license header check.

If that works for you it might come from an old module you have installed.

Jan 2 2019, 11:02 PM
Itms requested changes to D404: Add Coala Bear for the license header check.

This is a nice bear, and it works! All my apologies for letting this one aside for so long 😶

Jan 2 2019, 9:36 PM
Itms requested changes to D1488: Always use SetNextStateAlwaysEntering when processing an order in UnitAI.

This patch looks harmless and sensible, but I disagree with renaming unused code into dead code.

Jan 2 2019, 4:44 PM
Itms requested changes to D1711: sandbox map preview naming consistency.

This now needs a rebase after rP22005, sorry for that (I thought it would be better to plainly change mauryans to mauryas everywhere, to avoid mistakes as much as possible).

Jan 2 2019, 4:14 PM
Itms added a reviewer for D1483: Use Homebrew to fetch OSX libraries instead of compiling them all: trompetin17.
Jan 2 2019, 4:03 PM
Itms committed rP22005: Correct Mauryans into Mauryas..
Correct Mauryans into Mauryas.
Jan 2 2019, 4:02 PM
Itms closed D1342: Corrected Mauryans into Mauryas.
Jan 2 2019, 4:01 PM
Itms accepted D1342: Corrected Mauryans into Mauryas.

I used this and D1713 to perform the change, which I'm committing now.

Jan 2 2019, 3:55 PM
Itms added a comment to D1381: Improve and fix checkrefs.pl.

I am Perl illiterate, but I tested the updated script and it works fine. It detected the following issues for me:

Loading maps PMP...
Duplicate terrain name 'medit_city_tile' (from 'art/terrains/road/medit_city_tile.xml' and 'art/terrains/biome-mediterranean/medit_city_tile.xml')
[...]
Loading GUI XML...
Can't stat ../../../binaries/data/mods/public/gui/modio: No such file or directory
 at checkrefs.pl line 61.
Can't stat ../../../binaries/data/mods/public/gui/modmod/help: No such file or directory
 at checkrefs.pl line 61.
Can't stat ../../../binaries/data/mods/public/gui/msgbox: No such file or directory
 at checkrefs.pl line 61.
Can't stat ../../../binaries/data/mods/public/gui/termsdialog: No such file or directory
 at checkrefs.pl line 61.
[...]
Loading terrains...
Jan 2 2019, 1:57 PM
Itms planned changes to D1716: SpiderMonkey changes in preparation for the SM45 upgrade.

Thanks for the comments, addressing them today.

Jan 2 2019, 11:50 AM
Itms added a comment to rP21998: Do not actually Kill in debug_break() in non-debug binaries.

I agree with this change, it makes sense. What do you think of bringing up the usual debugging window instead of killing (in Debug mode)? I'm talking about the window that pops up when an ENSURE fails, for instance.

Jan 2 2019, 11:45 AM

Dec 30 2018

Itms requested changes to D1396: Silence C4351.

Not sure either why VS2015 doesn't get the error. Could you try to see what happens when the version check is removed? It doesn't make sense to add this new conditional as-is. The only meaningful patches would be, In my opinion, no conditional (the warning is silenced on all versions), or a conditional that keeps the old behavior for 2013 and introduces a change for the new version (that would be <= 1800).

Dec 30 2018, 5:37 PM
Itms added a comment to D1510: Update to Spidermonkey 45.0.2.
In D1510#68005, @elexis wrote:

It still seems very wrong to neglect the differences between a SpiderMonkey pre-release, a SpiderMonkey release and a Mozilla Extended Support Release....

Yes, sorry about that. However SM developers themselves use the terms "release" and "ESR" liberally, for instance in bug reports, hence my sloppy use of the terms. I'll be more cautious. To clarify: when Firefox has an ESR release, SM developers create a pre-release of SM as soon as possible, and mark it as a release when they are confident the product is good enough.

Dec 30 2018, 1:18 PM

Dec 29 2018

Itms added a comment to D1510: Update to Spidermonkey 45.0.2.
In D1510#67827, @elexis wrote:

@Itms you mentioned somewhere to plan to go to sm60 after sm52, but I still didn't see any information that indicates that sm60 is planned as a release [...]
Knowing about these things beforehand may increase the platforms 0ad can run on, so it may be worth to explore (or describe if already explored).

About the ESR versions of SpiderMonkey: yes the documentation is poorly maintained, and releases of SpiderMonkey are not well announced (more on that below). However, I confirm the past released versions of SM were 38, 45 and 52. The current version is 60. Version 68 is the upcoming ESR. SM60 started to be developed on 2018-01-22, was released 2018-05-19, and will receive fixes until 2019-10-21 (two versions after the release of SM68). Those dates are taken from https://wiki.mozilla.org/Release_Management/Calendar: SM releases match the releases of Firefox ESR, as stated in the documentation.

Dec 29 2018, 11:03 PM
Itms updated the diff for D1510: Update to Spidermonkey 45.0.2.

This works for me 🎉 and is based on D1716. arcanist should theoretically be able to patch in chain...

Dec 29 2018, 10:52 PM
Itms added a parent revision for D1510: Update to Spidermonkey 45.0.2: D1716: SpiderMonkey changes in preparation for the SM45 upgrade.
Dec 29 2018, 10:28 PM
Itms added a child revision for D1716: SpiderMonkey changes in preparation for the SM45 upgrade: D1510: Update to Spidermonkey 45.0.2.
Dec 29 2018, 10:28 PM
Itms created D1716: SpiderMonkey changes in preparation for the SM45 upgrade.
Dec 29 2018, 10:27 PM

Dec 28 2018

Itms requested verification of rP21960: Fix some untranslated strings, fixes #5155..
Dec 28 2018, 8:17 PM
Itms committed rP21967: Complete rP21960 by removing an obsolete reference..
Complete rP21960 by removing an obsolete reference.
Dec 28 2018, 8:16 PM
Itms closed D1714: Fix rP21960.
Dec 28 2018, 8:16 PM
Itms added a comment to D1714: Fix rP21960.
In D1714#67739, @elexis wrote:

was it quicker than looking if the directories exist by hand/eye/grep?.

Dec 28 2018, 8:14 PM
Itms created D1714: Fix rP21960.
Dec 28 2018, 5:32 PM
Itms abandoned D1713: rename /mauryans/ to /mauryas/ folders.

Thank you! That is a big patch. You should just update D1342 with this new version, though, in case there is a discussion on the patch, let's not scatter it.

Dec 28 2018, 5:15 PM
Itms added a comment to D1342: Corrected Mauryans into Mauryas.

You can patch your arc as in the link Stan provided, or you can set a property that I won't commit:

svn propset svn:mime-type text/plain garrison_flag_maur.xml

Whatever is easier for you.

Dec 28 2018, 3:51 PM
Itms committed rP21963: Rename the file of the Kushite emblem for consistency with the other emblems….
Rename the file of the Kushite emblem for consistency with the other emblems…
Dec 28 2018, 2:38 PM
Itms closed D1710: rename Kushite emblem for consistency.
Dec 28 2018, 2:38 PM
Itms accepted D1710: rename Kushite emblem for consistency.

I confirm that kush.json is the only place referencing the emblem, and I agree that it is way more simple to make the kush emblem follow the convention used for all the others.

Dec 28 2018, 2:35 PM
Itms added a comment to rP21960: Fix some untranslated strings, fixes #5155..

Thanks for the remarks 👍 I posted a comment on the diff I missed, and I am going to take the opportunity to go through all the resources to see if there are no other unneeded paths. I'll create a diff for my findings.

Dec 28 2018, 2:29 PM
Itms added a comment to D1623: Fix missing translate call in modmod.

Ah sorry for missing this patch, I committed the simplest fix for #5155, which was just adding the translate call.

Dec 28 2018, 2:28 PM
Itms committed rP21962: Update the War Elephants loading screen tip, which missed some factions, taken….
Update the War Elephants loading screen tip, which missed some factions, taken…
Dec 28 2018, 2:18 PM
Itms closed D1709: Update War Elephants tooltip for new civs.
Dec 28 2018, 2:18 PM
Itms accepted D1709: Update War Elephants tooltip for new civs.

👍

Dec 28 2018, 2:16 PM
Itms committed rP21961: Fix orthography of "Seleucus" and a typo, taken from D1342..
Fix orthography of "Seleucus" and a typo, taken from D1342.
Dec 28 2018, 2:15 PM
Itms closed D1708: fix Seleucid history typo.
Dec 28 2018, 2:15 PM
Itms accepted D1708: fix Seleucid history typo.

Thanks for the splitting! 👍

Dec 28 2018, 2:10 PM
Itms committed rP21960: Fix some untranslated strings, fixes #5155..
Fix some untranslated strings, fixes #5155.
Dec 28 2018, 2:07 PM
Itms closed D1560: Untranslated strings.
Dec 28 2018, 2:07 PM
Itms accepted D1560: Untranslated strings.

I'm committing this with the indentation fixed. I tested the pot generation and the missing strings are correctly extracted.

Dec 28 2018, 2:04 PM
Itms planned changes to D1510: Update to Spidermonkey 45.0.2.
Dec 28 2018, 11:24 AM
Itms commandeered D1510: Update to Spidermonkey 45.0.2.

I am working on this and so far I am not having issues, it's just a bit time-consuming (so holidays are perfect for me). So if you don't mind someone else commandeering this @wraitii, I'm taking it.

Dec 28 2018, 11:24 AM

Dec 27 2018

Itms added a comment to D1560: Untranslated strings.
In D1560#67463, @elexis wrote:

(I was wondering if one couldn't push the changes from the modified *po file to transifex using the commandline thing)

Dec 27 2018, 11:14 PM
Itms edited reviewers for D1525: Add a lobby server port config option , added: user1, elexis; removed: Itms.

Hello @mmoanis, and thank you very much for the patch! As you may know we had a large period without accepting patches, because we were preparing a re-release of the game.

Dec 27 2018, 10:44 PM
Itms requested changes to D1560: Untranslated strings.
  • The changes to our maintenance scripts seem unwanted/unneeded.
  • The changes to the Swedish pot files must be done from Transifex, else they will be overwritten.
  • The changes to the po files are unneeded, they will be performed by the autobuilder.
  • The changes to our code look good, but they probably need to be rebased now.
Dec 27 2018, 10:11 PM
Itms added a comment to D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.

@s0600204 This is a wonderful patch! 👍

Dec 27 2018, 7:52 PM
Itms added a comment to D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.
In D1395#67451, @elexis wrote:

Why are UTF8 strings preferable over UTF16 ones? Might be, but I didn't see the reason mentioned, and

  1. usually data is kept in the way the original data is provided (I failed to find the place where the strings are constructed)
  2. most of the changed lines use wstring
Dec 27 2018, 7:48 PM
Itms requested changes to D1342: Corrected Mauryans into Mauryas.

Hi Nescio! I can finally include this patch. It needs to be split however. Can you do the following for me?

Dec 27 2018, 7:19 PM

Dec 26 2018

Itms requested changes to D1611: Use pkg-config instead of hard-coding or library-specific programs.

This looks pretty cool, I'm eager to have this in!

Dec 26 2018, 5:34 PM
Stan awarded rP21955: Drop premake4 support, refs #3729. premake4 has been unused for a long time now… a Like token.
Dec 26 2018, 5:01 PM
Itms committed rP21955: Drop premake4 support, refs #3729. premake4 has been unused for a long time now….
Drop premake4 support, refs #3729. premake4 has been unused for a long time now…
Dec 26 2018, 5:01 PM
Itms closed D1275: Drop premake4 support [after A23].
Dec 26 2018, 5:01 PM
Itms updated the diff for D1275: Drop premake4 support [after A23].

Rebased this patch before committing it.

Dec 26 2018, 12:45 PM
Itms accepted D1705: Bump version to a24.

That is even more complete than what I would call complete 😉

Dec 26 2018, 12:15 PM
Itms abandoned D1706: Bump version numbers for A24.

lol, D1705

Dec 26 2018, 12:11 PM
Itms created D1706: Bump version numbers for A24.
Dec 26 2018, 12:09 PM
Itms added a comment to rP21947: Improve existing boar texture to make it less cartoony..

(Version bump to a24 ought to be the first commit)

Dec 26 2018, 11:52 AM
Itms awarded rP21947: Improve existing boar texture to make it less cartoony. a Party Time token.
Dec 26 2018, 10:28 AM
Itms requested verification of rP21719: Send rating related requests directly to EcheLOn..

Fixed by rP21925 and rP21926, right?

Dec 26 2018, 10:23 AM
Itms requested verification of rP21683: Update libcurl to 7.59.0 on Windows and enable SSL support on Windows and macOS..

@elexis Are we good with this? The remaining issues should be fixed by upgrading premake and committing a few patches. If I'm wrong we could really use a ticket to document our findings.

Dec 26 2018, 10:21 AM
Itms accepted rP21492: fix some maps missing VictoryConditions.
Dec 26 2018, 10:17 AM
Itms accepted rP20067: Add an icon to pyrogenesis' application window.
Dec 26 2018, 10:16 AM

Dec 25 2018

Itms added a member for Contributors: Alexandermb.
Dec 25 2018, 8:07 PM
Itms added a member for Contributors: Wundersam.
Dec 25 2018, 7:17 PM

Dec 21 2018

Itms added a comment to D14: Thread the pathfinder computations to reduce latency.
In D14#67127, @Kuba386 wrote:
+ binaries/system/test_dbg
Debugger launch failed: No such file or directory
Trace/breakpoint trap
Dec 21 2018, 9:23 AM

Dec 17 2018

Itms added a comment to D1695: Show translations of the labels of the tab-buttons in the credits gui page..

Thanks for tracking this one down 🙂

Dec 17 2018, 8:19 PM
Itms awarded D1695: Show translations of the labels of the tab-buttons in the credits gui page. a Like token.
Dec 17 2018, 8:16 PM

Dec 10 2018

Itms added a member for Contributors: cpc.
Dec 10 2018, 10:09 PM

Dec 8 2018

Itms committed rP21946: [i18n] Last manual update of the translations and associated credits..
[i18n] Last manual update of the translations and associated credits.
Dec 8 2018, 11:04 PM