I patched the Jenkins script, but this robocopy call is broken, I had to manually copy files on the slave. This needs to be fixed before committing.

This works on Jenkins and locally. The build failures above are mostly failed tests of the latest iteration of D1946 🙂

This is completely outdated, now that the build uses Docker. I will upload the current version of scripts here.

@Stan the error in checkrefs.pl is really strange on Jenkins... 😕 (https://jenkins.wildfiregames.com/blue/organizations/jenkins/docker-svn/detail/docker-svn/319/pipeline) it's saying it parses units/rome_centurio_imperial, what is this file, I can't find it? Is this a bug in the perl script caused by the empty file here?

Hello! I had not noticed the patch when you created it 🙂 I think it's a good idea.

In D2193#91271, @elexis wrote:

It can only be closed if it is accepted.

Thanks for taking a look 🙂

The setIsRunOnce addition must be reverted.

Updated RC following comments by historic_bruno, wraitii and elexis.

This looks fine to me, works with SM38 and without any change with SM45, and so much hacky code is removed that I can only be happy 😄 The autorequest looks needed to me.

Alright, everything is cleared up then! Thanks again for the work :)

Thanks for the answers! Indeed my dictionary must be marking only the vowels where confusion can happen. I still have one word where I do have a short vowel.

This is good now!

Thanks for the work! I went through my own dictionary for these changes (Latin-French by Gaffiot & Flobert, 2001) and I have a few differences. A lot of them are vowel lengths differing. Note that sometimes, my dictionary only says that the vowel is not always long, not that it is always short.

Thanks for looking into this! The concept looks good to me and works, but it has a memory leak. The fix is easy 🙂

I rebased my branch and added a commit addressing comments: https://github.com/na-Itms/0ad/tree/sm45.

Rebased; this is a RC.

Rebased.

The code looks almost perfect to me (I had too many >> problems in the past, it became an obsession), and this works on SM38 and on SM45. Thanks a lot!

Fix an integer overflow.

Thanks for the review 🙂

I used the latest one (probably vc12) with the compiler I wanted to build the game with. Recent versions of visual studio can open slightly older solutions without issue 🙂

You were right, there are a few bogus names here! I tracked them down, they are users who deleted their Transifex account. I added a regex to remove them from the credits.

This is superseded by our new CI system which is using Docker to build the game under clang-only or gcc-only environments.

This will be useful to start supporting VS2019. I would be against updating premake if we have no bugs or missing features in our version though, because that makes heavy commits. What is your opinion? If you agree, we should wait for when we actually enable 2019, at that time maybe that will be a more recent alpha version of premake.

@elexis, in the future, if you want to manually start an autobuild, it's better to use the helper job that triggers the autobuilder. Else, that helper job will start an autobuild as planned on the next day and create an extra commit. The helper job has "timeguard" in its name. If you run a build through it, it will reset its internal state.

Oh, well, I don't know. I usually license my stuff under GPL and it would make sense to put it under GPLv2+ like most of the 0ad code. However, seeing how barebones and easy to adapt this snippet is, maybe MIT would make more sense.

Address comments and use the opportunity to test the new Jenkins setup.

@Stan The script always returns 0, which makes Jenkins not complain about anything. See for instance https://jenkins.wildfiregames.com/blue/rest/organizations/jenkins/pipelines/svn/runs/1085/nodes/46/log/?start=0.

I experimentally added this pipeline to Jenkins with the fix to arc patch, and made Phabricator run it on differentials. We'll see if there are unexpected issues. In the meantime, a few comments...

Vorbis was compiled with VS2010 and still depended on the redistributables I deleted. I upgraded and recompiled libogg and libvorbis in rP22406, which fixes the issue for me. Other libs might create the same issue if built with VS2010 still.

Thanks for the patch!

Final version currently in place on Jenkins.

In D1942#80673, @wraitii wrote:

Alright, then the release code is wrong too imo. UB shouldn't be called, for one thing, but also I worked under the assumption that m_JumpPointCache.find(passClass) would always return a valid, if empty, vector. That's what the code in the Hierarchical Pathfinder does. IMO we should change this code to initialise the jump point cache with the passibility classes, instead of doing two bounds checks.

In D1942#80633, @wraitii wrote:

Mh, this is weird. I would gladly add an "ENSURE" there that there is a possibility class for the C++ code, this means we do something differently in release and debug mode and I don't like it.

Well well well fixes always need more fixes it seems. Dead code is the worst.

Good work! I am currently testing the pipeline on the autobuilder with the following changes.

In D1935#80249, @Nescio wrote:

Then let's use š in Old Persian.
Also, could you create a page https://trac.wildfiregames.com/wiki/SpecificNames, so I could write down a few things there?

There are no rules yet. For Latin I find the diacritics for vowels pretty, and since it's a transliteration I guess we should put them. For Sanskrit I am used to ś, sh doesn't bother me though.

In D1935#80241, @Nescio wrote:

The specific names are specifically non-English, so I'm not sure that style guide would be the appropiate place. I vaguely recall @Itms stating he wanted to write a page on transliterations months ago, but undoubtedly he's busy with other things.

You can upload with Planned Changes and I'll test.

Very nice! I'm proposing the following changes. They are either changes from the scripted pipeline syntax to declarative, or improvements that we could make to the current bat script (so, not a criticism towards your work). The only bug/puzzling thing is the absence of the repo address, which makes me think like this pipeline shouldn't work? Unless you checked the repo out manually once?

This works perfectly from me now, and the code still looks good 👍 I think the build error comes from the fact that the premake change makes the pch files invalid. I should improve Jenkins so that it performs cleanups when premake scripts are touched, but this is not trivial. I have an alternative fix in mind that I am implementing these days. Anyway, thanks for the great work on this!

There is your issue. I haven't fully reviewed the rest yet.

Regardless of the future merge between runtimes and context, I think we should use persistent rooteds as little as possible, so conceptually I agree with the patch.

Thanks for the fix.

Wait for the build, but yes from me.

Let's just wait for the build to finish: spoiler alert: it will warn about the copyright years 😛

I restarted the build, let's see.

Sorry, my reproduction steps were not correct. What I actually tried was adding a char that is outside the first block (ξ, i.e. U+03BE). From my research, this doesn't fail in Atlas, but in CSimulation2::GetMapSettingsString(), so this is a SpiderMonkey bug, not related to your patch. It should be fixed later, I'll try to have a look as part of the SM update.

What Stan said, unless the complete type is actually very long (not on desktop, I can't check).

This is working on my macOS VM and on Linux, and the code looks perfect. 👍

Very nice, thanks for the work 👍