Page MenuHomeWildfire Games

Itms (Nicolas Auvray)
User

User Details

User Since
Dec 19 2016, 10:38 PM (134 w, 23 h)

Recent Activity

Today

Itms updated subscribers of rP22485: [Windows] Automated build..

@elexis, in the future, if you want to manually start an autobuild, it's better to use the helper job that triggers the autobuilder. Else, that helper job will start an autobuild as planned on the next day and create an extra commit. The helper job has "timeguard" in its name. If you run a build through it, it will reset its internal state.

Tue, Jul 16, 6:00 PM
Itms added a comment to rP18656: SpiderMonkey 38 upgrade: 02/35.

Oh, well, I don't know. I usually license my stuff under GPL and it would make sense to put it under GPLv2+ like most of the 0ad code. However, seeing how barebones and easy to adapt this snippet is, maybe MIT would make more sense.

Tue, Jul 16, 5:50 PM

Sun, Jul 14

Itms created D2078: Simplify the translations maintenance script.
Sun, Jul 14, 5:04 PM

Tue, Jul 9

Itms updated the diff for D1850: Scripting tests update.

Address comments and use the opportunity to test the new Jenkins setup.

Tue, Jul 9, 8:16 PM

Sat, Jun 29

Itms added a comment to rP22096: Improve and fix checkrefs.pl, add a readme for usage, add mod support, add….

@Stan The script always returns 0, which makes Jenkins not complain about anything. See for instance https://jenkins.wildfiregames.com/blue/rest/organizations/jenkins/pipelines/svn/runs/1085/nodes/46/log/?start=0.

Sat, Jun 29, 10:18 PM

Fri, Jun 28

Itms requested verification of rP22348: Delete old redistributables for VS 2010, and add new ones for VS 2015. Refs….

Vorbis was compiled with VS2010 and still depended on the redistributables I deleted. I upgraded and recompiled libogg and libvorbis in rP22406, which fixes the issue for me. Other libs might create the same issue if built with VS2010 still.

Fri, Jun 28, 12:40 AM
Itms committed rP22406: Update precompiled win32 libogg to 1.3.3 and libvorbis to 1.3.6, building them….
Update precompiled win32 libogg to 1.3.3 and libvorbis to 1.3.6, building them…
Fri, Jun 28, 12:37 AM

Jun 16 2019

Itms committed rP22380: Define variables before mentioning them in scripted component tests, and add a….
Define variables before mentioning them in scripted component tests, and add a…
Jun 16 2019, 10:48 PM
Itms closed D1986: simulation tests: eslint fixes for no-use-before-define.
Jun 16 2019, 10:48 PM
Itms accepted D1986: simulation tests: eslint fixes for no-use-before-define.

Thanks for the patch!

Jun 16 2019, 10:42 PM

Jun 8 2019

Itms committed rP22348: Delete old redistributables for VS 2010, and add new ones for VS 2015. Refs….
Delete old redistributables for VS 2010, and add new ones for VS 2015. Refs…
Jun 8 2019, 9:46 AM
Itms awarded D1955: Support "phenotype"-tag in VisualActor. a Like token.
Jun 8 2019, 9:25 AM

Jun 4 2019

Itms committed rP22338: Version and update the Windows autobuilder script, refs #5379..
Version and update the Windows autobuilder script, refs #5379.
Jun 4 2019, 6:48 PM
Itms closed D1909: Version and update the Windows autobuilder script.
Jun 4 2019, 6:48 PM
Itms updated the diff for D1909: Version and update the Windows autobuilder script.

Final version currently in place on Jenkins.

Jun 4 2019, 4:37 PM
Itms commandeered D1909: Version and update the Windows autobuilder script.
Jun 4 2019, 4:34 PM
Itms awarded rP22335: Improve UTF-8 character handling in Atlas a Love token.
Jun 4 2019, 11:12 AM
Itms committed rP22336: Fix a m_JumpPointCache assertion failure in debug mode, refs rP22219..
Fix a m_JumpPointCache assertion failure in debug mode, refs rP22219.
Jun 4 2019, 10:30 AM
Itms closed D1942: Fix a m_JumpPointCache assertion failure in debug mode.
Jun 4 2019, 10:30 AM
Itms accepted D1942: Fix a m_JumpPointCache assertion failure in debug mode.
Jun 4 2019, 10:27 AM

Jun 3 2019

Itms added a comment to D1942: Fix a m_JumpPointCache assertion failure in debug mode.

Alright, then the release code is wrong too imo. UB shouldn't be called, for one thing, but also I worked under the assumption that m_JumpPointCache.find(passClass) would always return a valid, if empty, vector. That's what the code in the Hierarchical Pathfinder does. IMO we should change this code to initialise the jump point cache with the passibility classes, instead of doing two bounds checks.

Jun 3 2019, 10:08 AM

Jun 2 2019

Itms added a comment to D1942: Fix a m_JumpPointCache assertion failure in debug mode.

Mh, this is weird. I would gladly add an "ENSURE" there that there is a possibility class for the C++ code, this means we do something differently in release and debug mode and I don't like it.

Jun 2 2019, 10:11 PM
Itms added inline comments to D1909: Version and update the Windows autobuilder script.
Jun 2 2019, 9:53 PM
Itms added inline comments to D1942: Fix a m_JumpPointCache assertion failure in debug mode.
Jun 2 2019, 3:44 PM
Itms added inline comments to D1942: Fix a m_JumpPointCache assertion failure in debug mode.
Jun 2 2019, 3:23 PM
Itms requested changes to D1942: Fix a m_JumpPointCache assertion failure in debug mode.

Well well well fixes always need more fixes it seems. Dead code is the worst.

Jun 2 2019, 3:02 PM
Itms added a comment to D1909: Version and update the Windows autobuilder script.

Good work! I am currently testing the pipeline on the autobuilder with the following changes.

Jun 2 2019, 8:40 AM

May 31 2019

Itms added a comment to D1935: Anatolian → Lydian; correct Persian specific names.
In D1935#80249, @Nescio wrote:

Then let's use š in Old Persian.
Also, could you create a page https://trac.wildfiregames.com/wiki/SpecificNames, so I could write down a few things there?

May 31 2019, 1:17 PM
Itms added a comment to D1935: Anatolian → Lydian; correct Persian specific names.

There are no rules yet. For Latin I find the diacritics for vowels pretty, and since it's a transliteration I guess we should put them. For Sanskrit I am used to ś, sh doesn't bother me though.

May 31 2019, 12:47 PM
Itms added a comment to D1935: Anatolian → Lydian; correct Persian specific names.
In D1935#80241, @Nescio wrote:

The specific names are specifically non-English, so I'm not sure that style guide would be the appropiate place. I vaguely recall @Itms stating he wanted to write a page on transliterations months ago, but undoubtedly he's busy with other things.

May 31 2019, 12:29 PM
Itms added a comment to D1909: Version and update the Windows autobuilder script.

You can upload with Planned Changes and I'll test.

May 31 2019, 7:27 AM

May 30 2019

Itms added inline comments to D1909: Version and update the Windows autobuilder script.
May 30 2019, 10:14 PM
Itms added inline comments to D1910: Version the GCC Jenkins scripts.
May 30 2019, 8:52 PM

May 29 2019

Itms requested changes to D1909: Version and update the Windows autobuilder script.

Very nice! I'm proposing the following changes. They are either changes from the scripted pipeline syntax to declarative, or improvements that we could make to the current bat script (so, not a criticism towards your work). The only bug/puzzling thing is the absence of the repo address, which makes me think like this pipeline shouldn't work? Unless you checked the repo out manually once?

May 29 2019, 9:14 PM

May 28 2019

Itms accepted D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.

This works perfectly from me now, and the code still looks good 👍 I think the build error comes from the fact that the premake change makes the pch files invalid. I should improve Jenkins so that it performs cleanups when premake scripts are touched, but this is not trivial. I have an alternative fix in mind that I am implementing these days. Anyway, thanks for the great work on this!

May 28 2019, 7:16 PM

May 26 2019

Itms requested changes to D1835: Hierarchical Pathfinder - Add Global Regions / Optimise MakeGoalReachable (D53 outtake).

There is your issue. I haven't fully reviewed the rest yet.

May 26 2019, 2:57 PM
Itms added a comment to D1700: Use JS::Heap instead of JS::PersistentRooted to fix IGUIObject memory leak in rP5154.

Regardless of the future merge between runtimes and context, I think we should use persistent rooteds as little as possible, so conceptually I agree with the patch.

May 26 2019, 2:23 PM

May 25 2019

Itms accepted rP22225: Fix D1491 which introduced an ENSURE that should not have been there..

Thanks for the fix.

May 25 2019, 6:07 PM
Itms accepted D1875: JPS - make the JPC cache usable again (rP22225 fix).

Wait for the build, but yes from me.

May 25 2019, 5:21 PM
Itms accepted D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

Let's just wait for the build to finish: spoiler alert: it will warn about the copyright years 😛

May 25 2019, 5:19 PM
Itms added inline comments to D1875: JPS - make the JPC cache usable again (rP22225 fix).
May 25 2019, 5:04 PM
Itms added inline comments to D1875: JPS - make the JPC cache usable again (rP22225 fix).
May 25 2019, 4:42 PM
Itms added a comment to D1835: Hierarchical Pathfinder - Add Global Regions / Optimise MakeGoalReachable (D53 outtake).

I restarted the build, let's see.

May 25 2019, 11:55 AM
Itms added a reviewer for D1829: Fix Pathgoal::RectContainsGoal family of function for SQUARE goals, reduce ambiguities, improve coherence among the different functions.: Itms.
May 25 2019, 11:53 AM
Itms requested changes to D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.

Sorry, my reproduction steps were not correct. What I actually tried was adding a char that is outside the first block (ξ, i.e. U+03BE). From my research, this doesn't fail in Atlas, but in CSimulation2::GetMapSettingsString(), so this is a SpiderMonkey bug, not related to your patch. It should be fixed later, I'll try to have a look as part of the SM update.

May 25 2019, 11:52 AM
Itms added a comment to D1875: JPS - make the JPC cache usable again (rP22225 fix).

What Stan said, unless the complete type is actually very long (not on desktop, I can't check).

May 25 2019, 10:10 AM

May 23 2019

Itms accepted D1611: Use pkg-config instead of hard-coding or library-specific programs.

This is working on my macOS VM and on Linux, and the code looks perfect. 👍

May 23 2019, 10:57 PM

May 21 2019

Itms committed rDD2a0785d71397: Replace non-breaking space with normal space. (authored by Nescio).
Replace non-breaking space with normal space.
May 21 2019, 9:41 PM
Itms closed D1913: DD: replace non-breaking space with normal space.
May 21 2019, 9:41 PM
Itms accepted D1913: DD: replace non-breaking space with normal space.

Very nice, thanks for the work 👍

May 21 2019, 9:36 PM
Itms accepted D1747: Add a build flag to prefer locally-built libraries..
May 21 2019, 8:37 PM
Itms accepted D1747: Add a build flag to prefer locally-built libraries..

With three small improvements/cleanups, this looks good to me. You can fix them and then commit. 👍

May 21 2019, 8:34 PM
Itms updated subscribers of D1611: Use pkg-config instead of hard-coding or library-specific programs.

@wraitii Would you have time to test this on a mac?

May 21 2019, 8:13 PM
Itms requested changes to D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.

Thanks again for the patch, now I finally have some time to dedicate to it!

May 21 2019, 7:58 PM
Itms requested changes to D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

Ah actually yes, I agree with elexis. EntityExists is better. Something bugged me about the name and I couldn't pinpoint what.

May 21 2019, 7:19 PM
Itms accepted D1736: Early-exit when destroying invalid entities (INVALID_ENTITY, already destroyed…).

I just did some quick profiling on the patch. I don't see any difference between patched and unpatched versions on "Combat demo (huge)", so the perf gain is probably minimal. It's not bad to have it in though, and the new method might be useful in the future.

May 21 2019, 6:51 PM
Itms added a member for Contributors: Crynux.
May 21 2019, 5:21 PM
wraitii awarded D1910: Version the GCC Jenkins scripts a Party Time token.
May 21 2019, 8:08 AM

May 20 2019

Itms created D1910: Version the GCC Jenkins scripts.
May 20 2019, 8:48 PM
Itms added a comment to D1909: Version and update the Windows autobuilder script.

@Angen Marking for you the places where the scripts are actually cut on Jenkins.

May 20 2019, 8:34 PM

May 19 2019

Itms created D1909: Version and update the Windows autobuilder script.
May 19 2019, 8:58 PM
Itms added inline comments to D1850: Scripting tests update.
May 19 2019, 12:00 PM
Itms added inline comments to D1850: Scripting tests update.
May 19 2019, 11:50 AM
Itms added a comment to D1844: Improvements to simulation hotloading before the SM upgrade.

If you have five minutes I really think you could be interested in that code, especially the comments in c44465f2a483, and how it actually not ignores the permanent property in general but only in a very specific case.

May 19 2019, 11:46 AM
Itms added inline comments to D1850: Scripting tests update.
May 19 2019, 11:01 AM
Itms added a comment to D1844: Improvements to simulation hotloading before the SM upgrade.

One thing I'm curious about: there is no way for C++ code to delete a "PERMANENT" property? That seems dubious.
Looking at properties, it appears SM38 has "IGNORE_PERMANENT" attributes: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_Reference/Property_attributes
This seems like the kind of thing we should use here, and we can still make these globals permanent.

May 19 2019, 11:00 AM
Itms added inline comments to D1850: Scripting tests update.
May 19 2019, 10:52 AM
Itms added a comment to D1850: Scripting tests update.

I'm assuming this is post SM45 ?

May 19 2019, 10:38 AM

May 8 2019

Itms accepted rP22247: Slight cleanup of fogging OnDestroy and some comments.
May 8 2019, 9:55 PM
Itms added a comment to D1864: Fix warning introduced in the mirage cleanup, rP22247.

Ha I was testing and I can't accept now, but it's fine for me 👍

May 8 2019, 9:55 PM
Itms added a comment to D1864: Fix warning introduced in the mirage cleanup, rP22247.

Yeah as long as we don't need to break out of the loop, forEach is fine. I don't see a real need for it here, but if it's more to your tastes, why not. It's just lengthening the verification of the fix a bit, because it makes it less trivial 😊

May 8 2019, 6:50 PM
Itms added a comment to D1871: Make rasterisation strictly more permissive than real static obstruction shapes (alternative take on D1869).

I agree that this looks nice at first sight. I just followed Philip's concept regarding clearance, and then did some tuning to reduce the number of stuck units... This should be tested a lot but I don't see any conceptual issues with this.

May 8 2019, 6:34 PM
Itms added a comment to rDDbbca74824ec0: Complete the Kushite page..

Hi! Thanks for the input @Nescio. The DD is still a very experimental WIP but if you want to collaborate with Dok you are most welcome. It is located here on Phabricator: rDD. I am adding you to the group which can see differentials related to the DD.

May 8 2019, 11:16 AM
Itms updated subscribers of D1864: Fix warning introduced in the mirage cleanup, rP22247.
May 8 2019, 11:06 AM
Itms requested changes to D1864: Fix warning introduced in the mirage cleanup, rP22247.

As detected by the linter, you should use return and not continue in a function. The current code doesn't even parse.

May 8 2019, 11:05 AM

May 7 2019

Itms added a comment to rP22247: Slight cleanup of fogging OnDestroy and some comments.
In rP22247#33237, @Stan wrote:

I guess we only need +player on 202 that's where the warning comes from.

May 7 2019, 10:35 PM
Itms added a comment to rP22247: Slight cleanup of fogging OnDestroy and some comments.

I think it would be better to revert to the original for style like Polakrity suggests. for...in is better suited for dictionaries, and adding a + everywhere player is used in that function sounds like a pain and people might make the mistake again.

May 7 2019, 9:24 PM

May 2 2019

Itms committed rDDe55be1dd1bd7: Kushites page for the Design Document. (authored by Itms).
Kushites page for the Design Document.
May 2 2019, 8:08 AM

Apr 28 2019

Itms added inline comments to D14: Thread the pathfinder computations.
Apr 28 2019, 6:30 PM
Itms added a comment to D14: Thread the pathfinder computations.

UGH why can't it display the test results. Back to you.

Apr 28 2019, 6:24 PM
Itms added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.

Ah of course. I thought the (3) was about this patch specifically.

Apr 28 2019, 6:11 PM
Itms added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.

For tens of months before being banned, on a regular basis, unhelpful comments in the fashion of "there is a defect, I'm not helping you further" were made. Even if leper was allowed to answer here, he wouldn't (except if he has changed since then).

Apr 28 2019, 12:43 PM
Itms added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.

Sorry, which 3?

Apr 28 2019, 12:11 PM
Itms added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.
In D1754#76520, @Stan wrote:

She added: "Itms president !"

Apr 28 2019, 11:45 AM
Itms added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.

Well I agreed with all points of this patch, and I just looked for other possible uses of the new SendEventToAll and found none that relied on this workaround. It's possible that the code can be used in another place that we didn't see (in which case we'd only loose the opportunity to fix it sooner), but it seems incorrect that the patch "misses something".

Apr 28 2019, 11:18 AM

Apr 27 2019

Itms updated the diff for D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.

This is the patch rebased and with the second arguments renamed to data.

Apr 27 2019, 11:58 PM
Itms reclaimed D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.
Apr 27 2019, 11:56 PM
Itms commandeered D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.

I understand the feeling, but unfortunately we can do nothing except keeping developing the game with everything that we have and that we can actually access. Your work is certainly not crap (quite the opposite), your contributions and the ones from fellow WFG members are enough to keep creating 0 A.D. 🙂 Chin up! 💪

Apr 27 2019, 11:56 PM
Itms updated the diff for D1844: Improvements to simulation hotloading before the SM upgrade.

This is the version of the patch where I make all globals hotloadable. I also reverted currentlyHotloading to replace in order to make the script interface agnostic of the hotloading concept.

Apr 27 2019, 11:47 PM
Itms added a comment to D1737: Slight cleanup of fogging OnDestroy and some comments.

@bb Could you create a ticket for that? It sounds like we should indeed take a look at this and make the use of OwnershipChanged over Destroy consistent, and put explicit comments where one is needed over the other. 👍

Apr 27 2019, 11:41 PM
Itms created D1850: Scripting tests update.
Apr 27 2019, 11:38 PM
Itms accepted D1737: Slight cleanup of fogging OnDestroy and some comments.

Thanks for performing the changes and sorry for not going back on this immediately. I agree with the merging of the functions, because we indeed often use OwnershipChanged for gameplay stuff whereas Destroy is seen as a rather low-level message. Additionally it's always better to associate miraging code with ownership concepts.

Apr 27 2019, 11:30 PM
Itms added a comment to rP22159: [i18n] Updated POT and PO files..

Thanks for clarifying the report 😉 I'm fixing it on Transifex.

Apr 27 2019, 11:08 PM
Itms added a comment to D1844: Improvements to simulation hotloading before the SM upgrade.
In D1844#76466, @elexis wrote:

But hotloading in the simulation context means something different in the GUI context. In the GUI context one can be hotloading currently but it doesn't matter whether hotloadable is set to true or false?
And some caller other than the ComponentManager may need to replace somehow constant globals without being in hotloading context.
To me it seems like a https://en.wikipedia.org/wiki/Separation_of_concerns issue if the hotloading isn't shown to be (1) universally applicable to any hotloading mechanism and (2) no other mechanism wants to trigger the code flow that hotloadable triggers.

Apr 27 2019, 8:34 PM
Itms added a comment to D1844: Improvements to simulation hotloading before the SM upgrade.
In D1844#76445, @elexis wrote:
  1. If I understand correctly, the SetGlobal hotloading mechanism is only relevant to the simulation, yes?
Apr 27 2019, 6:28 PM
Itms planned changes to D1844: Improvements to simulation hotloading before the SM upgrade.

Thanks a lot for the input! I pondered a long time with the question of whether SetGlobal should get this or that parameter while writing the patch. Based on the comments I'll remove one of the parameters, which will make the patch a bit more simple.

Apr 27 2019, 11:34 AM

Apr 25 2019

Itms added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.
In D1754#76083, @elexis wrote:

(Also am I the only one using libboost 1.69.0-2 or am I just the only one too stupid to resolve the build errors? I better get them resolved if I want to commit my own patches)

Apr 25 2019, 7:44 PM
Itms raised a concern with rP22225: Fix D1491 which introduced an ENSURE that should not have been there..

This is removing state.jpc = m_JumpPointCache[passClass].get(); when it != m_JumpPointCache.end(), no?

Apr 25 2019, 9:15 AM

Apr 24 2019

Itms added inline comments to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.
Apr 24 2019, 10:49 PM
Itms added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.

This looks very good to me, and it works both on SM38 and SM45.

Apr 24 2019, 10:32 PM