Remove unnecessary argument of Pack-timer.
ClosedPublic
Actions

Authored by Freagarach on Mar 26 2020, 8:09 PM.

Details

Reviewers

Silier

Commits

rP23557: Remove unnecessary arguments in Pack.js

Summary

In (and unused) since its introduction: rP12904.

Test Plan

Verify the argument is indeed unused.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 11339
Build 20512: Vulcan Build	Jenkins
Build 20511: Vulcan Build (macOS)	Jenkins
Build 20510: Vulcan Build (Windows)	Jenkins
Build 20509: arc lint + arc unit

Event Timeline

Freagarach created this revision.Mar 26 2020, 8:09 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1923/display/redirect

Harbormaster completed remote builds in B11339: Diff 11568.Mar 26 2020, 8:13 PM

Freagarach edited the summary of this revision. (Show Details)Mar 26 2020, 8:27 PM

Nice catch :)

binaries/data/mods/public/simulation/components/Pack.js
64	btw, could you remove last `"packing"` please ?

Also remove duplicate/depraced "pack" in SetAnimation.
Missed in rP21359.

Freagarach marked an inline comment as done.Mar 26 2020, 10:38 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1927/display/redirect

Harbormaster completed remote builds in B11345: Diff 11574.Mar 26 2020, 10:41 PM

data passed inside timer are not used so removal is ok and it eliminates object creation.
SelecAnimation takes only 3 parameters DEFINE_INTERFACE_METHOD_3("SelectAnimation", void, ICmpVisual, SelectAnimation, std::string, bool, fixed)

This revision is now accepted and ready to land.Mar 26 2020, 10:53 PM

Freagarach edited the summary of this revision. (Show Details)Mar 27 2020, 8:20 AM

Freagarach edited the test plan for this revision. (Show Details)

Closed by commit rP23557: Remove unnecessary arguments in Pack.js (authored by Silier). · Explain WhyMar 27 2020, 9:00 PM

This revision was automatically updated to reflect the committed changes.

Silier added a commit: rP23557: Remove unnecessary arguments in Pack.js.

Thanks for the commit @Angen :)