Diffusion 0 A.D. Public Repository rP11444

Added deep forest map by FeXoR. Fixes #1287.
rP11444
Actions

Tags

None

Subscribers

Description

Added deep forest map by FeXoR. Fixes #1287.

Details

Committed

Apr 6 2012, 9:15 PM

Parents

rP11443: Use grayscale option instead of grayscaled icons

Branches

Unknown

Tags

Unknown

Event Timeline

quantumstate committed rP11444: Added deep forest map by FeXoR. Fixes #1287..Apr 6 2012, 9:15 PM

elexis raised a concern with this commit.Nov 15 2017, 6:42 PM

elexis added a subscriber: elexis.

elexis added inline comments.

/ps/trunk/binaries/data/mods/public/maps/random/deep_forest.js
52	As determined by the name and value, there are 5 tiles at the map border that do not count as 'playable'. This should use the global constant we have for this whose actual value is 3, so that if we ever intend to change the number or mechanism of impassable map border tiles, we only have to do it in one place (or can find it quickly for all maps if we want to set it to 0 / remove it). See #4814. The same code was copied to Schwarzwald in rP15327 and has the same problem.

This commit now has outstanding concerns.Nov 15 2017, 6:42 PM

elexis mentioned this in rP15327: Schwarzwald random map. Script by niektb, with random terrain generation from….Nov 15 2017, 6:43 PM

elexis mentioned this in rP20472: On both Deep Forest (rP11444) and Schwarzwald (rP15327) random maps, replace….Nov 17 2017, 5:09 PM

Fixed in the commit above. Didn't read the rest of the map yet, but there are some things that can be done afaics.

This commit no longer requires audit.Nov 17 2017, 5:10 PM

elexis mentioned this in rP20879: Extract a RandomPathPlacer prototype from Deep Forest (rP11444) and Schwarzwald….Jan 16 2018, 5:12 AM

elexis mentioned this in rP21078: On DeepForest and Schwarzwald, don't abuse the RectPlacer (nor formally….Jan 30 2018, 11:13 PM

Changes (2)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

maps/

random/

deep_forest.json

rP11444

ps/trunk/binaries/data/mods/public/maps/random/deep_forest.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/deep_forest.json

Loading...