Page MenuHomeWildfire Games

Ptolemy catapult packing entity
ClosedPublic

Authored by temple on Nov 13 2017, 5:59 PM.

Details

Summary

Came across this weird situation a couple weeks ago:

What happened was one of the catapults had unpacked/repacked, which turned it into a Macedonian catapult!

Test Plan

I glanced quickly at the other packed/unpacked templates, they seem to be okay.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

temple created this revision.Nov 13 2017, 5:59 PM
mimo accepted this revision.Nov 13 2017, 6:25 PM
mimo added a subscriber: mimo.

nice catch!

This revision is now accepted and ready to land.Nov 13 2017, 6:25 PM
This revision was automatically updated to reflect the committed changes.
elexis added a subscriber: elexis.Nov 13 2017, 7:10 PM

Issue introduced by rP15467.
(One could look whether there are similar issues in the same commit or other templates or alternatively do something more useful in the same time.)
(temple you already came across svn blame (and possibly the according web GUI on trac and phabricator for that)?)
(With regards to the screenshots, enabling the "water effects" setting while disabling the other water settings seems to be the best cost/use ratio)

In D1032#40581, @elexis wrote:

Issue introduced by rP15467.
(One could look whether there are similar issues in the same commit or other templates or alternatively do something more useful in the same time.)
(temple you already came across svn blame (and possibly the according web GUI on trac and phabricator for that)?)

Sometimes I go in depth and look at all that stuff, and other times I just do a quick fix. This was a quick fix.
Issue was actually introduced in rP13905. And glancing briefly, it looks like SelectionGroupName for some walls is wrong. I'll look closer when I have time.

(With regards to the screenshots, enabling the "water effects" setting while disabling the other water settings seems to be the best cost/use ratio)

I'll try it, thanks.