Page MenuHomeWildfire Games

mimo (mimo)
User

Projects

User Details

User Since
Dec 22 2016, 7:21 PM (139 w, 17 h)

Recent Activity

May 31 2019

mimo added a comment to rP21751: petra: allow the ai to use ranges for mod who support them, and add Archery….

Just a hint: what was the only stable in game at that time? was it a barracks?
Then if people had commited (without any review) inconsistent stable templates, i would not have expected petra to create some hacky code to support them in the future, but to first make all templates consistent. It seems that this took 1 year.

May 31 2019, 9:44 PM
mimo added a comment to rP21751: petra: allow the ai to use ranges for mod who support them, and add Archery….

Could you explain what is the point of raising a concern on a commit when the problem is created by a posterior commit? maybe just give some feeling of activity?

May 31 2019, 8:15 PM

Apr 28 2019

mimo added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.

I meant that from what i witnessed, i would never have expected such a ban.

Apr 28 2019, 2:55 PM
mimo added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.
In D1754#76534, @elexis wrote:

mimo if I call your work crap without having seen it or knowning what it is about and you wouldn't like that, does that mean you just can't stand my criticism?

Apr 28 2019, 1:14 PM
mimo added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.
In D1754#76533, @Itms wrote:

I'm sorry if I hurt someone's feelings while trying to cheer up and encourage people who are still at WFG. I'll try to be more vigilant about how I appear, but I really mean what I said and I can't be too hypocritical about how I truly feel. Apparently you can't restrain yourself from insulting people either, so you must understand me.

Apr 28 2019, 1:04 PM
mimo added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.
In D1754#76519, @Itms wrote:

This vague allegation should not block us from progressing. Unhelpful and rude remarks about our work were the reason he was banned in the first place. Saying there is a defect and refusing to point it out is childish at best. The assumption that we would have to re-re-release A23 was (is?) a similar kind of bullcrap, and thankfully we didn't wait for them to reveal The Secret (tm) to release.

Apr 28 2019, 12:23 PM

May 3 2018

mimo added a comment to D1461: Hint the location for "You have been attacked" notifications.

The button looks fine to me, but i'd rather put it after the "you've been attacked" message, possibly with some help text, for example "click to go there" as new players may not guess what is its use. Other alternatives would be to add an explicit icon (but looks really small) or at the very least a tooltip to that button.

May 3 2018, 7:23 PM

Apr 30 2018

mimo accepted rP21624: Fix mirages (and any other entity that blocks something but not….

tested rP21810 and works as expected

Apr 30 2018, 10:09 PM
mimo added a comment to rP21624: Fix mirages (and any other entity that blocks something but not….

Yep, i've just tested the patch and it works as expected. I don't have in mind any other template which could have that problems.
By the way, i've seen that problem (and used also for checking the patch) on wild lake random map. There are so much fishes on that map that it's ideal for testing that patch, but i don't think that is what was wanted. Maybe something to fix in that map for a24?

Apr 30 2018, 12:09 AM

Apr 29 2018

mimo raised a concern with rP21624: Fix mirages (and any other entity that blocks something but not….

Same problem still happen for dock foundations when placed above fishes.

Apr 29 2018, 10:57 PM
mimo added a comment to D1475: Add mod/engine version check workaround for persist-match-settings.

I did some basic tests, and works as expected. Thanks.

Apr 29 2018, 4:14 PM
mimo awarded D1475: Add mod/engine version check workaround for persist-match-settings a Like token.
Apr 29 2018, 4:13 PM
mimo committed rP21800: few templates fixes.
few templates fixes
Apr 29 2018, 10:57 AM
mimo closed D1477: few templates fixes.
Apr 29 2018, 10:57 AM
mimo created D1477: few templates fixes.
Apr 29 2018, 10:51 AM

Apr 28 2018

mimo committed rP21796: fix kush walls SelectionGroupname.
fix kush walls SelectionGroupname
Apr 28 2018, 11:37 AM
mimo committed rP21795: Ptol catapults should unpack to ptol catapults, not mace catapults.
Ptol catapults should unpack to ptol catapults, not mace catapults
Apr 28 2018, 11:31 AM
mimo closed D1474: Ptol catapults should unpack to ptol catapults, not mace catapults.
Apr 28 2018, 11:31 AM
mimo accepted D1474: Ptol catapults should unpack to ptol catapults, not mace catapults.

Thanks for spliting the uncontroversial part.

Apr 28 2018, 11:25 AM

Apr 27 2018

mimo committed rP21792: fixes a few templates.
fixes a few templates
Apr 27 2018, 11:54 PM
mimo added a comment to D1473: Add SelectionGroupNames for siege engines.

I've noticed that all 3 kush walls also have a wrong SelectionGroupName (either ptol or mace). That could be added to that patch.
Otherwise, I've no real preference on elexis' question,

Apr 27 2018, 6:46 PM

Apr 26 2018

mimo added a comment to rP21784: Fix a couple of packing problems from rP21630.
In rP21784#30460, @mimo wrote:

This commit make things worse for packing units in attack-move (as explained several times in D1458, if they are now in standground stance, it is for a reason).

It doesn't make them worse because in a22 every unit (except packable units) in standground would chase in attack-move, and now packable units will also chase (the point of your original commit was to remove the inconsistencies with packable units) rather than being bugged.

But as it seems that now, the new rule is to commit patches without acceptation,

You said

I agree with temple proposition in rP21630 (switching the order of the standground check and the pack)

and

That said, having the canPack at the place you mention seems to be useful to avoid units to be stuck.

which sounded to me like you agreed with the changes I made.
I didn't say "Reviewed by mimo" because you didn't official accept them, but still.

Apr 26 2018, 7:48 PM
mimo added a comment to rP21786: really fix packing problems reported in rP21630.

This doesn't really have much to do about packing or rP21630, it's changing the attack-move sub-orders from forced to not forced so units won't chase targets anymore.

Apr 26 2018, 7:43 PM
mimo added a comment to rP21784: Fix a couple of packing problems from rP21630.

This commit make things worse for packing units in attack-move (as explained several times in D1458, if they are now in standground stance, it is for a reason). But as it seems that now, the new rule is to commit patches without acceptation, i've done the same and committed my own fix in rP21786.

Apr 26 2018, 6:50 PM
mimo committed rP21786: really fix packing problems reported in rP21630.
really fix packing problems reported in rP21630
Apr 26 2018, 6:50 PM

Apr 23 2018

mimo added a comment to D1458: fix packing problems reported in rP21630.
In D1458#60068, @temple wrote:
In D1458#60001, @mimo wrote:
In D1458#59987, @temple wrote:

This seems to solve the chase problem for siege? (And attack-move changes can be saved for a24.)

Not really, that would make the siege to chase, but that's an unwanted behavior as its default stance is standground. When attack-move with catapults, you don't want them to chase any nearby units (which are much faster than them) but rather bomb anything on their route. Once again, the root of the problem is that the Attack suborder of a move-attack is considered as force=true while it should be force=false so to behave as expected from its stance.
That said, having the canPack at the place you mention seems to be useful to avoid units to be stuck.

In a22 non-packable standground units do chase, so I think we should keep force=true for a23 anyway.

Apr 23 2018, 11:00 PM
mimo committed rP21773: petra: small tweak for civs without field.
petra: small tweak for civs without field
Apr 23 2018, 10:30 PM
mimo added a comment to D1458: fix packing problems reported in rP21630.
In D1458#59987, @temple wrote:

This seems to solve the chase problem for siege? (And attack-move changes can be saved for a24.)

Apr 23 2018, 11:40 AM

Apr 22 2018

mimo committed rP21758: petra: make some use of mobile dropsites.
petra: make some use of mobile dropsites
Apr 22 2018, 7:00 PM
mimo committed rP21757: petra: support upgrade from one garrisonable structure to one non-garrisonable.
petra: support upgrade from one garrisonable structure to one non-garrisonable
Apr 22 2018, 6:52 PM
mimo committed rP21753: petra: improve mod support by allowing civs to build corrals when they can't….
petra: improve mod support by allowing civs to build corrals when they can't…
Apr 22 2018, 12:16 AM

Apr 21 2018

mimo added a comment to D1458: fix packing problems reported in rP21630.
In D1458#59893, @temple wrote:
In D1458#59879, @mimo wrote:
In D1458#59831, @temple wrote:

Then you (or somebody else) has to accept the patch, as simple as that. I also don't have time nor interest to discuss further the way stances should work in attack-move, so if anybody is interested, he should commandeer this patch, otherwise i'm fine with the first version and will commit it when accepted.

I accept moving the pack lines, I don't accept changing the attack-move behavior.

Apr 21 2018, 8:55 PM
mimo committed rP21752: remove debug printout forgotten in rP21751.
remove debug printout forgotten in rP21751
Apr 21 2018, 2:08 PM
mimo committed rP21751: petra: allow the ai to use ranges for mod who support them, and add Archery….
petra: allow the ai to use ranges for mod who support them, and add Archery…
Apr 21 2018, 1:56 PM
mimo added a comment to D1458: fix packing problems reported in rP21630.
In D1458#59831, @temple wrote:

The packing bug should be fixed in any case. (I'm not interested in taking this over or making decisions on how stances should behave.)

Apr 21 2018, 1:46 PM

Apr 20 2018

mimo committed rP21749: petra cleanup.
petra cleanup
Apr 20 2018, 5:36 PM
mimo committed rP21748: petra: fix for civs which do not have support worker units (as xiongnu in….
petra: fix for civs which do not have support worker units (as xiongnu in…
Apr 20 2018, 5:01 PM
mimo abandoned D1458: fix packing problems reported in rP21630.

Before that patch, all stances would be nearly equivalent in attack-move as all orders were treated as forced, which has precedence on stance.
Now, we have quite different behaviors and choosing different stances has some consequences, so that's fine with me and i cannot say better than "commandeer the patch and commit the version you like more" (i don't really mind, and you can consider it as accepted by me as I wrote it).

Apr 20 2018, 4:47 PM

Apr 19 2018

mimo added a comment to D1458: fix packing problems reported in rP21630.
In D1458#59700, @temple wrote:
In D1458#59699, @mimo wrote:

How should standground behave?

Apr 19 2018, 8:50 PM
mimo committed rP21746: further increase the training and building time of AI by 10% in easier levels….
further increase the training and building time of AI by 10% in easier levels…
Apr 19 2018, 7:17 PM
mimo added a comment to D1458: fix packing problems reported in rP21630.

In fact, on second thought, i'd prefer the previous version: when in defense stance with attack-move, it means that you want to defend something around the position you give and it makes sense to start the real attack-move only when you are around that position, otherwise you'd better choose the aggressive stance.

Apr 19 2018, 7:11 PM
mimo committed rP21745: petra: improve sorting of resources according to the needs..
petra: improve sorting of resources according to the needs.
Apr 19 2018, 5:30 PM
mimo updated the diff for D1458: fix packing problems reported in rP21630.

update patch

Apr 19 2018, 5:23 PM
mimo added a comment to D1458: fix packing problems reported in rP21630.

Good catch, but that's rather a walk-and-fight definition: if in defensive mode, it may be wanted that the attack-move only starts when around the target (otherwise why choosing that defensive stance?).
But i'm also aware that this is not necessary the expected behaviour. If the expected behaviour is a "standard" attack-move, the fix is to set the current position as heldPosition when searching for new targets (as done in the new version of the patch).

Apr 19 2018, 4:41 PM
mimo committed rP21744: Attacks resulting from a gathering order on an animal should be considered….
Attacks resulting from a gathering order on an animal should be considered…
Apr 19 2018, 4:21 PM
mimo closed D1457: Attacks resulting from a gathering order on an animal should be considered forced or not consistently with the original gather order.
Apr 19 2018, 4:21 PM
mimo added a comment to D1457: Attacks resulting from a gathering order on an animal should be considered forced or not consistently with the original gather order.
In D1457#59651, @temple wrote:

Forced orders never abandon chase, so it works for the first attack. Doesn't work for later attacks when they have to chase since the held position is still back at home, but that happens for regular attacks too.

Apr 19 2018, 4:17 PM

Apr 18 2018

mimo created D1458: fix packing problems reported in rP21630.
Apr 18 2018, 5:50 PM
mimo created D1457: Attacks resulting from a gathering order on an animal should be considered forced or not consistently with the original gather order.
Apr 18 2018, 5:21 PM

Apr 14 2018

mimo committed rP21717: Fix stats of peak percentage of map controlled.
Fix stats of peak percentage of map controlled
Apr 14 2018, 11:43 AM
mimo closed D1294: Fix stats of peak percentage of map controlled.
Apr 14 2018, 11:43 AM
mimo committed rP21716: petra: fix case of messed up accessibility in dock placement when too nearby….
petra: fix case of messed up accessibility in dock placement when too nearby…
Apr 14 2018, 11:39 AM
mimo added a comment to D1294: Fix stats of peak percentage of map controlled.
In D1294#59071, @bb wrote:

New code looks much simpler and less error prone
the elexis comment seems simple enough => accept

Apr 14 2018, 11:26 AM

Apr 12 2018

mimo committed rP21707: continuation of r21706.
continuation of r21706
Apr 12 2018, 7:19 PM
mimo committed rP21706: petra: internal renaming to follow the GameType -> VictoryConditions change in….
petra: internal renaming to follow the GameType -> VictoryConditions change in…
Apr 12 2018, 7:18 PM
mimo committed rP21705: petra: fix an error when an attacker was killed and moved outOfWorld.
petra: fix an error when an attacker was killed and moved outOfWorld
Apr 12 2018, 6:32 PM

Apr 11 2018

mimo committed rP21698: fix an oversight in rP21697.
fix an oversight in rP21697
Apr 11 2018, 10:34 PM
mimo committed rP21697: petra: cancel guard assignation when relic lost.
petra: cancel guard assignation when relic lost
Apr 11 2018, 10:31 PM
mimo added a comment to D1433: Remove Gamesetup.cpp readme.txt duplication.
In D1433#58973, @elexis wrote:

To me the objective was to remove the duplication, which is not easily achievable when we want to implement a CLI help and keep a readme.txt.

Apr 11 2018, 8:06 PM
mimo committed rP21695: petra: fix some defensive tweaks not applied in easier levels.
petra: fix some defensive tweaks not applied in easier levels
Apr 11 2018, 7:56 PM
mimo added a comment to D1433: Remove Gamesetup.cpp readme.txt duplication.
In D1433#58958, @elexis wrote:
In D1433#58512, @mimo wrote:

also developper :) usually i use that doc when i try to modify the Gamesetup.cpp file, it is much simpler to have it there than having to go through the directory hierarchy to find the readme.txt

Since the exact filepath is printed there, one doesn't have to type anything besides the fileviewer program, for instance gedit ctrl+v at worst (when using an IDE like eclipse it may only be ctrl+R + ctrl+V).
If the effort argument is true, then we could copy many things to many places leading to the duplication pattern problems.
For instance the other commandline options explained in readme.txt could be copied to the other files where the commandline options are implemented, resulting in even more files to keep in sync.
When exactly is the less-effort use case met?
When wanting to use the binary without reading or changing Gamesetup.cpp, the effort to open the readme and Gamesetup.cpp file are identical.
When wanting to extend Gamesetup.cpp, one has to change readme.txt too.
When wanting to modify but not extend Gamesetup.cpp, one has the name of the broken property already given.
I can abandon this without being convinced by the presented arguments however.

Apr 11 2018, 7:44 PM

Apr 9 2018

elexis awarded rP21685: Give capturePoints of defeated Players to gaia a Pirate Logo token.
Apr 9 2018, 7:54 PM
mimo added a comment to D1444: Give capturePoints of defeated Players to gaia.

Thanks for the review.

Apr 9 2018, 7:12 PM
mimo committed rP21685: Give capturePoints of defeated Players to gaia.
Give capturePoints of defeated Players to gaia
Apr 9 2018, 7:04 PM
mimo closed D1444: Give capturePoints of defeated Players to gaia.
Apr 9 2018, 7:04 PM
mimo added a comment to D1441: Fix Fsm error message when a guard ent is killed.

Thanks for the review.

Apr 9 2018, 6:44 PM
mimo committed rP21682: Fix Fsm error message when a guard ent is killed.
Fix Fsm error message when a guard ent is killed
Apr 9 2018, 6:37 PM
mimo closed D1441: Fix Fsm error message when a guard ent is killed.
Apr 9 2018, 6:37 PM

Apr 8 2018

mimo added a comment to D1426: Reduce aura defeat lag by avoiding useless recomputation of all auras globally.
In D1426#58814, @temple wrote:
In D1426#58809, @mimo wrote:

I'm fine with both features: auras do not affect gaia (does not have use on gameplay, so if it can save performance it's a good change)

For example that sele hero that affects enemy building health, with the patch it won't apply to gaia buildings.

Apr 8 2018, 11:13 PM
mimo added a comment to D1426: Reduce aura defeat lag by avoiding useless recomputation of all auras globally.
In D1426#58808, @temple wrote:

We should decide something on gaia.
I think at the moment gaia isn't affected by technology? At least the advanced/elite bonuses.
Currently auras affect gaia but this patch would change it so that they wouldn't affect gaia.
However, gaia entities can still have auras that affect players.

Apr 8 2018, 10:30 PM
mimo committed rP21673: petra cleanup.
petra cleanup
Apr 8 2018, 10:11 PM
mimo created D1444: Give capturePoints of defeated Players to gaia.
Apr 8 2018, 7:32 PM
mimo added a comment to D1441: Fix Fsm error message when a guard ent is killed.

Faster to reproduce (at turn about 5000) with
pyrogenesis -autostart=random/mainland -autostart-seed=5137 -autostart-aiseed=4193 -autostart-players=4 -autostart-ai=1:petra -autostart-civ=1:brit -autostart-ai=2:petra -autostart-civ=2:mace -autostart-ai=3:petra -autostart-civ=3:iber -autostart-ai=4:petra -autostart-civ=4:maur -autostart-nonvisual -autostart-victory=regicide

Apr 8 2018, 11:02 AM
mimo accepted D1434: Don't set hitpoints for completed foundations.
Apr 8 2018, 11:00 AM

Apr 7 2018

mimo added inline comments to D1438: Use Math.floor in resource costs.
Apr 7 2018, 8:00 PM
mimo created D1441: Fix Fsm error message when a guard ent is killed.
Apr 7 2018, 2:54 PM
mimo added inline comments to D1438: Use Math.floor in resource costs.
Apr 7 2018, 2:37 PM

Apr 5 2018

mimo added a comment to D1434: Don't set hitpoints for completed foundations.
In D1434#58513, @temple wrote:
In D1434#58509, @mimo wrote:

And why not setting the relative health (as is done in Promotion or Transform)? Having foundations which are usable without full health may be useful for mods even if we don't use it in vanilla game.

? Foundations are completed (turned into new buildings) when their relative health (i.e. build progress) is 1, but new buildings are initialized at max hitpoints.

Apr 5 2018, 7:11 PM
mimo added a comment to D1433: Remove Gamesetup.cpp readme.txt duplication.
In D1433#58491, @elexis wrote:

I agree that having a command line option to show all command line options would be great.
But that use case for the user, not for the developer.
Which use case does the Gamesetup.cpp contents serve for the reader of this file that can just as well read the same thing in readme.txt?

Apr 5 2018, 6:54 PM
mimo added a comment to D1434: Don't set hitpoints for completed foundations.

And why not setting the relative health (as is done in Promotion or Transform)? Having foundations which are usable without full health may be useful for mods even if we don't use it in vanilla game.

Apr 5 2018, 6:45 PM

Apr 4 2018

mimo committed rP21661: fix error when using salad-bowl on gaia, fixes #4603.
fix error when using salad-bowl on gaia, fixes #4603
Apr 4 2018, 9:27 PM
mimo added a comment to D1433: Remove Gamesetup.cpp readme.txt duplication.

I agree with such a duplication removal, but i don't find the "RTFM" quite handy. I'd rather have an option "autostart -help" which would display it on the console.

Apr 4 2018, 9:07 PM
mimo added a comment to rP21645: Fix rotation of promoted turrets and allow fixing the turret angle in the….

SetTurretStance uses SwitchToStance from UnitAI which has an early return for outOfWorld units, so the stance was not correctly set for such units. This is fixed with rP21656.
But it may be worth fixing directly UnitAI as there are no real reason to not switch stance if not InWorld.

Apr 4 2018, 6:28 PM
mimo committed rP21656: fix r21645 for turrets directly garrisoned from OutWorld.
fix r21645 for turrets directly garrisoned from OutWorld
Apr 4 2018, 6:23 PM

Apr 3 2018

mimo committed rP21645: Fix rotation of promoted turrets and allow fixing the turret angle in the….
Fix rotation of promoted turrets and allow fixing the turret angle in the…
Apr 3 2018, 7:13 PM
mimo closed D1420: Fix rotation of promoted turrets.
Apr 3 2018, 7:13 PM
mimo added inline comments to D1420: Fix rotation of promoted turrets.
Apr 3 2018, 7:08 PM

Apr 2 2018

mimo updated the diff for D1420: Fix rotation of promoted turrets.

updated patch

Apr 2 2018, 11:13 PM
mimo added inline comments to D1420: Fix rotation of promoted turrets.
Apr 2 2018, 11:12 PM
mimo committed rP21641: Fix cheatTimeMultiplier broken by rP21423.
Fix cheatTimeMultiplier broken by rP21423
Apr 2 2018, 10:30 PM
mimo closed D1429: Fix cheatTimeMultiplier broken by rP21423.
Apr 2 2018, 10:30 PM
mimo added a comment to D1429: Fix cheatTimeMultiplier broken by rP21423.
In D1429#58364, @temple wrote:

Tests okay. I think only the gather rate multiplier and cheat time multiplier are relevant with respect to resource gatherer, but I guess it can't hurt to do time multiplier too.

Apr 2 2018, 10:27 PM
mimo committed rP21637: don't do some actions every turn when this is not needed + some cleanup.
don't do some actions every turn when this is not needed + some cleanup
Apr 2 2018, 5:39 PM
mimo added a comment to D1420: Fix rotation of promoted turrets.
In D1420#58313, @temple wrote:
In D1420#58307, @mimo wrote:
In D1420#58272, @temple wrote:

I think it's a bug that setting the turret position changes the angle silently (by changing the definition of m_RotY but not changing the value), so we should include that fix rather than doing some subtractions to account for it. (Of course then we'll have to do an addition in a different spot, but still.)

Well, i would not call it a bug per se, but i fully agree that having the meaning of the rotation angle changing according to turret or not is really bugprone and should be changed. But that's outside the scope of that patch, and is more a post A23 feature than a bugfix.

I'm saying that it's expected that GetRotation().y before SetTurretParent is the same as GetRotation().y after. Setting a turret parent shouldn't turn the unit! Since we're here, we should fix that (it doesn't require any changes to m_RotY, just the two lines getting the rotation and setting it).

Apr 2 2018, 5:22 PM
mimo updated the diff for D1420: Fix rotation of promoted turrets.

update

Apr 2 2018, 5:20 PM
mimo added a comment to rP21423: Add a time multiplier for AI levels.

See D1429

Apr 2 2018, 5:03 PM
mimo created D1429: Fix cheatTimeMultiplier broken by rP21423.
Apr 2 2018, 5:01 PM

Apr 1 2018

mimo added inline comments to rP21423: Add a time multiplier for AI levels.
Apr 1 2018, 12:38 PM
mimo added inline comments to D1425: Formation members shouldn't use IsWalkingAndFighting.
Apr 1 2018, 11:02 AM
mimo added a comment to D1420: Fix rotation of promoted turrets.
In D1420#58272, @temple wrote:

I think it's a bug that setting the turret position changes the angle silently (by changing the definition of m_RotY but not changing the value), so we should include that fix rather than doing some subtractions to account for it. (Of course then we'll have to do an addition in a different spot, but still.)

Apr 1 2018, 10:43 AM