Use Array instead of Set in GUIInterface.entsWithAuraAndStatusBars
AbandonedPublic
Actions

Authored by elexis on Dec 9 2017, 4:05 PM.

Details

Reviewers: None

Summary

The Set is converted to an Array using the spread operator.
The only use thereof is getting a subset of the array, which currently is implemented with a filter function.
Constructing the array manually would require 4 lines, don't see the need to.
But avoiding the conversion and ugly spread operator were nice.

Test Plan

See the aura icons still above the units.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 4036
Build 7082: Vulcan Build (Windows)	Jenkins
Build 7081: Vulcan Build	Jenkins
Build 7080: arc lint + arc unit

Event Timeline

elexis created this revision.Dec 9 2017, 4:05 PM

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

Executing section Default...
Executing section Source...
Executing section JS...

Harbormaster completed remote builds in B4036: Diff 4669.Dec 9 2017, 4:45 PM

elexis abandoned this revision.Dec 16 2017, 5:47 PM

elexis added inline comments.Dec 16 2017, 5:50 PM

binaries/data/mods/public/simulation/components/GuiInterface.js
909	spread removed in rP20657
1113	unrelated, came from D555

elexis mentioned this in rP20657: Use Array.from intead of the spread operator (that's more readable and more….Dec 16 2017, 5:54 PM

Revision Contents
Changeset List

Path

Size

binaries/

data/

mods/

public/

simulation/

components/

GuiInterface.js

12 lines

Diff 4669

View Options

binaries/data/mods/public/simulation/components/GuiInterface.js

Use Array instead of Set in GUIInterface.entsWithAuraAndStatusBarsAbandonedPublicActions