ConquestCommon remove pointless spread operator
ClosedPublic
Actions

Authored by elexis on Dec 9 2017, 7:19 PM.

Details

Reviewers

Commits

rP20619: Remove pairwise annihilating array constructor and spread operator in rP16634.

Summary

rP16634 added the spread operator and [] for no apparent reason. While at it inline.

Test Plan

Can verify with a warn(uneval()) that the contents are the same with and without the patch on the same replay.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Dec 9 2017, 7:19 PM

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

Executing section Default...
Executing section Source...
Executing section JS...

Harbormaster completed remote builds in B4039: Diff 4671.Dec 9 2017, 7:24 PM

bb accepted this revision.Dec 9 2017, 9:08 PM

This revision is now accepted and ready to land.Dec 9 2017, 9:08 PM

Closed by commit rP20619: Remove pairwise annihilating array constructor and spread operator in rP16634. (authored by elexis). · Explain WhyDec 9 2017, 9:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

maps/

scripts/

ConquestCommon.js

7 lines

Diff 4676

View Options

ps/trunk/binaries/data/mods/public/maps/scripts/ConquestCommon.js

ConquestCommon remove pointless spread operatorClosedPublicActions