Page MenuHomeWildfire Games
Differential D1151

Fix mod regex in rP20637
ClosedPublic
Actions

Authored by elexis on Dec 15 2017, 9:13 PM.

Details

Reviewers
mimo
Commits
rP20656: Fix three wrongly chosen variables in rP20637 / D1093, a wrong case-insensitive…
Summary

As pointed out by Imarok, the case insensitive flag isn't effective. As pointed out by mimo, the dependency comparison operator regex failed.
Also the version instead of the name regex was used in validateDependencies.

Test Plan

Try enabling Delenda Est. Try the updated tests in this diff without the remaining patch.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Dec 15 2017, 9:13 PM
elexis mentioned this in rP20637: Define, document, validate and test validation of the format of mod.json files..Dec 15 2017, 9:16 PM
Vulcan added a subscriber: Vulcan.Dec 15 2017, 9:17 PM

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
Vulcan added a comment.Dec 15 2017, 9:18 PM
Executing section Default...
Executing section Source...
Executing section JS...
Harbormaster completed remote builds in B4118: Diff 4774.Dec 15 2017, 9:18 PM
mimo accepted this revision.Dec 15 2017, 9:49 PM
mimo added a subscriber: mimo.

Patch looks good, and dependency now works

This revision is now accepted and ready to land.Dec 15 2017, 9:49 PM
Closed by commit rP20656: Fix three wrongly chosen variables in rP20637 / D1093, a wrong case-insensitive… (authored by elexis). · Explain WhyDec 16 2017, 12:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
mod/
gui/
modmod/
4 lines
6 lines
11 lines

Diff 4779

View Options

ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.js

Loading...
View Options

ps/trunk/binaries/data/mods/mod/gui/modmod/validatemod.js

Loading...
View Options

ps/trunk/binaries/data/mods/mod/gui/modmod/validatemod_test.js

Loading...
Wildfire Games · Phabricator