Fix trigger difficulty level (rP20760) for translation
ClosedPublic
Actions

Authored by mimo on Jan 7 2018, 5:59 PM.

Details

Reviewers: None
Commits: rP20790: Fix trigger difficulty level (rP20760) for translation
Trac Tickets: #4931

Summary

As noted by fabio in #4931, the trigger difficulty selection dropdown does not appears with language other than english. This is because the test to check if a level is supported by the map is done on Name which has been translated before. That patch also add a level Ident which is not translated and used for tests.

Test Plan

check that the panel now works in any language when adding
"SupportedTriggerDifficulties": { "Values": ["Easy", "Medium", "Hard"], "Default": "Medium" }
in the map json file

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mimo created this revision.Jan 7 2018, 5:59 PM

Owners added a subscriber: Restricted Owners Package.Jan 7 2018, 5:59 PM

Might be less ambiguous to use Title for the label (like biomes.json, so only -1 +1 line in messages.json to accomplish that), and Name for the identification.
Other than that ok for me if it works.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 7 2018, 6:37 PM

Closed by commit rP20790: Fix trigger difficulty level (rP20760) for translation (authored by mimo). · Explain Why

This revision was automatically updated to reflect the committed changes.

Executing section Default...
Executing section Source...
Executing section JS...

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

Harbormaster completed remote builds in B4365: Diff 5163.Jan 7 2018, 8:52 PM