Details
Details
- Reviewers
s0600204 echotangoecho - Commits
- rP21097: Fix crash at start in snd_detect(), fixes #4786.
- Trac Tickets
- #4786
Check #4786 is fixed.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Looks good to me (can't check if issue is fixed as I don't have the issue, but the return value should be checked in any case).
Comment Actions
If someone wants to reproduce the crash easily on windows, just disable every sound card in the sound panel.
Interestingly enough, atlas will display an error message, while the game will just crash.
Atlas message
ERROR: Sound: AlcInit failed, m_Device=0x0 m_Context=0x0 dev_name=OpenAL Soft err=a004
Comment Actions
Just tested the patch, and can confirm it crashes without and it doesn't with it.
When testing it with no sound card, I get a slightly different message :
ERROR: Sound: AlcInit failed, m_Device=0x0 m_Context=0x0 dev_name=OpenAL Soft err=a004 ERROR: OpenAL error: (null); called from CSoundManager::~CSoundManager (line 277)
While atlas says (pyrogenesis.exe -editor)
ERROR: Sound: AlcInit failed, m_Device=0x0 m_Context=0x0 dev_name=OpenAL Soft err=a004
I guess it's because it's not playing sound in atlas.
When clicking on a building in the game I get this
ERROR: OpenAL error: (null); called from COggData::InitOggFile (line 74) ERROR: Failed to create initial buffer. OpenAL error: (null) ERROR: could not initialize ogg data at audio/interface/select/building/sel_civ_center.ogg ERROR: OpenAL error: (null); called from COggData::~COggData (line 36) ERROR: OpenAL error: (null); called from COggData::~COggData (line 40) ERROR: OpenAL error: (null); called from COggData::~COggData (line 44) ERROR: OpenAL error: (null); called from CSoundData::~CSoundData (line 37) ERROR: OpenAL error: (null); called from CSoundData::~CSoundData (line 41) ERROR: error loading sound: pathname=audio/interface/select/building/sel_civ_center.ogg, error=Function failed (no details available)