Page MenuHomeWildfire Games

s0600204
Engineering

Projects

User Details

User Since
Jan 23 2017, 5:13 PM (201 w, 3 d)

Recent Activity

Sun, Nov 29

s0600204 changed the visibility for D759: Adapt civinfo page to load relevant info from templates..
Sun, Nov 29, 6:14 AM
s0600204 updated the diff for D759: Adapt civinfo page to load relevant info from templates..

Rebase on top of recent changes.

Sun, Nov 29, 5:48 AM
s0600204 committed rP24290: Add globalscript helper function for Auras.
Add globalscript helper function for Auras
Sun, Nov 29, 5:45 AM
s0600204 committed rP24289: Rewrite the civinfo page to use OOP principles.
Rewrite the civinfo page to use OOP principles
Sun, Nov 29, 5:21 AM
s0600204 closed D2822: Rewrite the civinfo page to use OOP principles.
Sun, Nov 29, 5:21 AM

Sat, Nov 28

s0600204 added a comment to D3155: [WIP] - Show Gatherers next to resource icons.

It also appears that the tooltips that show an ally's resource and population counts are broken.

Sat, Nov 28, 9:32 AM

Fri, Nov 27

wraitii awarded rP24267: Update (and debundle) fmt dependancy a 100 token.
Fri, Nov 27, 8:40 AM
s0600204 updated the diff for D761: Attempt to cleanup the scrollbar code..

Third time's the charm?

Fri, Nov 27, 4:31 AM
s0600204 updated the diff for D761: Attempt to cleanup the scrollbar code..

Try this again, this time with a more up-to-date base.

Fri, Nov 27, 4:17 AM
s0600204 updated the diff for D761: Attempt to cleanup the scrollbar code..

Rebase on top of recent changes

Fri, Nov 27, 3:55 AM
s0600204 committed rP24270: Properly set and get GUI objects' style attribute in JS.
Properly set and get GUI objects' style attribute in JS
Fri, Nov 27, 3:31 AM
s0600204 closed D3109: Fix tab buttons not playing sounds.
Fri, Nov 27, 3:30 AM

Thu, Nov 26

s0600204 committed rP24267: Update (and debundle) fmt dependancy.
Update (and debundle) fmt dependancy
Thu, Nov 26, 10:01 PM
s0600204 closed D2689: Update fmt to the most recent release.
Thu, Nov 26, 10:01 PM
s0600204 updated the diff for D2689: Update fmt to the most recent release.

One last upload/run through CI to make sure I've got everything before committing to SVN

Thu, Nov 26, 6:53 PM
s0600204 updated the diff for D2689: Update fmt to the most recent release.
In D2689#138538, @Stan wrote:

You might want to rebase this.

Thu, Nov 26, 6:31 AM

Tue, Nov 24

s0600204 added a comment to D3109: Fix tab buttons not playing sounds.
In D3109#138370, @Stan wrote:

Might be nice to print the offending file though

Tue, Nov 24, 5:49 PM
s0600204 added inline comments to D3109: Fix tab buttons not playing sounds.
Tue, Nov 24, 3:52 PM
s0600204 added inline comments to D3109: Fix tab buttons not playing sounds.
Tue, Nov 24, 3:31 PM
s0600204 commandeered D3109: Fix tab buttons not playing sounds.
Tue, Nov 24, 2:44 PM
s0600204 updated the diff for D3109: Fix tab buttons not playing sounds.

Get sounds playing again, and reduce duplication between the style being set initially from XML and setting if from JS.

Tue, Nov 24, 2:43 PM
s0600204 added a comment to D3119: [WIP] Add a with-system-cxxtest.
In D3119#138238, @Stan wrote:

As noted in the log above this segfaults. maybe @fabio or @s0600204 have some idea.

Tue, Nov 24, 1:37 AM

Mon, Nov 23

s0600204 added inline comments to D3127: Change when system-provided mozjs headers are searched.
Mon, Nov 23, 6:11 PM
s0600204 added a comment to D3127: Change when system-provided mozjs headers are searched.

[...] I'm not sure why we don't regenerate this file [...]

Mon, Nov 23, 5:00 PM
s0600204 added a comment to D3127: Change when system-provided mozjs headers are searched.

Works on my mac, but you need to run cd build/premake/premake5/ && bin/release/premake5 embed to re-generate the scripts.c file. It's versioned afaik.

Mon, Nov 23, 1:23 PM

Sat, Nov 21

s0600204 updated the diff for D3127: Change when system-provided mozjs headers are searched.
  • Refactor the pkgconfig premake5 module
  • Attempt to place Windows includes in premake5 into the correct place in the include search order
  • Sort the new aftersysincludedirs premake5 global to a better location (alphabetically) in its file
Sat, Nov 21, 4:29 PM
s0600204 added inline comments to D3127: Change when system-provided mozjs headers are searched.
Sat, Nov 21, 4:29 PM
s0600204 added a comment to D2689: Update fmt to the most recent release.

Maybe it has a different name on Debian? E.g. fmt-dev, fmtlib, libfmt.

Sat, Nov 21, 12:36 PM
s0600204 added inline comments to D3127: Change when system-provided mozjs headers are searched.
Sat, Nov 21, 12:28 AM

Fri, Nov 20

s0600204 requested review of D3127: Change when system-provided mozjs headers are searched.
Fri, Nov 20, 10:58 PM

Tue, Nov 17

s0600204 updated the diff for D2689: Update fmt to the most recent release.

Amend gcc6 docker file

Tue, Nov 17, 4:20 PM
s0600204 added a comment to D2689: Update fmt to the most recent release.

The latest diff compiled fine on my Xcode 10.2.1 / MacOS 10.14 machine. I'm not sure what the CI runs, but probably something (much?) earlier.

Tue, Nov 17, 3:54 PM
s0600204 added a comment to D2689: Update fmt to the most recent release.
In D2689#136725, @Stan wrote:

You might also want to edit build/jenkins/dockerfiles/gcc6.Dockerfile.

Tue, Nov 17, 10:56 AM
s0600204 updated the diff for D2689: Update fmt to the most recent release.

Add fmt to rlinterface's build-time lib includes

Tue, Nov 17, 3:20 AM
s0600204 added a comment to D2689: Update fmt to the most recent release.
In D2689#136708, @Stan wrote:

Here are the lib files

Tue, Nov 17, 2:20 AM
s0600204 updated the diff for D2689: Update fmt to the most recent release.
  • Include the Windows lib files @Stan built;
  • Attempt to fix MacOS compilation;
Tue, Nov 17, 2:20 AM
s0600204 updated the diff for D2689: Update fmt to the most recent release.

Rebase; Update fmt to version 7.1.2.

Tue, Nov 17, 12:41 AM

Thu, Nov 5

s0600204 committed rP24133: Take civ code into account when determining base template name in the Reference….
Take civ code into account when determining base template name in the Reference…
Thu, Nov 5, 3:30 PM
s0600204 added a comment to rP23808: Rewrite Structure Tree and Template Viewer to use OOP principles.

[...] could #5848 be a result of this commit?

Thu, Nov 5, 3:30 PM

Jul 31 2020

s0600204 committed rP23913: Resolve issue with palisade health in Structure Tree.
Resolve issue with palisade health in Structure Tree
Jul 31 2020, 2:16 AM

Jul 29 2020

s0600204 updated the diff for D761: Attempt to cleanup the scrollbar code..

A "serious" rebase.

Jul 29 2020, 6:08 AM

Jul 17 2020

s0600204 added a comment to D2822: Rewrite the civinfo page to use OOP principles.

I'm getting some errors:

[...]
Jul 17 2020, 4:24 PM
s0600204 added inline comments to D2822: Rewrite the civinfo page to use OOP principles.
Jul 17 2020, 3:44 AM
s0600204 updated the diff for D2822: Rewrite the civinfo page to use OOP principles.

Enable scrolling on the History textbox

Jul 17 2020, 3:44 AM

Jul 16 2020

s0600204 updated the diff for D759: Adapt civinfo page to load relevant info from templates..

Rebase of work to take into account recent changes

Jul 16 2020, 5:32 AM
s0600204 updated the diff for D2822: Rewrite the civinfo page to use OOP principles.

Rebase of work

Jul 16 2020, 5:29 AM

Jul 11 2020

s0600204 added a comment to rP23808: Rewrite Structure Tree and Template Viewer to use OOP principles.

Should be remedied by rP23816

Jul 11 2020, 9:52 PM
s0600204 committed rP23816: Skip unresearchable techs when deriving production queues in Structure Tree.
Skip unresearchable techs when deriving production queues in Structure Tree
Jul 11 2020, 9:47 PM
Angen awarded rP23813: Don't have the Structure Tree fill up the entire screen a Evil Spooky Haunted Tree token.
Jul 11 2020, 9:32 AM
s0600204 committed rP23813: Don't have the Structure Tree fill up the entire screen.
Don't have the Structure Tree fill up the entire screen
Jul 11 2020, 4:51 AM

Jul 7 2020

s0600204 committed rP23808: Rewrite Structure Tree and Template Viewer to use OOP principles.
Rewrite Structure Tree and Template Viewer to use OOP principles
Jul 7 2020, 9:16 PM
s0600204 closed D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.
Jul 7 2020, 9:11 PM

Jun 18 2020

s0600204 committed rP23780: Introduce axeman templates.
Introduce axeman templates
Jun 18 2020, 11:36 PM
s0600204 closed D1355: [gameplay] introduce axeman templates.
Jun 18 2020, 11:36 PM
s0600204 accepted D1355: [gameplay] introduce axeman templates.

Art actor and icon renames are included in D2688.

Noted. I'll leave that for one of the Art team to look through. For now, at least.

Jun 18 2020, 12:56 AM
s0600204 updated the diff for D759: Adapt civinfo page to load relevant info from templates..

Bring the revision back into scope

Jun 18 2020, 12:51 AM
s0600204 created D2822: Rewrite the civinfo page to use OOP principles.
Jun 18 2020, 12:43 AM
s0600204 requested changes to D1619: Enable support for powerpc64 systems.

I'm not sure if you're still around (apologies this has taken so long), but as @Stan points out - in the intervening time between your last update and now some things have changed:

Jun 18 2020, 12:22 AM
s0600204 added inline comments to D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.
Jun 18 2020, 12:20 AM
s0600204 updated the diff for D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

Rebase, and update in response to line comments

Jun 18 2020, 12:20 AM

May 22 2020

s0600204 added a comment to D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

@elexis: I thank you for your thanks. I figured you would appreciate the intent of the proposed change, even if you disagreed with parts of the actual implementation. I acknowledge that you had not and do not request any changes, and I thank you for sharing your insight.

May 22 2020, 5:59 AM
s0600204 updated the diff for D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

Break structree gui up further into separate files and classes

May 22 2020, 5:58 AM

May 21 2020

s0600204 committed rP23687: Correct WallPiece schema help comments.
Correct WallPiece schema help comments
May 21 2020, 9:11 PM
s0600204 added a comment to rP23684: Add help comments to WallPiece component schema .

Ok, story time: I wrote this patch, and then sat on it for about a day. Read through it again, thought to myself "this looks ok: factually correct and all that", so committed it. Not half-an-hour later, I realised that I had made a mistake: orientation and bend weren't in radians[^1]. By this time, it was roughly six in the morning, I recognised I was way too tired to attempt to fix then, so resolved to do so after some sleep. I wake up, and find out I'd got the other unit of measurement wrong too... ?

May 21 2020, 9:11 PM
s0600204 committed rP23684: Add help comments to WallPiece component schema .
Add help comments to WallPiece component schema
May 21 2020, 6:34 AM

May 16 2020

s0600204 updated the diff for D759: Adapt civinfo page to load relevant info from templates..

Massive update and rebase.

May 16 2020, 6:35 PM
s0600204 updated the diff for D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

Apply linting suggestions from ESLintBear/JSHintBear

May 16 2020, 4:40 PM
s0600204 updated the diff for D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

Rebase to include the "History" -> "Civilization Overview" string change

May 16 2020, 4:24 PM
Stan awarded D2734: Rewrite Structure Tree and Template Viewer to use OOP principles a Pterodactyl token.
May 16 2020, 9:01 AM
s0600204 planned changes to D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

D'oh! Forgot the "History" -> "Civilization Overview" text change, didn't I? *sigh*

May 16 2020, 12:56 AM
s0600204 created D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.
May 16 2020, 12:50 AM

May 15 2020

s0600204 added a comment to D2722: [gui] rename “History” to “Civilization Overview”.
In D2722#115471, @Stan wrote:

Have you tried the longtext language?

May 15 2020, 11:32 PM
s0600204 committed rP23671: Rename civinfo page from "History" to "Civilization Overview".
Rename civinfo page from "History" to "Civilization Overview"
May 15 2020, 11:28 PM
s0600204 closed D2722: [gui] rename “History” to “Civilization Overview”.
May 15 2020, 11:27 PM
s0600204 accepted D2722: [gui] rename “History” to “Civilization Overview”.

We'll no doubt find out if the button is wide enough for translations when it gets translated.

May 15 2020, 1:56 AM

May 9 2020

s0600204 added a comment to D2720: update information in {civ}.json files.

It might be of interest to note that I intend to rewrite the civinfo page at some point so it obtains information about Heroes, Special Buildings and Technologies from their relevant template files, much like the structree already does. (In other words, information pertaining to these entities will cease to be read from the {civ}.json files.)

May 9 2020, 1:56 AM
s0600204 requested changes to D2722: [gui] rename “History” to “Civilization Overview”.

I think my only criticism is that the text no longer properly fits within the button within the structree. Could you explore button sizes to find something that

  1. Fits the new text (with plenty of space for translated strings that might be longer), and
  2. Doesn't look strange/out of place with the rest of the gui?
May 9 2020, 1:54 AM
s0600204 requested changes to D1355: [gameplay] introduce axeman templates.

My apologies: I completely forgot to continue reviewing this, and in the meantime things have changed.

May 9 2020, 1:53 AM

Apr 24 2020

s0600204 accepted rP21721: Make modmod looking nicer.
Apr 24 2020, 7:50 PM

Apr 14 2020

s0600204 added a comment to D2689: Update fmt to the most recent release.
In D2689#113619, @Stan wrote:

Looks like it failed to find it on linux ?

Apr 14 2020, 12:33 AM

Apr 13 2020

s0600204 updated the diff for D2689: Update fmt to the most recent release.

Put the headers in a place where they're findable on OSX

Apr 13 2020, 8:06 PM

Apr 9 2020

s0600204 retitled D2689: Update fmt to the most recent release from Update fmt to version 6.1.2 to Update fmt to the most recent release.
Apr 9 2020, 8:48 PM
s0600204 added inline comments to D2689: Update fmt to the most recent release.
Apr 9 2020, 8:26 PM
s0600204 added a comment to D2689: Update fmt to the most recent release.

on my Lubuntu 18.04 with fmt-dev 4.0.0 installed.
And I could not find fmt.pc. Sorry in advance if this is a noob question though,,,

Apr 9 2020, 5:39 PM
s0600204 updated the diff for D2689: Update fmt to the most recent release.

Get working with fmt 4.0 - 5.2.x on Linux

Apr 9 2020, 5:37 PM
s0600204 updated the diff for D2689: Update fmt to the most recent release.

Fix OSX fetching of the fmt archive

Apr 9 2020, 7:38 AM
s0600204 updated the diff for D2689: Update fmt to the most recent release.

Try de-bundling fmt

Apr 9 2020, 7:26 AM
s0600204 updated the diff for D2689: Update fmt to the most recent release.

Hopefully get this compiling on the Windows Jenkins slave

Apr 9 2020, 7:03 AM
s0600204 planned changes to D2689: Update fmt to the most recent release.
Apr 9 2020, 6:03 AM

Apr 5 2020

s0600204 updated the diff for D2689: Update fmt to the most recent release.

Build on OSX, second attempt

Apr 5 2020, 1:04 AM

Apr 4 2020

s0600204 added a comment to D2689: Update fmt to the most recent release.

It occurs to me that:

  • We no longer modify the fmt source;
  • The source is available from publicly accessible location;
  • Many, if not most, linux distro package repositories have a sufficiently recent version built and available;
Apr 4 2020, 11:16 PM
s0600204 updated the diff for D2689: Update fmt to the most recent release.

Build fmt on OSX (I hope)

Apr 4 2020, 11:10 PM

Apr 3 2020

s0600204 created D2689: Update fmt to the most recent release.
Apr 3 2020, 12:56 AM

Mar 29 2020

s0600204 updated the diff for D2613: Updated cppformat.

Re-rebase adrian's patch

Mar 29 2020, 5:33 PM

Mar 26 2020

s0600204 updated the diff for D2613: Updated cppformat.

Re-add a couple of files inadvertently missed from earlier update

Mar 26 2020, 1:31 AM

Mar 25 2020

s0600204 updated the diff for D2613: Updated cppformat.

Re-upload existing patch, with moved files marked as such

Mar 25 2020, 4:09 PM

Sep 5 2019

s0600204 changed the visibility for P168 #5574 test script.
Sep 5 2019, 3:11 AM
s0600204 changed the visibility for P168 #5574 test script.
Sep 5 2019, 3:02 AM
s0600204 edited P168 #5574 test script.
Sep 5 2019, 2:52 AM
s0600204 edited P168 #5574 test script.
Sep 5 2019, 12:31 AM