Page MenuHomeWildfire Games

s0600204
Engineering

Projects

User Details

User Since
Jan 23 2017, 5:13 PM (248 w, 2 d)

Recent Activity

Fri, Oct 22

s0600204 requested review of D4316: [Reference Suite] Show mercenaries' correct rank.
Fri, Oct 22, 12:02 AM

Sep 25 2021

s0600204 updated the diff for D3941: Use pkg-config with spidermonkey when not using --with-system-mozjs.

Rebase now that parent revision has been committed

Sep 25 2021, 3:08 AM
s0600204 added a comment to D4108: Adds FreeType support to the engine.
In D4108#182476, @Stan wrote:

@s0600204 any idea what we could do for macos and pkg config ?

Sep 25 2021, 2:50 AM

Sep 23 2021

s0600204 updated the diff for D4279: Improve minimap viewpoint-polygon placement.

Intersect camera at corners of polygon, instead of using an imaginary horizontal plane based on averaged terrain height (see previous diff for that).

Sep 23 2021, 7:53 PM
s0600204 committed rP25938: Use pkg-config more extensively in build.
Use pkg-config more extensively in build
Sep 23 2021, 6:11 PM
s0600204 closed D3611: Use pkg-config even more.
Sep 23 2021, 6:11 PM
s0600204 updated the diff for D4279: Improve minimap viewpoint-polygon placement.

Attempt to use the average height of terrain in the camera's view, instead of just the height of the centre point of the view.

Sep 23 2021, 5:28 PM
s0600204 added a comment to D4279: Improve minimap viewpoint-polygon placement.

[...] you could actually just query 4 height map points and draw a more accurate polygon.

Sep 23 2021, 5:27 PM

Sep 22 2021

s0600204 added a comment to D4279: Improve minimap viewpoint-polygon placement.

(Also I don't know how much more computationally expensive such an approach is.)

That's the main point. In theory it shouldn't be slower than 4 heightmap traces in your current approach.

Sep 22 2021, 11:57 PM
s0600204 added a comment to D4279: Improve minimap viewpoint-polygon placement.

Maybe you could get average height from HeightMipmap?

Sep 22 2021, 7:55 PM
s0600204 updated the diff for D4279: Improve minimap viewpoint-polygon placement.

Use const, and reduce number of method calls on the g_Renderer object.

Sep 22 2021, 6:00 PM
s0600204 requested review of D4279: Improve minimap viewpoint-polygon placement.
Sep 22 2021, 5:49 PM
s0600204 updated the diff for D3611: Use pkg-config even more.

One (final) pass on the CI

Sep 22 2021, 1:06 AM

Sep 21 2021

s0600204 updated the summary of D3611: Use pkg-config even more.
Sep 21 2021, 12:39 AM
s0600204 committed rP25933: Debundle Valgrind and make it optional.
Debundle Valgrind and make it optional
Sep 21 2021, 12:18 AM
s0600204 closed D3646: Debundle Valgrind and make it optional.
Sep 21 2021, 12:18 AM

Sep 18 2021

s0600204 added inline comments to D3611: Use pkg-config even more.
Sep 18 2021, 8:11 PM
s0600204 added a comment to D3646: Debundle Valgrind and make it optional.
In D3646#180948, @Stan wrote:

Mmmh there is no #ifdef in [source/lib/sysdep/os/osx/ocpu.cpp]

Sep 18 2021, 8:10 PM

Sep 6 2021

s0600204 added a comment to D3646: Debundle Valgrind and make it optional.
In D3646#180903, @Stan wrote:

Looks alright. Is mac able to use pkgconfig too or should we make it linux only /add more stuff to premake ?

Sep 6 2021, 3:38 PM
s0600204 updated the diff for D3646: Debundle Valgrind and make it optional.

Make the define CONFIG2_VALGRIND, as suggested by @sera

Sep 6 2021, 2:38 PM

Jul 1 2021

s0600204 added a comment to D4188: Translate map name in game setup.

I can't see how it would: we're not tagging anything to be translated here, just using translations that already exist.

Jul 1 2021, 12:44 PM

Jun 30 2021

s0600204 requested review of D4188: Translate map name in game setup.
Jun 30 2021, 9:01 PM

Jun 26 2021

s0600204 updated the Trac tickets for D3646: Debundle Valgrind and make it optional.
Jun 26 2021, 2:59 AM

Jun 10 2021

s0600204 updated the diff for D761: Attempt to cleanup the scrollbar code..
  • Rejig CInput's text-handling to prevent infinite loop when using IGUIObject::getComputedSize() in CGUIScrollBarVertical::Setup()
    • (See full commit message starting "Add a flag that's set [...]" under "Revision Contents" > "Commits" below)
  • Use IGUIObject::getComputedSize() in CGUIScrollBarVertical::Setup()
  • Calculate content size on demand, instead of reading from a cached value.
Jun 10 2021, 4:44 AM

Jun 9 2021

s0600204 added a comment to D3646: Debundle Valgrind and make it optional.

According to the Valgrind website, they don't - and probably never will - support Windows systems[1], so I've also made it non-Windows option.

As they mention it's possible to run it under Wine.

Jun 9 2021, 11:47 PM
s0600204 updated the diff for D3646: Debundle Valgrind and make it optional.

(Missed a file.)

Jun 9 2021, 10:55 PM
s0600204 updated the summary of D3611: Use pkg-config even more.
Jun 9 2021, 9:59 PM
s0600204 updated the diff for D3646: Debundle Valgrind and make it optional.

Debundle and make Valgrind optional

Jun 9 2021, 9:54 PM
s0600204 added a comment to D4122: Struct Tree: better handle failures to load templates..

@Angen, you'll still get error messages, however:

  • There should be fewer error messages emitted, as we now handle things being undefined better;
  • Error messages should be issued less often, as follows:
    • If it's a civ-specific template that's broken (e.g. structures/brit/arsenal) you should now only get error messages for that once (and not every time the template is requested somewhere);
    • Ditto for broken technologies and auras;
    • If it's a parent template that's broken (e.g. template_structure_military_arsenal) you'll get error messages for each civs' specific version of it (as you navigate down the "Civilizations" dropdown), but only the first time a given civ is selected.
  • Error messages concerning broken Entity templates should be reduced, as you no longer get a traceback of the JS code (which isn't particularly helpful in this case).
    • (Technology and Aura breakages still get a traceback, but that's part of the behaviour of the JSON parser on the c++ side.)
Jun 9 2021, 3:14 PM
s0600204 commandeered D4122: Struct Tree: better handle failures to load templates..
Jun 9 2021, 1:31 PM
s0600204 updated the diff for D4122: Struct Tree: better handle failures to load templates..

Also handle broken technologies and auras

Jun 9 2021, 1:31 PM
s0600204 committed rP25751: Apply modifiers from civ/team bonus auras in Reference Suite.
Apply modifiers from civ/team bonus auras in Reference Suite
Jun 9 2021, 1:36 AM
s0600204 closed D4093: (Reference Suite) Apply modifiers from civ/team bonus auras.
Jun 9 2021, 1:36 AM
s0600204 committed rP25750: (Re)display phase idents in Structure Tree.
(Re)display phase idents in Structure Tree
Jun 9 2021, 1:21 AM

Jun 7 2021

s0600204 added a comment to D4108: Adds FreeType support to the engine.

With the suggested changes below applied on an ArchLinux system, userreport_hwdetect.txt reports:

Jun 7 2021, 6:32 PM
s0600204 updated the summary of D3127: Change when system-provided mozjs headers are searched.
Jun 7 2021, 4:58 PM

Jun 5 2021

s0600204 requested review of D4093: (Reference Suite) Apply modifiers from civ/team bonus auras.
Jun 5 2021, 10:02 PM
s0600204 committed rP25690: (Reference Suite) Support aura-based civilization bonuses.
(Reference Suite) Support aura-based civilization bonuses
Jun 5 2021, 6:40 PM
s0600204 requested verification of rP24492: Adapt the civinfo page to read from templates.

@Nescio, your concern should have been addressed by rP25689 (and the line comment is addressed in the planned redesign).

Jun 5 2021, 6:27 PM
s0600204 committed rP25689: (Reference Suite) Fetch teambonus auras from player_{civ}.xml files.
(Reference Suite) Fetch teambonus auras from player_{civ}.xml files
Jun 5 2021, 6:25 PM
s0600204 closed D3864: Fetch teambonus auras from player_{civ}.xml files.
Jun 5 2021, 6:25 PM
s0600204 requested review of D4085: Arcanist extension to apply revision dependencies on CI.
Jun 5 2021, 12:34 AM

May 25 2021

s0600204 changed the visibility for D3941: Use pkg-config with spidermonkey when not using --with-system-mozjs.
May 25 2021, 5:09 PM

May 23 2021

s0600204 updated the diff for D761: Attempt to cleanup the scrollbar code..
  • Rebase on top of recent changes
  • Some changes in response to @Stan's comments
  • Fix bug introduced in earlier version that caused click-dragging the scrollbar's bar to not work correctly
  • Draw scrollbars on top of the background sprite of the gui elements
May 23 2021, 5:47 AM
s0600204 added inline comments to D761: Attempt to cleanup the scrollbar code..
May 23 2021, 5:47 AM
s0600204 added a comment to D4004: CList, COList, CDropdown, CText, CInput: Draw borders above the rest and improve scrollbar drawing order.
Test Plan

Also look for remaining border issues

May 23 2021, 3:22 AM

May 22 2021

s0600204 updated the diff for D3941: Use pkg-config with spidermonkey when not using --with-system-mozjs.

Revision now contains just the changes for this revision, and not also the changes of its parent.

May 22 2021, 8:54 PM

May 16 2021

s0600204 added a comment to D3911: Improve the usefulness of the counters in the top panel.

I wonder... do we have any players from the Indian Subcontinent? (e.g. India, Pakistan, Bangladesh, Myanmar, Sri Lanka)

May 16 2021, 1:23 AM

May 9 2021

s0600204 updated the diff for D3941: Use pkg-config with spidermonkey when not using --with-system-mozjs.

A version of this that doesn't move the Win32 build artefacts.

May 9 2021, 5:42 PM
s0600204 added a comment to D3611: Use pkg-config even more.

Yeah, it was a typo that sneaked in (should be miniupnpc not minipupnpc - too many ps). I've fixed it locally, but its not really worth updating the revision/running the CIs for a single character change.

May 9 2021, 2:36 PM
s0600204 requested review of D3941: Use pkg-config with spidermonkey when not using --with-system-mozjs.
May 9 2021, 4:51 AM
s0600204 updated the summary of D3611: Use pkg-config even more.
May 9 2021, 12:40 AM

May 8 2021

wraitii awarded rP25403: Fix auto-complete chat entries for Biome names in GameSetup a Love token.
May 8 2021, 11:06 PM
s0600204 committed rP25403: Fix auto-complete chat entries for Biome names in GameSetup.
Fix auto-complete chat entries for Biome names in GameSetup
May 8 2021, 10:46 PM
s0600204 updated the diff for D3611: Use pkg-config even more.

(Reading your comment in the code, this is expected?)

May 8 2021, 6:10 PM

May 3 2021

s0600204 updated the diff for D3611: Use pkg-config even more.

Upload without CI-only debugging commit

May 3 2021, 5:34 PM

Apr 22 2021

s0600204 added a comment to D3864: Fetch teambonus auras from player_{civ}.xml files.

Yeah... the JS environment has no way to tell if a file has been modified since it was last requested from the VFS. And considering that the VFS has its own caches - and hot-loading of simulation data files is not implemented - even when bypassing the JS-side cache the old file would still be loaded from the C++-side cache.

Apr 22 2021, 6:00 PM
s0600204 added a comment to D3864: Fetch teambonus auras from player_{civ}.xml files.

Edge case:
If you load up the civ overview (starting at athens) then move to Britons and add e.g. the Briton bonus to Athens and Carths, the bonus does show up when moving to Carth (was not present in the cache yet) but doesn't show for Athens (uses the cached data).

Apr 22 2021, 5:21 PM

Apr 17 2021

s0600204 published D3864: Fetch teambonus auras from player_{civ}.xml files for review.
Apr 17 2021, 12:59 PM

Apr 14 2021

s0600204 requested verification of rP23808: Rewrite Structure Tree and Template Viewer to use OOP principles.
Apr 14 2021, 10:09 PM
s0600204 committed rP25260: Show correct cost/phase of template-variants in structree whilst maintaining….
Show correct cost/phase of template-variants in structree whilst maintaining…
Apr 14 2021, 10:05 PM
s0600204 closed D3347: Fix structure tree parsing wrong templates.
Apr 14 2021, 10:05 PM

Mar 26 2021

s0600204 updated the diff for D3347: Fix structure tree parsing wrong templates.

Satisfy linter (hopefully)

Mar 26 2021, 12:30 AM

Mar 25 2021

s0600204 updated the summary of D3347: Fix structure tree parsing wrong templates.
Mar 25 2021, 10:35 PM
s0600204 updated the diff for D3347: Fix structure tree parsing wrong templates.

Cleanup!

Mar 25 2021, 10:29 PM
s0600204 commandeered D3347: Fix structure tree parsing wrong templates.
Mar 25 2021, 10:24 PM
s0600204 updated the diff for D3347: Fix structure tree parsing wrong templates.

Rewrite the template base/variant detection code, and how its used.

Mar 25 2021, 10:23 PM

Mar 23 2021

s0600204 added a comment to D3347: Fix structure tree parsing wrong templates.

@Angen, I think I've come up with an approach to this I prefer: may I commandeer this?

Mar 23 2021, 4:50 PM
s0600204 committed rP25110: Always pass a civcode to Viewer when instatiated by the session gui.
Always pass a civcode to Viewer when instatiated by the session gui
Mar 23 2021, 4:44 PM
s0600204 committed rP25109: Use Treasure tooltip function in Template Viewer.
Use Treasure tooltip function in Template Viewer
Mar 23 2021, 2:39 PM

Mar 7 2021

s0600204 requested review of D3646: Debundle Valgrind and make it optional.
Mar 7 2021, 1:33 AM

Mar 6 2021

s0600204 updated the diff for D3611: Use pkg-config even more.

Change cp arguments (the MacOS version of cp lacks args that the GNU one possesses.)

Mar 6 2021, 11:25 PM
s0600204 updated the diff for D3611: Use pkg-config even more.

Rebase;
Use cp instead of ln;

Mar 6 2021, 9:57 PM

Mar 3 2021

s0600204 added inline comments to D3611: Use pkg-config even more.
Mar 3 2021, 5:46 PM
s0600204 committed rP24998: Use pkgconfig to find libpng.
Use pkgconfig to find libpng
Mar 3 2021, 5:12 PM
s0600204 closed D3610: Use pkgconfig to find libpng.
Mar 3 2021, 5:11 PM
s0600204 added inline comments to D3611: Use pkg-config even more.
Mar 3 2021, 5:10 PM
s0600204 committed rP24997: Bump `miniupnpc` version built on MacOS.
Bump `miniupnpc` version built on MacOS
Mar 3 2021, 5:06 PM
s0600204 closed D3630: Bump `miniupnpc` version on MacOS.
Mar 3 2021, 5:06 PM
s0600204 updated the diff for D3611: Use pkg-config even more.

Change mind about miniupnpc; realise that zlib does support pkg-config

Mar 3 2021, 4:26 PM
s0600204 requested review of D3630: Bump `miniupnpc` version on MacOS.
Mar 3 2021, 3:12 PM
s0600204 planned changes to D3611: Use pkg-config even more.

10.12 is minimal deployment version 10.13 is the minimal compilation version (because of xCode versions), CI links with the 10.14 SDK. I'm not sure if the 10.13 SDK would work - I'm fairly sure the 10.12 doesn't however, there is also a comment in source/tools/dist/build-osx-executable.sh that fmt7 won't compile with the 10.12 SDK.

Mar 3 2021, 12:53 PM
s0600204 committed rP24987: Pass an install location to the `fmt` build on MacOS.
Pass an install location to the `fmt` build on MacOS
Mar 3 2021, 12:41 AM
s0600204 updated the diff for D3611: Use pkg-config even more.

Attempting to work out why isn't it able to find fmt.pc...

Mar 3 2021, 12:27 AM
s0600204 updated the diff for D3611: Use pkg-config even more.

Make sure we have the .pc files

Mar 3 2021, 12:05 AM

Mar 2 2021

s0600204 updated the diff for D3611: Use pkg-config even more.

Temporarily output the version of certain libs on MacOS (change not intended for inclusion on svn)

Mar 2 2021, 11:54 PM
s0600204 added a comment to D3611: Use pkg-config even more.

Hmm... looks like the precompiled headers need to be recreated.

Mar 2 2021, 7:13 AM
s0600204 updated the diff for D3611: Use pkg-config even more.

Hopefully this will be it!

Mar 2 2021, 6:47 AM
s0600204 updated the diff for D3611: Use pkg-config even more.

Try requesting the static libs on MacOS from pkg-config

Mar 2 2021, 6:37 AM
s0600204 updated the diff for D3611: Use pkg-config even more.

Provide the path to the .pc files... *sigh*

Mar 2 2021, 6:13 AM
s0600204 updated the diff for D3611: Use pkg-config even more.

Test SDL2 with pkgconf's --static argument

Mar 2 2021, 6:09 AM
s0600204 updated the diff for D3611: Use pkg-config even more.

Provide an actual path to sdl2-config, seeing as its not on the system...

Mar 2 2021, 5:34 AM
s0600204 updated the diff for D3611: Use pkg-config even more.

Hopefully get vorbis to link in, and get look at the sdl2-config output

Mar 2 2021, 5:26 AM
s0600204 updated the diff for D3611: Use pkg-config even more.

Fix mistake in previous attempt, and progress a test.

Mar 2 2021, 5:04 AM
s0600204 updated the diff for D3611: Use pkg-config even more.

Fix OpenAL/GL, and path debugging:

  • Try to ascertain deps for gnutls/gloox (2/?)
  • Test ogg/vorbis reqs
Mar 2 2021, 3:51 AM
s0600204 updated the diff for D3611: Use pkg-config even more.

Patch debugging for MacOS:

  • Try to find openal/gl .pc file names
  • Test gnutls linking reqs (test 1/?)
  • Test ogg lib required
Mar 2 2021, 3:04 AM
s0600204 updated the diff for D3611: Use pkg-config even more.

*sigh* missed an underscore. Just the one.

Mar 2 2021, 2:41 AM
s0600204 added inline comments to D3611: Use pkg-config even more.
Mar 2 2021, 2:30 AM
s0600204 updated the diff for D3611: Use pkg-config even more.

Use environment value instead of passed argument

Mar 2 2021, 2:30 AM
s0600204 added a comment to D3611: Use pkg-config even more.
In D3611#158118, @Stan wrote:

We also have a packaged mongoose with probably some tweaks https://github.com/cesanta/mongoose

Mar 2 2021, 1:42 AM