Page MenuHomeWildfire Games

s0600204
Engineering

Projects

User Details

User Since
Jan 23 2017, 5:13 PM (191 w, 4 d)

Recent Activity

Jul 31 2020

s0600204 committed rP23913: Resolve issue with palisade health in Structure Tree.
Resolve issue with palisade health in Structure Tree
Jul 31 2020, 2:16 AM

Jul 29 2020

s0600204 updated the diff for D761: Attempt to cleanup the scrollbar code..

A "serious" rebase.

Jul 29 2020, 6:08 AM

Jul 17 2020

s0600204 added a comment to D2822: Rewrite the civinfo page to use OOP principles.

I'm getting some errors:

[...]
Jul 17 2020, 4:24 PM
s0600204 added inline comments to D2822: Rewrite the civinfo page to use OOP principles.
Jul 17 2020, 3:44 AM
s0600204 updated the diff for D2822: Rewrite the civinfo page to use OOP principles.

Enable scrolling on the History textbox

Jul 17 2020, 3:44 AM

Jul 16 2020

s0600204 updated the diff for D2822: Rewrite the civinfo page to use OOP principles.

Rebase of work

Jul 16 2020, 5:29 AM

Jul 11 2020

s0600204 added a comment to rP23808: Rewrite Structure Tree and Template Viewer to use OOP principles.

Should be remedied by rP23816

Jul 11 2020, 9:52 PM
s0600204 committed rP23816: Skip unresearchable techs when deriving production queues in Structure Tree.
Skip unresearchable techs when deriving production queues in Structure Tree
Jul 11 2020, 9:47 PM
Angen awarded rP23813: Don't have the Structure Tree fill up the entire screen a Evil Spooky Haunted Tree token.
Jul 11 2020, 9:32 AM
s0600204 committed rP23813: Don't have the Structure Tree fill up the entire screen.
Don't have the Structure Tree fill up the entire screen
Jul 11 2020, 4:51 AM

Jul 7 2020

s0600204 committed rP23808: Rewrite Structure Tree and Template Viewer to use OOP principles.
Rewrite Structure Tree and Template Viewer to use OOP principles
Jul 7 2020, 9:16 PM
s0600204 closed D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.
Jul 7 2020, 9:11 PM

Jun 18 2020

s0600204 committed rP23780: Introduce axeman templates.
Introduce axeman templates
Jun 18 2020, 11:36 PM
s0600204 closed D1355: [gameplay] introduce axeman templates.
Jun 18 2020, 11:36 PM
s0600204 accepted D1355: [gameplay] introduce axeman templates.

Art actor and icon renames are included in D2688.

Noted. I'll leave that for one of the Art team to look through. For now, at least.

Jun 18 2020, 12:56 AM
s0600204 created D2822: Rewrite the civinfo page to use OOP principles.
Jun 18 2020, 12:43 AM
s0600204 requested changes to D1619: Enable support for powerpc64 systems.

I'm not sure if you're still around (apologies this has taken so long), but as @Stan points out - in the intervening time between your last update and now some things have changed:

Jun 18 2020, 12:22 AM
s0600204 added inline comments to D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.
Jun 18 2020, 12:20 AM
s0600204 updated the diff for D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

Rebase, and update in response to line comments

Jun 18 2020, 12:20 AM

May 22 2020

s0600204 added a comment to D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

@elexis: I thank you for your thanks. I figured you would appreciate the intent of the proposed change, even if you disagreed with parts of the actual implementation. I acknowledge that you had not and do not request any changes, and I thank you for sharing your insight.

May 22 2020, 5:59 AM
s0600204 updated the diff for D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

Break structree gui up further into separate files and classes

May 22 2020, 5:58 AM

May 21 2020

s0600204 committed rP23687: Correct WallPiece schema help comments.
Correct WallPiece schema help comments
May 21 2020, 9:11 PM
s0600204 added a comment to rP23684: Add help comments to WallPiece component schema .

Ok, story time: I wrote this patch, and then sat on it for about a day. Read through it again, thought to myself "this looks ok: factually correct and all that", so committed it. Not half-an-hour later, I realised that I had made a mistake: orientation and bend weren't in radians[^1]. By this time, it was roughly six in the morning, I recognised I was way too tired to attempt to fix then, so resolved to do so after some sleep. I wake up, and find out I'd got the other unit of measurement wrong too... 🤦

May 21 2020, 9:11 PM
s0600204 committed rP23684: Add help comments to WallPiece component schema .
Add help comments to WallPiece component schema
May 21 2020, 6:34 AM

May 16 2020

s0600204 updated the diff for D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

Apply linting suggestions from ESLintBear/JSHintBear

May 16 2020, 4:40 PM
s0600204 updated the diff for D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

Rebase to include the "History" -> "Civilization Overview" string change

May 16 2020, 4:24 PM
Stan awarded D2734: Rewrite Structure Tree and Template Viewer to use OOP principles a Pterodactyl token.
May 16 2020, 9:01 AM
s0600204 planned changes to D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.

D'oh! Forgot the "History" -> "Civilization Overview" text change, didn't I? *sigh*

May 16 2020, 12:56 AM
s0600204 created D2734: Rewrite Structure Tree and Template Viewer to use OOP principles.
May 16 2020, 12:50 AM

May 15 2020

s0600204 added a comment to D2722: [gui] rename “History” to “Civilization Overview”.
In D2722#115471, @Stan wrote:

Have you tried the longtext language?

May 15 2020, 11:32 PM
s0600204 committed rP23671: Rename civinfo page from "History" to "Civilization Overview".
Rename civinfo page from "History" to "Civilization Overview"
May 15 2020, 11:28 PM
s0600204 closed D2722: [gui] rename “History” to “Civilization Overview”.
May 15 2020, 11:27 PM
s0600204 accepted D2722: [gui] rename “History” to “Civilization Overview”.

We'll no doubt find out if the button is wide enough for translations when it gets translated.

May 15 2020, 1:56 AM

May 9 2020

s0600204 added a comment to D2720: update information in {civ}.json files.

It might be of interest to note that I intend to rewrite the civinfo page at some point so it obtains information about Heroes, Special Buildings and Technologies from their relevant template files, much like the structree already does. (In other words, information pertaining to these entities will cease to be read from the {civ}.json files.)

May 9 2020, 1:56 AM
s0600204 requested changes to D2722: [gui] rename “History” to “Civilization Overview”.

I think my only criticism is that the text no longer properly fits within the button within the structree. Could you explore button sizes to find something that

  1. Fits the new text (with plenty of space for translated strings that might be longer), and
  2. Doesn't look strange/out of place with the rest of the gui?
May 9 2020, 1:54 AM
s0600204 requested changes to D1355: [gameplay] introduce axeman templates.

My apologies: I completely forgot to continue reviewing this, and in the meantime things have changed.

May 9 2020, 1:53 AM

Apr 24 2020

s0600204 accepted rP21721: Make modmod looking nicer.
Apr 24 2020, 7:50 PM

Apr 14 2020

s0600204 added a comment to D2689: Update fmt to the most recent release.
In D2689#113619, @Stan wrote:

Looks like it failed to find it on linux ?

Apr 14 2020, 12:33 AM

Apr 13 2020

s0600204 updated the diff for D2689: Update fmt to the most recent release.

Put the headers in a place where they're findable on OSX

Apr 13 2020, 8:06 PM

Apr 9 2020

s0600204 retitled D2689: Update fmt to the most recent release from Update fmt to version 6.1.2 to Update fmt to the most recent release.
Apr 9 2020, 8:48 PM
s0600204 added inline comments to D2689: Update fmt to the most recent release.
Apr 9 2020, 8:26 PM
s0600204 added a comment to D2689: Update fmt to the most recent release.

on my Lubuntu 18.04 with fmt-dev 4.0.0 installed.
And I could not find fmt.pc. Sorry in advance if this is a noob question though,,,

Apr 9 2020, 5:39 PM
s0600204 updated the diff for D2689: Update fmt to the most recent release.

Get working with fmt 4.0 - 5.2.x on Linux

Apr 9 2020, 5:37 PM
s0600204 updated the diff for D2689: Update fmt to the most recent release.

Fix OSX fetching of the fmt archive

Apr 9 2020, 7:38 AM
s0600204 updated the diff for D2689: Update fmt to the most recent release.

Try de-bundling fmt

Apr 9 2020, 7:26 AM
s0600204 updated the diff for D2689: Update fmt to the most recent release.

Hopefully get this compiling on the Windows Jenkins slave

Apr 9 2020, 7:03 AM
s0600204 planned changes to D2689: Update fmt to the most recent release.
Apr 9 2020, 6:03 AM

Apr 5 2020

s0600204 updated the diff for D2689: Update fmt to the most recent release.

Build on OSX, second attempt

Apr 5 2020, 1:04 AM

Apr 4 2020

s0600204 added a comment to D2689: Update fmt to the most recent release.

It occurs to me that:

  • We no longer modify the fmt source;
  • The source is available from publicly accessible location;
  • Many, if not most, linux distro package repositories have a sufficiently recent version built and available;
Apr 4 2020, 11:16 PM
s0600204 updated the diff for D2689: Update fmt to the most recent release.

Build fmt on OSX (I hope)

Apr 4 2020, 11:10 PM

Apr 3 2020

s0600204 created D2689: Update fmt to the most recent release.
Apr 3 2020, 12:56 AM

Mar 29 2020

s0600204 updated the diff for D2613: Updated cppformat.

Re-rebase adrian's patch

Mar 29 2020, 5:33 PM

Mar 26 2020

s0600204 updated the diff for D2613: Updated cppformat.

Re-add a couple of files inadvertently missed from earlier update

Mar 26 2020, 1:31 AM

Mar 25 2020

s0600204 updated the diff for D2613: Updated cppformat.

Re-upload existing patch, with moved files marked as such

Mar 25 2020, 4:09 PM

Sep 5 2019

s0600204 changed the visibility for P168 #5574 test script.
Sep 5 2019, 3:11 AM
s0600204 changed the visibility for P168 #5574 test script.
Sep 5 2019, 3:02 AM
s0600204 edited P168 #5574 test script.
Sep 5 2019, 2:52 AM
s0600204 edited P168 #5574 test script.
Sep 5 2019, 12:31 AM

Sep 4 2019

s0600204 created P168 #5574 test script.
Sep 4 2019, 10:24 PM

Jul 29 2019

s0600204 added a comment to D1950: Create "Damage"-container for damage types in templates..

Have updated the relevant wiki page on trac: https://trac.wildfiregames.com/wiki/TechModifications

Jul 29 2019, 3:16 AM
s0600204 added inline comments to rP22335: Improve UTF-8 character handling in Atlas.
Jul 29 2019, 1:13 AM

Jun 25 2019

elexis awarded rP22308: Add a build flag to prefer locally-built libraries (linux/bsd systems) a Like token.
Jun 25 2019, 2:52 AM

Jun 24 2019

elexis awarded rP22302: Use pkg-config where possible instead of hard-coding or library-specific… a Like token.
Jun 24 2019, 4:49 PM

Jun 4 2019

Itms awarded rP22335: Improve UTF-8 character handling in Atlas a Love token.
Jun 4 2019, 11:12 AM

Jun 3 2019

elexis awarded rP22335: Improve UTF-8 character handling in Atlas a Like token.
Jun 3 2019, 11:20 PM
s0600204 committed rP22335: Improve UTF-8 character handling in Atlas.
Improve UTF-8 character handling in Atlas
Jun 3 2019, 10:20 PM
s0600204 closed D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.
Jun 3 2019, 10:20 PM

May 30 2019

s0600204 added a comment to D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.

I feel the scope of the suggestions is slipping into clean-up of surrounding code rather than critiquing the code alteration this revision was created to handle. Hence I've ignored some that I feel out-of-scope for this revision.

May 30 2019, 8:21 PM
s0600204 updated the diff for D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.

Update and clean-up.

May 30 2019, 8:21 PM
s0600204 updated the diff for D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.

Add some ampersands (&) that @Stan noticed I'd missed.

May 30 2019, 5:52 PM

May 29 2019

s0600204 added inline comments to D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.
May 29 2019, 8:35 PM
s0600204 updated the diff for D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.

Update in response to @vladislavbelov's comments.

May 29 2019, 8:35 PM

May 27 2019

s0600204 committed rP22308: Add a build flag to prefer locally-built libraries (linux/bsd systems).
Add a build flag to prefer locally-built libraries (linux/bsd systems)
May 27 2019, 5:46 PM
s0600204 closed D1747: Add a build flag to prefer locally-built libraries..
May 27 2019, 5:46 PM
s0600204 added a comment to D1871: Make rasterisation strictly more permissive than real static obstruction shapes (alternative take on D1869).

This patch unfortunately negatively impacts the AI's ability to place structures.

May 27 2019, 4:57 PM
s0600204 changed the visibility for F933990: Land Obstruction - before and after.
May 27 2019, 3:58 PM
s0600204 changed the visibility for F933990: Land Obstruction - before and after.
May 27 2019, 3:58 PM

May 26 2019

s0600204 updated the diff for D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.

Resolve issue with reading above-ascii characters from Map Name and Description, and Player Name input fields.

May 26 2019, 5:25 PM

May 25 2019

s0600204 committed rP22302: Use pkg-config where possible instead of hard-coding or library-specific….
Use pkg-config where possible instead of hard-coding or library-specific…
May 25 2019, 8:00 PM
s0600204 closed D1611: Use pkg-config instead of hard-coding or library-specific programs.
May 25 2019, 8:00 PM

May 24 2019

s0600204 added a comment to D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.
In D1395#78914, @Itms wrote:

Now unfortunately I have a bug in Atlas: if the name or description of a map contains special UTF-8 characters, they will not be saved. You can reproduce easily by just generating a map from Fields of Meroë, then saving it: in the saved XML file, the Name and Description fields will be empty. Removing the ë and saving again will work.

May 24 2019, 7:05 PM
s0600204 updated the diff for D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.

Update in response to @Itms's comments.

May 24 2019, 7:04 PM
s0600204 updated the diff for D1747: Add a build flag to prefer locally-built libraries..

Update in response to @Itms's comments.

May 24 2019, 7:03 PM

May 13 2019

s0600204 added inline comments to D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.
May 13 2019, 6:32 PM
s0600204 updated the diff for D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.

Here's a bright idea: let's upload the correct patch (duh!)

May 13 2019, 6:29 PM
s0600204 updated the diff for D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.

Code style updates (ternary)

May 13 2019, 6:25 PM

May 8 2019

s0600204 added inline comments to D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.
May 8 2019, 7:20 PM
s0600204 updated the diff for D1395: Handle UTF-8 multibyte characters in Atlas when loading from JSON.

Rebase; and *_casts as requested by @Stan

May 8 2019, 7:20 PM

Mar 19 2019

s0600204 requested changes to D1355: [gameplay] introduce axeman templates.

Furthermore, this patch also corrects infantry generic names for consistency (e.g. “Infantry Swordsman” instead of “Swordsman”; cf. “Cavalry Swordsman”).

In a different patch, please.

Mar 19 2019, 7:29 PM
s0600204 requested changes to D1355: [gameplay] introduce axeman templates.

Well, I'm personally in favour of the change. I know that the Aristeia mod has an axeman unit, so this will definitely be of benefit to at least one of our community mods!

Mar 19 2019, 1:43 AM
s0600204 requested changes to D906: templates/units/ champion naming consistency.

A valiant effort!

Mar 19 2019, 12:57 AM

Mar 18 2019

s0600204 committed rP22134: Add a `GetTextSize()` method to GUI objects.
Add a `GetTextSize()` method to GUI objects
Mar 18 2019, 11:16 PM
s0600204 closed D844: Add a `GetTextSize()` function to the GUI..
Mar 18 2019, 11:16 PM
s0600204 requested changes to D1603: Allow {native} and {civ} in auras.
In D1603#64225, @elexis wrote:
  • Does it burden mod development in any way (for example adding a requirement for added civs to implement some auras, launching two mods with two new civs impossible?), if so it could that be mitigated?

A point that needs addressing. @Angen, to express it differently: what should happen if a civ is added that does not have a teambonus aura? And what does happen? (Hint: it's not pretty.)

Mar 18 2019, 10:59 PM
s0600204 committed rP22133: Rename kush teambonus file to be consistent with the filenames of the other….
Rename kush teambonus file to be consistent with the filenames of the other…
Mar 18 2019, 9:33 PM

Jan 14 2019

s0600204 created D1747: Add a build flag to prefer locally-built libraries..
Jan 14 2019, 2:37 AM

Jan 12 2019

s0600204 added a comment to D1691: Remove boost "system" from Mac OS build system..

Doesn't work for me either (Arch Linux, Boost 1.68).

Jan 12 2019, 5:10 AM

Jan 10 2019

s0600204 accepted rP19380: Move multiplayer host and join page to a new directory, as it is not related….
Jan 10 2019, 6:02 PM
s0600204 accepted rP20537: Disjoint save and load GUI page..
Jan 10 2019, 6:02 PM
s0600204 committed rP22046: Use setStringTags in credits.js.
Use setStringTags in credits.js
Jan 10 2019, 5:49 PM