Lobby dialog button in endscreen summary
ClosedPublic
Actions

Authored by ffffffff on Jan 29 2018, 10:40 AM.

Details

Reviewers

elexis

Commits

rP21263: Add the lobby button to the summary screen.

Summary

Show lobby dialog button in endscreen summary when player has an xmpp client started.

Test Plan

test

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Thanks for the patch fpre!

binaries/data/mods/public/gui/page_summary.xml
8 ↗	(On Diff #5574)	L6 empty, not L7
binaries/data/mods/public/gui/summary/summary.js
157 ↗	(On Diff #5574)	Ok to not show it ingame from here. I prefer avoiding if statements where possible and just always setting the properties. This way the question cannot arise what the hidden value will be if `isIngame`. Also the init function should remain minimal, so moving this to a new function is worth a thought. At the very least it should be in the `Output globals` part. https://en.wikipedia.org/wiki/IPO_model Looking a bit further, this code should be part of `initGUILabelsAndButtons` since it's setting up a button.