Show lobby dialog button in endscreen summary when player has an xmpp client started.
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
Comment Actions
Thanks for the patch fpre!
binaries/data/mods/public/gui/page_summary.xml | ||
---|---|---|
8 | L6 empty, not L7 | |
binaries/data/mods/public/gui/summary/summary.js | ||
157 | Ok to not show it ingame from here. I prefer avoiding if statements where possible and just always setting the properties. Also the init function should remain minimal, so moving this to a new function is worth a thought. Looking a bit further, this code should be part of initGUILabelsAndButtons since it's setting up a button. |