Page MenuHomeWildfire Games

Imarok
User

Projects

User Details

User Since
Dec 23 2016, 12:04 AM (229 w, 12 h)

Recent Activity

Thu, Apr 29

Imarok added inline comments to D3429: Adds Vulkan check to HWDetect.
Thu, Apr 29, 10:23 AM

Wed, Apr 28

Imarok added a comment to D3898: [Gameplay] - Make outposts useful again..

Did you forget to add the vision range increase through garrisonning?

Wed, Apr 28, 11:02 AM

Thu, Apr 22

Imarok added a comment to D1751: [WIP] Map flares.
In D1751#167675, @Stan wrote:

Well the ping is unrelated to both.

EDIT: Feel free to suggest something better.

You could try to use target_marker_red_and_gold but with player colors instead of the red one.

Thu, Apr 22, 4:57 PM

Wed, Apr 21

Imarok added a comment to D3835: Disables depth test for GUI.

@vladislavbelov
This commit makes scrolling in the Settings -> Language menu invisible

Wed, Apr 21, 8:06 PM

Apr 11 2021

Imarok requested review of D3836: Partly revert rP23996..
Apr 11 2021, 8:11 PM
Imarok added a reverting change for D148: Fix gametime overlay and watermark in summary screen: D3836: Partly revert rP23996..
Apr 11 2021, 8:05 PM
Imarok added a reverting change for rP23996: Fix gametime overlay and watermark in summary screen: D3836: Partly revert rP23996..
Apr 11 2021, 8:05 PM

Apr 3 2021

Imarok resigned from rP25169: Do not trigger "HotkeyPress" events when releasing a key..

Seems to be fixed by rP25176 ๐Ÿ‘

Apr 3 2021, 4:19 PM
Imarok added inline comments to rP25182: Add a simple 'pushing' logic to unit motion to improve movement..
Apr 3 2021, 4:06 PM

Apr 2 2021

Imarok added a comment to D3775: Make dropdown keys change only the highlighted element - select on enter/click..

I'm not sure I like it.
Quickly scanning through the previews of maps by going down the list with the arrow keys is not possible anymore. (Yeah I know Map Browser :D)
I guess we should ask some more actual players for their opinion.

Apr 2 2021, 10:47 AM
Imarok added a comment to D1490: Unit Pushing.
Apr 2 2021, 10:36 AM

Apr 1 2021

Imarok added inline comments to D3780: Draws GUI elements by Z order.
Apr 1 2021, 8:46 PM
Imarok added a comment to D3780: Draws GUI elements by Z order.

You can revert rP23996 after this.

Apr 1 2021, 8:32 PM
Imarok added a comment to D3780: Draws GUI elements by Z order.

Edit: This diff refs #4719

Apr 1 2021, 8:29 PM
Imarok awarded D3780: Draws GUI elements by Z order a Burninate token.
Apr 1 2021, 8:29 PM
Imarok added a comment to D1490: Unit Pushing.

Just out of interest: Does this diff allow for different pushing forces per unit?
So that e.g. eles are very difficult to push away but they themselves can easily push other units away.

This diff by itself doesn't, but there's no technical impossibility. I didn't implement it because moving units cannot push idle units, and I didn't find a very strong reason to implement such things for moving-moving or idle-idle movements.
Can certainly be done later anyways.

Apr 1 2021, 8:26 PM
Imarok added a comment to D1490: Unit Pushing.

Just out of interest: Does this diff allow for different pushing forces per unit?
So that e.g. eles are very difficult to push away but they themselves can easily push other units away.

Apr 1 2021, 7:12 PM
Imarok added a comment to rP25169: Do not trigger "HotkeyPress" events when releasing a key..
  • scroll towards the cable of the mouse

You mean "scroll up with the mouse"?

Up and down are bit unclear for scrolling.
But yeah, I'd call it scrolling up. xD

Apr 1 2021, 9:51 AM
Imarok added a comment to rP25169: Do not trigger "HotkeyPress" events when releasing a key..

Scrolling is broken for me (Ubuntu Gnome) with this commit:

  • Start a game
  • press W and release it
  • scroll towards the cable of the mouse
  • the scrolling has no effect.
Apr 1 2021, 12:07 AM
Imarok raised a concern with rP25169: Do not trigger "HotkeyPress" events when releasing a key..

Scrolling is broken for me (Ubuntu Gnome) with this commit:

  • Start a game
  • press W and release it
  • scroll towards the cable of the mouse
  • the scrolling has no effect.
Apr 1 2021, 12:05 AM

Mar 30 2021

Imarok added inline comments to D3772: Only update status bars when necessary..
Mar 30 2021, 3:18 PM
Imarok added a comment to D3768: Quit confirmation dialog hotkey and button.

So the aim of the diff is to introduce a hotkey for quitting and giving the option to skip the summary, right?

Mar 30 2021, 12:25 PM

Mar 26 2021

Imarok added a comment to rP25071: Implement a Motion Manager around UnitMotion..

Ok, fine. I was just wondering because this side-effect was stated nowhere. The description of this diff also sounds like it's more a change in code structure and performance and not in functionality. Thanks for clarifying.

See D3746 anyways, I think this makes the pushing comparison fairer so I'll fix it :)

Mar 26 2021, 4:35 PM
Imarok added a comment to rP25071: Implement a Motion Manager around UnitMotion..

Ahm, I'm sorry but it's very easy to reproduce.

Yeah, this isn't really what I meant either, let me reword that :P
From what I've experience, it happens, but in less than 5-10% of cases or so (i.e. rarely / not systematically) -> rarely enough that I don't think it I should fix it right now, as it doesn't really prevent playing in a super significant way.
Unit Pushing will separate such 'stuck' units and that's what I intend to use to fix this problem - should I fail to get a working diff for that I'll have to update the functions a bit.

Ok, fine. I was just wondering because this side-effect was stated nowhere. The description of this diff also sounds like it's more a change in code structure and performance and not in functionality. Thanks for clarifying.

Mar 26 2021, 4:28 PM
Imarok added a comment to rP25071: Implement a Motion Manager around UnitMotion..

Not sure if this is intended, but with this commit I get multiple units standing on exactly the same spot.
To reproduce just order a bunch (50) of units to the same spot without using formations.

Freagarach reported that too. It's indeed this commit, but it should be fairly hard to reproduce, and I intend to fix it with unit pushing. At the moment I'm treating this as "working as designed", might need to reconsider that in the future but I'll see.

Mar 26 2021, 2:16 PM
Imarok added a comment to rP25071: Implement a Motion Manager around UnitMotion..

Not sure if this is intended, but with this commit I get multiple units standing on exactly the same spot.
Notice how the blue and the white coat are intersecting:


To reproduce just order a bunch (50) of units to the same spot without using formations.

Mar 26 2021, 12:47 PM

Mar 24 2021

Imarok added a comment to D3737: MP netcode: allow observers to lag however much they want..

Good idea but I think we should communicate this in some way.
Maybe we could show the observering person how many seconds they are behind?
(And maybe show a warning when this exceeds a minute or so)
I assume observers are still getting all commands even if they are minutes behind. right? (So they would also have the full replay if they started observing from start on)

Mar 24 2021, 9:40 PM

Mar 19 2021

Imarok added inline comments to D3714: Don't store init attributes in the NetServer/Client..
Mar 19 2021, 4:14 PM
Imarok added inline comments to D3714: Don't store init attributes in the NetServer/Client..
Mar 19 2021, 4:07 PM
Imarok added inline comments to D3714: Don't store init attributes in the NetServer/Client..
Mar 19 2021, 3:52 PM
Imarok added inline comments to D3714: Don't store init attributes in the NetServer/Client..
Mar 19 2021, 3:48 PM
Imarok added a comment to D431: Gamesetup - Optionally allow players to setup the game.

Might be a bit easier with rP25077

Mar 19 2021, 3:16 PM

Mar 18 2021

Imarok added a comment to D1269: Session: Show more command buttons.

It's a bit of a pain to quickly click on them now, perhaps show five at a time and increase the size of the arrows?

Hmm, I wanted to stay with 6 command buttons per page, so that you don't have to use the second page too often...

The benefit of the OOP is that e.g. the diff to scroll through the loading screen tips can partly use the same code. But @elexis would be way better at explaining that ^^

Mar 18 2021, 9:51 PM
Imarok added a comment to D3708: [gameplay] make animals invisible in FoW.

My personal preference would be for Animals to be properly miraged in the FoW (or at least, something be miraged). It's annoying having to remember where they are, since they don't move all that much once discovered.
If actual animals can't be miraged, we could have 'preview animals' once the animal goes in FoW, that doesn't move but shows the last known position of the animal.

Mar 18 2021, 2:16 PM

Mar 10 2021

Imarok closed D3660: Fix typo in log message.

Fixed by commit.

Mar 10 2021, 6:07 PM
Imarok commandeered D3660: Fix typo in log message.
Mar 10 2021, 6:07 PM
Imarok committed rP25033: Fix typos in log and warn messages.
Fix typos in log and warn messages
Mar 10 2021, 5:51 PM
Imarok closed D3659: Fix typo in log message.
Mar 10 2021, 5:51 PM
Imarok added a comment to D3661: Fix typo in log.

Do we fix typos in this third party library?

Mar 10 2021, 5:43 PM

Mar 9 2021

Imarok added a comment to D86: Cleanup of hwdetect.js and its test..

Poke @vladislavbelov

Mar 9 2021, 11:20 AM
Imarok added a comment to rP24550: Remove cache detection.

refs #4451

Mar 9 2021, 11:18 AM

Mar 6 2021

Imarok added a comment to D3644: Fix checkfs following D11.

Interesting, I thought we already switched that to python. xD

Mar 6 2021, 1:55 PM
Imarok updated the summary of D1751: [WIP] Map flares.
Mar 6 2021, 1:24 PM
Imarok updated the summary of D1751: [WIP] Map flares.
Mar 6 2021, 1:22 PM
Imarok added inline comments to D3592: Do not allow to start pyrogenesis with incompatible mods.
Mar 6 2021, 10:54 AM

Mar 5 2021

Imarok added a comment to D3243: Gamesetup cleanup - Separate Game Settings from the GUI Gamesetup.

As with every gamesetup rewrite: Have you tested against the reoccurrence of all the old fixed gamesetup bugs? (Seems especially important as Langbart seems to find a lot of bugs in this diff)

Mar 5 2021, 8:11 AM

Mar 4 2021

Imarok added a comment to D3615: Predictable Replay cache rebuild.

IMHO this means that the button is used for emergency/non-standart situations and should work as it should for the Cache: update the changed files and immediately show the results of the updated cache

Mar 4 2021, 5:50 PM
Imarok added a comment to D3632: Fix Previews in the lobby game list..

Descriptions are also broken btw.

Mar 4 2021, 5:48 PM
Imarok added inline comments to D3632: Fix Previews in the lobby game list..
Mar 4 2021, 5:43 PM

Feb 28 2021

Imarok added a comment to D1751: [WIP] Map flares.
In D1751#157739, @Stan wrote:

I will try to provide something yeah but maybe I'll do it after this patch is committed :) I'm supposed to get some rest. Failing completely for now :/

Feb 28 2021, 11:17 PM
Imarok added a comment to D1751: [WIP] Map flares.

But it behaves exactly the same as a normal preselected action with the only exception that it's not connected to an entity.

I think it's a big difference :P
Honestly I believe a bit of duplication in INPUT_** modes in the input will make the code cleaner overall.

And wrt left-/right-click. For nearly all actions you do right-click when using the hotkey and left-click when using the gui. So it seems rather consistent to me.

Are you sure it's consistent with other pre-selected actions? I think patrol/guard, when using the GUI buttons, are triggered using the left-click (I might be misremembering though)
If you change, like I suggested, so that pressing the hotkey enters 'flare mode' and you don't have to keep pressing the hotkey, it'd be more consistent to left-click .

Feb 28 2021, 11:16 PM
Imarok added a comment to D3614: Check for missing auras in GUI Interface.

Can we do the same for techs? ๐Ÿ˜

Feb 28 2021, 11:08 PM
Imarok added a comment to D1751: [WIP] Map flares.
In D1751#157731, @Stan wrote:

Oh right you should definitely hear them. One question about abuse. Is there a way we can limit spam?

Feb 28 2021, 11:06 PM
Imarok updated the diff for D1751: [WIP] Map flares.

Also play flare sound for yourself. Add comment requested by wraitii.

Feb 28 2021, 11:00 PM
Imarok added a comment to D1751: [WIP] Map flares.

This works great in-game, C++ code looks good, but I think the JS input handling needs work because it's very hacky right now...

Instead of switching to INPUT_PRESELECTEDACTION you should add a new input state called INPUT_FLARE, which you enter on pressing the hotkey/clicking the button, and then a left-click (or something) is a flare. That way you can remove the 'hotkeyActionCheck' things, you remove the code in determineAction, and it's always left-click instead of right-click on hotkey, and you don't have to keep pressing the hotkey to flare.

But it behaves exactly the same as a normal preselected action with the only exception that it's not connected to an entity.
And wrt left-/right-click. For nearly all actions you do right-click when using the hotkey and left-click when using the gui. So it seems rather consistent to me.

If you want to make something generic, it could be called INPUT_NONENTACTION (for 'non-entity related action') or something, and mirror preselectedAction but without an entity basically.


I also find it a bit weird that the sound only triggers for your allies.

Good point.

Feb 28 2021, 10:58 PM
Imarok updated the summary of D1751: [WIP] Map flares.
Feb 28 2021, 1:58 AM
Imarok added inline comments to D1751: [WIP] Map flares.
Feb 28 2021, 1:42 AM
Imarok updated the diff for D1751: [WIP] Map flares.

Improve animation. Fix ARB. New highlighted button version by stan. Cleanup

Feb 28 2021, 1:39 AM
Imarok updated the summary of D1751: [WIP] Map flares.
Feb 28 2021, 1:38 AM

Feb 27 2021

Imarok added a comment to D1751: [WIP] Map flares.
In D1751#155229, @Stan wrote:

  1. Can you add a trigger so it can be triggered by maps?
  2. Hyrule does something like this for another mater but I think it could look pretty good, what do you think?

Feb 27 2021, 10:56 PM
Imarok committed rP24950: Remove unneeded check in JSInterface_GameView.cpp.
Remove unneeded check in JSInterface_GameView.cpp
Feb 27 2021, 5:53 PM
Imarok closed D3608: Remove unneeded check in JSInterface_GameView.cpp.
Feb 27 2021, 5:53 PM
Imarok updated the diff for D3608: Remove unneeded check in JSInterface_GameView.cpp.

Merge some lines as Stan proposed

Feb 27 2021, 4:56 PM
Imarok added inline comments to D3608: Remove unneeded check in JSInterface_GameView.cpp.
Feb 27 2021, 4:50 PM
Imarok added a comment to D3608: Remove unneeded check in JSInterface_GameView.cpp.
In D3608#157305, @Stan wrote:

Why is it unneeded ?

Feb 27 2021, 4:22 PM
Imarok requested review of D3608: Remove unneeded check in JSInterface_GameView.cpp.
Feb 27 2021, 12:46 PM
Imarok committed rP24940: The `SetCameraTarget` script function should not change the orientation.
The `SetCameraTarget` script function should not change the orientation
Feb 27 2021, 10:13 AM
Imarok closed D3569: The `SetCameraTarget` script function should not change the orientation.
Feb 27 2021, 10:13 AM

Feb 19 2021

Imarok added inline comments to D3303: Split treasures from ResourceSupply..
Feb 19 2021, 2:22 PM
Imarok added a comment to D3303: Split treasures from ResourceSupply..
In D3303#156498, @Angen wrote:

@Imarok I believe merchant ships can gather them, or at least one of the available ships could in a23b.

Feb 19 2021, 2:20 PM
Imarok added a comment to D3303: Split treasures from ResourceSupply..

Fine. Now I can't spot any more oversights.
A bit unrelated to this diff: Do you know how the floating treasures are supposed to be gathered? (Ships can't gather them and units can only gather them if the treasures are close at the shore)

Feb 19 2021, 9:24 AM

Feb 18 2021

Imarok added a comment to D3303: Split treasures from ResourceSupply..

Catafalque.

Feb 18 2021, 8:00 PM
Imarok added inline comments to D3303: Split treasures from ResourceSupply..
Feb 18 2021, 7:01 PM

Feb 17 2021

Imarok updated the Trac tickets for D3575: Fix assert in topology.cpp.
Feb 17 2021, 6:19 PM

Feb 16 2021

Imarok added a member for Contributors: DynamoFox.
Feb 16 2021, 5:27 PM
Imarok added a comment to D3572: Fix variant loading order.

Could you add tests for this bug? (So that we prevent regressions ;)
Ofc not for A24.

Feb 16 2021, 12:55 PM

Feb 15 2021

Imarok added a comment to D3569: The `SetCameraTarget` script function should not change the orientation.

Nice :)

Just one question, shouldn't you use the function above?

Feb 15 2021, 9:39 PM
Imarok added a comment to D3569: The `SetCameraTarget` script function should not change the orientation.

Are there more occurences that use this function?

Feb 15 2021, 7:59 PM

Feb 14 2021

Imarok requested review of D3569: The `SetCameraTarget` script function should not change the orientation.
Feb 14 2021, 7:05 PM
Imarok added a comment to D3566: Fix attack notifications with buildings.

Yes, it works. Now its the same for when someone attacks my units. Thanks for noticing and fixing it.
Clicking on the notification takes me to the action hotspot, it changes my camera perspective to the way it was when spawning into the game, if you never change the camera perspective or you press "R" (camera.reset) before clicking on the notification, you won't notice it. It is the same when some of my units are attacked.

Haven't noticed any bad effects otherwise.

Hmm, Good point about the change of the camera perspective. Wanna create a ticket for that?

Feb 14 2021, 6:32 PM
Imarok added inline comments to rP7930: # Redesigned the camera control system..
Feb 14 2021, 6:18 PM
Imarok added a comment to D3566: Fix attack notifications with buildings.

Yes, it works. Now its the same for when someone attacks my units. Thanks for noticing and fixing it.
Clicking on the notification takes me to the action hotspot, it changes my camera perspective to the way it was when spawning into the game, if you never change the camera perspective or you press "R" (camera.reset) before clicking on the notification, you won't notice it. It is the same when some of my units are attacked.

Haven't noticed any bad effects otherwise.

Feb 14 2021, 5:50 PM

Feb 13 2021

Imarok committed rP24904: Fix attack notifications with buildings.
Fix attack notifications with buildings
Feb 13 2021, 10:31 PM
Imarok closed D3566: Fix attack notifications with buildings.
Feb 13 2021, 10:31 PM
Imarok requested review of D3566: Fix attack notifications with buildings.
Feb 13 2021, 10:21 PM
Imarok added inline comments to D3554: JS Interface Profiler2.
Feb 13 2021, 8:43 PM

Feb 10 2021

Imarok committed rP24868: Fix positioning of the research progress icons below the counters overlay.
Fix positioning of the research progress icons below the counters overlay
Feb 10 2021, 6:00 PM
Imarok closed D3525: Fix positioning of the research progress icons below the counters overlay.
Feb 10 2021, 6:00 PM
Imarok added a comment to D3525: Fix positioning of the research progress icons below the counters overlay.

Ah, now I understand what this diff does ^^ (I just tested it.)
Works for me :)

Feb 10 2021, 5:54 PM

Feb 9 2021

Imarok updated the diff for D3525: Fix positioning of the research progress icons below the counters overlay.

missing semi

Feb 9 2021, 6:56 PM
Imarok commandeered D3525: Fix positioning of the research progress icons below the counters overlay.
Feb 9 2021, 6:55 PM

Feb 6 2021

Imarok retitled D3525: Fix positioning of the research progress icons below the counters overlay from Research progress overlay buttons add correct below overlay counters. to Fix positioning of the research progress icons below the counters overlay.
Feb 6 2021, 9:53 PM
Imarok resigned from rP24558: Regroup special technologies..

Fixed by rP24843

Feb 6 2021, 9:34 PM
Imarok committed rP24843: Fix Phoenician Trireme.
Fix Phoenician Trireme
Feb 6 2021, 9:30 PM
Imarok closed D3526: Fix Phoenician Trireme.
Feb 6 2021, 9:30 PM
Imarok added a comment to D3526: Fix Phoenician Trireme.

Feb 6 2021, 9:29 PM
Imarok added inline comments to D3526: Fix Phoenician Trireme.
Feb 6 2021, 9:16 PM
Imarok updated the diff for D3525: Fix positioning of the research progress icons below the counters overlay.

Fix it properly

Feb 6 2021, 9:14 PM
Imarok requested review of D3526: Fix Phoenician Trireme.
Feb 6 2021, 8:42 PM
Imarok raised a concern with rP24558: Regroup special technologies..

Caused #5998

Feb 6 2021, 8:30 PM