Page MenuHomeWildfire Games

Imarok
User

Projects

User Details

User Since
Dec 23 2016, 12:04 AM (142 w, 2 d)

Recent Activity

Tue, Aug 27

Imarok awarded D2197: Add support for recording replay metadata when in nonvisual mode a Like token.
Tue, Aug 27, 12:15 AM

Mon, Aug 26

Imarok awarded rP22773: Fix L10n::FormatMillisecondsIntoDateString memory leak following rP18725, refs… a Like token.
Mon, Aug 26, 11:50 PM

Jul 22 2019

Imarok accepted D2070: Linting: Remove controversial 'curly' eslint rules.

Looks sensible to me.

Jul 22 2019, 9:05 PM

May 21 2019

Imarok committed rP22293: Replace , with . in an AI's chat sentence.
Replace , with . in an AI's chat sentence
May 21 2019, 7:33 PM
Imarok closed D1912: replace , with ..
May 21 2019, 7:33 PM
Imarok added a comment to D1912: replace , with ..

thanks for the patch

May 21 2019, 7:32 PM
Imarok accepted D1912: replace , with ..

Slipped through in rP19194

May 21 2019, 5:26 PM

May 16 2019

Imarok added a comment to D1877: Show summary graphs for teams.
In D1877#78342, @elexis wrote:

One argument for the button is that it looks more streamlined

Yes, I understood your reasoning and it's not inherently wrong to use a button, especially depending on which graphics represent the control elements. I just wanted to point out that that typically checkboxes are used for binary settings and buttons for actions. If I don't use red color, it's not a contractual obligation to perform changes.

Yes, I also understood your reasoning and found the arguments for a checkbox better than the arguments for a button, so I used a checkbox instead. (It appears that also is a reduction in LOC ;) )

May 16 2019, 7:54 PM
Imarok updated the diff for D1877: Show summary graphs for teams.

Fix indent

May 16 2019, 6:27 PM
Imarok updated the diff for D1877: Show summary graphs for teams.

Use a checkbox instead of a toggle button

May 16 2019, 3:49 PM
Imarok added a comment to D1877: Show summary graphs for teams.
In D1877#78328, @elexis wrote:

It's a multiple choice, either it shows the stats grouped per team, or it shows the stats grouped per player.
So naturally the options are:

  • A checkbox
  • A dropdown
  • Radio buttons (in HTML, we don't have it in Pyrogenesis GUI)

The purpose of a button to perform an action, not to trigger an option.
So a checkbox [x] Group per team seems more nearby to the purposes of GUI object types me.

Yeah, that seems like a better alternative. (One argument for the button is that it looks more streamlined.)

May 16 2019, 3:24 PM
Imarok updated the diff for D1877: Show summary graphs for teams.

Remember the state of g_ShowTeamCharts when summary is closed.

May 16 2019, 12:46 PM
Imarok added a comment to D1877: Show summary graphs for teams.

player graphs:

May 16 2019, 12:31 PM
Imarok added a comment to D1892: Add unit motion integration test map.

I guess you should apply the comments of the linter.

May 16 2019, 12:28 PM

May 14 2019

Imarok committed rP22284: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`
May 14 2019, 12:13 PM
Imarok closed D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
May 14 2019, 12:13 PM
Imarok added a comment to D1849: Clarify the use of the macmouse config option.
In D1849#78009, @elexis wrote:

I think it's just a minority of mac users.

@vladislavbelov got numbers on mac users and perhaps number of mouse buttons?
Even without numbers, if we can estimate that the option is relevant to half of mac users, it sounds relevant.
Imagine you have to play on a mac and can't use right click. Your ability to use the game is strongly impacted, no?

Many mac users have normal external mice.
There will also be many that just use "two-finger clicks".
So there should only be about 2%-10% remaining. (I am no mac user, so I am just estimating)

May 14 2019, 12:21 AM

May 13 2019

Imarok added a comment to D1751: [WIP] Map ping.
In D1751#77632, @elexis wrote:

I'd prefer to not use the simulation as imho minimap pings shouldn't be in the simualation. They are a purely gui thing, just as chat.

Seems like I was arguing with myself. I already do the pings as simulation commands. xD Sorry for my confusion.

May 13 2019, 11:31 PM
Imarok committed rP22282: [CChart] Add a percentage format and round displayed integers.
[CChart] Add a percentage format and round displayed integers
May 13 2019, 11:23 PM
Imarok closed D1878: [CChart] Add a percentage format.
May 13 2019, 11:23 PM
Imarok updated the diff for D1878: [CChart] Add a percentage format.

Rounding for INTEGER and PERCENTAGE. Seems saner to me.

May 13 2019, 11:01 PM
Imarok added a comment to D1751: [WIP] Map ping.
In D1751#77680, @elexis wrote:

Yeah it's bad that it will be defined for all GUI objects, but I don't see this as a blocker.

rP22134, adds only a little bit of mess, not a blocker, someone else can fix it afterwards
D1781, adds only a little bit of mess, not a blocker, someone else can fix it afterwards
D1751, adds only a little bit of mess, not a blocker, someone else can fix it afterwards
Who will fix it?
Why should he fix it?
When will he fix it?
Why should the code be introduced with a known defect?
Why do I get accused of wanting to stop people from progressing if I point out anti-patterns that only add a little defect for now that can be fixed in the future by someone else?
Created #5442.

May 13 2019, 10:41 PM
Imarok added a comment to D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.

@weberkai I guess this newer version of the patch still fixes your issues?

May 13 2019, 10:37 PM
Imarok planned changes to D1849: Clarify the use of the macmouse config option.
In D1849#77631, @elexis wrote:

Sure, but I don't think that would match in the manual.

What stops us from keeping the manual in sync?

Yeah, why not.

And why is the manual not the first place to look at if the purpose of the diff is to inform mac users how to adapt their thing rather than in the source that only developers see?
If the setting is relevant to all or the majority of mac users (is it?), why would it be overkill to expose it in the GUI?

I think it's just a minority of mac users.

May 13 2019, 10:33 PM

May 12 2019

Imarok added inline comments to D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
May 12 2019, 1:49 AM
Imarok updated the diff for D1878: [CChart] Add a percentage format.

Make the License Bear happy ;)

May 12 2019, 1:39 AM
Imarok added inline comments to D1878: [CChart] Add a percentage format.
May 12 2019, 1:38 AM
Imarok created D1878: [CChart] Add a percentage format.
May 12 2019, 1:34 AM
Imarok added a comment to D1877: Show summary graphs for teams.
In D1877#77655, @Stan wrote:

How does it handle changing teams during the game ?

May 12 2019, 1:32 AM
Imarok added inline comments to D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
May 12 2019, 1:31 AM
Imarok updated the diff for D1877: Show summary graphs for teams.

Tiny style fix

May 12 2019, 1:17 AM
Imarok updated the diff for D1877: Show summary graphs for teams.

Hide the Toggle button if no teams

May 12 2019, 1:15 AM
Imarok created D1877: Show summary graphs for teams.
May 12 2019, 1:10 AM
Imarok added inline comments to D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
May 12 2019, 12:56 AM
Imarok added inline comments to D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
May 12 2019, 12:25 AM

May 11 2019

Imarok added inline comments to D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
May 11 2019, 11:29 PM
Imarok updated the diff for D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.

direct return

May 11 2019, 11:29 PM
Imarok added inline comments to D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
May 11 2019, 10:56 PM
Imarok updated the diff for D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.

Fix comments.

May 11 2019, 10:56 PM

May 1 2019

Imarok added inline comments to D1856: Fix UnitMotion calculation of time left to avoid units going ever so slightly too fast..
May 1 2019, 2:56 PM
Imarok added a comment to D1856: Fix UnitMotion calculation of time left to avoid units going ever so slightly too fast..

No idea, but does it make sense to test against that behaviour?

May 1 2019, 2:52 PM
Imarok added inline comments to D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
May 1 2019, 12:31 AM
Imarok updated the diff for D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.

Cache replay directory path

May 1 2019, 12:31 AM
Imarok added a comment to D14: [RC] Thread the pathfinder computations.

Way better. Can't see any performance loss compared to svn anymore. 👍

May 1 2019, 12:14 AM

Apr 29 2019

Imarok added a comment to D1851: Automated exploring..
In D1851#76566, @Imarok wrote:

Yeah, that doesn't always have a meaning ;)

I know, but since I had an idea about how to do it, I thought I could just share it with the community and perhaps get some feedback in the process. It is not that I *expect* this to come into the main game, I think it is merely a start ;) And perhaps a help to others.
It would be a shame if bad ideas get lost ;)

Apr 29 2019, 12:58 PM
Imarok added a comment to rP19674: Fix replay menu loading time by using a cache file.

Hi!
Good news!
The Differential D1852 fix the issue!
Awesome work guys! Congratulations!
Thank you very much!

Apr 29 2019, 12:53 PM

Apr 28 2019

Imarok added a comment to D14: [RC] Thread the pathfinder computations.
In D14#76593, @wraitii wrote:
In D14#76586, @Imarok wrote:

Hmm, seems like it takes far longer to load a map.
Just quickly tested with Corinthian Istmus (4):
Svn took about 7 seconds.
With D14 it took about 18 seconds and I got a notice from my OS that it seems like the program has hung up and if I want to go on or quit the program.

That's weird. Is it stuck at 100%? The only thing I can see taking more time is the thread creation, but that really shouldn't add 9 seconds

Yeah, sorry. I measured the time I was stuck at 100%.

Apr 28 2019, 6:38 PM
Imarok added a comment to D14: [RC] Thread the pathfinder computations.

Hmm, seems like it takes far longer to load a map.
Just quickly tested with Corinthian Istmus (4):
Svn stuck about 7 seconds at 100%.
With D14 it stuck about 18 seconds at 100% and I got a notice from my OS that it seems like the program has hung up and if I want to go on or quit the program.

Apr 28 2019, 6:02 PM
Imarok committed rP22234: Don't add the period outside a translated string.
Don't add the period outside a translated string
Apr 28 2019, 5:26 PM
Imarok closed D1366: Don't add the period outside a translated string.
Apr 28 2019, 5:26 PM
Imarok added inline comments to D1751: [WIP] Map ping.
Apr 28 2019, 5:23 PM
Imarok added a comment to D1751: [WIP] Map ping.
In D1751#76309, @elexis wrote:

Perhaps draw vs. display can be made consistent.

Yeah, sure.

There is a conflicting name MT_MinimapPing in components/CCmpMinimap.cpp.
There should only be one minimap ping, so one of the two should be renamed.

I know. I planned to rename the MT_MinimapPing to MT_MinimapBlink

So in the current revision it works this way:

  1. GUI -> send simulation command and displayMapPing locally
  2. Commands.js -> record to replay and broadcast GUI message
  3. messages.js -> displayMapPing -> GetGUIObjectByName("minimap").ping = true and GUIInterface drawTargetMarker;

yes

I mentioned GetGUIObjectByName("minimap").ping(position, template); is also possible by editing the JSInterface_IGUIObject.cpp function (this file should be split into one file per GUI Object type, since the new function will be added to every GUI Object type).
But not having to hardcode the GUI objects seems preferable, then people can add a second minimap if they'd like to, or rename it.

That was what I looked for. Thank you ;)
I'd prefer to take that way. Yeah it's bad that it will be defined for all GUI objects, but I don't see this as a blocker. We can still use two minimaps as long as they both use the MiniMap class.
I'd prefer to not use the simulation as imho minimap pings shouldn't be in the simualation. They are a purely gui thing, just as chat.

Apr 28 2019, 5:17 PM
Imarok added a comment to D1849: Clarify the use of the macmouse config option.
In D1849#76530, @elexis wrote:

Where would you add that to inform the users?

In the files that inform users about hotkeys? Which are the same as:

Which two other places are traditionally kept in sync with this file?

A third place was mentioned in the comments too.

Apr 28 2019, 4:59 PM
Imarok updated the diff for D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.

Fix years

Apr 28 2019, 4:57 PM
Imarok added a comment to D1851: Automated exploring..

Also I saw the ticket

Yeah, that doesn't always have a meaning ;)

Apr 28 2019, 4:55 PM
Imarok added a comment to rP19674: Fix replay menu loading time by using a cache file.

See D1852

Apr 28 2019, 4:51 PM
Imarok created D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
Apr 28 2019, 4:50 PM
Imarok added a comment to rP19674: Fix replay menu loading time by using a cache file.

@elexis should GetDirectoryName really called that name? Isn't GetDirectoryPath more appropriate?

Apr 28 2019, 4:29 PM
Imarok added a comment to D1851: Automated exploring..

Picking hidden gaia entities really sounds like cheating. ;)
Also do we really need scouting? With a few shift+clicks on the minimap a unit can be ordered to scout the whole map.

Apr 28 2019, 4:18 PM
Imarok added a comment to rP19674: Fix replay menu loading time by using a cache file.

@Imarok wanna fix this, have it tested by @weberkai and approved by vladislav and me?

Apr 28 2019, 4:10 PM
Imarok added a comment to D1849: Clarify the use of the macmouse config option.
In D1849#76384, @elexis wrote:
In D1849#76361, @Imarok wrote:
In D1849#76307, @elexis wrote:

Which two other places are traditionally kept in sync with this file?
Also, how many mac players will look at default.cfg?

To my knowledge this is the only place where macmouse is mentioned. It's neither in the manual nor on the hotkeys wikipage as it is no hotkey.

So the intention is just to inform developers who modify default.cfg, but not to inform users with a mac mouse that their hotkeys might need to be changed?

Apr 28 2019, 12:19 PM

Apr 26 2019

Imarok added a comment to D1849: Clarify the use of the macmouse config option.
In D1849#76307, @elexis wrote:

Which two other places are traditionally kept in sync with this file?
Also, how many mac players will look at default.cfg?

Apr 26 2019, 5:08 PM
Imarok added a comment to D1842: Set ship status bars in parent.

Imho the large bar looks to big for the small fishing boat

Apr 26 2019, 5:07 PM
Imarok created D1849: Clarify the use of the macmouse config option.
Apr 26 2019, 2:11 AM
Imarok added a comment to D1751: [WIP] Map ping.

I think we should restrict the number of pings, because I'm sure there will be many spammer on servers.

Apr 26 2019, 2:03 AM
Imarok updated the diff for D1751: [WIP] Map ping.

Rebase and apply the proposed changes

Apr 26 2019, 2:03 AM
Imarok updated the summary of D1751: [WIP] Map ping.
Apr 26 2019, 2:01 AM
Imarok updated the summary of D1751: [WIP] Map ping.
Apr 26 2019, 1:16 AM
Imarok added a comment to D1752: Add GUI events for middle mouse click.

Ok, seems like I shouldn't try using the private svn for phab ^^

Apr 26 2019, 12:25 AM
Imarok updated the diff for D1752: Add GUI events for middle mouse click.

Rebase

Apr 26 2019, 12:22 AM

Apr 25 2019

Imarok added a comment to rP22230: Fix forgotten tab in rP22227 line 1337..

So it was intended. :d

Apr 25 2019, 11:13 PM
Imarok committed rP22230: Fix forgotten tab in rP22227 line 1337..
Fix forgotten tab in rP22227 line 1337.
Apr 25 2019, 11:06 PM
Imarok added inline comments to rP22227: Reload wheel-adjusted batchsize immediately.
Apr 25 2019, 10:59 PM
Imarok added a comment to D1754: Pass an argument to GUI events / SendEventToAll, remove loading screen progess workaround.
In D1754#76083, @elexis wrote:

(Also am I the only one using libboost 1.69.0-2 or am I just the only one too stupid to resolve the build errors? I better get them resolved if I want to commit my own patches)

See https://github.com/boostorg/random/issues/49 (Found by Vladislav)
(Also see discussion at irclogs 2019-04-04 around 21:44)
TLDR: just ignore the notes and wait for boost 1.70

Apr 25 2019, 7:51 PM
Imarok updated the summary of D1751: [WIP] Map ping.
Apr 25 2019, 7:29 PM
Imarok added a comment to D1752: Add GUI events for middle mouse click.
In D1752#72574, @elexis wrote:

I guess worldclick doesn't work since it only reacts after left-click; unless we make that hotkey a modifier (minimap click + hotkey(default shift) for instance).

Yes.

So the question is how minimap ping should be implemented for the people who don't have a third mouse button.
Isn't the usual way to add a button near the minimap, that if clicked changes the input.js state, and if that state is set, both the minimap "worldclick" events and the clicks on the actual 3D world would equally trigger the 'minimap ping'?

Apr 25 2019, 7:28 PM
Imarok committed rP22227: Reload wheel-adjusted batchsize immediately.
Reload wheel-adjusted batchsize immediately
Apr 25 2019, 7:20 PM
Imarok closed D1742: Reload wheel-adjusted batchsize immediately.
Apr 25 2019, 7:20 PM
Imarok updated the diff for D1623: Fix button caption and enable in modmod.

Fix indent spotted by Stan

Apr 25 2019, 7:12 PM
Imarok updated the summary of D1623: Fix button caption and enable in modmod.
Apr 25 2019, 7:03 PM
Imarok updated the diff for D1623: Fix button caption and enable in modmod.

Rebase. Disable Website button if selected mod has no url.

Apr 25 2019, 7:01 PM
Imarok updated the diff for D1366: Don't add the period outside a translated string.

Apply comments of elexis

Apr 25 2019, 6:19 PM
Imarok committed rP22226: Add an experience status bar.
Add an experience status bar
Apr 25 2019, 5:59 PM
Imarok closed D1460: Add an experience status bar.
Apr 25 2019, 5:59 PM
Imarok added a comment to D665: Make ship pickup nicer.
In D665#76122, @elexis wrote:

The expected player experience is that the ship moves to the closest point to the shoreline where the units to be picked up are.
The current behavior is that the ship moves to the correct island, but upon every garrisoning moves to a presumed better location again (which turns out to be a waste of time in many cases).
If I understood the patch correctly, the behavior of the patch is that the ship moves to the closest shoreline, which may be on an entirely different island, at least.
So if I understand the patch correctly, it changes one defect for another.
But the patch might be adapted to match the expected user behavior.

One easy fix would be that the ship won't move if the units can be garrissoned with the ship not moving.
Or just never move the ship.

Apr 25 2019, 2:26 PM
Imarok requested changes to D1842: Set ship status bars in parent.

Seems like that won't work cause of template_unit_ship_fishing.xml

Apr 25 2019, 11:32 AM
Imarok updated the diff for D1461: Hint the location for "You have been attacked" notifications.

Do changes according to inlines

Apr 25 2019, 12:11 AM
Imarok added a comment to D1461: Hint the location for "You have been attacked" notifications.
In D1461#73338, @elexis wrote:

Good.
Now the question remains how we make it visible to the players that this click-feature exists.
Usually the mouse cursor changes when one hovers a link. Underlining won't be supported by our small font base, but adding a sprite should be easily possible (resource icons in tooltips.js / setup_resources.xml as an example).

Apr 25 2019, 12:11 AM

Apr 24 2019

Imarok added a comment to D1786: Refactor input.js.

Didn't look closely at it, but we definitely shouldn't copy the general fsm definition, but instead put it somewhere where UnitAI and input.js can use it.

Apr 24 2019, 10:43 PM
Imarok added a comment to D1837: Input.js refactoring - separate diplomatic tribute in their own file..

not an expert then again.

Apr 24 2019, 10:32 PM

Apr 23 2019

Imarok added a comment to D1482: Target build version explicitly for Xcode.
In D1482#75880, @Stan wrote:
In D1482#75878, @Imarok wrote:
In D1482#75871, @Stan wrote:

I can't really review my own patch ^^

But you can review the changes of the guy that commandeered.

Nothing changed :D

Then I don't see, why he has commandeered it...

Apr 23 2019, 7:12 PM
Imarok updated subscribers of D1482: Target build version explicitly for Xcode.
In D1482#75871, @Stan wrote:

I can't really review my own patch ^^

Apr 23 2019, 3:39 PM

Apr 7 2019

Imarok added a comment to D359: Water shader improvements: fix some of the redness, fix edge-of-map showing up, improve entity-under-water, slight improvement to reflection edges..

@wraitii I guess you have overseen @vladislavbelov's inline comments. ;)

Apr 7 2019, 7:49 PM

Apr 6 2019

nani awarded rP22164: [CSlider] On click move the slider-button to the mouse position a Like token.
Apr 6 2019, 11:07 PM
Imarok committed rP22164: [CSlider] On click move the slider-button to the mouse position.
[CSlider] On click move the slider-button to the mouse position
Apr 6 2019, 8:47 PM
Imarok closed D1622: [CSlider] On click move the slider-button to the mouse position.
Apr 6 2019, 8:47 PM
Imarok added inline comments to D1622: [CSlider] On click move the slider-button to the mouse position.
Apr 6 2019, 3:27 PM

Apr 5 2019

Imarok added inline comments to D1622: [CSlider] On click move the slider-button to the mouse position.
Apr 5 2019, 9:06 AM
Imarok added inline comments to D1622: [CSlider] On click move the slider-button to the mouse position.
Apr 5 2019, 12:09 AM

Apr 4 2019

Imarok added inline comments to D1622: [CSlider] On click move the slider-button to the mouse position.
Apr 4 2019, 11:33 PM