Page MenuHomeWildfire Games

Imarok
User

Projects

User Details

User Since
Dec 23 2016, 12:04 AM (184 w, 1 d)

Recent Activity

Wed, Jul 1

Imarok added a comment to D2848: [WIP] NetClient Threading.

You might want to add some description to this diff like:
What is its state? (TODOs, Bugs, etc)
Did this originate from the diff andy9595 (I think that's the wrong number ;) wrote or was it written by you?

Wed, Jul 1, 9:00 AM

Sat, Jun 27

Imarok updated the diff for D1877: Show summary graphs for teams.

Minor style fixes

Sat, Jun 27, 11:43 PM
Imarok updated the diff for D1877: Show summary graphs for teams.

Translate and use setStringTags

Sat, Jun 27, 11:40 PM

Thu, Jun 25

Imarok added inline comments to D1877: Show summary graphs for teams.
Thu, Jun 25, 1:32 AM
Imarok updated the diff for D1269: Session: Show more command buttons.

Use icons from Stan. No extra icon definition. Remove change crept in from other diff.

Thu, Jun 25, 1:20 AM
Imarok added inline comments to D1269: Session: Show more command buttons.
Thu, Jun 25, 1:20 AM
Imarok added inline comments to D1269: Session: Show more command buttons.
Thu, Jun 25, 12:54 AM
Imarok updated the diff for D1269: Session: Show more command buttons.

Rebase

Thu, Jun 25, 12:51 AM
Stan awarded D2836: When opening the summary as Gaia don't show warnings a Hungry Hippo token.
Thu, Jun 25, 12:41 AM
Imarok created D2836: When opening the summary as Gaia don't show warnings.
Thu, Jun 25, 12:35 AM
Imarok added a comment to D1877: Show summary graphs for teams.

Will commit this soon.
(Still not convinced about the reduction of the duplication. It is probably doable but doesn't get more readable.)

Thu, Jun 25, 12:31 AM
Imarok updated the diff for D1877: Show summary graphs for teams.

Rebase

Thu, Jun 25, 12:24 AM

Wed, Jun 24

Imarok added a comment to D2833: Add where and how to contribute to README.txt.

It's not really consistent in the rest of the file ;)

Wed, Jun 24, 11:20 PM
Imarok committed rP23790: Remove inappropriate quote about women.
Remove inappropriate quote about women
Wed, Jun 24, 11:18 PM
Imarok closed D2832: Remove inappropriate quote about women.
Wed, Jun 24, 11:18 PM

Tue, Jun 23

Imarok added inline comments to D2833: Add where and how to contribute to README.txt.
Tue, Jun 23, 10:45 PM
Imarok added inline comments to D2833: Add where and how to contribute to README.txt.
Tue, Jun 23, 10:16 PM
Imarok updated the diff for D2833: Add where and how to contribute to README.txt.

https

Tue, Jun 23, 10:15 PM
Imarok added a comment to D2832: Remove inappropriate quote about women.

Nor is line 138. To me 138 seems to be in the same vein as e.g. “a true gentleman’s name appears in newspapers only three times in his life: to announce his birth, marriage and death.” Not being talked about was generally a virtue.

any real knowledge about the "real" position of women in this times.

Hmm didn't thought about it that way around. To me the quote just sounded like women should not matter.

Tue, Jun 23, 10:14 PM
Imarok accepted D1206: Absorb duplicated summary tab code to the tab_buttons gui.

Looks very good.
Notice my two comments.

Tue, Jun 23, 9:16 PM
Imarok added a comment to D2832: Remove inappropriate quote about women.

How is this fundamentally different from e.g. line 52 or 199? Or the way female citizens are presented in game (i.e. cheap, weak, expendable workers)?
I don't really care about this particular quote, but once you start censoring ancient authors based on modern views of political correctness, you enter a slippery slope.

Tue, Jun 23, 8:43 PM
Imarok created D2833: Add where and how to contribute to README.txt.
Tue, Jun 23, 8:09 PM
Imarok created D2832: Remove inappropriate quote about women.
Tue, Jun 23, 7:42 PM

Sun, Jun 21

Imarok committed rP23784: CVector2D: Fix members may not be initialized warnings.
CVector2D: Fix members may not be initialized warnings
Sun, Jun 21, 8:23 PM
Imarok closed D2825: CVector2D: Fix members may not be initialized warnings.
Sun, Jun 21, 8:23 PM
Imarok updated the diff for D1751: [WIP] Map ping.

Rebase

Sun, Jun 21, 8:00 PM
Imarok updated the summary of D1751: [WIP] Map ping.
Sun, Jun 21, 7:57 PM
Imarok updated the summary of D1751: [WIP] Map ping.
Sun, Jun 21, 7:46 PM
Imarok updated the summary of D1751: [WIP] Map ping.
Sun, Jun 21, 7:42 PM
Imarok updated the diff for D1751: [WIP] Map ping.

Add frames for an animated ping.

Sun, Jun 21, 7:41 PM
Imarok updated the summary of D1751: [WIP] Map ping.
Sun, Jun 21, 5:06 PM
Imarok updated the diff for D1751: [WIP] Map ping.

Correct scissoring → Don't draw parts of the ping outside the minimap.

Sun, Jun 21, 4:55 PM
Imarok added a comment to D2825: CVector2D: Fix members may not be initialized warnings.

Hm, this technically could be a small performance regression if the uninitialisation is on purpose. Though I'm not sure it is from comparing with CVector3.

Yeah, in theory. But I doubt it has a real impact. And as you also noticed we already do it in CVector3D

I'm not sure we use CVector2 a lot so it's probably irrelevant.

Yep.

Sun, Jun 21, 4:25 PM

Sat, Jun 20

Imarok added inline comments to D1751: [WIP] Map ping.
Sat, Jun 20, 11:53 AM
Imarok added a comment to D1751: [WIP] Map ping.

Seems like this does not work with GLSL disabled.

Sat, Jun 20, 11:13 AM
Imarok created D2825: CVector2D: Fix members may not be initialized warnings.
Sat, Jun 20, 9:42 AM

Mon, Jun 15

Imarok added a comment to D2815: [gameplay] give all civs rams.

Isn't this another step into making the different civs indistinguishable?
Wrt rams vs rams: Afaik swordmen are quite effective against rams aren't they?

Mon, Jun 15, 9:48 AM

Sun, Jun 14

Imarok updated the diff for D1751: [WIP] Map ping.

Use a circle texture.

Sun, Jun 14, 8:11 PM

Sat, Jun 13

Imarok added a comment to D2814: Allow remapping hotkeys from inside the game / fix QWERTY hotkeys.

I think you should split the string fix.
And you should show some translated explanation for each hotkey instead of it's config name.

Sat, Jun 13, 8:34 PM

Fri, Jun 12

Imarok added a comment to D2812: Adds MSAA to anti-aliasing techniques.

Does MSAA 32× make sense?

I don't think so, I see no difference with 32 (also I don't remember such value in most games).

Me neither xD

Seems like not working when changing in atlas.

It's disabled in Atlas, because it uses wxWidgets's canvas with own GL context.

aha. I guess that makes sense. (I personally have no idea, about that topic ;P)

Fri, Jun 12, 11:33 PM
Imarok added a comment to rP23747: Refactor HWDetect and rendering options setup..
../../../source/ps/GameSetup/HWDetect.cpp:138:13: warning: ‘bool IsOverridden(const char*)’ defined but not used [-Wunused-function]
 static bool IsOverridden(const char* setting)
Fri, Jun 12, 11:28 PM
Imarok added a comment to D2812: Adds MSAA to anti-aliasing techniques.

Looks really sharp. Does MSAA 32× make sense?
Can change ingame without issues.
Seems like not working when changing in atlas. (FXAA is working)

Fri, Jun 12, 11:01 PM

Jun 1 2020

Imarok committed rP23727: Improve the warning message for FromJSValue<CColor> when trying to convert a….
Improve the warning message for FromJSValue<CColor> when trying to convert a…
Jun 1 2020, 6:09 PM
Imarok closed D2778: Improve the warning message for FromJSValue<CColor>.
Jun 1 2020, 6:09 PM
Imarok added a comment to D2778: Improve the warning message for FromJSValue<CColor>.
In D2778#117793, @Stan wrote:

The mac build failiure in unrelated. Itms disabled Mac SVN build until he has some time to address the bug. Linux one is the usual segfault.

Jun 1 2020, 6:02 PM
Imarok created D2778: Improve the warning message for FromJSValue<CColor>.
Jun 1 2020, 12:01 PM

May 30 2020

Imarok added a comment to D2651: Allow right-click on disabled buttons..

Hmm, it feels quite wrong to allow a disabled button to be pressed when it's disabled in general.
What about adding a special event for rightlclick on disabled button?
That way a disabled button is still disabled, but one can add a special event handler for a specific button if they really want to react to a right-click even if the button is disabled. (Like in case of unit buttons)

May 30 2020, 4:12 PM

May 29 2020

Imarok updated the diff for D1751: [WIP] Map ping.

Small style fixes.

May 29 2020, 10:00 PM
Imarok updated the diff for D1751: [WIP] Map ping.

This patch is still WIP.

May 29 2020, 8:47 PM

May 24 2020

Imarok added a comment to D2362: Allow for building-specific build/repair animations and use seeding animation for fields.

I kind of get how you want to do this. It sounds sane.
But I've never done something with our animations/variants etc. so I'll need to look into it first. I'll do that when I find the time.
If you think it's a quick no-brainer for you, feel free to commandeer. ;)

It's quite easy: you set the animation variant, and in the groups you have something like:

<group>
  <variant name="default0" frequency="0.5">
    <animation name='Idle' ... />
  </variant>
  <variant name="default1" frequency="0.5">
    <animation name='Idle' ... />
  </variant>
  <variant name="build_field" frequency="0">  <- this never gets picked, unless the animation variant is "build_field", in which case it always gets picked
    <animation name='Idle' ... />
  </variant>
</group>

Ah, that's how I imagined it :)

May 24 2020, 12:18 PM
Imarok added a comment to D2362: Allow for building-specific build/repair animations and use seeding animation for fields.

Anyways, don't bother with XML, just do like carrying animations: define a variant build_{generic building name} (instead of an animation) and set it when building. Then make sure to create a group with the build animations only, and let the default one(s) have some >0 frequency, and name one "build_farm" with frequency 0. Then your units will do what you want automagically.
(you'll need to use "Idle" for your animation name when Idle, but that's OK).

May 24 2020, 11:58 AM

May 22 2020

Imarok changed the visibility for P206 A better fix for rP23690?.
May 22 2020, 10:54 PM
Imarok edited P206 A better fix for rP23690?.
May 22 2020, 10:54 PM
Imarok edited P205 Disable gcc warning introduced by rP23690.
May 22 2020, 10:44 PM
Imarok changed the visibility for P205 Disable gcc warning introduced by rP23690.
May 22 2020, 10:42 PM
Imarok edited P205 Disable gcc warning introduced by rP23690.
May 22 2020, 10:42 PM

May 17 2020

Imarok added a comment to D1751: [WIP] Map ping.

Note to self: According to Vladislav a texture should be used to draw circles. Scaling should be done with "adding tex coords and so on". Entry point for understanding how that works could be OverlayRenderer::RenderForegroundOverlays.

May 17 2020, 9:18 PM

May 16 2020

Imarok awarded D2476: Remove obsolete GetVideoMode platform-specifics a Love token.
May 16 2020, 12:38 PM

May 15 2020

Imarok added a comment to D1849: Clarify the use of the macmouse config option.
In D1849#87712, @elexis wrote:

Precisely because they have no idea how to fix this, the one line in options.json is the right fix isn't it?

Then the next issues comes straight ahead: The user needs to remap attack-move and garrisson.
Yeah, we could change that in the same go, but no idea to what key we should remap that.
(And not the free time to look into it)

May 15 2020, 6:42 PM
Imarok updated the summary of D1751: [WIP] Map ping.
May 15 2020, 6:08 PM

May 10 2020

Imarok committed rP23653: Enable preSelectedi actions on the minimap.
Enable preSelectedi actions on the minimap
May 10 2020, 4:22 PM
Imarok closed D2728: Enable preSelectedAction on the minimap.
May 10 2020, 4:22 PM
Imarok committed rP23652: IGUIObject ScriptEventi: optional return value for signalling if the event has….
IGUIObject ScriptEventi: optional return value for signalling if the event has…
May 10 2020, 4:01 PM
Imarok closed D2727: IGUIObject ScriptEvent return value.
May 10 2020, 4:01 PM
Imarok updated the diff for D2728: Enable preSelectedAction on the minimap.

Don't recreate the bug fixed by D2729

May 10 2020, 3:34 PM
Imarok committed rP23651: Allow "orderone"-hotkey for preselected actions..
Allow "orderone"-hotkey for preselected actions.
May 10 2020, 1:12 PM
Imarok closed D2729: Allow "orderone"-hotkey for preselected actions..
May 10 2020, 1:12 PM
Imarok accepted D2729: Allow "orderone"-hotkey for preselected actions..

Good.

May 10 2020, 1:01 PM
Imarok added a comment to D2729: Allow "orderone"-hotkey for preselected actions..

Never thought that someone might want to use orderone for preselcted actions xD

May 10 2020, 12:15 PM

May 9 2020

Imarok updated the diff for D2728: Enable preSelectedAction on the minimap.

Don't upload changes from D2727

May 9 2020, 8:31 PM
Imarok created D2728: Enable preSelectedAction on the minimap.
May 9 2020, 8:25 PM
Imarok added inline comments to D2727: IGUIObject ScriptEvent return value.
May 9 2020, 8:08 PM
Imarok added a comment to D2727: IGUIObject ScriptEvent return value.

I didn't understand how this function will be used exactly, but if CMinimap.cpp will consume a boolean, is it conceivable that it will consume a number or string (for example the type of the preselected action), or another GUI object type consuming another object?

No.
I kind of explained already why I need this diff. But I hope my next diff makes it clearer.

May 9 2020, 7:00 PM
Imarok added inline comments to D2727: IGUIObject ScriptEvent return value.
May 9 2020, 6:52 PM
Imarok updated the diff for D2727: IGUIObject ScriptEvent return value.

consistent return and correct include.

May 9 2020, 6:32 PM
Imarok added a comment to D2727: IGUIObject ScriptEvent return value.

WithReturn can be avoided from the name, the functions are distinguished by signature already and do the same except return value.

Why? They have the same signature and only distinguish in the return value. Some parts of the gui need ScriptEvent to have no return value. (e.g. RecurseObject)

Is there a compile error if RecurseObject gets a function with ignorable return value instead of a void?
Aside from that one can still name the void and function the same way if both signatures are necessary and the compiler will chose the signature it needs.

No, you can't overload a function only by changing the return type.

This can be used to get a feedback if the function called through ScriptEvent handled the event.

It sounds like boolean would restrict the use cases of that function then, that the caller that expects a boolean can do that after calling the function and that other callers might consume something other than boolean.

So you propose just returning a JSValue?

I dont know the use case envisioned but the use case seems conceivable in gernal, so diff direction seems correct.

I already teased the use case in the diffs description: the bool will say whether this event has been handled or not.
I can't think of use cases, that use a nonboolean return value.

Just because we can't conceive use cases of non-boolean return values doesnt mean that its best to cast the return value to boolean in any case - the alternative is to let the caller decide, if a caller wants bools, it can cast to bool, if a caller wants a function, string or numbers as return value, it can use it, but not if it only provides a boolean. So the only reason to cast tobool in that function would be if there would be many callers that all want booleans (i.e. too much code duplication), or if returning the JS value would cost more performance, but as far as I know it only returns a pointer that already exists.
I.e. cast to bool inside the function would be useful if it improves performance or avoids 20+ bool conversions outside of the caller, otherwise the function becomes more versatile if its the caller that casts to bool.

May 9 2020, 6:15 PM
Imarok added inline comments to D2727: IGUIObject ScriptEvent return value.
May 9 2020, 4:51 PM
Imarok added a comment to D2727: IGUIObject ScriptEvent return value.

WithReturn can be avoided from the name, the functions are distinguished by signature already and do the same except return value.

Why? They have the same signature and only distinguish in the return value. Some parts of the gui need ScriptEvent to have no return value. (e.g. RecurseObject)

This can be used to get a feedback if the function called through ScriptEvent handled the event.

It sounds like boolean would restrict the use cases of that function then, that the caller that expects a boolean can do that after calling the function and that other callers might consume something other than boolean.

So you propose just returning a JSValue?

I dont know the use case envisioned but the use case seems conceivable in gernal, so diff direction seems correct.

May 9 2020, 4:50 PM

May 8 2020

Imarok created D2727: IGUIObject ScriptEvent return value.
May 8 2020, 11:56 PM

May 3 2020

Imarok committed rP23619: Show correct action cursor over minimap.
Show correct action cursor over minimap
May 3 2020, 12:33 PM
Imarok closed D2718: Show correct cursor over minimap.
May 3 2020, 12:33 PM
Imarok added inline comments to D2718: Show correct cursor over minimap.
May 3 2020, 11:51 AM
Imarok accepted rP23484: Adds anti-aliasing option with FXAA algorithm..
May 3 2020, 11:40 AM
Krinkle awarded D2718: Show correct cursor over minimap a Love token.
May 3 2020, 3:54 AM

May 2 2020

Imarok updated the diff for D2718: Show correct cursor over minimap.

Rebase upon D2719

May 2 2020, 11:07 PM
Imarok committed rP23616: Minimap → MiniMap and consistent return.
Minimap → MiniMap and consistent return
May 2 2020, 11:04 PM
Imarok closed D2719: Minimap → MiniMap and consistent return.
May 2 2020, 11:04 PM
Imarok retitled D2719: Minimap → MiniMap and consistent return from Minimap → MiniMap to Minimap → MiniMap and consistent return.
May 2 2020, 11:02 PM
Imarok updated the diff for D2719: Minimap → MiniMap and consistent return.

Consistent return

May 2 2020, 10:50 PM
Imarok created D2719: Minimap → MiniMap and consistent return.
May 2 2020, 10:21 PM
Imarok updated the diff for D2718: Show correct cursor over minimap.

Dot after comment and use a getter to comply with OOP

May 2 2020, 9:48 PM
Imarok added inline comments to D2718: Show correct cursor over minimap.
May 2 2020, 9:42 PM
Imarok added inline comments to D2718: Show correct cursor over minimap.
May 2 2020, 9:13 PM
Imarok added a comment to D1751: [WIP] Map ping.

This is great! Can we add a keybinding to ping on the center of the current camera view?

May 2 2020, 6:43 PM
Imarok added a comment to D2718: Show correct cursor over minimap.

Looks like a sane and small scoped change for me. So I'll commit that in the coming days if nobody objects.

May 2 2020, 6:37 PM
Imarok updated the diff for D2718: Show correct cursor over minimap.

Remove superfluous newline

May 2 2020, 6:34 PM
Imarok updated the diff for D2718: Show correct cursor over minimap.

Add comment explaining why we disable preselcted actions on minimap

May 2 2020, 6:33 PM
Imarok created D2718: Show correct cursor over minimap.
May 2 2020, 6:28 PM

Apr 19 2020

Imarok added a reverting change for D1752: Add GUI events for middle mouse click: rP23589: Revert rP23505 / r23505.
Apr 19 2020, 2:31 PM
Imarok added a reverting change for rP23505: Add GUI events for middle mouse click: rP23589: Revert rP23505 / r23505.
Apr 19 2020, 2:31 PM