Page MenuHomeWildfire Games

Imarok
User

Projects

User Details

User Since
Dec 23 2016, 12:04 AM (252 w, 6 d)

Recent Activity

Sep 3 2021

Imarok awarded D4249: [Gameplay] The Mauryan working elephant is building again a Love token.
Sep 3 2021, 8:39 AM

Jun 26 2021

Imarok added inline comments to D4183: Fix rare crash when opening dropdowns..
Jun 26 2021, 11:44 AM

Jun 13 2021

Imarok committed rP25783: Small tweak of map flare characteristics.
Small tweak of map flare characteristics
Jun 13 2021, 12:35 AM
Imarok closed D4099: Small tweak of map flare characteristics.
Jun 13 2021, 12:35 AM

Jun 12 2021

Imarok added a comment to D4156: Update the splash screen.

Right, what do you think of different icons?

Jun 12 2021, 8:32 PM

Jun 11 2021

Imarok committed rP25775: Add a setting for the minimap flare lifetime..
Add a setting for the minimap flare lifetime.
Jun 11 2021, 10:47 PM
Imarok closed D4135: Add a setting for the minimap flare lifetime..
Jun 11 2021, 10:47 PM
Imarok updated the diff for D4099: Small tweak of map flare characteristics.

Update wrt D4135 and fix comment wording

Jun 11 2021, 10:33 PM
Imarok retitled D4099: Small tweak of map flare characteristics from Small tweak to map flare characteristics to Small tweak of map flare characteristics.
Jun 11 2021, 10:19 PM
Imarok added a comment to D4099: Small tweak of map flare characteristics.

When the max is 120 sec as in D4135 implemented, I wouldn't lower the cooldown (or at least not so much). It can get quite crowded otherwise. Maybe 4?

Jun 11 2021, 9:08 PM
Imarok committed rP25774: Remove duplicated loading tip images.
Remove duplicated loading tip images
Jun 11 2021, 9:07 PM

Jun 10 2021

Imarok committed rP25768: Loading tips: Dynamically adjust the title height and fix the width.
Loading tips: Dynamically adjust the title height and fix the width
Jun 10 2021, 9:59 PM
Imarok closed D4152: Loading tips: Dynamically adjust the title height.
Jun 10 2021, 9:59 PM
Imarok added a comment to rP25767: Brush up the loading tips.

Created a diff: D4151

Jun 10 2021, 9:30 PM
Imarok updated the diff for D4152: Loading tips: Dynamically adjust the title height.

Make the bot happy with const

Jun 10 2021, 9:27 PM
Imarok updated the diff for D4135: Add a setting for the minimap flare lifetime..

CMiniMap: Use floats for flareLifetime and animationSpeed.
js: use a slider.

Jun 10 2021, 8:58 PM
Imarok requested review of D4152: Loading tips: Dynamically adjust the title height.
Jun 10 2021, 8:53 PM
Imarok updated the summary of D4135: Add a setting for the minimap flare lifetime..
Jun 10 2021, 8:50 PM
Imarok abandoned D4151: Correction for tips committed with rP25767.

Better fix at D4152

Jun 10 2021, 8:42 PM
Imarok accepted D4146: Look for resources near the order when forced..

Looks fine.
The search radius seems to be a bit big for my test in general, but I guess that's not in the scope of this diff.

Jun 10 2021, 7:33 PM
Imarok committed rP25767: Brush up the loading tips.
Brush up the loading tips
Jun 10 2021, 7:25 PM
Imarok closed D4107: new loading tips.
Jun 10 2021, 7:25 PM
Imarok added a comment to D4146: Look for resources near the order when forced..

I got a group of 26 ladies and ordered them to chop those trees trees, two ladies would go the other way.


In A23b the 2 ladies would have gone with the other 24 ladies and then returned to the CC without wood, I guess this problem arose as a result of the solution to the problem I mentioned earlier?

I think that's heavily distance dependent. I don't think it's completely broken for the 2 women to go on the left tbh.

Jun 10 2021, 6:04 PM

Jun 9 2021

Imarok added a comment to D4132: Tentative fix for #6092 - alt+F4 is retriggerd on linux..

Maybe add some comment that the exit hotkey is a bit broken on Linux?

Jun 9 2021, 7:46 PM
Imarok added a comment to D4132: Tentative fix for #6092 - alt+F4 is retriggerd on linux..

Works.
Successfully hides the issue.

Jun 9 2021, 7:16 PM
Imarok raised a concern with rP24215: Let players remap hotkeys in-game, fix default hotkeys being qwerty-specific..

introduced #6092

Jun 9 2021, 7:13 PM
Imarok committed rP25761: Disable the flare button for observers..
Disable the flare button for observers.
Jun 9 2021, 6:35 PM
Imarok closed D4136: Disable the flare button for observers..
Jun 9 2021, 6:34 PM

Jun 8 2021

Imarok updated the diff for D4136: Disable the flare button for observers..

Style

Jun 8 2021, 8:59 PM
Imarok requested review of D4136: Disable the flare button for observers..
Jun 8 2021, 8:58 PM
Imarok requested review of D4135: Add a setting for the minimap flare lifetime..
Jun 8 2021, 8:46 PM
Imarok added inline comments to D4107: new loading tips.
Jun 8 2021, 8:46 PM
Imarok edited P253 prints for #6092.
Jun 8 2021, 7:47 PM
Imarok created P253 prints for #6092.
Jun 8 2021, 7:37 PM
Imarok requested changes to D4132: Tentative fix for #6092 - alt+F4 is retriggerd on linux..

doesn't fix the issue

Jun 8 2021, 7:31 PM
Imarok added inline comments to D4107: new loading tips.
Jun 8 2021, 6:40 AM

Jun 7 2021

Imarok accepted D4116: Add description for new hotkeys.

Thx, for the patch.
Wording is good.

Jun 7 2021, 8:18 PM
Imarok added a comment to D4108: Adds FreeType support to the engine.

With @s0600204's proposed changes and running apt install libfreetype6-dev it compiles on Ubuntu 20.04 and reports:

"freetype": "2.10.1",

That is the correct version.

Jun 7 2021, 7:49 PM

Jun 6 2021

Imarok committed rP25716: Don't open the template viewer when in special input state.
Don't open the template viewer when in special input state
Jun 6 2021, 9:02 PM
Imarok closed D4105: Don't open the template viewer when in special input state.
Jun 6 2021, 9:01 PM
Imarok requested review of D4105: Don't open the template viewer when in special input state.
Jun 6 2021, 8:58 PM
Imarok committed rP25715: Add a hotkey to focus on the last attack alarm.
Add a hotkey to focus on the last attack alarm
Jun 6 2021, 8:31 PM
Imarok closed D4101: Add a hotkey to focus on the last attack alarm.
Jun 6 2021, 8:30 PM
Imarok updated the diff for D4101: Add a hotkey to focus on the last attack alarm.

Constify

Jun 6 2021, 6:35 PM
Imarok updated the diff for D4099: Small tweak of map flare characteristics.

Play the animation a bit faster

Jun 6 2021, 6:19 PM
Imarok requested review of D4101: Add a hotkey to focus on the last attack alarm.
Jun 6 2021, 6:13 PM
Imarok committed rP25710: Don't store the camera pointer in the minimap.
Don't store the camera pointer in the minimap
Jun 6 2021, 6:09 PM
Imarok closed D4100: Don't store the camera pointer in the minimap.
Jun 6 2021, 6:09 PM
Imarok updated the Trac tickets for D4100: Don't store the camera pointer in the minimap.
Jun 6 2021, 5:59 PM
Imarok requested review of D4100: Don't store the camera pointer in the minimap.
Jun 6 2021, 5:51 PM
Imarok requested review of D4099: Small tweak of map flare characteristics.
Jun 6 2021, 4:56 PM
Imarok added a comment to D4091: Bring back the sun to Sahyadri Buttes.

<Environment>

		<SkySet>stratus</SkySet>
		<SunColor r="0.996863" g="0.971569" b="0.853922"/>
		<SunElevation angle="0.74756"/>
		<SunRotation angle="-1.18019"/>
		<AmbientColor r="0.364706" g="0.376471" b="0.419608"/>
		<Fog>
			<FogFactor>0.000253906</FogFactor>
			<FogThickness>0</FogThickness>
			<FogColor r="0.8" g="0.847059" b="0.929412"/>
		</Fog>
		<Water>
			<WaterBody>
				<Type>lake</Type>
				<Color r="0" g="0.247059" b="0"/>
				<Tint r="0" g="0.501961" b="0"/>
				<Height>19.9</Height>
				<Waviness>1.16211</Waviness>
				<Murkiness>0.876953</Murkiness>
				<WindAngle>-0.13499</WindAngle>
			</WaterBody>
		</Water>
		<Postproc>
			<Brightness>0.0263438</Brightness>
			<Contrast>1.095516</Contrast>
			<Saturation>0.847875</Saturation>
			<Bloom>0.16</Bloom>
			<PostEffect>hdr</PostEffect>
		</Postproc>

</Environment>

Jun 6 2021, 3:08 PM

Jun 5 2021

Imarok added a comment to D4091: Bring back the sun to Sahyadri Buttes.

I somewhat agree, maybe there's a middle ground to find?

Jun 5 2021, 8:14 PM
Imarok committed rP25691: Map flares.
Map flares
Jun 5 2021, 7:37 PM
Imarok closed D1751: [WIP] Map flares.
Jun 5 2021, 7:37 PM
Imarok accepted D4092: Fix gamesetup player assignment issue when joining.

Can't find any bugs with that.

Jun 5 2021, 6:17 PM
Imarok updated the diff for D1751: [WIP] Map flares.

adjust other minimap buttons.
Don't crash for negative flare count.

Jun 5 2021, 6:12 PM
Imarok requested changes to D4092: Fix gamesetup player assignment issue when joining.

Just for documentation (already discussed on irc):

  1. Host a game
  2. choose rmgen map with 4 players
  3. unassign all slots
  4. join with second client
  5. assign second client to slot 3
  6. leave with second client
  7. set map to 1 player
  8. join again with second client
Jun 5 2021, 5:13 PM
Imarok updated the diff for D1751: [WIP] Map flares.

Don't show flare cursors for observers.

Jun 5 2021, 4:20 PM
Imarok requested review of D4091: Bring back the sun to Sahyadri Buttes.
Jun 5 2021, 3:38 PM
Imarok updated the diff for D1751: [WIP] Map flares.

Observers shall not flare

Jun 5 2021, 3:26 PM
Imarok added a comment to D1751: [WIP] Map flares.

The map flare as an observer can be done via the minimap button but it does not work via hotkey. Map flares was not possible with diffID 17960 at all.


Seems inconsistent that it only works via the button but not the hotkey. I would like to have this map flare for observers, discussing player strategies would help locate the place of interest more easily instead of writing text.

Jun 5 2021, 3:01 PM
Imarok added a comment to D1751: [WIP] Map flares.

Will commit that today.
(If no major issues appear)

Jun 5 2021, 9:42 AM

Jun 4 2021

Imarok added inline comments to D1751: [WIP] Map flares.
Jun 4 2021, 10:08 PM
Imarok updated the diff for D1751: [WIP] Map flares.

Add hotkey to activate flare mode.
Always flare on left click but also flare on rightclick when using the direct hotkey.
Apply inlines by Vladislav and wraitii.

Jun 4 2021, 10:03 PM
Imarok added inline comments to D4083: Fix invalid translation in options.json.
Jun 4 2021, 9:58 PM
Imarok added a comment to D1751: [WIP] Map flares.

PS: I still think the icon needs to be redesigned, maybe the creator of DE could create one for you. The icon is so thin and tall, it should be wide and short.

Our artist designed it and who am I to disagree with that ;P (Honestly: You might be right. I like the current one.)

Also, when I press the "MapFlare" icon above the minimap I have to do a "left click" with the mouse, when I press the "K" key I have to do a "right click", seems inconsistent, shouldn't it be the same "left or right click"?

I copied the behaviour of the unit command buttons.
There it is also right click when using the hotkey and left click when preselecting an action with a gui button.
(Though as you are not the first who complains, I might need to change the flare behaviour...)

Jun 4 2021, 6:34 PM
Imarok committed rP25676: Fix borders of game description in gamesetup.
Fix borders of game description in gamesetup
Jun 4 2021, 6:31 PM
Imarok closed D4074: Fix borders of game description in gamesetup.
Jun 4 2021, 6:31 PM
Imarok updated the diff for D1751: [WIP] Map flares.

Forgot an include

Jun 4 2021, 12:33 AM
Imarok updated the diff for D1751: [WIP] Map flares.

Use the new Canvas2D

Jun 4 2021, 12:19 AM

Jun 3 2021

Imarok requested review of D4074: Fix borders of game description in gamesetup.
Jun 3 2021, 10:44 PM
Imarok committed rP25647: Fix ignoring arrays as supported biomes in gamesetup.
Fix ignoring arrays as supported biomes in gamesetup
Jun 3 2021, 12:04 AM
Imarok closed D4044: Fix ignoring arrays as supported biomes in gamesetup.
Jun 3 2021, 12:04 AM

Jun 2 2021

Imarok committed rP25646: Delete test .zip file after running tests.
Delete test .zip file after running tests
Jun 2 2021, 11:31 PM
Imarok closed D4043: Delete test zip after test.
Jun 2 2021, 11:31 PM
Imarok awarded D4055: Random Map: Fjords a Love token.
Jun 2 2021, 10:59 AM
Imarok added a comment to D4053: Random Maps: Echo Valley & Echo Shores.

(Easier to get a first grasp of the diff it contains an example picture)

Jun 2 2021, 10:57 AM

Jun 1 2021

Imarok added a comment to D4044: Fix ignoring arrays as supported biomes in gamesetup.

I think I missed this being part of the spec, TBH.

Jun 1 2021, 10:35 PM

May 31 2021

Imarok requested review of D4044: Fix ignoring arrays as supported biomes in gamesetup.
May 31 2021, 11:17 PM
Imarok added inline comments to rP25077: Separate Game Settings from the GUI Gamesetup.
May 31 2021, 10:53 PM
Imarok added a comment to rP25077: Separate Game Settings from the GUI Gamesetup.
May 31 2021, 10:47 PM
Imarok requested review of D4043: Delete test zip after test.
May 31 2021, 9:24 PM

May 30 2021

Imarok added a comment to D1751: [WIP] Map flares.

Is it waiting for something in order to be committed?

May 30 2021, 12:36 PM

May 28 2021

Imarok added a comment to D4016: [WIP] Hide overlaying Overlay Counters.

Do you have an alternative idea?

Make all message boxes provide counters and add the mentioned events x)

May 28 2021, 6:49 PM
Imarok committed rP25587: CList, COList, CDropdown, CText, CInput: Draw borders above the rest and….
CList, COList, CDropdown, CText, CInput: Draw borders above the rest and…
May 28 2021, 6:32 PM
Imarok closed D4004: CList, COList, CDropdown, CText, CInput: Draw borders above the rest and improve scrollbar drawing order.
May 28 2021, 6:32 PM
Imarok added a comment to D4016: [WIP] Hide overlaying Overlay Counters.

In what way?

In it's implementation. A lot of g_OverlayCounterManager.hide(true); are spreaded all over the code (including many onPress events totally unrelated to the overlays) and related strictly to PushPage. Which means you also duplicate a logic without a strict check. Since anyone can miss adding the call.

May 28 2021, 6:29 PM
Imarok added a comment to D4016: [WIP] Hide overlaying Overlay Counters.

pushPage popPage

May 28 2021, 6:18 PM
Imarok retitled D4016: [WIP] Hide overlaying Overlay Counters from Hide overlaying Overlay Counters to [WIP] Hide overlaying Overlay Counters.
May 28 2021, 5:54 PM
Imarok updated the diff for D4016: [WIP] Hide overlaying Overlay Counters.

Add PageRegainedFocus event and tests for some cases. (Currently crashing)

May 28 2021, 5:54 PM

May 26 2021

Imarok added a comment to D4016: [WIP] Hide overlaying Overlay Counters.

It seems like that won't really work.
E.g. messageboxes also use PushGuiPage but they don't provide their own Overlay Counters.

Hm, indeed, quite annoying.
Though you could still use it for "un-hiding" the overlay. That way you don't have to pollute the callbacks. You still need to explicitly hide, but that's easier done IMO.

May 26 2021, 11:30 AM
Imarok updated subscribers of rP25570: Fix some error in rmgen..

The fix looks like a workaround unrelated code since there is no usages of ‘getPoints’ in the near scope, maybe move it closer to its usage.

May 26 2021, 11:29 AM

May 25 2021

Imarok added a comment to D4017: Fix some error in rmgen..

This fix looks good to me and solves the issue of the map not loading for certain seed values.

May 25 2021, 11:28 PM
Imarok committed rP25570: Fix some error in rmgen..
Fix some error in rmgen.
May 25 2021, 11:26 PM
Imarok closed D4017: Fix some error in rmgen..
May 25 2021, 11:26 PM
Imarok requested review of D4017: Fix some error in rmgen..
May 25 2021, 7:48 PM
Imarok added inline comments to D4016: [WIP] Hide overlaying Overlay Counters.
May 25 2021, 5:57 PM
Imarok added a comment to D4016: [WIP] Hide overlaying Overlay Counters.

It's a bit annoying that you have to pass callbacks every time...

I think I'd prefer if you modified CGUI.cpp (or something) to send an event on:

  • page gets focus
  • page loses focus

And then the overlay could react on its own.
I think it might even be easier to implement.

Yeah, that also annoyed me. I looked for this kind of event but couldn't find it...
I didn't thought about implementing it myself xD
I'll look into it.

May 25 2021, 5:53 PM
Imarok added a comment to D4016: [WIP] Hide overlaying Overlay Counters.

It's a bit annoying that you have to pass callbacks every time...

I think I'd prefer if you modified CGUI.cpp (or something) to send an event on:

  • page gets focus
  • page loses focus

And then the overlay could react on its own.
I think it might even be easier to implement.

May 25 2021, 4:32 PM