Page MenuHomeWildfire Games

Imarok
User

Projects

User Details

User Since
Dec 23 2016, 12:04 AM (217 w, 6 d)

Recent Activity

Fri, Feb 19

Imarok added inline comments to D3303: Split treasures from ResourceSupply..
Fri, Feb 19, 2:22 PM
Imarok added a comment to D3303: Split treasures from ResourceSupply..
In D3303#156498, @Angen wrote:

@Imarok I believe merchant ships can gather them, or at least one of the available ships could in a23b.

Fri, Feb 19, 2:20 PM
Imarok added a comment to D3303: Split treasures from ResourceSupply..

Fine. Now I can't spot any more oversights.
A bit unrelated to this diff: Do you know how the floating treasures are supposed to be gathered? (Ships can't gather them and units can only gather them if the treasures are close at the shore)

Fri, Feb 19, 9:24 AM

Thu, Feb 18

Imarok added a comment to D3303: Split treasures from ResourceSupply..

Catafalque.

Thu, Feb 18, 8:00 PM
Imarok added inline comments to D3303: Split treasures from ResourceSupply..
Thu, Feb 18, 7:01 PM

Wed, Feb 17

Imarok updated the Trac tickets for D3575: Fix assert in topology.cpp.
Wed, Feb 17, 6:19 PM

Tue, Feb 16

Imarok added a member for Contributors: DynamoFox.
Tue, Feb 16, 5:27 PM
Imarok added a comment to D3572: Fix variant loading order.

Could you add a test for this bug? (So that we prevent regressions ;)
Ofc not for A24.

Tue, Feb 16, 12:55 PM

Mon, Feb 15

Imarok added a comment to D3569: The `SetCameraTarget` script function should not change the orientation.

Nice :)

Just one question, shouldn't you use the function above?

Mon, Feb 15, 9:39 PM
Imarok added a comment to D3569: The `SetCameraTarget` script function should not change the orientation.

Are there more occurences that use this function?

Mon, Feb 15, 7:59 PM

Sun, Feb 14

Imarok requested review of D3569: The `SetCameraTarget` script function should not change the orientation.
Sun, Feb 14, 7:05 PM
Imarok added a comment to D3566: Fix attack notifications with buildings.

Yes, it works. Now its the same for when someone attacks my units. Thanks for noticing and fixing it.
Clicking on the notification takes me to the action hotspot, it changes my camera perspective to the way it was when spawning into the game, if you never change the camera perspective or you press "R" (camera.reset) before clicking on the notification, you won't notice it. It is the same when some of my units are attacked.

Haven't noticed any bad effects otherwise.

Hmm, Good point about the change of the camera perspective. Wanna create a ticket for that?

Sun, Feb 14, 6:32 PM
Imarok added inline comments to rP7930: # Redesigned the camera control system..
Sun, Feb 14, 6:18 PM
Imarok added a comment to D3566: Fix attack notifications with buildings.

Yes, it works. Now its the same for when someone attacks my units. Thanks for noticing and fixing it.
Clicking on the notification takes me to the action hotspot, it changes my camera perspective to the way it was when spawning into the game, if you never change the camera perspective or you press "R" (camera.reset) before clicking on the notification, you won't notice it. It is the same when some of my units are attacked.

Haven't noticed any bad effects otherwise.

Sun, Feb 14, 5:50 PM

Sat, Feb 13

Imarok committed rP24904: Fix attack notifications with buildings.
Fix attack notifications with buildings
Sat, Feb 13, 10:31 PM
Imarok closed D3566: Fix attack notifications with buildings.
Sat, Feb 13, 10:31 PM
Imarok requested review of D3566: Fix attack notifications with buildings.
Sat, Feb 13, 10:21 PM
Imarok added inline comments to D3554: JS Interface Profiler2.
Sat, Feb 13, 8:43 PM

Wed, Feb 10

Imarok committed rP24868: Fix positioning of the research progress icons below the counters overlay.
Fix positioning of the research progress icons below the counters overlay
Wed, Feb 10, 6:00 PM
Imarok closed D3525: Fix positioning of the research progress icons below the counters overlay.
Wed, Feb 10, 6:00 PM
Imarok added a comment to D3525: Fix positioning of the research progress icons below the counters overlay.

Ah, now I understand what this diff does ^^ (I just tested it.)
Works for me :)

Wed, Feb 10, 5:54 PM

Tue, Feb 9

Imarok updated the diff for D3525: Fix positioning of the research progress icons below the counters overlay.

missing semi

Tue, Feb 9, 6:56 PM
Imarok commandeered D3525: Fix positioning of the research progress icons below the counters overlay.
Tue, Feb 9, 6:55 PM

Sat, Feb 6

Imarok retitled D3525: Fix positioning of the research progress icons below the counters overlay from Research progress overlay buttons add correct below overlay counters. to Fix positioning of the research progress icons below the counters overlay.
Sat, Feb 6, 9:53 PM
Imarok resigned from rP24558: Regroup special technologies..

Fixed by rP24843

Sat, Feb 6, 9:34 PM
Imarok committed rP24843: Fix Phoenician Trireme.
Fix Phoenician Trireme
Sat, Feb 6, 9:30 PM
Imarok closed D3526: Fix Phoenician Trireme.
Sat, Feb 6, 9:30 PM
Imarok added a comment to D3526: Fix Phoenician Trireme.

Sat, Feb 6, 9:29 PM
Imarok added inline comments to D3526: Fix Phoenician Trireme.
Sat, Feb 6, 9:16 PM
Imarok updated the diff for D3525: Fix positioning of the research progress icons below the counters overlay.

Fix it properly

Sat, Feb 6, 9:14 PM
Imarok requested review of D3526: Fix Phoenician Trireme.
Sat, Feb 6, 8:42 PM
Imarok raised a concern with rP24558: Regroup special technologies..

Caused #5998

Sat, Feb 6, 8:30 PM
Imarok added a comment to D1751: [WIP] Map flares.

@vladislavbelov :
Sorry if this wasn't clear, but this revision of my diff was mainly uploaded to get some help in finding the bug in the arb shader.
It wasn't not meant to be a clean ready to commit version. ;)

Sat, Feb 6, 8:01 PM

Jan 21 2021

Imarok committed rP24755: Fix game speed multiplier sometimes being outside overlay box and resizing in a….
Fix game speed multiplier sometimes being outside overlay box and resizing in a…
Jan 21 2021, 6:37 PM
Imarok closed D3391: Fix game speed multiplier sometimes being outside overlay box.
Jan 21 2021, 6:37 PM
Imarok added a comment to D3440: Fix miscellaneous tab values shifted..

"I guess it is either this or a revert. I don't like the fact that we filter here, I think we should do it earlier, if one has hideInSummary true for the counter, but not for the heading things get ugly again."

That's without the hideInSummary variable already true. If headings and counters contained different number of values it would be ugly (independent of rP24721). It's the disconnection between headings and counters that feels weird. I think in long term the getScorePanelsData should return something like:

[
    {
        "label": ...
        "titleHeadings": ...
        "values": [
            {
                "identifier": "total",
                "caption": translate("Total"),
                "yStart": 34,
                "width": 105,
                "verticalOffset": 3,
                "fn": calculateBuildings
                "hideInSummary": false
            },
            ...
        ],
        "teamCounterFn": calculateBuildingsTeam
    },
    ...    
]
Jan 21 2021, 6:30 PM

Jan 20 2021

Imarok updated the diff for D3391: Fix game speed multiplier sometimes being outside overlay box.

Fix linebreak noticed by Langbart.
Also fix weird sizing when first disabling all overlays and then repeatedly enabling → disabling the FPS overlay.
Don't use callbacks for the speed multiplier as the ingame time would also need one when the game gets longer than 59.9999 minutes. (And mabye something else also would need a callback)

Jan 20 2021, 11:15 PM
Imarok added a comment to rP24721: Add resource and population counts to the summary screen..

I marked the lines where I suspect you forgot to filter for hideInSummary

Jan 20 2021, 10:10 PM
Imarok requested verification of rP24565: Hint the location for "You have been attacked" notifications.

position issue fixed in rP24736

Jan 20 2021, 10:01 PM
Imarok committed rP24736: Fix attack notification (rP24565).
Fix attack notification (rP24565)
Jan 20 2021, 10:00 PM
Imarok closed D3387: Fix attack notification (rP24565).
Jan 20 2021, 10:00 PM
Imarok committed rP24735: Fix game speed button being unusable in min resolution.
Fix game speed button being unusable in min resolution
Jan 20 2021, 9:49 PM
Imarok closed D3389: Fix game speed button being unusable in min resolution.
Jan 20 2021, 9:49 PM
Imarok added a comment to D3389: Fix game speed button being unusable in min resolution.

Works as expected. Button is again usable.
Lul semicolon missing. Well imarok will handle that. :D

Jan 20 2021, 9:47 PM
Imarok updated the diff for D3387: Fix attack notification (rP24565).

Reuse event.position as event is used widely anyway.

Jan 20 2021, 9:43 PM
Imarok added a comment to rP24565: Hint the location for "You have been attacked" notifications.

This commit introduced a bug that created blank lines.
It was fixed by rP24671.

Jan 20 2021, 9:40 PM

Jan 17 2021

Imarok added a comment to D3400: Fix market waypoints..

Tried setting three waypoints? first to somewhere, second to the other market, third to somewhere else?
(That gives quite strange behaviour.)

Jan 17 2021, 8:27 PM
Imarok added a comment to D3395: Adding resource counts and population count graphs.

Looks good. 👍
Added some quick comments.
Maybe think of a more specific name then just hide? (I mean it's only hidden in the normal summary and not in the graphs.)

Jan 17 2021, 8:23 PM
Imarok requested review of D3391: Fix game speed multiplier sometimes being outside overlay box.
Jan 17 2021, 1:13 AM
Imarok requested review of D3389: Fix game speed button being unusable in min resolution.
Jan 17 2021, 1:02 AM

Jan 16 2021

Imarok requested review of D3387: Fix attack notification (rP24565).
Jan 16 2021, 7:54 PM

Jan 15 2021

Imarok added a comment to rP24565: Hint the location for "You have been attacked" notifications.

Ignore me ^^'

Jan 15 2021, 11:10 PM
Imarok added a comment to rP24565: Hint the location for "You have been attacked" notifications.

Could any of you two reproduce the issue consistently?

Jan 15 2021, 10:40 PM
Imarok added a comment to rP24565: Hint the location for "You have been attacked" notifications.

(One can sent the position from AttackDetection.js. (Don't need to get the ent-state then.) Although that may cause the entity to have left the screen already.)

Jan 15 2021, 9:01 PM
Imarok added a comment to rP24565: Hint the location for "You have been attacked" notifications.

ERROR: Errors executing script event "Press"

ERROR: JavaScript error: gui/session/chat/ChatMessageFormatSimulation.js line 28 position is null parse/<.callback</<@gui/session/chat/ChatMessageFormatSimulation.js:28:6

I think it is because entity already died

Jan 15 2021, 8:59 PM

Jan 12 2021

Imarok added a comment to D2830: Alpine Mountains random map.

Well probably not actually otherwise the deprecated functions placeholder wouldn't be needed. Plus I just reread the ticket so indeed there is no equivalence. I'll adjust the values if necessary

Jan 12 2021, 9:18 PM
Imarok resigned from rP24459: Map browser, used in the gamesetup and in the main menu..

Is only an issue when resizing the window while in gamesetup.
So it is still kind of a bug but not as severe as thought.

Jan 12 2021, 8:19 PM
Imarok added inline comments to D2830: Alpine Mountains random map.
Jan 12 2021, 8:17 PM
Imarok committed rP24565: Hint the location for "You have been attacked" notifications.
Hint the location for "You have been attacked" notifications
Jan 12 2021, 8:13 PM
Imarok closed D1461: Hint the location for "You have been attacked" notifications.
Jan 12 2021, 8:13 PM
Imarok added inline comments to D2830: Alpine Mountains random map.
Jan 12 2021, 8:11 PM
Imarok raised a concern with rP24459: Map browser, used in the gamesetup and in the main menu..

I think there is something wrong in fullscreen.
I'd expect to see 9 or 12 maps in fullscreen and not only two:

Jan 12 2021, 6:25 PM

Jan 11 2021

Imarok committed rP24550: Remove cache detection.
Remove cache detection
Jan 11 2021, 6:30 PM
Imarok closed D3165: Remove cache detection.
Jan 11 2021, 6:30 PM
asterix awarded D3165: Remove cache detection a Like token.
Jan 11 2021, 12:24 PM

Jan 5 2021

Imarok resigned from D2857: Matrix3D SSE.

Fixed graphical issue.
But dramatically increased test calculation time:

matrix multiplication
number_of_samples = 200
number_of_iteration = 1000000
have_sse = true
SSE (off): 3.28038ms
SSE (on):  3.36736ms
.
matrix Blend
number_of_samples = 200
number_of_iteration = 1000000
have_sse = true
SSE (off): 2.49736ms
SSE (on):  2.40249ms
.
matrix AddBlend
number_of_samples = 200
number_of_iteration = 1000000
have_sse = true
SSE (off): 2.36652ms
SSE (on):  2.39413ms
Jan 5 2021, 7:18 PM
Imarok requested changes to D2857: Matrix3D SSE.

Broken on Sahyadri Buttes:

Jan 5 2021, 2:34 PM
Imarok added a comment to D2857: Matrix3D SSE.
In file included from ../../../source/maths/tests/test_Matrix3d.cpp:17:
source/maths/tests/test_Matrix3d.h: In member function ‘void TestMatrix::test_MatrixMultiplicationPerformance()’:
source/maths/tests/test_Matrix3d.h:85:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
   85 |   for (int i = 0; i < number_of_iteration; ++i)
      |                   ~~^~~~~~~~~~~~~~~~~~~~~
source/maths/tests/test_Matrix3d.h: In member function ‘void TestMatrix::test_MatrixBlendPerformance()’:
source/maths/tests/test_Matrix3d.h:161:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
  161 |   for (int i = 0; i < number_of_iteration; ++i)
      |                   ~~^~~~~~~~~~~~~~~~~~~~~
source/maths/tests/test_Matrix3d.h: In member function ‘void TestMatrix::test_MatrixAddBlendPerformance()’:
source/maths/tests/test_Matrix3d.h:232:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
  232 |   for (int i = 0; i < number_of_iteration; ++i)
      |                   ~~^~~~~~~~~~~~~~~~~~~~~
Jan 5 2021, 2:24 PM

Jan 2 2021

Imarok added a comment to D3281: Increase maps version.

Shouldn't that version bump be in the same commit as the breaking change (D3237) and therefore in the same diff?

Jan 2 2021, 3:38 PM

Dec 21 2020

Imarok updated the summary of D1751: [WIP] Map flares.
Dec 21 2020, 10:07 PM

Dec 20 2020

Imarok updated the diff for D1751: [WIP] Map flares.

Rebase upon rP24384 and account for some of Vladislav's comments

Dec 20 2020, 4:02 PM
Imarok added inline comments to D1751: [WIP] Map flares.
Dec 20 2020, 3:47 PM

Dec 12 2020

Imarok updated the summary of D1461: Hint the location for "You have been attacked" notifications.
Dec 12 2020, 5:12 PM
Imarok added inline comments to D3184: Hide ip and port from users until they want to join, add optional password.
Dec 12 2020, 5:11 PM

Dec 11 2020

Imarok committed rP24378: Add `getTextSize()` for CButton.
Add `getTextSize()` for CButton
Dec 11 2020, 5:13 PM
Imarok closed D3195: Add `getTextSize()` for CButton.
Dec 11 2020, 5:13 PM

Dec 8 2020

Imarok added inline comments to D2818: Replace DEFINE_INTERFACE_XX and RegisterFunction macros with pure templated code.
Dec 8 2020, 11:29 PM
Imarok added inline comments to D3197: Add context for mustang attacks.
Dec 8 2020, 11:19 PM
Imarok requested review of D3195: Add `getTextSize()` for CButton.
Dec 8 2020, 10:51 PM
Imarok updated the diff for D1461: Hint the location for "You have been attacked" notifications.

Translate properly.

Dec 8 2020, 9:23 PM
Imarok updated the diff for D1461: Hint the location for "You have been attacked" notifications.

Tooltip and crosshair icon.
TODO: Find/Create a better icon.

Dec 8 2020, 9:11 PM
Imarok added inline comments to D3184: Hide ip and port from users until they want to join, add optional password.
Dec 8 2020, 8:57 AM
Imarok added inline comments to D3184: Hide ip and port from users until they want to join, add optional password.
Dec 8 2020, 8:44 AM
Imarok added a comment to D3184: Hide ip and port from users until they want to join, add optional password.
In D3184#140944, @Stan wrote:

If you're doing the consent thing one might look into not broadcasting team messages to everyone.

Dec 8 2020, 8:39 AM
Imarok accepted D3192: Improve LLVM_OBJDUMP detection..

See inline. Else it looks good.

Dec 8 2020, 8:33 AM
Imarok abandoned D3193: Fix building on arch and manjaro.
In D3193#140938, @Stan wrote:
Dec 8 2020, 8:31 AM
Imarok requested review of D3193: Fix building on arch and manjaro.
Dec 8 2020, 12:03 AM

Dec 7 2020

Imarok updated the diff for D1461: Hint the location for "You have been attacked" notifications.

Fix indentation

Dec 7 2020, 9:21 PM

Dec 6 2020

Imarok updated the diff for D1461: Hint the location for "You have been attacked" notifications.

Cosmetics

Dec 6 2020, 1:29 AM
Imarok updated the summary of D1461: Hint the location for "You have been attacked" notifications.
Dec 6 2020, 1:29 AM
Imarok updated the diff for D1461: Hint the location for "You have been attacked" notifications.

Rebase. Cause of rP23020 this now depends on a patch coming soon™ that adds getTextSize to buttons again.

Dec 6 2020, 1:22 AM

Dec 5 2020

Imarok added a comment to D1461: Hint the location for "You have been attacked" notifications.

TODO: Need to implement getTextSize for CButton. (see http://irclogs.wildfiregames.com/%230ad-dev/2020-12-05-QuakeNet-%230ad-dev.log)

Dec 5 2020, 9:44 PM
Imarok committed rP24326: Handle unknown APIC IDs in the ACPI SRAT.
Handle unknown APIC IDs in the ACPI SRAT
Dec 5 2020, 2:41 PM
Imarok closed D1789: Handle unknown APIC IDs in the ACPI SRAT.
Dec 5 2020, 2:40 PM
Imarok added inline comments to D3177: Fix all reported warnings by Clang 10.
Dec 5 2020, 2:27 PM

Dec 2 2020

Imarok updated the diff for D1751: [WIP] Map flares.

Try implementing an ARB shader for flaring. Currently not working.

Dec 2 2020, 11:21 PM

Dec 1 2020

Imarok updated the diff for D1751: [WIP] Map flares.

Fix rebase mistake in minimap.vs

Dec 1 2020, 7:50 PM
Imarok updated the diff for D1751: [WIP] Map flares.

Don't forget the new JSInterface file this time

Dec 1 2020, 6:34 PM
Imarok updated the diff for D1751: [WIP] Map flares.

Rebase. (SM-Update)

Dec 1 2020, 6:28 PM
Imarok added inline comments to D3176: Fix rP24306 - actually use the code..
Dec 1 2020, 4:55 PM