Page MenuHomeWildfire Games

Imarok
User

Projects

User Details

User Since
Dec 23 2016, 12:04 AM (170 w, 1 d)

Recent Activity

Fri, Feb 28

Imarok raised a concern with rP23484: Adds anti-aliasing option with FXAA algorithm..
Fri, Feb 28, 6:06 PM
Imarok added a comment to rP23484: Adds anti-aliasing option with FXAA algorithm..

Hmm, is it intended, that FXAA is not used on maps with PostEffect to default even when I enabled FXAA in the options?
I guess we will definitely get some reports because of that after the release...

Fri, Feb 28, 6:05 PM

Feb 26 2020

Imarok updated the diff for D2362: Allow for building-specific build/repair animations and use seeding animation for fields.

Use an extra component for SpecialVariants

Feb 26 2020, 9:01 PM

Feb 23 2020

Imarok added a comment to D2362: Allow for building-specific build/repair animations and use seeding animation for fields.

It might be better to store the data in UnitAI as datapairs of class and variation.

Feb 23 2020, 7:06 PM
Imarok updated the diff for D2362: Allow for building-specific build/repair animations and use seeding animation for fields.

Fix small style issues

Feb 23 2020, 5:36 PM
Imarok added a comment to D2642: Contrast-Adaptiv-Sharpening pass.

I got

ERROR: Failed to compile shader 'shaders/glsl/cas.fs':
0(64) : error C1008: undefined variable "rcp"
0(70) : error C1008: undefined variable "rcp"
0(73) : error C1008: undefined variable "rcp"

Edit: Tested on Ubuntu 18.04 with GTX 960

Feb 23 2020, 5:07 PM
Imarok added a comment to D2642: Contrast-Adaptiv-Sharpening pass.

I got

ERROR: Failed to compile shader 'shaders/glsl/cas.fs':
0(64) : error C1008: undefined variable "rcp"
0(70) : error C1008: undefined variable "rcp"
0(73) : error C1008: undefined variable "rcp"

Edit: Tested on Ubuntu 18.04 with GTX 960

Feb 23 2020, 3:44 PM

Feb 19 2020

Imarok added inline comments to D2362: Allow for building-specific build/repair animations and use seeding animation for fields.
Feb 19 2020, 6:48 AM

Feb 18 2020

Imarok added inline comments to D2362: Allow for building-specific build/repair animations and use seeding animation for fields.
Feb 18 2020, 9:40 PM

Feb 17 2020

Imarok committed rP23507: Should have waited for the bears.
Should have waited for the bears
Feb 17 2020, 8:23 PM
Imarok added a comment to D148: Fix gametime overlay and watermark in summary screen.

@vladislavbelov any news regarding that issue? ;)

Feb 17 2020, 7:41 PM
Imarok added a comment to D1517: [RFC] Print out the state and message name in Fsm error warnings.

@elexis Do you have any preferred solution?
I'd like to have this feature but don't care too much about its way of implementation.

Feb 17 2020, 7:38 PM
Imarok committed rP23506: Fix button caption and enable in modmod.
Fix button caption and enable in modmod
Feb 17 2020, 7:23 PM
Imarok closed D1623: Fix button caption and enable in modmod.
Feb 17 2020, 7:23 PM
Imarok committed rP23505: Add GUI events for middle mouse click.
Add GUI events for middle mouse click
Feb 17 2020, 7:17 PM
Imarok closed D1752: Add GUI events for middle mouse click.
Feb 17 2020, 7:17 PM
Imarok updated the diff for D1752: Add GUI events for middle mouse click.

Allow reuse of the strings in inherited and friend classes.

Feb 17 2020, 7:06 PM
Imarok added inline comments to D2362: Allow for building-specific build/repair animations and use seeding animation for fields.
Feb 17 2020, 6:27 PM
Imarok updated the diff for D2362: Allow for building-specific build/repair animations and use seeding animation for fields.

Show helmets for women. Default to build

Feb 17 2020, 6:26 PM

Feb 16 2020

Imarok updated the diff for D1752: Add GUI events for middle mouse click.

Rebase

Feb 16 2020, 4:52 PM
Imarok updated the diff for D2362: Allow for building-specific build/repair animations and use seeding animation for fields.

Indent with spaces in templates

Feb 16 2020, 4:34 PM
Imarok updated the diff for D2362: Allow for building-specific build/repair animations and use seeding animation for fields.

Define the building-specific animation in the buildings template.

Feb 16 2020, 4:27 PM
Imarok retitled D2362: Allow for building-specific build/repair animations and use seeding animation for fields from Use seeding animation to Allow for building-specific build/repair animations and use seeding animation for fields.
Feb 16 2020, 4:25 PM
Imarok updated subscribers of D1623: Fix button caption and enable in modmod.
Feb 16 2020, 3:54 PM
Imarok updated the diff for D1623: Fix button caption and enable in modmod.

Rebase, Only two states for Enable/Disable button, delete caption of button in xml file

Feb 16 2020, 3:52 PM
Imarok added inline comments to D1877: Show summary graphs for teams.
Feb 16 2020, 2:26 PM
Imarok added a comment to D2362: Allow for building-specific build/repair animations and use seeding animation for fields.
In D2362#99185, @Stan wrote:

That inline got me wondering, wouldn't a saner implementation be to specify the build animation and fallback in the cmpIdentity ?

Yeah, I agree we should not hardcode it in the code. Any suggeestions on a format?

Feb 16 2020, 2:15 PM

Dec 19 2019

Imarok committed rP23262: Workaround for L3 cache detection of Ryzen 3000.
Workaround for L3 cache detection of Ryzen 3000
Dec 19 2019, 5:53 PM
Imarok closed D2353: L3 Ryzen 3000 Bugfix.
Dec 19 2019, 5:52 PM
Imarok committed rP23261: Linting: Remove "no-lone-blocks" rule for ESLint.
Linting: Remove "no-lone-blocks" rule for ESLint
Dec 19 2019, 5:38 PM
Imarok closed D2452: Linting: Remove "no-lone-blocks" rule for ESLint.
Dec 19 2019, 5:38 PM
Imarok awarded D2483: Gamesetup class rewrite a Yellow Medal token.
Dec 19 2019, 3:46 PM
Imarok accepted D2452: Linting: Remove "no-lone-blocks" rule for ESLint.

I'm ok with removing that rule.
I understand elexis reasoning and I think the cases where such blocks are code-wise useless and don't help with understanding the code are very seldom and easy to spot.

Dec 19 2019, 3:45 PM

Dec 18 2019

Imarok added a comment to D2171: Avoid GUI errors for captured buildings with paired techs of a different civ.

The patches fixes the bug.
But it seems it reveals a new one.
With your test plan and the patch the paired tech is greyed out and says this tech will be unlocked in city phase...

Dec 18 2019, 6:44 PM
Imarok awarded D2460: Implement placeholder text for input fields and get rid of hack with mod filter a Love token.
Dec 18 2019, 6:36 PM
Imarok resigned from rP22772: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.

Fixed by rP23259.

Dec 18 2019, 6:24 PM
Imarok committed rP23259: Fix User Reporter worker thread always using a full CPU-Thread.
Fix User Reporter worker thread always using a full CPU-Thread
Dec 18 2019, 6:21 PM
Imarok closed D2373: Fix the waiting of the User Reporter worker thread.
Dec 18 2019, 6:21 PM
Imarok added a comment to D2373: Fix the waiting of the User Reporter worker thread.

Thank you for the review.
I'll commit that soon.

Dec 18 2019, 4:45 PM

Dec 8 2019

Imarok accepted D2353: L3 Ryzen 3000 Bugfix.

So I think we should commit this workaround.
Pros:

  • It fixes the issue.
  • It gets the correct result at least until zen3 comes out.

Cons:

  • It is not the correct way to get the cache associativity from this CPUs.
Dec 8 2019, 8:29 PM

Dec 2 2019

Imarok added a comment to D2353: L3 Ryzen 3000 Bugfix.
In D2353#102347, @Stan wrote:

This person also runs out of memory #5645 without the fix, maybe it's the same reason.

Dec 2 2019, 9:16 PM

Nov 14 2019

Imarok added a comment to D2285: Inform player that second market is too close to setup trade route and use disabled action.

Nice. Maybe print Market is too close to first one in red?
(not sure, if that is possible)

Nov 14 2019, 11:17 AM

Oct 17 2019

Imarok added a comment to D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).
In D1511#99249, @Vulcan wrote:

Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/978/display/redirect

Oct 17 2019, 9:05 AM

Oct 15 2019

Imarok added inline comments to D2362: Allow for building-specific build/repair animations and use seeding animation for fields.
Oct 15 2019, 2:51 PM

Oct 14 2019

Imarok updated the Trac tickets for D2373: Fix the waiting of the User Reporter worker thread.
Oct 14 2019, 11:53 PM
Imarok created D2373: Fix the waiting of the User Reporter worker thread.
Oct 14 2019, 11:52 PM
Imarok added inline comments to rP22772: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.
Oct 14 2019, 11:51 PM
Imarok added inline comments to rP22772: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.
Oct 14 2019, 11:38 PM
Imarok added inline comments to rP22772: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.
Oct 14 2019, 11:29 PM
Imarok added a comment to rP22772: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.

Now has a ticket at #5620

Oct 14 2019, 11:17 PM
Imarok added a comment to rP22772: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.

Reverting the UserReporter back to rP22771 proves it is the UserReporter

Oct 14 2019, 11:01 PM
Imarok raised a concern with rP22772: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.

With this revision the CPU usage of 0ad on my machine is always 12 percentage points higher than before this revision.
That equals exactly one virtual core, so one thread. Guess you are badly polling somewhere.

Oct 14 2019, 10:55 PM
Imarok added a comment to D2353: L3 Ryzen 3000 Bugfix.
In D2353#99093, @elexis wrote:
In D2353#99092, @Imarok wrote:

(OptimusShepard got an OOM after about 30 minutes when playing on a big map with 8 AIs that might be related to this issue.)

Reproducibly? (For example by replaying the match or starting a new match with the same settings)

No idea. Didn't got any more information.

It sounds unexpected that a magic number comparison would trigger an out-of-memory during a match later.
If the same happens without the patch (commenting out the ENSURE), then it's not the patch.
Also then it would be something in the simulation, in which case a replay and some profiling on that to figure out what happens might be useful.

Yeah, I also don't think it has anything to do with the patch, but I can't rule it out 100%.

Oct 14 2019, 5:33 PM
Imarok added a comment to D2353: L3 Ryzen 3000 Bugfix.

Great Work!
I conform that the modification on line 92 dows the trick for my ryzen 3600. Now working. The packager for Archlinux has already included this patch in the a23.1-6 version of 0ad

Oct 14 2019, 5:04 PM

Oct 12 2019

Imarok added a comment to D1190: Allow restoring lost wall turrets.

Quickly tested the patch. Looks like a really nice behaviour. 👍
But here are some things I noticed:

Oct 12 2019, 10:26 PM

Oct 7 2019

Imarok created D2362: Allow for building-specific build/repair animations and use seeding animation for fields.
Oct 7 2019, 3:55 PM

Oct 5 2019

Imarok requested changes to D2353: L3 Ryzen 3000 Bugfix.

Please add a comment with some explanation and the link to the doc.

Oct 5 2019, 11:21 AM
Imarok added a comment to D2353: L3 Ryzen 3000 Bugfix.
In D2353#98462, @elexis wrote:
In D2353#98374, @Imarok wrote:

I think we now had multiple Zen 2 users complaining about crashes.

Got a link?

Just see the ticket and the link in the post above.

The other question I have is whether we should actually call ENSURE in AddTLB.
It sounds better to fail more softly with a red error message?
Wouldn't object to a ticket for that (perhaps we already have a "dont use ENSURE" ticket?).

I think we should in general not use ENSURE in hardware detection but red error warnings instead.
Afaik there is nothing that critical that would justify an ENSURE

Sooner or later the magic numbers will change again I assume.

I don't think so.

Looking at the spec of that CPU(PDF page 75) it seems 0x9 is still reserved.

It sounds useful to add the links in the code, there already are some

Good idea

What does reserved mean?

That the number has no current meaning but is reservered for assigning some meaning in the future.

After this change it means in the worst case it will report a 16-way associative cache when someone just has a 8-way or a 32-way or whatever.

Reporting the correct number of not reporting would be more correct if the number is not known.
Either the magic number is correct for all caches, or there should be a wildcard and the Validate function should be changed to account for that wildcard?
(I have no clue what Im talking about)

Seems like ;P
The issue is: we currently don't know what this 0x9 means. But everyone who played 0ad and got this 0x9 had a CPU with a L3 16-way associative cache.
And to be honest: I don't even know why we need this information at all...

Oct 5 2019, 11:20 AM
Imarok accepted D2353: L3 Ryzen 3000 Bugfix.

The one in https://wildfiregames.com/forum/index.php?/topic/27095-cachecpp43-assertion-failed-cachevalidate/ also has this 0x9 and a 16-way associative cache.
So I assume it's correct.

Oct 5 2019, 10:30 AM
Imarok added a comment to D2353: L3 Ryzen 3000 Bugfix.
In D2353#98445, @elexis wrote:

It seems like you know more than the rest of us about this issue, you have many facts gathered.

I just went down the rabbit hole a bit xD
(Plus some knowledge about how a CPU works internally)

Oct 5 2019, 9:57 AM

Oct 4 2019

Imarok added a comment to D2353: L3 Ryzen 3000 Bugfix.
In D2353#98371, @elexis wrote:

Will the numbers not bug for other people? (As no other CPU users seem to have complained about them)

I think we now had multiple Zen 2 users complaining about crashes.

Oct 4 2019, 12:29 AM
Imarok added a comment to D2353: L3 Ryzen 3000 Bugfix.

As I was "pushed" by @OptimusShepard to help him on that part, I'll answer:

In D2353#98371, @elexis wrote:

How does one determine the magic numbers that should be there?
E.g. can we look it up on some specification of the manufacturer?

In an earlier version of this table It said the zero values are reserved.
But @OptimusShepard reported he got 0x9 as value for the L3-Cache. And it's know, that his CPU has a 16-ways associative cache.
Looking at the spec of that CPU(PDF page 75) it seems 0x9 is still reserved.
So I'm not sure, what goes on here, but it seems 0x9 means 16-way associative in this case.

In D2353#98371, @elexis wrote:

Will the numbers not bug for other people? (As no other CPU users seem to have complained about them)

This change only affects people who got this 0x9, and with previous code they just crashed.
After this change it means in the worst case it will report a 16-way associative cache when someone just has a 8-way or a 32-way or whatever.
So I think the harm is quite limited.

Oct 4 2019, 12:14 AM

Sep 17 2019

Imarok added a comment to D2294: Rephrase the tooltip of Reload Cache to avoid confusion.

I’m just looking for using the same wording. If “Rebuild” works on both strings, I’ll switch both to “Rebuild”.

Sep 17 2019, 4:13 PM
Imarok accepted D2294: Rephrase the tooltip of Reload Cache to avoid confusion.

Good idea to streamline that.
But I think "Rebuild" would be the better word because the whole cache file gets built again and not loaded again. However as you are our language master, if you think rebuild fits better, then go on with that.

Sep 17 2019, 9:55 AM

Aug 27 2019

Imarok awarded D2197: Add support for recording replay metadata when in nonvisual mode a Like token.
Aug 27 2019, 12:15 AM

Aug 26 2019

Imarok awarded rP22773: Fix L10n::FormatMillisecondsIntoDateString memory leak following rP18725, refs… a Like token.
Aug 26 2019, 11:50 PM

Jul 22 2019

Imarok accepted D2070: Linting: Remove controversial 'curly' eslint rules.

Looks sensible to me.

Jul 22 2019, 9:05 PM

May 21 2019

Imarok committed rP22293: Replace , with . in an AI's chat sentence.
Replace , with . in an AI's chat sentence
May 21 2019, 7:33 PM
Imarok closed D1912: replace , with ..
May 21 2019, 7:33 PM
Imarok added a comment to D1912: replace , with ..

thanks for the patch

May 21 2019, 7:32 PM
Imarok accepted D1912: replace , with ..

Slipped through in rP19194

May 21 2019, 5:26 PM

May 16 2019

Imarok added a comment to D1877: Show summary graphs for teams.
In D1877#78342, @elexis wrote:

One argument for the button is that it looks more streamlined

Yes, I understood your reasoning and it's not inherently wrong to use a button, especially depending on which graphics represent the control elements. I just wanted to point out that that typically checkboxes are used for binary settings and buttons for actions. If I don't use red color, it's not a contractual obligation to perform changes.

Yes, I also understood your reasoning and found the arguments for a checkbox better than the arguments for a button, so I used a checkbox instead. (It appears that also is a reduction in LOC ;) )

May 16 2019, 7:54 PM
Imarok updated the diff for D1877: Show summary graphs for teams.

Fix indent

May 16 2019, 6:27 PM
Imarok updated the diff for D1877: Show summary graphs for teams.

Use a checkbox instead of a toggle button

May 16 2019, 3:49 PM
Imarok added a comment to D1877: Show summary graphs for teams.
In D1877#78328, @elexis wrote:

It's a multiple choice, either it shows the stats grouped per team, or it shows the stats grouped per player.
So naturally the options are:

  • A checkbox
  • A dropdown
  • Radio buttons (in HTML, we don't have it in Pyrogenesis GUI)

The purpose of a button to perform an action, not to trigger an option.
So a checkbox [x] Group per team seems more nearby to the purposes of GUI object types me.

Yeah, that seems like a better alternative. (One argument for the button is that it looks more streamlined.)

May 16 2019, 3:24 PM
Imarok updated the diff for D1877: Show summary graphs for teams.

Remember the state of g_ShowTeamCharts when summary is closed.

May 16 2019, 12:46 PM
Imarok added a comment to D1877: Show summary graphs for teams.

player graphs:

May 16 2019, 12:31 PM
Imarok added a comment to D1892: Add unit motion integration test map.

I guess you should apply the comments of the linter.

May 16 2019, 12:28 PM

May 14 2019

Imarok committed rP22284: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`
May 14 2019, 12:13 PM
Imarok closed D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
May 14 2019, 12:13 PM
Imarok added a comment to D1849: Clarify the use of the macmouse config option.
In D1849#78009, @elexis wrote:

I think it's just a minority of mac users.

@vladislavbelov got numbers on mac users and perhaps number of mouse buttons?
Even without numbers, if we can estimate that the option is relevant to half of mac users, it sounds relevant.
Imagine you have to play on a mac and can't use right click. Your ability to use the game is strongly impacted, no?

Many mac users have normal external mice.
There will also be many that just use "two-finger clicks".
So there should only be about 2%-10% remaining. (I am no mac user, so I am just estimating)

May 14 2019, 12:21 AM

May 13 2019

Imarok added a comment to D1751: [WIP] Map ping.
In D1751#77632, @elexis wrote:

I'd prefer to not use the simulation as imho minimap pings shouldn't be in the simualation. They are a purely gui thing, just as chat.

Seems like I was arguing with myself. I already do the pings as simulation commands. xD Sorry for my confusion.

May 13 2019, 11:31 PM
Imarok committed rP22282: [CChart] Add a percentage format and round displayed integers.
[CChart] Add a percentage format and round displayed integers
May 13 2019, 11:23 PM
Imarok closed D1878: [CChart] Add a percentage format.
May 13 2019, 11:23 PM
Imarok updated the diff for D1878: [CChart] Add a percentage format.

Rounding for INTEGER and PERCENTAGE. Seems saner to me.

May 13 2019, 11:01 PM
Imarok added a comment to D1751: [WIP] Map ping.
In D1751#77680, @elexis wrote:

Yeah it's bad that it will be defined for all GUI objects, but I don't see this as a blocker.

rP22134, adds only a little bit of mess, not a blocker, someone else can fix it afterwards
D1781, adds only a little bit of mess, not a blocker, someone else can fix it afterwards
D1751, adds only a little bit of mess, not a blocker, someone else can fix it afterwards
Who will fix it?
Why should he fix it?
When will he fix it?
Why should the code be introduced with a known defect?
Why do I get accused of wanting to stop people from progressing if I point out anti-patterns that only add a little defect for now that can be fixed in the future by someone else?
Created #5442.

May 13 2019, 10:41 PM
Imarok added a comment to D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.

@weberkai I guess this newer version of the patch still fixes your issues?

May 13 2019, 10:37 PM
Imarok planned changes to D1849: Clarify the use of the macmouse config option.
In D1849#77631, @elexis wrote:

Sure, but I don't think that would match in the manual.

What stops us from keeping the manual in sync?

Yeah, why not.

And why is the manual not the first place to look at if the purpose of the diff is to inform mac users how to adapt their thing rather than in the source that only developers see?
If the setting is relevant to all or the majority of mac users (is it?), why would it be overkill to expose it in the GUI?

I think it's just a minority of mac users.

May 13 2019, 10:33 PM

May 12 2019

Imarok added inline comments to D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
May 12 2019, 1:49 AM
Imarok updated the diff for D1878: [CChart] Add a percentage format.

Make the License Bear happy ;)

May 12 2019, 1:39 AM
Imarok added inline comments to D1878: [CChart] Add a percentage format.
May 12 2019, 1:38 AM
Imarok created D1878: [CChart] Add a percentage format.
May 12 2019, 1:34 AM
Imarok added a comment to D1877: Show summary graphs for teams.
In D1877#77655, @Stan wrote:

How does it handle changing teams during the game ?

May 12 2019, 1:32 AM
Imarok added inline comments to D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
May 12 2019, 1:31 AM
Imarok updated the diff for D1877: Show summary graphs for teams.

Tiny style fix

May 12 2019, 1:17 AM
Imarok updated the diff for D1877: Show summary graphs for teams.

Hide the Toggle button if no teams

May 12 2019, 1:15 AM
Imarok created D1877: Show summary graphs for teams.
May 12 2019, 1:10 AM
Imarok added inline comments to D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
May 12 2019, 12:56 AM
Imarok added inline comments to D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
May 12 2019, 12:25 AM

May 11 2019

Imarok added inline comments to D1852: Fix possibly using uninitialized global in rP19674 and rename `GetDirectoryName`.
May 11 2019, 11:29 PM