- User Since
- Dec 23 2016, 12:04 AM (130 w, 4 d)
May 21 2019
May 16 2019
Yes, I also understood your reasoning and found the arguments for a checkbox better than the arguments for a button, so I used a checkbox instead. (It appears that also is a reduction in LOC ;) )
Use a checkbox instead of a toggle button
Yeah, that seems like a better alternative. (One argument for the button is that it looks more streamlined.)
Remember the state of g_ShowTeamCharts when summary is closed.
I guess you should apply the comments of the linter.
May 14 2019
Many mac users have normal external mice.
There will also be many that just use "two-finger clicks".
So there should only be about 2%-10% remaining. (I am no mac user, so I am just estimating)
May 13 2019
Seems like I was arguing with myself. I already do the pings as simulation commands. xD Sorry for my confusion.
Rounding for INTEGER and PERCENTAGE. Seems saner to me.
@weberkai I guess this newer version of the patch still fixes your issues?
Yeah, why not.
And why is the manual not the first place to look at if the purpose of the diff is to inform mac users how to adapt their thing rather than in the source that only developers see?
If the setting is relevant to all or the majority of mac users (is it?), why would it be overkill to expose it in the GUI?
I think it's just a minority of mac users.
May 12 2019
Make the License Bear happy ;)
Hide the Toggle button if no teams
May 11 2019
May 1 2019
No idea, but does it make sense to test against that behaviour?
Cache replay directory path
Way better. Can't see any performance loss compared to svn anymore. 👍
Apr 29 2019
Apr 28 2019
Yeah, sorry. I measured the time I was stuck at 100%.
Hmm, seems like it takes far longer to load a map.
Just quickly tested with Corinthian Istmus (4):
Svn stuck about 7 seconds at 100%.
With D14 it stuck about 18 seconds at 100% and I got a notice from my OS that it seems like the program has hung up and if I want to go on or quit the program.
There is a conflicting name MT_MinimapPing in components/CCmpMinimap.cpp.
There should only be one minimap ping, so one of the two should be renamed.
I know. I planned to rename the MT_MinimapPing to MT_MinimapBlink
So in the current revision it works this way:
- GUI -> send simulation command and displayMapPing locally
- Commands.js -> record to replay and broadcast GUI message
- messages.js -> displayMapPing -> GetGUIObjectByName("minimap").ping = true and GUIInterface drawTargetMarker;
I mentioned GetGUIObjectByName("minimap").ping(position, template); is also possible by editing the JSInterface_IGUIObject.cpp function (this file should be split into one file per GUI Object type, since the new function will be added to every GUI Object type).
But not having to hardcode the GUI objects seems preferable, then people can add a second minimap if they'd like to, or rename it.
That was what I looked for. Thank you ;)
I'd prefer to take that way. Yeah it's bad that it will be defined for all GUI objects, but I don't see this as a blocker. We can still use two minimaps as long as they both use the MiniMap class.
I'd prefer to not use the simulation as imho minimap pings shouldn't be in the simualation. They are a purely gui thing, just as chat.
Yeah, that doesn't always have a meaning ;)
@elexis should GetDirectoryName really called that name? Isn't GetDirectoryPath more appropriate?
Picking hidden gaia entities really sounds like cheating. ;)
Also do we really need scouting? With a few shift+clicks on the minimap a unit can be ordered to scout the whole map.
Apr 26 2019
Imho the large bar looks to big for the small fishing boat
Rebase and apply the proposed changes
Ok, seems like I shouldn't try using the private svn for phab ^^
Apr 25 2019
See https://github.com/boostorg/random/issues/49 (Found by Vladislav)
(Also see discussion at irclogs 2019-04-04 around 21:44)
TLDR: just ignore the notes and wait for boost 1.70
So the question is how minimap ping should be implemented for the people who don't have a third mouse button.
Isn't the usual way to add a button near the minimap, that if clicked changes the input.js state, and if that state is set, both the minimap "worldclick" events and the clicks on the actual 3D world would equally trigger the 'minimap ping'?
Fix indent spotted by Stan
Rebase. Disable Website button if selected mod has no url.
Apply comments of elexis
One easy fix would be that the ship won't move if the units can be garrissoned with the ship not moving.
Or just never move the ship.
Seems like that won't work cause of template_unit_ship_fishing.xml
Do changes according to inlines
Apr 24 2019
Didn't look closely at it, but we definitely shouldn't copy the general fsm definition, but instead put it somewhere where UnitAI and input.js can use it.
Apr 23 2019
Then I don't see, why he has commandeered it...
Apr 7 2019
Apr 6 2019
Apr 5 2019
Apr 4 2019
Mar 26 2019
I listed myself, because I thought not listing myself leaves the impression I didn't review the patch. But you are right, committing implies a review by the committer, so listing myself is redundant.