Page MenuHomeWildfire Games

Imarok
User

User Details

User Since
Dec 23 2016, 12:04 AM (102 w, 4 d)

Recent Activity

Sat, Nov 24

Imarok accepted D1556: NetClient and NetServer state comments, renames and cleanup.

Assuming you the renames are correct and the proposed changes are made.

Sat, Nov 24, 6:09 PM
Imarok accepted D1649: Update client loading state upon client disconnect too.

Accept if proposed changes are followed.

Sat, Nov 24, 6:04 PM

Thu, Nov 22

Imarok added a comment to D406: Add a steps param to sliders.

the double > JS::Number conversion loses precision.

I think that is why we have FixedPoint number type in C++. (I guess it's mainly use in simulation)

Thu, Nov 22, 8:21 AM

Sun, Nov 18

Imarok added a comment to D1649: Update client loading state upon client disconnect too.
In D1649#66370, @elexis wrote:
In D1649#66186, @Imarok wrote:

Besides the comments: Looks good.
Could reproduce and fixes. 👍

Anything more that needs review?

Sun, Nov 18, 10:41 AM
Imarok added inline comments to D1672: Cleanup of SkyManager.
Sun, Nov 18, 10:04 AM

Sat, Nov 17

Imarok added inline comments to D1649: Update client loading state upon client disconnect too.
Sat, Nov 17, 8:52 PM
Imarok added inline comments to D1556: NetClient and NetServer state comments, renames and cleanup.
Sat, Nov 17, 8:50 PM
Imarok added inline comments to D1672: Cleanup of SkyManager.
Sat, Nov 17, 8:36 PM
Imarok added inline comments to D1623: Fix missing translate call in modmod.
Sat, Nov 17, 7:35 PM

Fri, Nov 16

Imarok added a comment to D1674: Check translations for sprintf errors.

Nice 👍

Fri, Nov 16, 11:30 AM

Mon, Nov 12

Imarok added inline comments to D1672: Cleanup of SkyManager.
Mon, Nov 12, 7:45 PM
Imarok added inline comments to D1556: NetClient and NetServer state comments, renames and cleanup.
Mon, Nov 12, 7:37 PM
Imarok added inline comments to D1649: Update client loading state upon client disconnect too.
Mon, Nov 12, 7:30 PM
Imarok added inline comments to D1623: Fix missing translate call in modmod.
Mon, Nov 12, 7:26 PM

Sun, Nov 11

Imarok added inline comments to D1623: Fix missing translate call in modmod.
Sun, Nov 11, 8:57 AM

Nov 10 2018

Imarok added inline comments to D1649: Update client loading state upon client disconnect too.
Nov 10 2018, 11:37 PM
Imarok added a comment to D1649: Update client loading state upon client disconnect too.

Besides the comments: Looks good.
Could reproduce and fixes. 👍

Nov 10 2018, 11:37 PM
Imarok updated the diff for D1623: Fix missing translate call in modmod.

Fix the inconsistency noticed by elexis for the Enable/Disable button, the website button and the arrows.

Nov 10 2018, 10:58 PM
Imarok added a comment to D1623: Fix missing translate call in modmod.
In D1623#64723, @elexis wrote:

While proofreading the modmod files for completeness, I found that the default caption of this button is inconsistent. It is shown when the button is disabled by default, but the caption remains Enabled if there is no mod selected. It would be more consistent to always have the same state if there is no mod selected.

Good catch!

Nov 10 2018, 10:51 PM
Imarok added inline comments to D1516: [NetServer] Split `OnInGame` function.
Nov 10 2018, 10:10 PM
Imarok added a comment to D1383: Open portrait dialog with left-click, not rightclick.

Why did you abandon?
I think nothing speaks against allowing right and left click.

Nov 10 2018, 10:06 PM
Imarok added a comment to D1556: NetClient and NetServer state comments, renames and cleanup.

The proposed renames in the patch description sound sane. 👍
The added descriptions are also good. (Besides the comments I gave)
(Needs rebase.)

Nov 10 2018, 10:04 PM
Imarok accepted D1672: Cleanup of SkyManager.

Else looks good

Nov 10 2018, 9:41 PM

Oct 29 2018

Imarok raised a concern with rP21723: Define and associate .pyromod filetype with pyrogenesis on Linux and Windows..
Oct 29 2018, 8:43 AM

Sep 24 2018

Imarok added a comment to D1627: Support custom buttons in the termsdialog and use it for mod.io legal links and UserReporter config paths and publications link.
In D1627#65048, @smiley wrote:
In D1627#65047, @Imarok wrote:

Good job. 👍
Is it intended, that the Enable Feedback button is first greyed out and the user has to click on technical details and then on connect to enable the user report?

Pretty sure it's intended. They are supposed to read and accept the terms before doing it I guess.

Sure but wouldn't it be better to just open the terms window when the user clicks the enable feedback button without reading the terms instead of disabling the button?
The current way seems to be a bit counterintuitive.

Sep 24 2018, 3:00 PM
Imarok added a comment to D1627: Support custom buttons in the termsdialog and use it for mod.io legal links and UserReporter config paths and publications link.

Good job. 👍
Is it intended, that the Enable Feedback button is first greyed out and the user has to click on technical details and then on connect to enable the user report?

Sep 24 2018, 11:10 AM

Sep 14 2018

Imarok added a comment to D1362: Remove the list of hardcoded training hotkeys..

I didn't forget this diff, but as I understand our current state, only things that are needed for the rerelease or that are game-breaking are committed.

Sep 14 2018, 12:46 PM

Sep 4 2018

Imarok resigned from rP20064: XmppClient cleanup..

Ok, works

Sep 4 2018, 11:35 AM

Sep 1 2018

Imarok added a comment to rP20064: XmppClient cleanup..
Sep 1 2018, 11:41 AM
Imarok created D1623: Fix missing translate call in modmod.
Sep 1 2018, 11:39 AM
Imarok created D1622: [CSlider] On click move the slider-button to the mouse position.
Sep 1 2018, 11:13 AM

Aug 28 2018

Imarok added a reviewer for D1617: implement Travis code integration testing: Itms.

I think Itms has the best overview about our CI and such things.

Aug 28 2018, 7:09 PM

Jul 3 2018

Imarok added a comment to rP21441: Create winning teams for relic and wonder victory instead of letting all allies….

se>>! In rP21441#31054, @elexis wrote:

So when I commit a bug and call it "commit a bug", it's not broken because it does what it claims to?
Why do we have the concern feature if we don't use it to keep a list of things that should be fixed that are related to a known commit?

Jul 3 2018, 4:49 PM

Jun 21 2018

Imarok added a comment to D1582: Use pkg-config instead of sdl2-config.

Ubuntu 16.04.4 LTS 64-Bit
gcc version 5.4.0 20160609
using premake5 ✔

Jun 21 2018, 12:23 AM

Jun 18 2018

Imarok added a comment to D1581: Mod Interface: Enable setting territory visibility.
In D1581#63463, @Stan wrote:

Might want to make sure as well that the territory does not have any influence, so we can have the classical mode @wowgetoffyourcellphone talked about. Because switching territory visibility off is nice, but it might confuse people. Also it will have to be made an option, and that option shouldn't be available for rated games.

Thanks for the patch.

Jun 18 2018, 10:18 AM

Jun 11 2018

Imarok raised a concern with rP20064: XmppClient cleanup..

Cause of the "registered too many accounts within one hour" message not shown anymore.

Jun 11 2018, 1:08 AM

Jun 10 2018

Imarok added inline comments to rP20447: Not so small input.js (originally been batch training) cleanup.
Jun 10 2018, 3:28 PM

Jun 3 2018

Imarok added a comment to D1557: Fix NetServer FSM error when ending the MP match in the loading screen.
In D1557#62851, @Imarok wrote:

Looks good code-wise.
Played a game and also worked.
Couldn't reproduce the OOS, so couldn't test that.

Jun 3 2018, 2:10 PM
Imarok accepted D1557: Fix NetServer FSM error when ending the MP match in the loading screen.

Looks good code-wise.
Played a game and also worked.
Couldn't reproduce the OOS, so couldn't test that.

Jun 3 2018, 11:56 AM
Imarok added a comment to D1517: [RFC] Print out the state and message name in Fsm error warnings.

So do I get a "yes" for the approach?

Jun 3 2018, 11:43 AM

May 31 2018

Imarok added inline comments to D1525: Add a lobby server port config option .
May 31 2018, 8:35 PM

May 29 2018

Imarok added inline comments to D1525: Add a lobby server port config option .
May 29 2018, 11:14 AM

May 27 2018

Imarok accepted D1479: Lobby: Ignore games with no valid modentry.
May 27 2018, 12:22 PM
Imarok added a comment to D1479: Lobby: Ignore games with no valid modentry.

Looks good, tested.
(Couldn't test a malformed report, as that would have broken the game for all A23 players)

May 27 2018, 12:22 PM

May 26 2018

Imarok added a comment to D1518: Fix mod version comparison lag in lobby.js, gamesetup.js, load.js and any other place.
In D1518#62053, @elexis wrote:
In D1518#62052, @Imarok wrote:

wanna add that minimal lobby.js diff, so that we don't call Engine.GetEngineInfo() number_of_lobby_games times per guiTick?

Not for 20 microseconds * numGames.
I was rather becoming interested to go the other way and remove the cache of that call in the replaymenu.

May 26 2018, 7:10 AM

May 23 2018

Imarok added a comment to D1518: Fix mod version comparison lag in lobby.js, gamesetup.js, load.js and any other place.

wanna add that minimal lobby.js diff, so that we don't call Engine.GetEngineInfo() number_of_lobby_games times per guiTick?
(else looks good)

May 23 2018, 11:43 PM
Imarok updated the diff for D1517: [RFC] Print out the state and message name in Fsm error warnings.

Maybe nicer approach fro creating the map, by using a macro

May 23 2018, 12:24 AM
Imarok added a comment to D1517: [RFC] Print out the state and message name in Fsm error warnings.
In D1517#61919, @elexis wrote:

Benefits of the patch:

  • less error-prone debugging: It is easy to mix up things when debugging as you pointed out in this trac ticket today.
  • less time-consuming: One also has to either use an IDE that displays the enum values or compute them manually. There is a number of state variables with similar names which can mislead debugging developers.
  • simple code: Since the map is directly below the enum, it seems to be hard to forget the // Keep this in sync with foo part.

    Disadvantages of the patch:
  • more error-prone code: It's feasible to mismatch string with enums when maintaining.
  • slightly more maintenance work, more hunks in patches, more code to learn before comprehending it for beginners

    So it seems like a tradeoff of limited advantages and disadvantages. Given the time that I already spent on matching the numbers with enum constants, chosing the code strategy where one should optimize the code for progressive revisioning, maybe this could be considered doable if you want to spend the time on this rather than other things. But do we really benefit from paying the cost or is it sufficient if we debug correctly when we debug?
May 23 2018, 12:18 AM

May 22 2018

Imarok added inline comments to D1513: Prevent players from dropping during map generation.
May 22 2018, 11:57 PM
Imarok added a comment to D856: Tab more names when autocomplete in chat (Autocomplete Cycling).

Just quickly scanned the diff and tried it out. Seems to be nice.
Shouldn't we also do cycling for the other autocomplete words?

May 22 2018, 11:19 PM
Imarok retitled D856: Tab more names when autocomplete in chat (Autocomplete Cycling) from Tab more names when autocomplete in chat to Tab more names when autocomplete in chat (Autocomplete Cycling).
May 22 2018, 11:03 PM
Imarok accepted D1513: Prevent players from dropping during map generation.

Tested it in the lobby today.
Only I as host had the patch applied.
At start while loading 3 people lost connection and I got Net server: Error running FSM update (type=25 state=4) (That is NMT_END_COMMAND_BATCH and NSS_PREGAME).
But after the the remaining players finished loading, all could at least rejoin successfully.

May 22 2018, 10:41 PM
Imarok added a comment to P121 Simple launched mod version caching in js.
In P121#920, @wraitii wrote:

I think the lobby change is still OK, but I'm fine with not adding it for slight readability reasons.

May 22 2018, 7:18 PM
Imarok added inline comments to D1512: Fix Lobby lag when updating the game list.
May 22 2018, 6:56 PM
Imarok added a comment to P121 Simple launched mod version caching in js.
In P121#917, @elexis wrote:

IMO Globals are something to be avoided where possible. We have so many of them already and the ideal number of total globals is somewhere near 2.
After implementing the C++ cache, it consumes 10-30ms instead of 170ms.
30 games * 20ms per call = 0.6 seconds every few seconds or more often.
So I'd be ok with paying the cost of 1 added line of code in the updateGameList function of lobby.js as you had proposed once, while leaving the rest in JS as is?
Reportedly the gamesetup is slow too when sending stanzas, but that must be a problem of a factor 10 less than in the lobby page (as the problem is multiplied with the number of games there, while gamesetup stanzas are only sent all 3 seconds or upon client join / leave.

May 22 2018, 6:51 PM
Imarok added a comment to D1512: Fix Lobby lag when updating the game list.

Let's do it your way then, I'm not dying on this hill. Feel free to commandeer with your patch, otherwise I'll take it as a basis and carry on myself.

In German we say: "der klügere gibt nach" ;)
(No offense in direction of elexis intended)

May 22 2018, 3:30 PM
Imarok added a comment to D1512: Fix Lobby lag when updating the game list.
In D1512#61875, @elexis wrote:

something like that although it doesn't work yet at all, needs a different scriptinterface when started in nonvisual mode, missing comments and motivation, unneeded include and moved something unrelated which gave me pain while reading.

That could work 👍

May 22 2018, 1:19 PM
Imarok added a comment to P121 Simple launched mod version caching in js.
In P121#915, @elexis wrote:

What speaks against this approach for the release?

See irclogs yesterday. Recaping:
My main reason for prefering a C++ solution is that it is done once, rather than N times and that it is implementable with the same amount of code in a different place. So why pick the worse alternative if the alternative has presumably the same cost. Prefering quantity over quality doesn't pay off in the long term.
A second weaker argument is that const g_EngineInfo = Engine.GetEngineInfo(); is called each time a new GUI page is opened, every message box, so you get 170ms delay (on my machine) each time even if not used.

Hmm, that's a point..

A third weaker argument is that new pages don't have it cached, we need to go through all GUI pages to check it for completeness.

May 22 2018, 1:17 PM
Imarok added a comment to D1512: Fix Lobby lag when updating the game list.

I think we have a pretty good handle on the problem, and we realise that properly fixing it is hard. I suggest doing the hotfix (JS caching), and then raising a concern about it until we fix things properly. Otherwise it'll take ages imo.

I agree. I proposed a patch in P121.

May 22 2018, 1:06 PM
Imarok added a comment to P121 Simple launched mod version caching in js.

What speaks against this approach for the release?
It is global.
It needs no maintenance.
It changes only simple things, so probability of breaking is quite low.
Of course this does not cache C++ invocations of Engine.GetEngineInfo(), but those aren't called that often.

May 22 2018, 1:05 PM
Imarok updated the title for P121 Simple launched mod version caching in js from Masterwork From Distant Lands to Simple caching in js.
May 22 2018, 1:02 PM
Imarok edited P121 Simple launched mod version caching in js.
May 22 2018, 1:01 PM
Imarok added a comment to D1512: Fix Lobby lag when updating the game list.
In D1512#61930, @elexis wrote:
In D1512#61928, @Imarok wrote:

Could we just do a small and quick fix (common js only cache) for A23 and think about the approptiate fix for A24 after the rerelease?

Committing something without knowing what investigating the situation prior to the commit is not happening with my agreement and the matter is not hard to understand.

May 22 2018, 12:58 PM
Imarok added a comment to D1512: Fix Lobby lag when updating the game list.

Could we just do a small and quick fix (common js only cache) for A23 and think about the approptiate fix for A24 after the rerelease?

May 22 2018, 12:50 PM
Imarok created D1517: [RFC] Print out the state and message name in Fsm error warnings.
May 22 2018, 10:53 AM
elexis awarded D1516: [NetServer] Split `OnInGame` function a Like token.
May 22 2018, 10:14 AM
Imarok created D1516: [NetServer] Split `OnInGame` function.
May 22 2018, 10:10 AM
Imarok added inline comments to D1512: Fix Lobby lag when updating the game list.
May 22 2018, 9:11 AM

May 21 2018

Imarok requested changes to D1512: Fix Lobby lag when updating the game list.

This breaks the version check.

May 21 2018, 11:04 PM
Imarok added a comment to D1513: Prevent players from dropping during map generation.

Looks good.
The use of SetLongTimeout is correct and complete. (i.e. all functions leading to a loading screen set the long timeout and all functions leading out of the loading into the game revert the timeout)
Wondered about the 0s in enet_peer_timeout(peer, 0, 0, 0); but after reading the documentation (http://enet.bespin.org/group__peer.html#gac48f35cdd39a89318a7b4fc19920b21b) it seems correct.

May 21 2018, 10:58 PM
Imarok awarded D1513: Prevent players from dropping during map generation a Manufacturing Defect? token.
May 21 2018, 10:17 PM
Imarok added a comment to D1513: Prevent players from dropping during map generation.

Looks nice, will give a closer look tomorrow.

May 21 2018, 10:17 PM
Imarok added a comment to D1512: Fix Lobby lag when updating the game list.

Why not caching it on init?

May 21 2018, 10:05 PM
Imarok added a comment to D1512: Fix Lobby lag when updating the game list.

I cannot reproduce any lobbylag on windows. All above was doen using Ubuntu.

May 21 2018, 9:06 AM
Imarok added a comment to rP21301: Check lobby games for incompatible mods.

lead to immersive lags in the lobby (Engine.GetEngineInfo().mods command) (only when public mod is zipped to public.zip, unzipped all fine)

to test replace Engine.GetEngineInfo().mods in lobby.js and gamesetup.js with [] so it wont be executed

will be much faster then
but i dont know why atm

(i hear when they take my mod fgodmod and the lobby files and some other files are in unpacked version then on files system is less lag users tell.)

May 21 2018, 8:45 AM
Imarok created D1512: Fix Lobby lag when updating the game list.
May 21 2018, 8:45 AM

May 20 2018

Imarok added a comment to rP21242: Move `GetEngineInfo` to Mod.[h|cpp].

lead to immersive lags in the lobby (Engine.GetEngineInfo().mods command) (only when public mod is zipped to public.zip, unzipped all fine)

to test replace Engine.GetEngineInfo().mods in lobby.js and gamesetup.js with [] so it wont be executed

will be much faster then
but i dont know why atm

May 20 2018, 12:54 AM

May 18 2018

Imarok awarded D1497: Mapgen: Alpine Valley a Love token.
May 18 2018, 7:37 AM

May 15 2018

Imarok added a comment to D1490: Unit Pushing.

What about that: enemy units give some resistance against pushing, but if they get pushed hard enough they also go away. (Not sure if that is easy to implement)

May 15 2018, 11:09 PM

May 14 2018

Imarok updated the diff for D1461: [RFC] Hint the location for "You have been attacked" notifications.

Also add the location if entity has vanished. Still containing a button texture and not using the correct textWidth. Both will be fixed as soon as D844 is done.

May 14 2018, 7:28 PM
Imarok added inline comments to D1461: [RFC] Hint the location for "You have been attacked" notifications.
May 14 2018, 6:41 PM
Imarok added a comment to D1461: [RFC] Hint the location for "You have been attacked" notifications.
In D1461#60834, @elexis wrote:

We can equally convert the lagwarnings to buttons that ask you to kick the guy.

May 14 2018, 5:56 PM
Imarok added a parent revision for D1461: [RFC] Hint the location for "You have been attacked" notifications: D844: Add a `GetTextSize()` function to the GUI..
May 14 2018, 5:56 PM
Imarok added a child revision for D844: Add a `GetTextSize()` function to the GUI.: D1461: [RFC] Hint the location for "You have been attacked" notifications.
May 14 2018, 5:56 PM
Imarok removed a parent revision for D1481: Remove the unneeded sound warnings when no sound: D844: Add a `GetTextSize()` function to the GUI..
May 14 2018, 5:55 PM
Imarok removed a child revision for D844: Add a `GetTextSize()` function to the GUI.: D1481: Remove the unneeded sound warnings when no sound.
May 14 2018, 5:55 PM
Imarok added a comment to D1481: Remove the unneeded sound warnings when no sound.

oops, that was the wrong tab xD

May 14 2018, 5:55 PM
Imarok added a parent revision for D1481: Remove the unneeded sound warnings when no sound: D844: Add a `GetTextSize()` function to the GUI..
May 14 2018, 5:50 PM
Imarok added a child revision for D844: Add a `GetTextSize()` function to the GUI.: D1481: Remove the unneeded sound warnings when no sound.
May 14 2018, 5:50 PM
Imarok added a comment to D1461: [RFC] Hint the location for "You have been attacked" notifications.
In D1461#60588, @elexis wrote:

As mentioned line breaks won't occur here as far as I see, but if we ever want to support them, D844 would be a place to visit.

May 14 2018, 5:06 PM
Imarok accepted D1362: Remove the list of hardcoded training hotkeys..

Fix works and is complete.
Was broken since implementation in rP13944

May 14 2018, 5:03 PM
Imarok added inline comments to D1481: Remove the unneeded sound warnings when no sound.
May 14 2018, 4:55 PM
Imarok added a comment to rP13944: Rearrange hotkeys a bit. Queue the 8th unit is now Comma, and select idle….

Really using the hotkey was forgotten...

May 14 2018, 3:44 PM
Imarok added inline comments to D1418: Enable garrisoning on gates.
May 14 2018, 1:04 PM

May 5 2018

Imarok created D1485: Clarify the purpose of the Replay button in the summary.
May 5 2018, 11:03 PM

May 3 2018

Imarok added a comment to D1461: [RFC] Hint the location for "You have been attacked" notifications.
In D1461#60571, @elexis wrote:

afaik

Complaint and Engine.GetTextWidth

May 3 2018, 10:55 PM
Imarok added a comment to rP21076: Show rank icon above status bars.

can we get experience bar small white below healthbar maybe on unit? helpsome for watching development of units in fight.

May 3 2018, 3:01 PM
Imarok added a comment to rP20886: Enable players to open the lobby as a dialog in the gamesetup, running games….

(Notice he means the golden line, not the white one)

oh there must be wrong something no gap ther

May 3 2018, 3:00 PM
Imarok added a comment to D1461: [RFC] Hint the location for "You have been attacked" notifications.
In D1461#59849, @elexis wrote:

Only "You have been attacked" should be the button, maybe that timestamp prefix too. The rest has no reason to not remain clickable.

May 3 2018, 2:57 PM

May 2 2018

Imarok created D1481: Remove the unneeded sound warnings when no sound.
May 2 2018, 8:39 PM