In D3303#156498, @Angen wrote:

@Imarok I believe merchant ships can gather them, or at least one of the available ships could in a23b.

Fine. Now I can't spot any more oversights.
A bit unrelated to this diff: Do you know how the floating treasures are supposed to be gathered? (Ships can't gather them and units can only gather them if the treasures are close at the shore)

In D3303#156448, @Freagarach wrote:

Catafalque.

Could you add a test for this bug? (So that we prevent regressions ;)
Ofc not for A24.

In D3569#156168, @Freagarach wrote:

Nice :)

Just one question, shouldn't you use the function above?

In D3569#156102, @Freagarach wrote:

Are there more occurences that use this function?

In D3566#156068, @Imarok wrote:

In D3566#155958, @Langbart wrote:

Yes, it works. Now its the same for when someone attacks my units. Thanks for noticing and fixing it.
Clicking on the notification takes me to the action hotspot, it changes my camera perspective to the way it was when spawning into the game, if you never change the camera perspective or you press "R" (camera.reset) before clicking on the notification, you won't notice it. It is the same when some of my units are attacked.

Haven't noticed any bad effects otherwise.

Hmm, Good point about the change of the camera perspective. Wanna create a ticket for that?

In D3566#155958, @Langbart wrote:

Yes, it works. Now its the same for when someone attacks my units. Thanks for noticing and fixing it.
Clicking on the notification takes me to the action hotspot, it changes my camera perspective to the way it was when spawning into the game, if you never change the camera perspective or you press "R" (camera.reset) before clicking on the notification, you won't notice it. It is the same when some of my units are attacked.

Haven't noticed any bad effects otherwise.

In D3525#155510, @Freagarach wrote:

Ah, now I understand what this diff does ^^ (I just tested it.)
Works for me :)

missing semi

Fixed by rP24843

In D3526#154926, @Langbart wrote:

Fix it properly

Caused #5998

@vladislavbelov :
Sorry if this wasn't clear, but this revision of my diff was mainly uploaded to get some help in finding the bug in the arb shader.
It wasn't not meant to be a clean ready to commit version. ;)

In D3440#152272, @toonijn wrote:

"I guess it is either this or a revert. I don't like the fact that we filter here, I think we should do it earlier, if one has hideInSummary true for the counter, but not for the heading things get ugly again."

That's without the hideInSummary variable already true. If headings and counters contained different number of values it would be ugly (independent of rP24721). It's the disconnection between headings and counters that feels weird. I think in long term the getScorePanelsData should return something like:

[
    {
        "label": ...
        "titleHeadings": ...
        "values": [
            {
                "identifier": "total",
                "caption": translate("Total"),
                "yStart": 34,
                "width": 105,
                "verticalOffset": 3,
                "fn": calculateBuildings
                "hideInSummary": false
            },
            ...
        ],
        "teamCounterFn": calculateBuildingsTeam
    },
    ...    
]

Fix linebreak noticed by Langbart.
Also fix weird sizing when first disabling all overlays and then repeatedly enabling → disabling the FPS overlay.
Don't use callbacks for the speed multiplier as the ingame time would also need one when the game gets longer than 59.9999 minutes. (And mabye something else also would need a callback)

I marked the lines where I suspect you forgot to filter for hideInSummary

position issue fixed in rP24736

In D3389#150463, @ffffffff wrote:

Works as expected. Button is again usable.
Lul semicolon missing. Well imarok will handle that. :D

Reuse event.position as event is used widely anyway.

This commit introduced a bug that created blank lines.
It was fixed by rP24671.

Tried setting three waypoints? first to somewhere, second to the other market, third to somewhere else?
(That gives quite strange behaviour.)

Looks good. 👍
Added some quick comments.
Maybe think of a more specific name then just hide? (I mean it's only hidden in the normal summary and not in the graphs.)

In rP24565#47691, @Freagarach wrote:

Ignore me ^^'

Could any of you two reproduce the issue consistently?

In rP24565#47429, @Freagarach wrote:

(One can sent the position from AttackDetection.js. (Don't need to get the ent-state then.) Although that may cause the entity to have left the screen already.)

In rP24565#47420, @Angen wrote:

ERROR: Errors executing script event "Press"

ERROR: JavaScript error: gui/session/chat/ChatMessageFormatSimulation.js line 28 position is null parse/<.callback</<@gui/session/chat/ChatMessageFormatSimulation.js:28:6

I think it is because entity already died

In D2830#148457, @Feldfeld wrote:

Well probably not actually otherwise the deprecated functions placeholder wouldn't be needed. Plus I just reread the ticket so indeed there is no equivalence. I'll adjust the values if necessary

Is only an issue when resizing the window while in gamesetup.
So it is still kind of a bug but not as severe as thought.

I think there is something wrong in fullscreen.
I'd expect to see 9 or 12 maps in fullscreen and not only two:

Fixed graphical issue.
But dramatically increased test calculation time:

matrix multiplication
number_of_samples = 200
number_of_iteration = 1000000
have_sse = true
SSE (off): 3.28038ms
SSE (on):  3.36736ms
.
matrix Blend
number_of_samples = 200
number_of_iteration = 1000000
have_sse = true
SSE (off): 2.49736ms
SSE (on):  2.40249ms
.
matrix AddBlend
number_of_samples = 200
number_of_iteration = 1000000
have_sse = true
SSE (off): 2.36652ms
SSE (on):  2.39413ms

Broken on Sahyadri Buttes:

Shouldn't that version bump be in the same commit as the breaking change (D3237) and therefore in the same diff?

Rebase upon rP24384 and account for some of Vladislav's comments

Translate properly.

Tooltip and crosshair icon.
TODO: Find/Create a better icon.

In D3184#140944, @Stan wrote:

If you're doing the consent thing one might look into not broadcasting team messages to everyone.

See inline. Else it looks good.

In D3193#140938, @Stan wrote:

D3192 :)

Fix indentation

Cosmetics

Rebase. Cause of rP23020 this now depends on a patch coming soon™ that adds getTextSize to buttons again.

TODO: Need to implement getTextSize for CButton. (see http://irclogs.wildfiregames.com/%230ad-dev/2020-12-05-QuakeNet-%230ad-dev.log)

Try implementing an ARB shader for flaring. Currently not working.

Fix rebase mistake in minimap.vs

Don't forget the new JSInterface file this time

Rebase. (SM-Update)