Page MenuHomeWildfire Games

Add relicCount to autostart
ClosedPublic

Authored by bb on Mar 16 2018, 12:17 AM.

Details

Summary

Currently (and never been) there is no way to set the relicCount in autostarted game, resulting in some falsy variable and thus the creation loop in CaptureTheRelic doesn't create anything. Adding the setting to gamesetup.cpp here + a default.

Noticed by mimo in rP21474

Test Plan

start the game like binaries/system/pyrogenesis -autostart-victory=capture_the_relic -autostart="random/alpine_lakes" -autostart-seed=-1 -autostart-players=2 -autostart-civ=1:athen -autostart-civ=2:brit -autostart-ai=2:petra and capture some relics

Notice duplicating settings and defaults from gamesetup.js is bad and we need to find a way to shrink that, but consider it meh for now

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis accepted this revision.Mar 16 2018, 12:20 AM
elexis added a subscriber: elexis.

Speaking of duplication, binaries/system/readme.txt is outdated

This revision is now accepted and ready to land.Mar 16 2018, 12:20 AM
Vulcan added a subscriber: Vulcan.Mar 16 2018, 12:28 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/255/display/redirect

This revision was automatically updated to reflect the committed changes.