Added more mines and a crossable shallow to the river.
Details
- Reviewers
elexis - Commits
- rP21680: Add two cataracts and more mines to Fields Of Meroë.
Make sure the passage is crossable and whether mine count is appropriate.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 5691 Build 9562: Vulcan Build Jenkins Build 9561: arc lint + arc unit
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Default... Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 122| 122| "landFunc": (position, shoreDist1, shoreDist2) => { | 123| 123| for (let riv of riverTextures) | 124| 124| if (riv.left < +shoreDist1 && +shoreDist1 < riv.right || riv.left < -shoreDist2 && -shoreDist2 < riv.right) | 125| |- { | | 125|+ { | 126| 126| riv.tileClass.add(position); | 127| 127| if (riv.terrain) | 128| 128| createTerrain(riv.terrain).place(position); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 123| 123| for (let riv of riverTextures) | 124| 124| if (riv.left < +shoreDist1 && +shoreDist1 < riv.right || riv.left < -shoreDist2 && -shoreDist2 < riv.right) | 125| 125| { | 126| |- riv.tileClass.add(position); | | 126|+ riv.tileClass.add(position); | 127| 127| if (riv.terrain) | 128| 128| createTerrain(riv.terrain).place(position); | 129| 129| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 124| 124| if (riv.left < +shoreDist1 && +shoreDist1 < riv.right || riv.left < -shoreDist2 && -shoreDist2 < riv.right) | 125| 125| { | 126| 126| riv.tileClass.add(position); | 127| |- if (riv.terrain) | | 127|+ if (riv.terrain) | 128| 128| createTerrain(riv.terrain).place(position); | 129| 129| } | 130| 130| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 125| 125| { | 126| 126| riv.tileClass.add(position); | 127| 127| if (riv.terrain) | 128| |- createTerrain(riv.terrain).place(position); | | 128|+ createTerrain(riv.terrain).place(position); | 129| 129| } | 130| 130| } | 131| 131| }); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 126| 126| riv.tileClass.add(position); | 127| 127| if (riv.terrain) | 128| 128| createTerrain(riv.terrain).place(position); | 129| |- } | | 129|+ } | 130| 130| } | 131| 131| }); | 132| 132| Engine.SetProgress(10);
Link to build: https://jenkins.wildfiregames.com/job/differential/310/display/redirect
Thanks for the crossing, otherwise I think it's too hard to continually ferry units across the river.
About the part that ships can't cross, that's geographically and historically accurate. Land trade was important because of that.
binaries/data/mods/public/maps/random/fields_of_meroe.js | ||
---|---|---|
145 | PI/2 can be avoided by switching X/Y I guess. Also it would be good to have scaleByMapSize(2, 4) passages, right? | |
153 | Was wondering if we should have bumps and stones around the area too (NearTileClasses(clPassage) constrained to the water area). | |
375 | ByAreas, otherwise you get too few rocks, also performance |
binaries/data/mods/public/maps/random/fields_of_meroe.js | ||
---|---|---|
145 | I actually wanted to include the fifth and sixth(?) cataracts. But couldnt get the constraint to work, and i guess its not geographically accurate when two are too close. |
binaries/data/mods/public/maps/random/fields_of_meroe.js | ||
---|---|---|
145 | I forgot, exactly two of them. We should have it as a code comment if we don't add it to the map description (the latter wouldn't be inadvisable as it teaches the players some relevant history and geography). A simple implementation of two cataracts would be for (let x of randFloat(0.15, 0.35), randFloat(0.65, 0.85)) |
Besides aRock, this contains the fixes to the inline comments: https://pastebin.com/8ikR3vX1
binaries/data/mods/public/maps/random/fields_of_meroe.js | ||
---|---|---|
137 | Can move the PI/2 and riverAngle here too to remove a bit of duplication | |
147 | \n} | |
151 | Constants for heights | |
155 | 100 retries shouldn't be needed now that it always tries to place within that area. | |
372 | aRockA doesnt fit to water, should avoid it | |
381 | This one needs more retries, because it choses a random point on the map and its unlikely that its near the cataract. (An alternative would be to create an area around the passage and then use createObjectGroupsByAreas, but that doesn't seem worth the lines of code) |
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Default... Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 124| 124| "landFunc": (position, shoreDist1, shoreDist2) => { | 125| 125| for (let riv of riverTextures) | 126| 126| if (riv.left < +shoreDist1 && +shoreDist1 < riv.right || riv.left < -shoreDist2 && -shoreDist2 < riv.right) | 127| |- { | | 127|+ { | 128| 128| riv.tileClass.add(position); | 129| 129| if (riv.terrain) | 130| 130| createTerrain(riv.terrain).place(position); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 125| 125| for (let riv of riverTextures) | 126| 126| if (riv.left < +shoreDist1 && +shoreDist1 < riv.right || riv.left < -shoreDist2 && -shoreDist2 < riv.right) | 127| 127| { | 128| |- riv.tileClass.add(position); | | 128|+ riv.tileClass.add(position); | 129| 129| if (riv.terrain) | 130| 130| createTerrain(riv.terrain).place(position); | 131| 131| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 126| 126| if (riv.left < +shoreDist1 && +shoreDist1 < riv.right || riv.left < -shoreDist2 && -shoreDist2 < riv.right) | 127| 127| { | 128| 128| riv.tileClass.add(position); | 129| |- if (riv.terrain) | | 129|+ if (riv.terrain) | 130| 130| createTerrain(riv.terrain).place(position); | 131| 131| } | 132| 132| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 127| 127| { | 128| 128| riv.tileClass.add(position); | 129| 129| if (riv.terrain) | 130| |- createTerrain(riv.terrain).place(position); | | 130|+ createTerrain(riv.terrain).place(position); | 131| 131| } | 132| 132| } | 133| 133| }); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 128| 128| riv.tileClass.add(position); | 129| 129| if (riv.terrain) | 130| 130| createTerrain(riv.terrain).place(position); | 131| |- } | | 131|+ } | 132| 132| } | 133| 133| }); | 134| 134| Engine.SetProgress(10); | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 168| 168| undefined, | 169| 169| scaleByMapSize(20, 50), | 170| 170| 20, | 171| |- [areaPassage]) | | 171|+ [areaPassage]); | 172| 172| } | 173| 173| | 174| 174| var [playerIDs, playerPosition] = playerPlacementRandom(sortAllPlayers(), avoidClasses(clRiver, 15, clPlayer, 30)); binaries/data/mods/public/maps/random/fields_of_meroe.js | 171| » » [areaPassage]) | | [NORMAL] JSHintBear: | | Missing semicolon.
Link to build: https://jenkins.wildfiregames.com/job/differential/345/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Default... Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 123| 123| "landFunc": (position, shoreDist1, shoreDist2) => { | 124| 124| for (let riv of riverTextures) | 125| 125| if (riv.left < +shoreDist1 && +shoreDist1 < riv.right || riv.left < -shoreDist2 && -shoreDist2 < riv.right) | 126| |- { | | 126|+ { | 127| 127| riv.tileClass.add(position); | 128| 128| if (riv.terrain) | 129| 129| createTerrain(riv.terrain).place(position); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 124| 124| for (let riv of riverTextures) | 125| 125| if (riv.left < +shoreDist1 && +shoreDist1 < riv.right || riv.left < -shoreDist2 && -shoreDist2 < riv.right) | 126| 126| { | 127| |- riv.tileClass.add(position); | | 127|+ riv.tileClass.add(position); | 128| 128| if (riv.terrain) | 129| 129| createTerrain(riv.terrain).place(position); | 130| 130| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 125| 125| if (riv.left < +shoreDist1 && +shoreDist1 < riv.right || riv.left < -shoreDist2 && -shoreDist2 < riv.right) | 126| 126| { | 127| 127| riv.tileClass.add(position); | 128| |- if (riv.terrain) | | 128|+ if (riv.terrain) | 129| 129| createTerrain(riv.terrain).place(position); | 130| 130| } | 131| 131| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 126| 126| { | 127| 127| riv.tileClass.add(position); | 128| 128| if (riv.terrain) | 129| |- createTerrain(riv.terrain).place(position); | | 129|+ createTerrain(riv.terrain).place(position); | 130| 130| } | 131| 131| } | 132| 132| }); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 127| 127| riv.tileClass.add(position); | 128| 128| if (riv.terrain) | 129| 129| createTerrain(riv.terrain).place(position); | 130| |- } | | 130|+ } | 131| 131| } | 132| 132| }); | 133| 133| Engine.SetProgress(10); | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required before '}'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 145| 145| "tileClass": clCataract, | 146| 146| "startHeight": heightCataract, | 147| 147| "endHeight": heightCataract, | 148| |- "constraints": new HeightConstraint(-Infinity, 0)}); | | 148|+ "constraints": new HeightConstraint(-Infinity, 0) }); | 149| 149| | 150| 150| createAreasInAreas( | 151| 151| new ClumpPlacer(4, 0.4, 0.6), | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 161| 161| undefined, | 162| 162| scaleByMapSize(20, 50), | 163| 163| 50, | 164| |- [areaPassage]) | | 164|+ [areaPassage]); | 165| 165| } | 166| 166| | 167| 167| var [playerIDs, playerPosition] = playerPlacementRandom(sortAllPlayers(), avoidClasses(clRiver, 15, clPlayer, 30)); binaries/data/mods/public/maps/random/fields_of_meroe.js | 164| » » [areaPassage]) | | [NORMAL] JSHintBear: | | Missing semicolon.
Link to build: https://jenkins.wildfiregames.com/job/differential/347/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Default... Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 123| 123| "landFunc": (position, shoreDist1, shoreDist2) => { | 124| 124| for (let riv of riverTextures) | 125| 125| if (riv.left < +shoreDist1 && +shoreDist1 < riv.right || riv.left < -shoreDist2 && -shoreDist2 < riv.right) | 126| |- { | | 126|+ { | 127| 127| riv.tileClass.add(position); | 128| 128| if (riv.terrain) | 129| 129| createTerrain(riv.terrain).place(position); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 124| 124| for (let riv of riverTextures) | 125| 125| if (riv.left < +shoreDist1 && +shoreDist1 < riv.right || riv.left < -shoreDist2 && -shoreDist2 < riv.right) | 126| 126| { | 127| |- riv.tileClass.add(position); | | 127|+ riv.tileClass.add(position); | 128| 128| if (riv.terrain) | 129| 129| createTerrain(riv.terrain).place(position); | 130| 130| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 125| 125| if (riv.left < +shoreDist1 && +shoreDist1 < riv.right || riv.left < -shoreDist2 && -shoreDist2 < riv.right) | 126| 126| { | 127| 127| riv.tileClass.add(position); | 128| |- if (riv.terrain) | | 128|+ if (riv.terrain) | 129| 129| createTerrain(riv.terrain).place(position); | 130| 130| } | 131| 131| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 126| 126| { | 127| 127| riv.tileClass.add(position); | 128| 128| if (riv.terrain) | 129| |- createTerrain(riv.terrain).place(position); | | 129|+ createTerrain(riv.terrain).place(position); | 130| 130| } | 131| 131| } | 132| 132| }); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 127| 127| riv.tileClass.add(position); | 128| 128| if (riv.terrain) | 129| 129| createTerrain(riv.terrain).place(position); | 130| |- } | | 130|+ } | 131| 131| } | 132| 132| }); | 133| 133| Engine.SetProgress(10); | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required before '}'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 145| 145| "tileClass": clCataract, | 146| 146| "startHeight": heightCataract, | 147| 147| "endHeight": heightCataract, | 148| |- "constraints": new HeightConstraint(-Infinity, 0)}); | | 148|+ "constraints": new HeightConstraint(-Infinity, 0) }); | 149| 149| | 150| 150| createAreasInAreas( | 151| 151| new ClumpPlacer(4, 0.4, 0.6), | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 161| 161| undefined, | 162| 162| scaleByMapSize(20, 50), | 163| 163| 50, | 164| |- [areaPassage]) | | 164|+ [areaPassage]); | 165| 165| } | 166| 166| | 167| 167| var [playerIDs, playerPosition] = playerPlacementRandom(sortAllPlayers(), avoidClasses(clRiver, 15, clPlayer, 30)); binaries/data/mods/public/maps/random/fields_of_meroe.js | 164| » » [areaPassage]) | | [NORMAL] JSHintBear: | | Missing semicolon.
Link to build: https://jenkins.wildfiregames.com/job/differential/348/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Default... Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 124| 124| "landFunc": (position, shoreDist1, shoreDist2) => { | 125| 125| for (let riv of riverTextures) | 126| 126| if (riv.left < +shoreDist1 && +shoreDist1 < riv.right || riv.left < -shoreDist2 && -shoreDist2 < riv.right) | 127| |- { | | 127|+ { | 128| 128| riv.tileClass.add(position); | 129| 129| if (riv.terrain) | 130| 130| createTerrain(riv.terrain).place(position); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 125| 125| for (let riv of riverTextures) | 126| 126| if (riv.left < +shoreDist1 && +shoreDist1 < riv.right || riv.left < -shoreDist2 && -shoreDist2 < riv.right) | 127| 127| { | 128| |- riv.tileClass.add(position); | | 128|+ riv.tileClass.add(position); | 129| 129| if (riv.terrain) | 130| 130| createTerrain(riv.terrain).place(position); | 131| 131| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 126| 126| if (riv.left < +shoreDist1 && +shoreDist1 < riv.right || riv.left < -shoreDist2 && -shoreDist2 < riv.right) | 127| 127| { | 128| 128| riv.tileClass.add(position); | 129| |- if (riv.terrain) | | 129|+ if (riv.terrain) | 130| 130| createTerrain(riv.terrain).place(position); | 131| 131| } | 132| 132| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 127| 127| { | 128| 128| riv.tileClass.add(position); | 129| 129| if (riv.terrain) | 130| |- createTerrain(riv.terrain).place(position); | | 130|+ createTerrain(riv.terrain).place(position); | 131| 131| } | 132| 132| } | 133| 133| }); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 128| 128| riv.tileClass.add(position); | 129| 129| if (riv.terrain) | 130| 130| createTerrain(riv.terrain).place(position); | 131| |- } | | 131|+ } | 132| 132| } | 133| 133| }); | 134| 134| Engine.SetProgress(10); | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/fields_of_meroe.js | 168| 168| undefined, | 169| 169| scaleByMapSize(20, 50), | 170| 170| 20, | 171| |- [areaPassage]) | | 171|+ [areaPassage]); | 172| 172| } | 173| 173| | 174| 174| var [playerIDs, playerPosition] = playerPlacementRandom(sortAllPlayers(), avoidClasses(clRiver, 15, clPlayer, 30)); binaries/data/mods/public/maps/random/fields_of_meroe.js | 171| » » [areaPassage]) | | [NORMAL] JSHintBear: | | Missing semicolon.
Link to build: https://jenkins.wildfiregames.com/job/differential/358/display/redirect