Details
Details
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Default... Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required after '{'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 126| 126| this.formationMembersWithAura = []; // Members with a formation aura | 127| 127| this.width = 0; | 128| 128| this.depth = 0; | 129| |- this.oldOrientation = {"sin": 0, "cos": 0}; | | 129|+ this.oldOrientation = { "sin": 0, "cos": 0}; | 130| 130| this.twinFormations = []; | 131| 131| // distance from which two twin formations will merge into one. | 132| 132| this.formationSeparation = 0; | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required before '}'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 126| 126| this.formationMembersWithAura = []; // Members with a formation aura | 127| 127| this.width = 0; | 128| 128| this.depth = 0; | 129| |- this.oldOrientation = {"sin": 0, "cos": 0}; | | 129|+ this.oldOrientation = {"sin": 0, "cos": 0 }; | 130| 130| this.twinFormations = []; | 131| 131| // distance from which two twin formations will merge into one. | 132| 132| this.formationSeparation = 0; | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required after '{'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 144| 144| | 145| 145| Formation.prototype.GetSize = function() | 146| 146| { | 147| |- return {"width": this.width, "depth": this.depth}; | | 147|+ return { "width": this.width, "depth": this.depth}; | 148| 148| }; | 149| 149| | 150| 150| Formation.prototype.GetSpeedMultiplier = function() | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required before '}'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 144| 144| | 145| 145| Formation.prototype.GetSize = function() | 146| 146| { | 147| |- return {"width": this.width, "depth": this.depth}; | | 147|+ return {"width": this.width, "depth": this.depth }; | 148| 148| }; | 149| 149| | 150| 150| Formation.prototype.GetSpeedMultiplier = function() | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required after '{'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 563| 563| footprints.push(cmpFootprint.GetShape()); | 564| 564| } | 565| 565| if (!footprints.length) | 566| |- return {"width":1, "depth": 1}; | | 566|+ return { "width":1, "depth": 1}; | 567| 567| | 568| 568| var r = {"width": 0, "depth": 0}; | 569| 569| for (var shape of footprints) | | [NORMAL] ESLintBear (key-spacing): | | Missing space before value for key 'width'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 563| 563| footprints.push(cmpFootprint.GetShape()); | 564| 564| } | 565| 565| if (!footprints.length) | 566| |- return {"width":1, "depth": 1}; | | 566|+ return {"width": 1, "depth": 1}; | 567| 567| | 568| 568| var r = {"width": 0, "depth": 0}; | 569| 569| for (var shape of footprints) | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required before '}'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 563| 563| footprints.push(cmpFootprint.GetShape()); | 564| 564| } | 565| 565| if (!footprints.length) | 566| |- return {"width":1, "depth": 1}; | | 566|+ return {"width":1, "depth": 1 }; | 567| 567| | 568| 568| var r = {"width": 0, "depth": 0}; | 569| 569| for (var shape of footprints) | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required after '{'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 565| 565| if (!footprints.length) | 566| 566| return {"width":1, "depth": 1}; | 567| 567| | 568| |- var r = {"width": 0, "depth": 0}; | | 568|+ var r = { "width": 0, "depth": 0}; | 569| 569| for (var shape of footprints) | 570| 570| { | 571| 571| if (shape.type == "circle") | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required before '}'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 565| 565| if (!footprints.length) | 566| 566| return {"width":1, "depth": 1}; | 567| 567| | 568| |- var r = {"width": 0, "depth": 0}; | | 568|+ var r = {"width": 0, "depth": 0 }; | 569| 569| for (var shape of footprints) | 570| 570| { | 571| 571| if (shape.type == "circle") | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'for-of'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 567| 567| | 568| 568| var r = {"width": 0, "depth": 0}; | 569| 569| for (var shape of footprints) | 570| |- { | | 570|+ | 571| 571| if (shape.type == "circle") | 572| 572| { | 573| 573| r.width += shape.radius * 2; | 578| 578| r.width += shape.width; | 579| 579| r.depth += shape.depth; | 580| 580| } | 581| |- } | | 581|+ | 582| 582| r.width /= footprints.length; | 583| 583| r.depth /= footprints.length; | 584| 584| return r; | | [NORMAL] ESLintBear (comma-spacing): | | A space is required after ','. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 591| 591| separation.depth *= this.separationMultiplier.depth; | 592| 592| | 593| 593| if (this.columnar) | 594| |- var sortingClasses = ["Cavalry","Infantry"]; | | 594|+ var sortingClasses = ["Cavalry", "Infantry"]; | 595| 595| else | 596| 596| var sortingClasses = this.sortingClasses.slice(); | 597| 597| sortingClasses.push("Unknown"); | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'for' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 608| 608| var classes = cmpIdentity.GetClassesList(); | 609| 609| var done = false; | 610| 610| for (var c = 0; c < sortingClasses.length; ++c) | 611| |- { | | 611|+ | 612| 612| if (classes.indexOf(sortingClasses[c]) > -1) | 613| 613| { | 614| 614| types[sortingClasses[c]].push({"ent": active[i], "pos": positions[i]}); | 615| 615| done = true; | 616| 616| break; | 617| 617| } | 618| |- } | | 618|+ | 619| 619| if (!done) | 620| 620| types["Unknown"].push({"ent": active[i], "pos": positions[i]}); | 621| 621| } | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required after '{'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 611| 611| { | 612| 612| if (classes.indexOf(sortingClasses[c]) > -1) | 613| 613| { | 614| |- types[sortingClasses[c]].push({"ent": active[i], "pos": positions[i]}); | | 614|+ types[sortingClasses[c]].push({ "ent": active[i], "pos": positions[i]}); | 615| 615| done = true; | 616| 616| break; | 617| 617| } | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required before '}'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 611| 611| { | 612| 612| if (classes.indexOf(sortingClasses[c]) > -1) | 613| 613| { | 614| |- types[sortingClasses[c]].push({"ent": active[i], "pos": positions[i]}); | | 614|+ types[sortingClasses[c]].push({"ent": active[i], "pos": positions[i] }); | 615| 615| done = true; | 616| 616| break; | 617| 617| } | | [NORMAL] ESLintBear (dot-notation): | | ["Unknown"] is better written in dot notation. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 617| 617| } | 618| 618| } | 619| 619| if (!done) | 620| |- types["Unknown"].push({"ent": active[i], "pos": positions[i]}); | | 620|+ types.Unknown.push({"ent": active[i], "pos": positions[i]}); | 621| 621| } | 622| 622| | 623| 623| var count = active.length; | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required after '{'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 617| 617| } | 618| 618| } | 619| 619| if (!done) | 620| |- types["Unknown"].push({"ent": active[i], "pos": positions[i]}); | | 620|+ types["Unknown"].push({ "ent": active[i], "pos": positions[i]}); | 621| 621| } | 622| 622| | 623| 623| var count = active.length; | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required before '}'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 617| 617| } | 618| 618| } | 619| 619| if (!done) | 620| |- types["Unknown"].push({"ent": active[i], "pos": positions[i]}); | | 620|+ types["Unknown"].push({"ent": active[i], "pos": positions[i] }); | 621| 621| } | 622| 622| | 623| 623| var count = active.length; | | [NORMAL] ESLintBear (comma-spacing): | | A space is required after ','. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 635| 635| if (this.columnar) | 636| 636| { | 637| 637| shape = "square"; | 638| |- cols = Math.min(count,3); | | 638|+ cols = Math.min(count, 3); | 639| 639| shiftRows = false; | 640| 640| centerGap = 0; | 641| 641| sortingOrder = null; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 689| 689| n -= r%2; | 690| 690| } | 691| 691| else if (shape == "triangle") | 692| |- { | | 692|+ | 693| 693| if (shiftRows) | 694| 694| var n = r + 1; | 695| 695| else | 696| 696| var n = r * 2 + 1; | 697| |- } | | 697|+ | 698| 698| if (!shiftRows && n > left) | 699| 699| n = left; | 700| 700| for (var c = 0; c < n && left > 0; ++c) | | [NORMAL] ESLintBear (space-before-function-paren): | | Unexpected space before function parentheses. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 730| 730| // calculating offset distances without a zero average makes no sense, as the formation | 731| 731| // will jump to a different position any time | 732| 732| var avgoffset = Vector2D.average(offsets); | 733| |- offsets.forEach(function (o) {o.sub(avgoffset);}); | | 733|+ offsets.forEach(function(o) {o.sub(avgoffset);}); | 734| 734| | 735| 735| // sort the available places in certain ways | 736| 736| // the places first in the list will contain the heaviest units as defined by the order | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required after '{'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 789| 789| closestOffsetId = i; | 790| 790| } | 791| 791| } | 792| |- this.memberPositions[entPos.ent] = {"row": offsets[closestOffsetId].row, "column":offsets[closestOffsetId].column}; | | 792|+ this.memberPositions[entPos.ent] = { "row": offsets[closestOffsetId].row, "column":offsets[closestOffsetId].column}; | 793| 793| return closestOffsetId; | 794| 794| }; | 795| 795| | | [NORMAL] ESLintBear (key-spacing): | | Missing space before value for key 'column'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 789| 789| closestOffsetId = i; | 790| 790| } | 791| 791| } | 792| |- this.memberPositions[entPos.ent] = {"row": offsets[closestOffsetId].row, "column":offsets[closestOffsetId].column}; | | 792|+ this.memberPositions[entPos.ent] = {"row": offsets[closestOffsetId].row, "column": offsets[closestOffsetId].column}; | 793| 793| return closestOffsetId; | 794| 794| }; | 795| 795| | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required before '}'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 789| 789| closestOffsetId = i; | 790| 790| } | 791| 791| } | 792| |- this.memberPositions[entPos.ent] = {"row": offsets[closestOffsetId].row, "column":offsets[closestOffsetId].column}; | | 792|+ this.memberPositions[entPos.ent] = {"row": offsets[closestOffsetId].row, "column":offsets[closestOffsetId].column }; | 793| 793| return closestOffsetId; | 794| 794| }; | 795| 795| | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required after '{'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 799| 799| Formation.prototype.GetRealOffsetPositions = function(offsets, pos) | 800| 800| { | 801| 801| var offsetPositions = []; | 802| |- var {sin, cos} = this.GetEstimatedOrientation(pos); | | 802|+ var { sin, cos} = this.GetEstimatedOrientation(pos); | 803| 803| // calculate the world positions | 804| 804| for (var o of offsets) | 805| 805| offsetPositions.push(new Vector2D(pos.x + o.y * sin + o.x * cos, pos.y + o.y * cos - o.x * sin)); | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required before '}'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 799| 799| Formation.prototype.GetRealOffsetPositions = function(offsets, pos) | 800| 800| { | 801| 801| var offsetPositions = []; | 802| |- var {sin, cos} = this.GetEstimatedOrientation(pos); | | 802|+ var {sin, cos } = this.GetEstimatedOrientation(pos); | 803| 803| // calculate the world positions | 804| 804| for (var o of offsets) | 805| 805| offsetPositions.push(new Vector2D(pos.x + o.y * sin + o.x * cos, pos.y + o.y * cos - o.x * sin)); | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required after '{'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 816| 816| Formation.prototype.GetEstimatedOrientation = function(pos) | 817| 817| { | 818| 818| var cmpUnitAI = Engine.QueryInterface(this.entity, IID_UnitAI); | 819| |- var r = {"sin": 0, "cos": 1}; | | 819|+ var r = { "sin": 0, "cos": 1}; | 820| 820| var unitAIState = cmpUnitAI.GetCurrentState(); | 821| 821| if (unitAIState == "FORMATIONCONTROLLER.WALKING" || unitAIState == "FORMATIONCONTROLLER.COMBAT.APPROACHING") | 822| 822| { | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required before '}'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 816| 816| Formation.prototype.GetEstimatedOrientation = function(pos) | 817| 817| { | 818| 818| var cmpUnitAI = Engine.QueryInterface(this.entity, IID_UnitAI); | 819| |- var r = {"sin": 0, "cos": 1}; | | 819|+ var r = {"sin": 0, "cos": 1 }; | 820| 820| var unitAIState = cmpUnitAI.GetCurrentState(); | 821| 821| if (unitAIState == "FORMATIONCONTROLLER.WALKING" || unitAIState == "FORMATIONCONTROLLER.COMBAT.APPROACHING") | 822| 822| { | | [NORMAL] ESLintBear (comma-spacing): | | A space is required after ','. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Formation.js | 898| 898| cmpOtherFormation.RemoveMembers(otherMembers); | 899| 899| this.AddMembers(otherMembers); | 900| 900| Engine.DestroyEntity(this.twinFormations[i]); | 901| |- this.twinFormations.splice(i,1); | | 901|+ this.twinFormations.splice(i, 1); | 902| 902| } | 903| 903| // Switch between column and box if necessary | 904| 904| var cmpUnitAI = Engine.QueryInterface(this.entity, IID_UnitAI); binaries/data/mods/public/simulation/components/Formation.js | 335| » for·(var·ent·of·this.formationMembersWithAura) | | [NORMAL] JSHintBear: | | 'ent' is already defined. binaries/data/mods/public/simulation/components/Formation.js | 422| » for·(var·ent·of·this.formationMembersWithAura) | | [NORMAL] JSHintBear: | | 'ent' is already defined. binaries/data/mods/public/simulation/components/Formation.js | 468| » var·cmpPosition·=·Engine.QueryInterface(this.entity,·IID_Position); | | [NORMAL] JSHintBear: | | 'cmpPosition' is already defined. binaries/data/mods/public/simulation/components/Formation.js | 509| » » var·cmpUnitAI·=·Engine.QueryInterface(offset.ent,·IID_UnitAI); | | [NORMAL] JSHintBear: | | 'cmpUnitAI' is already defined. binaries/data/mods/public/simulation/components/Formation.js | 544| » var·cmpPosition·=·Engine.QueryInterface(this.entity,·IID_Position); | | [NORMAL] JSHintBear: | | 'cmpPosition' is already defined. binaries/data/mods/public/simulation/components/Formation.js | 596| » » var·sortingClasses·=·this.sortingClasses.slice(); | | [NORMAL] JSHintBear: | | 'sortingClasses' is already defined. binaries/data/mods/public/simulation/components/Formation.js | 605| » for·(var·i·in·active) | | [NORMAL] JSHintBear: | | 'i' is already defined. binaries/data/mods/public/simulation/components/Formation.js | 620| » » » types["Unknown"].push({"ent":·active[i],·"pos":·positions[i]}); | | [NORMAL] JSHintBear: | | ['Unknown'] is better written in dot notation. binaries/data/mods/public/simulation/components/Formation.js | 660| » » for·(var·i·=·0;·i·<·count;·++i) | | [NORMAL] JSHintBear: | | 'i' is already defined. binaries/data/mods/public/simulation/components/Formation.js | 694| » » » » » var·n·=·r·+·1; | | [NORMAL] JSHintBear: | | 'n' is already defined. binaries/data/mods/public/simulation/components/Formation.js | 696| » » » » » var·n·=·r·*·2·+·1; | | [NORMAL] JSHintBear: | | 'n' is already defined. binaries/data/mods/public/simulation/components/Formation.js | 700| » » » for·(var·c·=·0;·c·<·n·&&·left·>·0;·++c) | | [NORMAL] JSHintBear: | | 'c' is already defined. binaries/data/mods/public/simulation/components/Formation.js | 707| » » » » » var·x·=·side·*·Math.ceil(c/2)·*·separation.width; | | [NORMAL] JSHintBear: | | 'x' is already defined. binaries/data/mods/public/simulation/components/Formation.js | 710| » » » » » if·(x·==·0)·//·don't·use·the·center·position·with·a·center·gap | | [NORMAL] JSHintBear: | | 'x' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 712| » » » » » x·+=·side·*·centerGap·/·2; | | [NORMAL] JSHintBear: | | 'x' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 718| » » » » offsets.push(new·Vector2D(x·+·r1,·z·+·r2)); | | [NORMAL] JSHintBear: | | 'x' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 698| » » » if·(!shiftRows·&&·n·>·left) | | [NORMAL] JSHintBear: | | 'n' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 699| » » » » n·=·left; | | [NORMAL] JSHintBear: | | 'n' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 700| » » » for·(var·c·=·0;·c·<·n·&&·left·>·0;·++c) | | [NORMAL] JSHintBear: | | 'n' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 704| » » » » if·(n%2·==·0) | | [NORMAL] JSHintBear: | | 'n' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 714| » » » » var·column·=·Math.ceil(n/2)·+·Math.ceil(c/2)·*·side; | | [NORMAL] JSHintBear: | | 'n' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 724| » » » this.maxColumnsUsed[r]·=·n; | | [NORMAL] JSHintBear: | | 'n' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 753| » for·(var·i·=·sortingClasses.length;·i;·--i) | | [NORMAL] JSHintBear: | | 'i' is already defined. binaries/data/mods/public/simulation/components/Formation.js | 597| » sortingClasses.push("Unknown"); | | [NORMAL] JSHintBear: | | 'sortingClasses' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 602| » for·(var·i·=·0;·i·<·sortingClasses.length;·++i) | | [NORMAL] JSHintBear: | | 'sortingClasses' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 603| » » types[sortingClasses[i]]·=·[]; | | [NORMAL] JSHintBear: | | 'sortingClasses' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 610| » » for·(var·c·=·0;·c·<·sortingClasses.length;·++c) | | [NORMAL] JSHintBear: | | 'sortingClasses' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 612| » » » if·(classes.indexOf(sortingClasses[c])·>·-1) | | [NORMAL] JSHintBear: | | 'sortingClasses' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 614| » » » » types[sortingClasses[c]].push({"ent":·active[i],·"pos":·positions[i]}); | | [NORMAL] JSHintBear: | | 'sortingClasses' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 753| » for·(var·i·=·sortingClasses.length;·i;·--i) | | [NORMAL] JSHintBear: | | 'sortingClasses' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 755| » » var·t·=·types[sortingClasses[i-1]]; | | [NORMAL] JSHintBear: | | 'sortingClasses' used out of scope. binaries/data/mods/public/simulation/components/Formation.js | 860| » var·cmpUnitMotion·=·Engine.QueryInterface(this.entity,·IID_UnitMotion); | | [NORMAL] JSHintBear: | | 'cmpUnitMotion' is already defined.
Link to build: https://jenkins.wildfiregames.com/job/differential/346/display/redirect
Comment Actions
Now that we found a reason for the second of the three occurrences, maybe we can avoid having to create a third revision proposal for the third occurrence (which smells like it could be triggered with some unlucky timing, garrisoning while promoting or such).
Thanks for the fixes.
Comment Actions
The third if (!cmpPosition) is in the Garrison function where actually we do want to garrison out of world entities.