This diff is in response to the comments in rP19226. If a wonder game starts with any wonders already constructed, these will be added to the criticalEnts Map. assignGuardToCriticalEnt will correctly check if the entity passed to it can actually guard, and some other small improvements to the code's quality have been added.
Details
Details
- Reviewers
mimo - Commits
- rP19230: Petra: cleanup of the gameTypeManager (follow up of r19226)
Check to make sure that wonders are still guarded once they are built, and that (in regicide) the AI still assigns guards to the hero unit when it is transported to a different access index.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| binaries/data/mods/public/simulation/ai/petra/gameTypeManager.js | ||
|---|---|---|
| 304 ↗ | (On Diff #545) | Just a white space fix here. |
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/369/ for more details.
Comment Actions
Thanks for the patch. Looks nearly good.
| binaries/data/mods/public/simulation/ai/petra/gameTypeManager.js | ||
|---|---|---|
| 191 ↗ | (On Diff #545) | I think you should add here |
| 382 ↗ | (On Diff #545) | same remark here, add |
| 389 ↗ | (On Diff #545) | Shouldn't it return false? |
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/375/ for more details.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/376/ for more details.