Page MenuHomeWildfire Games

Sandarac
User

Projects

User Details

User Since
Dec 27 2016, 8:33 PM (101 w, 6 d)

Recent Activity

Aug 2 2017

Sandarac updated the summary of D765: Petra: Look for aquatic treasure on naval maps.
Aug 2 2017, 12:13 AM
Sandarac created D765: Petra: Look for aquatic treasure on naval maps.
Aug 2 2017, 12:08 AM

Aug 1 2017

elexis awarded D764: Petra: Fix some cases that would cause territory expansion with Sandbox difficulty a Like token.
Aug 1 2017, 10:47 PM
Sandarac created D764: Petra: Fix some cases that would cause territory expansion with Sandbox difficulty.
Aug 1 2017, 10:43 PM
Sandarac added a comment to D763: Add readonly mode to the CInput.

0ad-project/binaries/... That's not going to apply cleanly when someone tries to test your patch. Please either use arc (described in https://trac.wildfiregames.com/wiki/Phabricator#UsingArcanist), or at the very least ensure that you create the patch using the directory that has binaries/ and source/ as the root.

Aug 1 2017, 8:37 PM

Jul 22 2017

Sandarac created D751: Fix AI error in ApplyEntitiesDelta().
Jul 22 2017, 7:59 AM

Jul 14 2017

Itms awarded D746: Choose AI behavior in gamesetup a 100 token.
Jul 14 2017, 2:05 PM
Sandarac created D746: Choose AI behavior in gamesetup.
Jul 14 2017, 10:43 AM
Sandarac awarded D744: Allow specifying gaia settings in maps, and do so in the maps. a Like token.
Jul 14 2017, 10:28 AM
Sandarac accepted D742: Remove commented out code..
In D742#29187, @elexis wrote:

GameView.cpp:869

Jul 14 2017, 10:26 AM

Jul 12 2017

Sandarac added a comment to D717: Show rank icon above status bars.
In D717#29070, @elexis wrote:

keyword option

Jul 12 2017, 12:11 AM

Jul 11 2017

Sandarac added a comment to D717: Show rank icon above status bars.

(IMO it makes things too crowded, but it just comes down to personal taste.)

Jul 11 2017, 11:51 PM

Jul 10 2017

Sandarac updated the diff for D730: Petra: Move land traders to safety when a trade route is destroyed instead of leaving them idle in the open.

Fix oversight; the traders should only move if !possibleRoute, as well as !ship.

Jul 10 2017, 10:26 AM
elexis awarded D730: Petra: Move land traders to safety when a trade route is destroyed instead of leaving them idle in the open a Like token.
Jul 10 2017, 3:08 AM
Sandarac created D731: Remove CTerritoryManager pointer in CWorld, a relic from before simulation2.
Jul 10 2017, 2:08 AM
Sandarac created D730: Petra: Move land traders to safety when a trade route is destroyed instead of leaving them idle in the open.
Jul 10 2017, 1:38 AM

Jul 9 2017

Sandarac added a comment to D642: Remove remnants of the old, deleted trigger system.
In D642#28784, @leper wrote:

(Also there is an unused CTerritoryManager member var (another non-existent class) in CWorld with a corresponding getter, a relic of the old simulation (before the big rewrite that replaced it with simulation2).)

Care to post another diff for that one?

Okay, will do.

Jul 9 2017, 11:58 PM

Jul 8 2017

Sandarac accepted D708: Allow the AI to research techs in captured structures.

The patch removes the early return and now matches with the trainableEntities() function.

Jul 8 2017, 10:28 PM

Jul 7 2017

Sandarac added a comment to D708: Allow the AI to research techs in captured structures.

I first had to do a bit more reading on how this function is used, but in fact I am still a bit confused about what this patch achieves (maybe I miss something obvious, or didn't read enough):

  • In all 5 uses of researchableTechs(), the civ passed to it will always be the player civ.
  • The trainableEntities() function, which is like a sister function, is sometimes passed a civ (which again is the player civ), or sometimes not, and so it is possible that it may return invalid templates.
Jul 7 2017, 8:56 PM

Jul 6 2017

Sandarac added inline comments to D715: Forbid lobby account registration with parentheses and other characters not thought of.
Jul 6 2017, 6:53 PM

Jul 5 2017

Sandarac created D709: Petra: Fix bug in a case when an army captures its target and then tries to help another army.
Jul 5 2017, 10:01 PM
Sandarac accepted D705: Be less restrictive for building shipyards for mods support.

Alright, the comment was addressed in the new diff, and I ran tests on naval maps with the new diff.

Jul 5 2017, 9:36 PM
Sandarac added inline comments to D708: Allow the AI to research techs in captured structures.
Jul 5 2017, 9:14 PM
Sandarac added a comment to D705: Be less restrictive for building shipyards for mods support.

I believe the diff is good, although to play devil's advocate, I'm really not sure about adding support for arbitrary mods which may or may not be modified later at a whim, making the code irrelevant (there is, of course, no comparable quality control nor review process for Delenda Est, and this is typical for most game mods). And in any case, such added code which panders to mods will be irrelevant/useless in the vast majority of cases anyways, as most people do not use mods (so this could be seen as effectively adding dead code), but only add unneeded complexity which will need to be maintained. I know there is some support in f.e. the structure tree, but that is perhaps different.

Jul 5 2017, 8:26 PM
Sandarac added a comment to D707: Complete support of {civ} replacement in Builder list (as in ProductionQueue).

I don't believe the AI will need adaptation to these changes. The AI never accesses the Builder component (through AIProxy or otherwise); it instead uses its own
buildableEntities() function in entity.js (which is basically the equivalent of cmpBuilder.GetEntitiesList()). And in any case, this change to GetEntitiesList() just adds a template existence check, and the AI already does checks for this in the appropriate places.

Jul 5 2017, 6:21 AM

Jul 3 2017

Sandarac added inline comments to D705: Be less restrictive for building shipyards for mods support.
Jul 3 2017, 10:31 PM

Jul 1 2017

Sandarac awarded rP19862: Recompute water graphics when changing the water level and upon deserialization… a Like token.
Jul 1 2017, 2:32 PM
Sandarac created D698: Fix issue with Healer range visualization described in #4632.
Jul 1 2017, 1:50 AM

Jun 30 2017

Sandarac resigned from rP19375: Move most cinematic path simulation data and control from the graphics class to….
Jun 30 2017, 3:44 PM

Jun 29 2017

Sandarac updated the diff for D684: Fix assertion failure that may happen when closing the game during the loading screen.

Use Vladislav's recommendation and add the function that deletes m_MapReader to the LoadRequests to be called when all map loading tasks are finished, instead of calling it from CGame.

Jun 29 2017, 8:23 PM
Sandarac added a comment to D638: Update graphical water level after deserialization.
In D638#25957, @elexis wrote:

Camera Bug:
The camera height only checks for the terrain and completely ignores the waterheight. Hence it becomes more likely to have the camera below the waterheight with rising water.
It's also relevant to fix for maps that don't change the waterheight later, because if the difference between the terrain and water level is great enough, then the camera will drop off unexpectedly when moving it over a river for example.

Jun 29 2017, 7:38 PM
Sandarac created D695: Petra: Fix possible inconsistent response when trying to become allies.
Jun 29 2017, 4:40 PM
Sandarac added a comment to D684: Fix assertion failure that may happen when closing the game during the loading screen.

Thank you Vladislav for the comments!

Jun 29 2017, 4:29 PM

Jun 28 2017

Sandarac updated the diff for D684: Fix assertion failure that may happen when closing the game during the loading screen.

SAFE_DELETE() m_MapReader once all map-loading tasks have been finished.

Jun 28 2017, 11:23 PM

Jun 27 2017

Sandarac created D684: Fix assertion failure that may happen when closing the game during the loading screen.
Jun 27 2017, 6:24 PM

Jun 26 2017

Sandarac added a comment to D642: Remove remnants of the old, deleted trigger system.

(Also there is an unused CTerritoryManager member var (another non-existent class) in CWorld with a corresponding getter, a relic of the old simulation (before the big rewrite that replaced it with simulation2).)

Jun 26 2017, 7:38 PM

Jun 25 2017

Sandarac added a comment to D651: Fix foundation 6x6 and 8x8 actors..

If you're not going to use arc, you might want to try creating patches from root directory of your working copy. Using your E drive as the root directory is not helpful.

Jun 25 2017, 1:08 PM
This is a test notification, sent at Sun, Jun 25, 11:39 AM.
Jun 25 2017, 11:39 AM
This is a test notification, sent at Sun, Jun 25, 11:39 AM.
Jun 25 2017, 11:39 AM
Sandarac created D676: Petra: use moveToRange() instead of move() in some cases.
Jun 25 2017, 11:27 AM
Sandarac planned changes to D672: Unify duplicated texture creation code in the simulation.
In D672#26968, @wraitii wrote:

I like the idea, but there's really nothing specific here about overlays. I'd refactor this into an overload of CreateTexture (i.e. a no-argument version or something along those lines). You'd have to call it twice, but then it'd be slightly more generic.

If you were to do that, you might check most existing calls to CreateTexture because I'm quite sure that many other cases could be slightly abstracted away.

Jun 25 2017, 10:30 AM

Jun 24 2017

Sandarac resigned from D673: Remove useless computations and simplify code for getting the points of some lines in Selectable component..

I don't really know this code; when adding the range visualization I just moved the code that was already in the old UpdateStaticOverlay into the new UpdateTexturedOverlay (I didn't change/look at the math).

Jun 24 2017, 4:56 PM

Jun 23 2017

Sandarac created D672: Unify duplicated texture creation code in the simulation.
Jun 23 2017, 8:44 AM

Jun 20 2017

Sandarac added inline comments to D660: petra: fix a case when ptol or sele have their cc destroyed while they already had a colony, they would no more try to build a cc.
Jun 20 2017, 4:34 PM

Jun 18 2017

Sandarac added inline comments to D640: Petra: Fix behavior of guards when the guarded entity becomes garrisoned.
Jun 18 2017, 12:52 PM

Jun 16 2017

Sandarac added inline comments to D640: Petra: Fix behavior of guards when the guarded entity becomes garrisoned.
Jun 16 2017, 3:06 PM

Jun 15 2017

elexis awarded D642: Remove remnants of the old, deleted trigger system a Manufacturing Defect? token.
Jun 15 2017, 2:11 PM
Sandarac created D642: Remove remnants of the old, deleted trigger system.
Jun 15 2017, 10:46 AM
Sandarac created D641: Fix issue in rP19732.
Jun 15 2017, 9:02 AM
Sandarac created D640: Petra: Fix behavior of guards when the guarded entity becomes garrisoned.
Jun 15 2017, 8:39 AM

Jun 14 2017

mimo awarded D639: Template loading from the AI a Like token.
Jun 14 2017, 7:28 PM
Itms awarded D639: Template loading from the AI a Like token.
Jun 14 2017, 2:37 PM
elexis awarded D639: Template loading from the AI a Like token.
Jun 14 2017, 1:51 PM
Sandarac created D639: Template loading from the AI.
Jun 14 2017, 1:41 PM

Jun 10 2017

Sandarac added inline comments to rP19756: petra: fix a side effect of rP19655.
Jun 10 2017, 5:04 AM

Jun 6 2017

Sandarac added inline comments to D607: fix a side effect of rP19655.
Jun 6 2017, 3:30 AM
Sandarac added a comment to D601: petra: fix rP19698 when a unit is promoted the same turn the attack is launched.
In D601#24680, @mimo wrote:

Yes, that's an autostart and you need -mod=public

I meant I used the exact command ./pyrogenesis -mod=public -replay=commands.txt on the attached commands.txt, but got the errors I posted when doing so. I didn't pass the mod 'mod', but I did pass the mod 'public'. It seems like some sort of bug.

Jun 6 2017, 3:12 AM

Jun 5 2017

Sandarac added a comment to D600: Petra: do not create trade route crossing enemy territory.
In D600#24684, @mimo wrote:

Thanks, this will be a great help for this issue, but still, as alluded to the trac ticket, I believe that HQ.isDangerousLocation() should be used as well when planing trade routes, even more so as this approach is less perfect than doing an actual computePath check.

isDangerousLocation() also checks the presence of an enemy army around, which is much shorter time range than a trade route.

Yes, and it would be preferable to include it for trade routes (eventually, Petra should check its trade routes periodically with this check imo, even if just using a straight line as is done here). But yes, isUnderEnemyFire is fine.

Jun 5 2017, 6:21 PM

Jun 4 2017

Sandarac added a comment to D576: Fix VisualActor tech changes not being applied in some cases.
In D576#24598, @leper wrote:

I'm not sure if it is worth extra logic to handle the case where an actor changing technology is researched while the user is placing a building.

This does not seem to be handled, or is it?

Jun 4 2017, 7:35 PM
Sandarac updated the diff for D576: Fix VisualActor tech changes not being applied in some cases.

Update SetWallPlacementPreview, remove uneeded QueryOwnerInterface call in GuiInterface.js (just use the player var already passed to the functions), remove old comment in cmpVisual, remove the return in SetActor.

Jun 4 2017, 7:08 PM
Sandarac added a comment to D601: petra: fix rP19698 when a unit is promoted the same turn the attack is launched.
In D601#24623, @mimo wrote:


Replay which shows the problem on turn about 14000

Jun 4 2017, 2:47 AM
Sandarac added a comment to D600: Petra: do not create trade route crossing enemy territory.

Thanks, this will be a great help for this issue, but still, as alluded to the trac ticket, I believe that HQ.isDangerousLocation() should be used as well when planing trade routes, even more so as this approach is less perfect than doing an actual computePath check.

Jun 4 2017, 12:59 AM

Jun 1 2017

Sandarac raised a concern with rP19375: Move most cinematic path simulation data and control from the graphics class to….

This commit seems to be the one that broke two hotkeys, see D584.

Jun 1 2017, 11:20 PM
Sandarac accepted D579: petra: fix an garrison/ungarrison loop due to rP19547.

Okay, this fixes the garrison/ungarrison loop in the described case.

Jun 1 2017, 9:01 PM
Sandarac created D587: Remove VFS cache.
Jun 1 2017, 8:36 PM
Sandarac added a comment to D579: petra: fix an garrison/ungarrison loop due to rP19547.
In D579#23883, @mimo wrote:


a small commands.txt for testing the patch

Jun 1 2017, 7:36 PM
Sandarac accepted D380: Danubius: Spawn gaia waves at civic centers.

The comments were addressed in the new diff, looks good.

Jun 1 2017, 7:30 PM
Sandarac created D584: Fix CinemaManager code that broke some hotkeys.
Jun 1 2017, 6:43 AM

May 31 2017

Sandarac accepted D571: Plus symbol for heal ranges.

I really like this texture for the new heal range, thanks for that (preferably just for entities with the heal component, not for healing auras).

May 31 2017, 9:07 PM
Sandarac resigned from rP19194: Improve AI chat messages.

rP19700

May 31 2017, 9:00 PM
Sandarac added inline comments to D581: Petra: diplomacyManager cleanup.
May 31 2017, 8:47 PM
Sandarac updated the diff for D581: Petra: diplomacyManager cleanup.

Remove typo fix that was committed, add early return if teamsLocked.

May 31 2017, 8:44 PM
Sandarac updated the diff for D581: Petra: diplomacyManager cleanup.

Fix typo in rP19194 in chathelper.js that throws errors.

May 31 2017, 7:52 PM
Sandarac raised a concern with rP19194: Improve AI chat messages.
May 31 2017, 7:49 PM
Sandarac added inline comments to D581: Petra: diplomacyManager cleanup.
May 31 2017, 7:33 PM
Sandarac updated the diff for D581: Petra: diplomacyManager cleanup.

Update.

May 31 2017, 7:25 PM
Sandarac accepted D575: petra: fight back when a cc is captured instead of retreating.

The patch was tested, and it works as advertised.

May 31 2017, 6:18 PM
Sandarac created D581: Petra: diplomacyManager cleanup.
May 31 2017, 5:38 PM
Sandarac added inline comments to D575: petra: fight back when a cc is captured instead of retreating.
May 31 2017, 3:29 AM

May 30 2017

Sandarac added a comment to D545: Petra: fix a case where the AI loose control of its units (they become only driven by UnitAI).

Here is an example when enemy structures are close to the AI's territory, maybe there needs to be a check for structure, the units will get stuck in a loop indefinitely; there are three enemy houses below the civic center:

May 30 2017, 6:59 PM
Sandarac requested changes to D380: Danubius: Spawn gaia waves at civic centers.

I think this trigger script is getting to the point that some of the logic/functions should be moved to a common place (TriggerHelper) so that other scripts can easily use them to handle spawning gaia units/make them patrol/attack, etc. (likely won't happen in this diff), as the lot of the functions are generic enough that they should be elsewhere.

May 30 2017, 6:06 PM
Sandarac updated the diff for D577: Add GetMapSize to cmpTerrain.

Fix that.

May 30 2017, 5:46 AM
Sandarac updated the diff for D577: Add GetMapSize to cmpTerrain.

Some tweaks.

May 30 2017, 5:30 AM
Sandarac created D577: Add GetMapSize to cmpTerrain.
May 30 2017, 5:01 AM

May 29 2017

Sandarac created D576: Fix VisualActor tech changes not being applied in some cases.
May 29 2017, 11:02 PM
Sandarac accepted D566: petra cleanup.

Okay, I think it is good.

May 29 2017, 8:10 PM
Sandarac added inline comments to D566: petra cleanup.
May 29 2017, 7:35 PM
Sandarac updated the diff for D568: Visual Attack Range.

Include wall tower.

May 29 2017, 6:13 AM
Sandarac added a comment to D548: Wild Lake random map script.

I tested this map, and I think it is nice from a gameplay perspective (didn't look at the code).

May 29 2017, 5:32 AM
Sandarac updated the diff for D568: Visual Attack Range.

Update and allow space in the options menu.

May 29 2017, 5:19 AM
Sandarac added a comment to D571: Plus symbol for heal ranges.

This is good to see, it's good to have different textures for different range visualizations (although I'm a bit uncertain if this new texture should also be used for auras that happen to heal, it may be confusing to new players).

May 29 2017, 1:29 AM
Sandarac added inline comments to D566: petra cleanup.
May 29 2017, 12:35 AM

May 28 2017

Sandarac created D568: Visual Attack Range.
May 28 2017, 8:38 PM
Sandarac updated the diff for D563: Fix hero selection rings becoming unsaturated when moving.

Fix whitespace.

May 28 2017, 6:48 AM
Sandarac updated the diff for D432: Visual Heal Range.

Don't save a another var to the rangevis comp that doesn't need to be saved.

May 28 2017, 5:11 AM
Sandarac created D563: Fix hero selection rings becoming unsaturated when moving.
May 28 2017, 12:30 AM

May 27 2017

Sandarac accepted D560: petra: do not gather berries too far.

Seems good.

May 27 2017, 5:22 PM
Sandarac added inline comments to D39: Fix replay menu loading time by using a cache file.
May 27 2017, 4:47 AM

May 26 2017

Sandarac added a comment to D39: Fix replay menu loading time by using a cache file.

On Windows, this diff causes a crash deep in SpiderMonkey when opening the replay menu (not if there is nothing to load in the replay menu though).

May 26 2017, 4:15 PM
Sandarac updated the diff for D555: Refactor range overlay renderering to allow showing ranges in building previews .

Forgot TypeList.h.

May 26 2017, 3:26 PM