Allow rejointest on turn 0
ClosedPublic
Actions

Authored by elexis on May 25 2018, 6:49 PM.

Details

Reviewers: None
Commits: rP22998: Support testing rejoins on turn 0, refs #3460, #4242, #5185, #5162, rP18940
Trac Tickets: #5162
#5185

Summary

Since it is possible to rejoin on turn 0, it should be possible to test it.
#5162 / #5185 describes a reproducible OOS on rejoin on turn 0.

Test Plan

Can we identify a reason why it should be impossible to test?

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 6148
Build 10227: Vulcan Build	Jenkins
Build 10226: arc lint + arc unit

Event Timeline

elexis created this revision.May 25 2018, 6:49 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/568/display/redirect

Harbormaster completed remote builds in B6148: Diff 6643.May 25 2018, 8:48 PM

elexis edited the summary of this revision. (Show Details)Sep 26 2019, 2:05 PM

elexis updated the Trac tickets for this revision.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 26 2019, 2:09 PM

Closed by commit rP22998: Support testing rejoins on turn 0, refs #3460, #4242, #5185, #5162, rP18940 (authored by elexis). · Explain Why

This revision was automatically updated to reflect the committed changes.

elexis added a commit: rP22998: Support testing rejoins on turn 0, refs #3460, #4242, #5185, #5162, rP18940.

Owners added a subscriber: Restricted Owners Package.Sep 26 2019, 2:09 PM

Revision Contents
Changeset List

Path

Size

source/

ps/

Replay.cpp

2 lines

simulation2/

Simulation2.cpp

2 lines

Diff 6643

View Options

source/ps/Replay.cpp