Rewrite harbor without the proxies used in rmgen2 and fix some know issues. Such as circles of grass being painted under the water. The shape of the harbors are also slightly modified to a more natural look.
Not quite ready for review just yet.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 6250 Build 10376: Vulcan Build Jenkins Build 10375: arc lint + arc unit
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues:
Executing section Default...
Executing section Source...
Executing section JS...
| | [NORMAL] ESLintBear (no-multi-spaces):
| | Multiple spaces found before 'heightOffsetSpine'.
|----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/harbor.js
| |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/maps/random/harbor.js
| 60| 60|
| 61| 61| g_Map.log("Creating spines");
| 62| 62| var numSpines = ((numPlayers <= 3 || mapSize >= 320) && numPlayers <= 4 ? 2 : 1) * numPlayers;
| 63| |-var [spineSize, spineTapering, heightOffsetSpine] = mapSize <= 192 ? [0.02, -0.1, 20] : [0.5, -1.4, 35];
| | 63|+var [spineSize, spineTapering, heightOffsetSpine] = mapSize <= 192 ? [0.02, -0.1, 20] : [0.5, -1.4, 35];
| 64| 64|
| 65| 65| for (let i = 0; i < numSpines; ++i)
| 66| 66| {Link to build: https://jenkins.wildfiregames.com/job/differential/650/display/redirect
Comment Actions
(In general currentBiome() conditions are meh, the biome should specify biome-specifc things and then the map should unconditionally use the biome templates.)
| binaries/data/mods/public/maps/random/harbor.js | ||
|---|---|---|
| 219 | here and below, move template to the top for consistency | |
Comment Actions
This diff is with changes to the shape of the harbor to minimise perfect circles ftw. If that’s bad, I am sure there would be a DiskPlacer changed to ClumpPlacer somewhere.