Page MenuHomeWildfire Games

Fix missing refs in sound files.
ClosedPublic

Authored by fatherbushido on Tue, Jan 1, 8:03 PM.

Details

Summary

A powerful tool has detected some missing refs in rP21965.

  • fix the messed paths.
  • also change the attack_order group for the healer which would be messed with civ replacement (the related soundgroup is missing). Use the same as other units (same as support_female too for example). It doesn't change anything as it seems no healer can attack yet.
Test Plan

-

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fatherbushido created this revision.Tue, Jan 1, 8:03 PM
Stan accepted this revision.Tue, Jan 1, 8:07 PM

Thank you for the fix !

binaries/data/mods/public/gui/credits/texts/programming.json
88 ↗(On Diff #7181)

Wasn't there a 9001 or something ? Also maybe it's more a nick than a real name ?

This revision is now accepted and ready to land.Tue, Jan 1, 8:07 PM
smiley awarded a token.Tue, Jan 1, 8:07 PM
fatherbushido marked an inline comment as done.Tue, Jan 1, 8:16 PM

You are welcome.

binaries/data/mods/public/gui/credits/texts/programming.json
88 ↗(On Diff #7181)

Let's skip the 9001 for the moment. It's not a nick because projects have names not nicks.

Stan added a comment.Tue, Jan 1, 8:23 PM

Should I say Patch by: Fork 0AD then ?

In D1725#68444, @Stan wrote:

Should I say Patch by:
Fork 0AD then ?

Yes!

Closed by commit rP22001: Fix missing refs in sound files. (authored by Stan, committed by ). · Explain WhyTue, Jan 1, 9:26 PM
This revision was automatically updated to reflect the committed changes.
Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Tue, Jan 1, 9:26 PM