Page MenuHomeWildfire Games

remove unnecessary building_collapse_large sounds
ClosedPublic

Authored by Nescio on Mar 18 2019, 10:07 AM.

Details

Summary

Because the <death>attack/destruction/building_collapse_large.xml</death> sound is already defined in template_structure.xml and template_gaia_ruins.xml, there is no point in having this line in about every structure template, therefore these lines can be removed.

Test Plan

Ought to be unproblematic.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Mar 18 2019, 10:07 AM
Vulcan added a subscriber: Vulcan.Mar 18 2019, 11:33 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1117/display/redirect

bb accepted this revision.Sat, Apr 6, 4:27 PM

reads correct, greps complete, unit demo works => accept

Now I only got wondering why there is large in building_collapse_large.

This revision is now accepted and ready to land.Sat, Apr 6, 4:27 PM
This revision was automatically updated to reflect the committed changes.