Page MenuHomeWildfire Games

Remove unused variable and conversion in the ComponentManager
Needs ReviewPublic

Authored by Angen on Apr 4 2019, 9:25 PM.

Details

Reviewers
wraitii
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Introduced in rP14877. The variable proto is not used in its scope and function called on assignment does nothing with the object itself (what would affect it later) so can be removed.

There is assert check inside that function for isObjectOrNull but it is done in this scope already.

Test Plan

:)

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7102
Build 11594: Vulcan BuildJenkins
Build 11593: arc lint + arc unit

Event Timeline

Angen created this revision.Apr 4 2019, 9:25 PM
Owners added a subscriber: Restricted Owners Package.Apr 4 2019, 9:25 PM
Vulcan added a subscriber: Vulcan.Apr 4 2019, 9:27 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1169/display/redirect

wraitii added reviewers: wraitii, Restricted Owners Package.Apr 22 2019, 9:35 AM
elexis retitled this revision from Remove not needed variable and conversion to object to Remove unused variable and conversion in the ComponentManager.Apr 25 2019, 12:31 PM