Differential D1919

Fix red squares on some maps when using HQ water effects
ClosedPublic
Actions

Authored by wraitii on May 26 2019, 8:39 AM.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP22310: Fix red squares on some maps when using HQ water effects

Summary

I failed to notice this in rP22297.

The HQ water effects render geometry on top of land in a sometimes crazy manner (honestly that code should be rewritten...) and this led to red squares (See here).

This fixes it.

Test Plan

Check it out in-game.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

D14_thread_pathfinder

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 7611
Build 12414: Vulcan Build	Jenkins
Build 12413: arc lint + arc unit

Event Timeline

wraitii created this revision.May 26 2019, 8:39 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1505/display/redirect

Harbormaster completed remote builds in B7611: Diff 8149.May 26 2019, 9:14 AM

This revision was not accepted when it landed; it landed in state Needs Review.May 28 2019, 11:57 AM

Closed by commit rP22310: Fix red squares on some maps when using HQ water effects (authored by wraitii). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

binaries/

data/

mods/

public/

shaders/

glsl/

water_high.fs

2 lines

Diff 8149

View Options

binaries/data/mods/public/shaders/glsl/water_high.fs

Fix red squares on some maps when using HQ water effectsClosedPublicActions