Page MenuHomeWildfire Games
Differential D2319

Fix undefined resource in PetraAI diplomacy manager after D1846/rP22970.
ClosedPublic
Actions

Authored by Freagarach on Sep 22 2019, 10:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 13, 11:45 AM
Unknown Object (File)
Tue, Sep 3, 10:47 PM
Unknown Object (File)
Aug 24 2024, 6:55 PM
Subscribers
wraitii
Restricted Owners Package

Details

Reviewers
wraitii
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22980: Fix undefined resource in PetraAI diplomacy manager after D1846/rP22970.
Summary

This patch fixes a bug where in was supposed to be a of in iteration in the diplomacy manager of PetraAI after D1846/rP22970.

Test Plan

Play the replay given at rP22970 and verify the warning is gone.
Play new matches to check as well.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Freagarach created this revision.Sep 22 2019, 10:17 PM
Owners added a subscriber: Restricted Owners Package.Sep 22 2019, 10:17 PM
Freagarach mentioned this in rP22970: Adds a "properties"-property to resources and let mods be able to prevent….Sep 22 2019, 10:17 PM
Vulcan added a comment.Sep 22 2019, 10:18 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/293/display/redirect

Vulcan added a comment.Sep 22 2019, 10:21 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/808/display/redirect

Harbormaster completed remote builds in B9560: Diff 9925.Sep 22 2019, 10:21 PM
Freagarach retitled this revision from Bugfixes after D1846/rP22970. to Fix undefined resource in PetraAI diplomacy manager after D1846/rP22970..Sep 22 2019, 10:26 PM
Freagarach edited the summary of this revision. (Show Details)
Freagarach edited the test plan for this revision. (Show Details)
wraitii accepted this revision.Sep 23 2019, 8:45 AM
wraitii added a subscriber: wraitii.

Ran a quick AI 2v1 with some tributing and looked at all other loops in the code, this looks to have been the only miss.

This revision is now accepted and ready to land.Sep 23 2019, 8:45 AM
Closed by commit rP22980: Fix undefined resource in PetraAI diplomacy manager after D1846/rP22970. (authored by wraitii). · Explain WhySep 23 2019, 8:46 AM
This revision was automatically updated to reflect the committed changes.
wraitii added a commit: rP22980: Fix undefined resource in PetraAI diplomacy manager after D1846/rP22970..

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
ai/
petra/
2 lines

Diff 9931

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/diplomacyManager.js

Loading...
Wildfire Games · Phabricator