Page MenuHomeWildfire Games
Differential D2553

[art/actors] standardize fortress actor names
ClosedPublic
Actions

Authored by Nescio on Jan 9 2020, 12:32 PM.

Details

Reviewers
Stan
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23351: Standardize fortress actor names. EOL to native.
Summary

Most fortress actor files are just called fortress, but three civs have different names; this patch standardizes those for consistency; similar to D2552 and D2554.

Test Plan

Check for mistakes and omissions.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 9 2020, 12:32 PM
Owners added a subscriber: Restricted Owners Package.Jan 9 2020, 12:32 PM
Vulcan added a comment.Jan 9 2020, 12:34 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/988/display/redirect

Vulcan added a comment.Jan 9 2020, 12:36 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/84/display/redirect

Vulcan added a comment.Jan 9 2020, 12:36 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1506/display/redirect

Harbormaster completed remote builds in B10698: Diff 10940.Jan 9 2020, 12:36 PM
Nescio mentioned this in D2554: [art/actors] wall_med → wall_medium.Jan 9 2020, 12:59 PM
Nescio edited the summary of this revision. (Show Details)
Stan accepted this revision.Jan 9 2020, 2:20 PM
This revision is now accepted and ready to land.Jan 9 2020, 2:20 PM
Nescio edited the summary of this revision. (Show Details)Jan 9 2020, 2:28 PM
Nescio mentioned this in D2552: [art/actors] standardize tower actor file names.Jan 9 2020, 2:32 PM
Closed by commit rP23351: Standardize fortress actor names. EOL to native. (authored by Stan). · Explain WhyJan 9 2020, 2:37 PM
This revision was automatically updated to reflect the committed changes.
Stan added a commit: rP23351: Standardize fortress actor names. EOL to native..
Stan mentioned this in rP23400: Fix lineendings..Jan 15 2020, 2:39 PM
Nescio retitled this revision from standardize fortress actor names to [art/actors] standardize fortress actor names.May 18 2020, 10:15 AM

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
art/
actors/
structures/
britons/
128 lines
128 lines
gauls/
71 lines
71 lines
macedonians/
48 lines
48 lines
simulation/
templates/
structures/
2 lines
2 lines
2 lines

Diff 10942

View Options

ps/trunk/binaries/data/mods/public/art/actors/structures/britons/fortress.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/structures/britons/fortress_briton.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/structures/gauls/fortress.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/structures/gauls/fortress_gallic.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/structures/macedonians/fortress.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/structures/macedonians/fortress_up.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/brit_fortress.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/gaul_fortress.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/mace_fortress.xml

Loading...
Wildfire Games · Phabricator