Page MenuHomeWildfire Games

gui: standardize modmod buttons width
ClosedPublic

Authored by Nescio on Tue, Jan 14, 7:39 PM.

Details

Reviewers
bb
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23393: Standardize modmod buttons width
Summary

The buttons at the bottom of the mod selection screen all have the same height (28), but slightly different widths (two have 220, three 190, three 194). This patch standardizes them to a width of 180.
As a consequence it also looks better at screens with a width of 960, which is equivalent to 1920 at gui.scale = "2", 2880 at 3×, and 3840 at 4×.
Before:


After:

Test Plan

Agree this is an improvement.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Tue, Jan 14, 7:39 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1037/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/133/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1555/display/redirect

Nescio updated this revision to Diff 11015.Tue, Jan 14, 7:44 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1038/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/134/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1556/display/redirect

bb added a subscriber: bb.Tue, Jan 14, 8:23 PM
bb added inline comments.
binaries/data/mods/mod/gui/modmod/modmod.xml
177–180 ↗(On Diff #11015)

what is this button? seems like it is underneath another button, also not sure if we really want this button

Nescio added inline comments.Tue, Jan 14, 8:30 PM
binaries/data/mods/mod/gui/modmod/modmod.xml
177–180 ↗(On Diff #11015)

Yes, we do. If you disable the 0ad mod, then you can't cancel to return to the 0 A.D. main menu; instead, you can quit. Upon restarting 0ad you go directly back to the mod selection screen, which is desirable.

bb accepted this revision.Tue, Jan 14, 9:02 PM
bb added inline comments.
binaries/data/mods/mod/gui/modmod/modmod.xml
177–180 ↗(On Diff #11015)

never new about that, thx

This revision is now accepted and ready to land.Tue, Jan 14, 9:02 PM
This revision was automatically updated to reflect the committed changes.