Check for m_Territory in CCmpTerritoryManager::IsTerritoryBlinking
ClosedPublic
Actions

Authored by Sandarac on Mar 25 2017, 12:34 AM.

Details

Reviewers

• leper

Commits

rP19343: Ensure m_Territory in cmpTerriotryManager.IsTerritoryBlinking. Fixes #4466.

Trac Tickets

#4466

Summary

As described in the trac ticket, this function uses m_Territory without calling CalculateTerritories() and properly checking for it like other functions in this component.

Test Plan

Check that it compiles.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Sandarac created this revision.Mar 25 2017, 12:34 AM

Thanks.

This revision is now accepted and ready to land.Mar 25 2017, 2:41 AM

Closed by commit rP19343: Ensure m_Territory in cmpTerriotryManager.IsTerritoryBlinking. Fixes #4466. (authored by • leper). · Explain WhyMar 25 2017, 2:43 AM

This revision was automatically updated to reflect the committed changes.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/595/ for more details.

Harbormaster completed remote builds in B882: Diff 936.Mar 25 2017, 3:25 AM