Page MenuHomeWildfire Games

leperDisabled
Disabled

Projects

User Details

User Since
Dec 22 2016, 11:05 AM (102 w, 4 d)
Roles
Disabled

Recent Activity

Apr 22 2018

leper added a comment to D1029: mod.io support.

The part about not indicating something that I don't.

Apr 22 2018, 7:09 PM
leper added a comment to D1029: mod.io support.

Ah, it most likely fails because it cannot nicely convert the enum class into an int (which is the whole point of using an enum class), while not having a hash specialization for the enum class. Seems very much like something that's too complicated. Use a map.

Apr 22 2018, 6:47 PM
leper added a comment to D1029: mod.io support.

Meh, use a normal map if that works. Not worth worrying to much about this (like it seems last) issue.

Apr 22 2018, 6:44 PM
leper added inline comments to D1029: mod.io support.
Apr 22 2018, 5:52 PM
leper added a comment to D1029: mod.io support.
In D1029#59924, @Itms wrote:
  • I got rid of all the helper methods of that struct. It indeed removes a significant number of lines. However the tuple version makes it difficult to name elements (std::get<0> is quite ugly) and even first, second in the case of a pair is less clear than status and progress, so I didn't go all the way.

I suppose the naming helps with that yes. But the main issue was (and to some extent maybe still is) too much code for what is actually required.

Apr 22 2018, 3:48 PM
leper added inline comments to rP21754: Move some utility functions from the public mod to the mod mod in preparation….
Apr 22 2018, 3:15 PM
leper added inline comments to rP21754: Move some utility functions from the public mod to the mod mod in preparation….
Apr 22 2018, 2:53 PM

Apr 21 2018

leper requested changes to D1029: mod.io support.

I suppose if you fix those, and think a lot about the struct thing this is close enough to a state I'm not going to disagree with too much...

Apr 21 2018, 10:06 AM

Apr 20 2018

leper requested changes to D1029: mod.io support.

The below should be most of the things that are still not fixed, there might be more, but there are more interesting things to do than complain about things that were broken relatively recently...

Apr 20 2018, 4:01 AM

Apr 18 2018

leper added a comment to D1029: mod.io support.
In D1029#59608, @Itms wrote:

Another iteration. Includes @s0600204's change to the download size units, and changes from me after your comments. I also made a change to the error propagation in parsing. It uses the production instance.

One of the recent gui changes seems a step on the road of using stale data if things go wrong.

Apr 18 2018, 9:49 PM

Apr 17 2018

leper requested changes to D1029: mod.io support.

I take it some of the last batch of comments are yet to be done.

Apr 17 2018, 8:36 PM

Apr 16 2018

leper requested changes to D1029: mod.io support.

Just to provide some sense of scale, the original patch managed to fit download+verify into 137 lines. This patch here needs 101 lines for most of the status struct.

Apr 16 2018, 12:30 PM

Apr 15 2018

leper requested changes to D1029: mod.io support.

And while I might not agree with a bunch of commits to the mod selector that happened recently (the count of which has increased recently), I'm still somewhat bound to complain about certain things, even though I know some of you would prefer if I wouldn't.

Apr 15 2018, 9:00 AM

Mar 21 2018

leper updated the diff for D1029: mod.io support.

Clarify some things, since people seem to get tons of things wrong anyway.

Mar 21 2018, 7:36 PM

Mar 8 2018

leper added inline comments to D1029: mod.io support.
Mar 8 2018, 12:54 AM
leper updated the summary of D1029: mod.io support.
Mar 8 2018, 12:45 AM
leper updated the diff for D1029: mod.io support.

Some cleanup, slightly nicer gui, connection warning message box.

Mar 8 2018, 12:41 AM

Feb 20 2018

leper updated the diff for D1029: mod.io support.

Use similar external_libs block for libsodium as for other libs.

Feb 20 2018, 8:17 PM

Feb 19 2018

leper added inline comments to D1029: mod.io support.
Feb 19 2018, 7:08 PM
leper updated the summary of D1029: mod.io support.
Feb 19 2018, 7:03 PM
leper updated the diff for D1029: mod.io support.

Move rationale to the header, and extend it a bit.

Feb 19 2018, 7:01 PM

Feb 18 2018

leper added inline comments to D1029: mod.io support.
Feb 18 2018, 7:17 PM

Feb 17 2018

leper updated the diff for D1029: mod.io support.

Open file as binary to make downloads actually work on win32.

Feb 17 2018, 6:33 PM
leper updated the diff for D1029: mod.io support.

Small cleanup, correct handling of malformed trusted comments.

Feb 17 2018, 4:13 PM

Feb 15 2018

leper updated the diff for D1029: mod.io support.

Verify the global sig, add some rationale, some cleanup.

Feb 15 2018, 9:47 PM

Feb 9 2018

leper removed a reviewer for D955: Check for and save mod version for savegames and replays: leper.
Feb 9 2018, 11:09 AM

Feb 7 2018

leper updated the summary of D1029: mod.io support.
Feb 7 2018, 12:50 PM
leper added inline comments to rP21128: Artwork by: LordGood, wowgetoffyourcellphone, Stan, wackyserious, Lion.Kanzen….
Feb 7 2018, 12:49 PM
leper updated the diff for D1029: mod.io support.

With tests. One of which exposes breakage in the conversion code.

Feb 7 2018, 12:47 PM

Feb 6 2018

leper updated the summary of D1029: mod.io support.
Feb 6 2018, 3:36 PM
leper updated the diff for D1029: mod.io support.

Support for multiple signatures, some cleanup, temp file name to handle program termination during the download nicely.

Feb 6 2018, 3:32 PM

Feb 1 2018

leper updated the summary of D1029: mod.io support.
Feb 1 2018, 8:49 AM
leper updated the diff for D1029: mod.io support.

Signing.

Feb 1 2018, 8:27 AM

Jan 30 2018

leper updated the summary of D1029: mod.io support.
Jan 30 2018, 10:31 AM
leper updated the diff for D1029: mod.io support.

Untested signature checking implementation (because downloads from upstream are
currently broken).

Jan 30 2018, 10:27 AM

Jan 22 2018

leper updated the summary of D1029: mod.io support.
Jan 22 2018, 12:05 AM
leper updated the diff for D1029: mod.io support.

Update for upstream API changes.

Jan 22 2018, 12:04 AM

Jan 13 2018

leper added inline comments to D1211: Suggest saveSettingAndWriteToUserConfig() function.
Jan 13 2018, 12:58 AM

Jan 9 2018

leper added inline comments to D1211: Suggest saveSettingAndWriteToUserConfig() function.
Jan 9 2018, 11:09 PM
leper updated the summary of D1029: mod.io support.
Jan 9 2018, 10:21 PM
leper updated the diff for D1029: mod.io support.

Upstream does not require secrets for downloads anymore.
Some cleanup.

Jan 9 2018, 10:18 PM

Jan 8 2018

leper updated the summary of D1029: mod.io support.
Jan 8 2018, 3:34 AM
leper updated the diff for D1029: mod.io support.

Use a custom write function to simplify hash computation.
Now check the hash. Currently not checking the length (which should be done as long as there's only md5...).

Jan 8 2018, 3:26 AM

Jan 2 2018

leper updated the test plan for D1029: mod.io support.
Jan 2 2018, 3:01 AM
leper updated the summary of D1029: mod.io support.
Jan 2 2018, 3:00 AM
leper updated the diff for D1029: mod.io support.

Now with working downloads.

Jan 2 2018, 2:54 AM
leper added a comment to D1029: mod.io support.
In D1029#48094, @elexis wrote:

Binding to a commercial website from a free & open source gives me a bit stomach ache.

It's more of an API and depending on some development some parts might be open source so one could host it. That said this is both WIP and a PoC.

Jan 2 2018, 1:25 AM

Dec 31 2017

leper added a comment to D1029: mod.io support.

In case someone didn't notice that this is based on top of my working branch which will not move forward past r20551, then consider yourself informed now.

Dec 31 2017, 3:50 PM
leper removed a reviewer for D1029: mod.io support: Restricted Project.
Dec 31 2017, 1:55 AM
leper updated the summary of D1029: mod.io support.
Dec 31 2017, 1:55 AM
leper updated the diff for D1029: mod.io support.

Small updates for API changes.

Dec 31 2017, 1:51 AM

Dec 19 2017

leper changed the visibility for D1029: mod.io support.
Dec 19 2017, 6:43 PM
leper abandoned D454: Subscribe to RenderSubmit dynamically, since it is only needed for the debug overlay..

I guess the RL test isn't going to happen, and me caring to update this in case someone actually gets around to check this also isn't.

Dec 19 2017, 6:42 PM
leper abandoned D422: Do not rely on undefined behavior in an unsupported part of the glooxwrapper..

Feel free to commit this in case you think it helps with not invoking undefined behaviour.

Dec 19 2017, 6:41 PM
leper abandoned D744: Allow specifying gaia settings in maps, and do so in the maps..

Feel free to take over, I guess here you're unlikely to break things you don't care to understand.

Dec 19 2017, 6:40 PM
leper raised a concern with rP20552: Cleanup mod selection GUI page..

Still broken. Well I guess because at some point I stopped reading commits that fixed one thing and broke at least two others.

Dec 19 2017, 6:40 PM
leper added a comment to rP15677: Add mod selection mod..

Thanks for giving the user an easy way to enable and disable mods!

Thanks for cleaning this up, breaking parts of it, not caring about invalidating possibly not obvious parts of the design instead of figuring out or even just asking to clarify that, then being smug about having done so. Have fun mainta^W breaking this more.

Dec 19 2017, 6:38 PM

Dec 1 2017

leper edited reviewers for D1081: Cleanup mod page cleanup in r20552, added: Itms; removed: leper.

I could have written that yesterday already if we would focus our energy on the partial agreement instead of the partial disagreement.

Given that you went ahead and decided to commit something broken I'll take the liberty of not doing the work of fixing your breakage. Have fun.

Dec 1 2017, 10:13 PM

Nov 29 2017

leper requested changes to D1082: Deprecate mod types.

Does this actually differ from D1081?

Nov 29 2017, 10:18 PM
leper requested changes to D1081: Cleanup mod page cleanup in r20552.

See comments elsewhere.

Nov 29 2017, 10:17 PM
leper added inline comments to rP20552: Cleanup mod selection GUI page..
Nov 29 2017, 10:15 PM
leper requested changes to D1085: Unify simulation Engine.ReadJSON, simulation Engine.ReadCivJSONFile with the unified gui rmgen Engine.ReadJSON.

Does not really seem any cleaner.

Nov 29 2017, 9:57 PM
leper added a comment to D1062: Delete CMapGeneratorWorker::GetCivData, badly located JS rmgen civ data parsing code and gui/common/functions_civinfo.js.

Can someone clarify this whole debate you're having? I don't really understand the issue.

Is it that ReadJSONFile shouldn't, in general, be able to read files in /gui? If so, it's probably best to have a readJSON method for everything but GUI.

  • The simulation shouldn't be able to read anything apart from files under simulation/.
  • rmgen shouldn't be able to read anything apart from things in maps/ and simulation/.
  • GUI can read anything, because why not.
Nov 29 2017, 8:45 AM
leper accepted D1068: Remove hack from cxxtest premake module.

Works without pch.

Nov 29 2017, 4:39 AM
leper added a comment to D422: Do not rely on undefined behavior in an unsupported part of the glooxwrapper..
In D422#42077, @Itms wrote:

Tested and works [...]

I assume you built passed the parameter for building the shared glooxwrapper?

Nov 29 2017, 3:29 AM
leper updated the diff for D422: Do not rely on undefined behavior in an unsupported part of the glooxwrapper..

Now with UNUSED().

Nov 29 2017, 3:27 AM
leper added a comment to D1062: Delete CMapGeneratorWorker::GetCivData, badly located JS rmgen civ data parsing code and gui/common/functions_civinfo.js.
In D1062#42930, @elexis wrote:

rmgen/ needs to be able to read from simulation/ and maps/ but should for the same reason not be able to read from gui/.

Given a quick grep there are 2 cases in which JSON files are read in maps/. That is not counting the one that reads civ files that already uses the helper. I'm not sure why we should have a generic function (that does not have the same behaviour everywhere) and then make things more complicated by restricting that. Two wrappers around the common function including the registration part should count in at something around 12 lines and that is counting blank lines.

Nov 29 2017, 3:15 AM
leper added inline comments to D1080: Move mod version label from GUI pages to the mod info.
Nov 29 2017, 3:06 AM
leper added inline comments to D1080: Move mod version label from GUI pages to the mod info.
Nov 29 2017, 2:47 AM
leper added a comment to D1080: Move mod version label from GUI pages to the mod info.

Then factor out those common things into two XML files, or possibly even one and unify the capitalization of those. Oh, wait, parts of that have already been done, maybe just do the others instead of trying to do something because something must be done and this is something.

Nov 29 2017, 1:27 AM
leper added inline comments to D1079: Sort mods with arrow icons and string changes.
Nov 29 2017, 1:18 AM
leper added a comment to rP20551: Allow civ specific techs with {civ}.

I'd still prefer getting rid of the individual non-{civ} and non-generic techs, might need a little cleanup in a few places, or introduction of replaces: "phase_x", though probably with an array. (Though I guess not introducing the latter is a lot cleaner.

Nov 29 2017, 1:13 AM
leper added a comment to D1076: Remove separate gaia range query from BuildingAI.

This also removes the "preferential" treatment of enemies over gaia. Not that I guess any of that has been considered since fixing a single map seems important.

Nov 29 2017, 1:10 AM
leper added a comment to rP20541: Rename gui/savedgames/ to gui/savegame/ so that the page XML filename always….

Why can't page_foo_bar.xml not be for foo/bar/? Not that there is any need to have all of that in a single folder. Folders make things easier to compartmentalize, use them.

Nov 29 2017, 1:07 AM
leper added a comment to rP20540: Fix Builder and ProductionQueue schemas inconsistencies.

Doesn't fix the one invalid comment before the actual replacement.

Nov 29 2017, 1:06 AM
leper added a comment to D1062: Delete CMapGeneratorWorker::GetCivData, badly located JS rmgen civ data parsing code and gui/common/functions_civinfo.js.
In D1062#42638, @elexis wrote:

Implementing an unrestricted ReadJSONFile and a ReadSimulationJSONFile dilutes the point on unification and still doesn't prevent rmgen code from loading gui/ JSON files. One might argue that loading anything from gui/ is blatantly obviously a bad idea and thus not important to prevent in C++. But then that same argument would hold for simulation too. Not easy going. Tried two things (P95) and got nowhere. Retrying with a namespace.

Nov 29 2017, 1:01 AM
leper raised a concern with rP20552: Cleanup mod selection GUI page..

Something something reviews.

Nov 29 2017, 12:49 AM

Nov 26 2017

leper added a comment to rP20521: Units should only be able to build structures from their owner's civ, and not….

No, what was done previously just had no sense. If we want to only allow to build structures from the Identity civ, then the unit template should just not have {civ} but the civ we want: It would be useless to have that {civ} replacement here,. The behaviour of the patch (replaced by the civ player, as is done in the ProductionQueue for units) is what has always been expected but was buggy.

Ah, I guess I was somewhat confused by the comment that wasn't fixed in rP16506 that still talks about the entity. Same for the schema here and in the production queue.

Nov 26 2017, 2:24 AM

Nov 25 2017

leper added a comment to rP20521: Units should only be able to build structures from their owner's civ, and not….

(See differential and or ticket)

Those just state "Yeah, that shouldn't be done and now we'll enshrine that after not checking any previous discussion after less than a day of discussion.".

Nov 25 2017, 10:41 PM
leper added inline comments to D1062: Delete CMapGeneratorWorker::GetCivData, badly located JS rmgen civ data parsing code and gui/common/functions_civinfo.js.
Nov 25 2017, 10:40 PM
leper added a comment to rP20521: Units should only be able to build structures from their owner's civ, and not….

This now prevents C&C style capturing (which allows one to build everything from the other faction). It also somewhat breaks that one cheat.

Nov 25 2017, 10:23 PM
leper added inline comments to D1064: Fix undefined behavior in the StunClient.
Nov 25 2017, 10:20 PM
leper added a comment to D1039: Remove PickSpawnPointBothPass.

That seems limiting. Imagine a case where a ship can and does garrison siege engines. Assuming sane people they would try to get to land, but nobody would care about dying just to save some heavy equipment.

The logic is, if a unit can ungarrison when we click the ungarrison button then they should also ungarrison when the ship dies, the two behaviors should be exactly the same.

Depends if we want to reward players for being lazy. Also it seems that the consensus was that we don't want to do that in this case at some point.

Nov 25 2017, 10:17 PM
leper added a comment to D945: Projectile hit animation.

Also what @bb said.

Nov 25 2017, 10:14 PM
leper added a comment to D8: Change internals of EntityMap to use an std:: vector.
In D8#42149, @wraitii wrote:

Rename ITERATOR_GATE to ITERATOR_FENCE as that's the right name for it.

Sentinel might be the word you are looking for.

Nov 25 2017, 9:57 PM
leper added a comment to D1039: Remove PickSpawnPointBothPass.

For example, healers and cavalry can garrison in a bireme, but when it sinks they'll die rather than try to ungarrison:

<GarrisonHolder>
  <EjectClassesOnDestroy datatype="tokens">FemaleCitizen Infantry Dog</EjectClassesOnDestroy>
  <List datatype="tokens">Support Infantry Cavalry Dog</List>

I feel the lists should be the same (which means we can get rid of EjectClassesOnDestroy).

That seems limiting. Imagine a case where a ship can and does garrison siege engines. Assuming sane people they would try to get to land, but nobody would care about dying just to save some heavy equipment.

Nov 25 2017, 9:54 PM
leper committed rP20519: More ScriptInterface const..
More ScriptInterface const.
Nov 25 2017, 7:50 AM
leper closed D863: More ScriptInterface const..
Nov 25 2017, 7:50 AM
leper raised a concern with rP20381: Migrate to premake5, fixes #3729..
Nov 25 2017, 7:45 AM
leper added inline comments to D1062: Delete CMapGeneratorWorker::GetCivData, badly located JS rmgen civ data parsing code and gui/common/functions_civinfo.js.
Nov 25 2017, 6:03 AM
leper added inline comments to rP20517: Remove +1 in getPlayerTeam and areAllies of rmgen/ and -1 in the calls to that….
Nov 25 2017, 5:47 AM
leper added a comment to rP20369: Fix few typos found with the Debian lintian tool..
In rP20369#24246, @bb wrote:

programming.json?

(Wasn't sure if it can be considered a sufficient programming effort.)

Probably not, still it doesn't really hurt to include it.

Nov 25 2017, 5:13 AM
leper resigned from rP19408: Fix CChart scaling edgecases (constant value and infinity).

Ah, hadn't noticed that one.

Nov 25 2017, 4:15 AM
leper added inline comments to D1062: Delete CMapGeneratorWorker::GetCivData, badly located JS rmgen civ data parsing code and gui/common/functions_civinfo.js.
Nov 25 2017, 4:13 AM
leper raised a concern with rP19408: Fix CChart scaling edgecases (constant value and infinity).
Nov 25 2017, 4:05 AM
leper abandoned D413: Remove unused variables and an unused function..

I'll keep the current thing in my local tree, in case someone cares enough about this to do the work take over.

Nov 25 2017, 3:55 AM
leper updated the diff for D422: Do not rely on undefined behavior in an unsupported part of the glooxwrapper..

Now with the correct commit.

Nov 25 2017, 3:52 AM
leper updated the diff for D422: Do not rely on undefined behavior in an unsupported part of the glooxwrapper..

Actually fail. Not really more tested than the previous iteration, though I have had this iteration in my local copy for a while.

Nov 25 2017, 3:51 AM
leper updated the diff for D863: More ScriptInterface const..

Remove now useless include. Also include network code changes.

Nov 25 2017, 3:41 AM
leper requested changes to D1062: Delete CMapGeneratorWorker::GetCivData, badly located JS rmgen civ data parsing code and gui/common/functions_civinfo.js.
Nov 25 2017, 3:24 AM