rP23847 introduced a crash which happened each time someone used a non wxCheckbox control
Details
- Reviewers
Silier vladislavbelov - Commits
- rP23881: Fix Atlas crash introduced by rP23847
Make sure everything works as expected, saving loading, editing fields
Remove conquest from binaries/data/mods/public/simulation/data/settings/victory_conditions/conquest_structures.json and binaries/data/mods/public/simulation/data/settings/victory_conditions/conquest_units.json and check that ticking conquest disable both of them. but that disabling it does nothing as it's handled by the rest of the code.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Map/Map.cpp | ||
---|---|---|
330 ↗ | (On Diff #12837) | There is something that doesn't work here for conquest, not sure what I do bad. |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2741/display/redirect
source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Map/Map.cpp | ||
---|---|---|
330 ↗ | (On Diff #12837) | Hmm. Found another issue in current svn state. Uncheck conquest. |
source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Map/Map.cpp | ||
---|---|---|
330 ↗ | (On Diff #12837) | Fixed Angen issue by setting it to false always. |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2743/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2744/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2746/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2747/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2748/display/redirect
source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Map/Map.cpp | ||
---|---|---|
316 ↗ | (On Diff #12845) | this is not working. |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2759/display/redirect
I've tested the patch on Windows 10, it works for me for any map settings editing. The patch looks ok, a bit wordy but ok for atlas.
source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Map/Map.cpp | ||
---|---|---|
111 ↗ | (On Diff #12864) | Unnecessary empty line. |
both disabledwhenchecked and changeonchecked works correctly
cannot reproduce any crashes