Differential D2918

Fixes cavalry units
Needs RevisionPublic
Actions

Authored by Mr.lie on Jul 28 2020, 4:25 PM.

Details

Reviewers

Stan

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Summary

This patch fixes several issues on cavalry units

attach missing reins
correct wrong variant-name on iberian cavalry_javelinist_e_m
delete unnecessary/wrong variant-names (base_horse_death, base_horse_trot) on several heroes/champions (in this cases i.e. no blood was shown on animations)

Test Plan

iterate through all cavalry units in atlas to see it works correct

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 12642
Build 24443: Vulcan Build	Jenkins
Build 24442: Vulcan Build (macOS)	Jenkins
Build 24441: Vulcan Build (Windows)	Jenkins

Event Timeline

Mr.lie created this revision.Jul 28 2020, 4:25 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2797/display/redirect

Harbormaster completed remote builds in B12642: Diff 12946.Jul 28 2020, 4:49 PM

I'm not sure all the actors need reins, some do not use them.

binaries/data/mods/public/art/actors/units/iberians/cavalry_javelinist_e_m.xml
27	Same here is there a bug?
binaries/data/mods/public/art/actors/units/macedonians/hero_cavalry_spearman_philip_m.xml
29	Fix looks correct, but do you have an actual bug with those?

This revision now requires changes to proceed.Jul 28 2020, 10:37 PM

Revision Contents
Changeset List

Path

Size

binaries/

data/

mods/

public/

art/

actors/

units/

carthaginians/

	cavalry_spearman_a_m.xml
	cavalry_spearman_a_m.xml (Revision 23905)

1 line

	cavalry_spearman_b_m.xml
	cavalry_spearman_b_m.xml (Revision 23905)

1 line

	cavalry_spearman_c_m.xml
	cavalry_spearman_c_m.xml (Revision 23905)

1 line

	cavalry_spearman_e_m.xml
	cavalry_spearman_e_m.xml (Revision 23905)

1 line

iberians/

	cavalry_javelinist_e_m.xml
	cavalry_javelinist_e_m.xml (Revision 23905)

2 lines

kushites/

	hero_cavalry_spearman_harsiotef_m.xml
	hero_cavalry_spearman_harsiotef_m.xml (Revision 23905)

4 lines

	hero_cavalry_spearman_nastasen_m.xml
	hero_cavalry_spearman_nastasen_m.xml (Revision 23905)

4 lines

macedonians/

	cavalry_spearman_c_m.xml
	cavalry_spearman_c_m.xml (Revision 23905)

4 lines

	hero_cavalry_spearman_philip_m.xml
	hero_cavalry_spearman_philip_m.xml (Revision 23905)

4 lines

	hero_cavalry_spearman_pyrrhus_m.xml
	hero_cavalry_spearman_pyrrhus_m.xml (Revision 23905)

4 lines

ptolemies/

	cavalry_spearman_a_m.xml
	cavalry_spearman_a_m.xml (Revision 23905)

1 line

	cavalry_spearman_c_m.xml
	cavalry_spearman_c_m.xml (Revision 23905)

1 line

	cavalry_spearman_e_m.xml
	cavalry_spearman_e_m.xml (Revision 23905)

1 line

Diff 12946

View Options

binaries/data/mods/public/art/actors/units/carthaginians/cavalry_spearman_a_m.xml

View Options

binaries/data/mods/public/art/actors/units/carthaginians/cavalry_spearman_b_m.xml

View Options

binaries/data/mods/public/art/actors/units/carthaginians/cavalry_spearman_c_m.xml

View Options

binaries/data/mods/public/art/actors/units/carthaginians/cavalry_spearman_e_m.xml

View Options

binaries/data/mods/public/art/actors/units/iberians/cavalry_javelinist_e_m.xml

View Options

binaries/data/mods/public/art/actors/units/kushites/hero_cavalry_spearman_harsiotef_m.xml

View Options

binaries/data/mods/public/art/actors/units/kushites/hero_cavalry_spearman_nastasen_m.xml

View Options

binaries/data/mods/public/art/actors/units/macedonians/cavalry_spearman_c_m.xml

View Options

binaries/data/mods/public/art/actors/units/macedonians/hero_cavalry_spearman_philip_m.xml

View Options

binaries/data/mods/public/art/actors/units/macedonians/hero_cavalry_spearman_pyrrhus_m.xml

View Options

binaries/data/mods/public/art/actors/units/ptolemies/cavalry_spearman_a_m.xml

View Options

binaries/data/mods/public/art/actors/units/ptolemies/cavalry_spearman_c_m.xml

View Options

binaries/data/mods/public/art/actors/units/ptolemies/cavalry_spearman_e_m.xml

Fixes cavalry unitsNeeds RevisionPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 12946

binaries/data/mods/public/art/actors/units/carthaginians/cavalry_spearman_a_m.xml

binaries/data/mods/public/art/actors/units/carthaginians/cavalry_spearman_b_m.xml

binaries/data/mods/public/art/actors/units/carthaginians/cavalry_spearman_c_m.xml

binaries/data/mods/public/art/actors/units/carthaginians/cavalry_spearman_e_m.xml

binaries/data/mods/public/art/actors/units/iberians/cavalry_javelinist_e_m.xml

binaries/data/mods/public/art/actors/units/kushites/hero_cavalry_spearman_harsiotef_m.xml

binaries/data/mods/public/art/actors/units/kushites/hero_cavalry_spearman_nastasen_m.xml

binaries/data/mods/public/art/actors/units/macedonians/cavalry_spearman_c_m.xml

binaries/data/mods/public/art/actors/units/macedonians/hero_cavalry_spearman_philip_m.xml

binaries/data/mods/public/art/actors/units/macedonians/hero_cavalry_spearman_pyrrhus_m.xml

binaries/data/mods/public/art/actors/units/ptolemies/cavalry_spearman_a_m.xml

binaries/data/mods/public/art/actors/units/ptolemies/cavalry_spearman_c_m.xml

binaries/data/mods/public/art/actors/units/ptolemies/cavalry_spearman_e_m.xml

Fixes cavalry units
Needs RevisionPublic
Actions

Revision Contents
Changeset List