Page MenuHomeWildfire Games

Add Catafalque to placeablesFilter
AbandonedPublic

Authored by elexis on Apr 14 2017, 1:07 PM.

Details

Reviewers
Sandarac
Summary

Adding this new directory to this file means it will be placeable in atlas and the units demo map.

Test Plan

Open atlas, click on the objects tab, search for catafalque. Start the units demo map.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1108
Build 1746: Vulcan BuildJenkins
Build 1745: arc lint + arc unit

Event Timeline

elexis created this revision.Apr 14 2017, 1:07 PM
Vulcan added a subscriber: Vulcan.Apr 14 2017, 1:53 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/758/ for more details.

Sandarac requested changes to this revision.Apr 14 2017, 1:56 PM
Sandarac added a subscriber: Sandarac.

I think there needs to be decisions made first on how to handle relic units that have been hand-placed by map makers - mainly because the script for capture the relic does not currently take into account relic units already on the map at game-start.

This revision now requires changes to proceed.Apr 14 2017, 1:56 PM
elexis abandoned this revision.Sep 7 2017, 12:14 AM

The placeables part will be included in D878. Tracking the script issue in #4762.