Page MenuHomeWildfire Games

Fix strange character at the end of kush arsenal specific name
ClosedPublic

Authored by Silier on Jan 10 2021, 1:10 PM.

Details

Reviewers
Nescio
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP24534: Fix strange character at the end of kush arsenal specific name
Summary

Currenlty when one looks into specific name of kush arsenal there is weird character at the end.
Maybe there was some strange encoding or something, but visible part did not changed.

Test Plan

:)

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Silier created this revision.Jan 10 2021, 1:10 PM
Owners added a subscriber: Restricted Owners Package.Jan 10 2021, 1:10 PM
Silier published this revision for review.Jan 10 2021, 1:11 PM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2744/display/redirect for more details.

Stan added a subscriber: Stan.Jan 10 2021, 1:32 PM

What was the commit ? Could be a weird space

Nescio added a subscriber: Nescio.Jan 10 2021, 1:40 PM

Both strings really look the same to me, I wonder what's changed.

Nescio accepted this revision.Jan 10 2021, 1:49 PM

Yes, you're right, there is an empty character between the s and the <, which shouldn't be there, and is correctly removed by this patch. I do wonder how it got introduced, though.

This revision is now accepted and ready to land.Jan 10 2021, 1:49 PM
This revision was automatically updated to reflect the committed changes.