Following rP24462, the OOS debugSerializer would try to serialize AI objects entirely. This is extremely slow (might be an infinite loop in some cases).
Instead, it should print the result of Serialize() in those cases.
Details
- Reviewers
- None
- Commits
- rP24641: Fix lag on OOS with AIs
- Trac Tickets
- #5917
Have an OOS with AIs.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- temp
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 15029 Build 32512: Vulcan Build Jenkins Build 32511: Vulcan Build (macOS) Jenkins Build 32510: Vulcan Build (Windows) Jenkins Build 32509: arc lint + arc unit
Time | Test | |
---|---|---|
0 ms | Jenkins > TestComponentManager::Debug: Test / test_script_serialization Error: Expected (std::string(debugStream.str()) == std::string("rng: \"78606\"\nentities:\n- id: 1\n TestScript1_values:\n comp: {\n \"x\": 1234,\n \"str\": \"this is a string\",\n \"things\": {\n \"a\": 1,\n \"b\": \"2\",\n \"c\": [\n 3,\n \"4\",\n [\n 5,\n []\n ]\n ]\n }\n}\n\n- id: 2\n TestScript1_entity:\n comp: {}\n\n- id: 3\n TestScript1_nontree:\n comp: ({x:[[2], [2], [], {y:[2]}]})\n\n- id: 4\n TestScript1_custom:\n comp: {\n \"c\": 1\n} (raw: ({y:2}))\n\n")), found ("rng: \"78606\"\nentities:\n- id: 1\n TestScript1_values:\n comp: {\n \"x\": 1234,\n \"str\": \"this is a string\",\n \"things\": {\n \"a\": 1,\n \"b\": \"2\",\n \"c\": [\n 3,\n \"4\",\n [\n 5,\n []\n ]\n ]\n }\n}\n\n- id: 2\n TestScript1_entity:\n comp: {}\n\n- id: 3\n TestScript1_nontree:\n comp: ({x:[[2], [2], [], {y:[2]}]})\n\n- id: 4\n TestScript1_custom:\n comp: {\n \"c\": 1\n}\n\n" != "rng: \"78606\"\nentities:\n- id: 1\n TestScript1_values:\n comp: {\n \"x\": 1234,\n \"str\": \"this is a string\",\n \"things\": {\n \"a\": 1,\n \"b\": \"2\",\n \"c\": [\n 3,\n \"4\",\n [\n 5,\n []\n ]\n ]\n }\n}\n\n- id: 2\n TestScript1_entity:\n comp: {}\n\n- id: 3\n TestScript1_nontree:\n comp: ({x:[[2], [2], [], {y:[2]}]})\n\n- id: 4\n TestScript1_custom:\n comp: {\n \"c\": 1\n} (raw: ({y:2}))\n\n") | |
0 ms | Jenkins > TestComponentManager::Release: Test / test_script_serialization Error: Expected (std::string(debugStream.str()) == std::string("rng: \"78606\"\nentities:\n- id: 1\n TestScript1_values:\n comp: {\n \"x\": 1234,\n \"str\": \"this is a string\",\n \"things\": {\n \"a\": 1,\n \"b\": \"2\",\n \"c\": [\n 3,\n \"4\",\n [\n 5,\n []\n ]\n ]\n }\n}\n\n- id: 2\n TestScript1_entity:\n comp: {}\n\n- id: 3\n TestScript1_nontree:\n comp: ({x:[[2], [2], [], {y:[2]}]})\n\n- id: 4\n TestScript1_custom:\n comp: {\n \"c\": 1\n} (raw: ({y:2}))\n\n")), found ("rng: \"78606\"\nentities:\n- id: 1\n TestScript1_values:\n comp: {\n \"x\": 1234,\n \"str\": \"this is a string\",\n \"things\": {\n \"a\": 1,\n \"b\": \"2\",\n \"c\": [\n 3,\n \"4\",\n [\n 5,\n []\n ]\n ]\n }\n}\n\n- id: 2\n TestScript1_entity:\n comp: {}\n\n- id: 3\n TestScript1_nontree:\n comp: ({x:[[2], [2], [], {y:[2]}]})\n\n- id: 4\n TestScript1_custom:\n comp: {\n \"c\": 1\n}\n\n" != "rng: \"78606\"\nentities:\n- id: 1\n TestScript1_values:\n comp: {\n \"x\": 1234,\n \"str\": \"this is a string\",\n \"things\": {\n \"a\": 1,\n \"b\": \"2\",\n \"c\": [\n 3,\n \"4\",\n [\n 5,\n []\n ]\n ]\n }\n}\n\n- id: 2\n TestScript1_entity:\n comp: {}\n\n- id: 3\n TestScript1_nontree:\n comp: ({x:[[2], [2], [], {y:[2]}]})\n\n- id: 4\n TestScript1_custom:\n comp: {\n \"c\": 1\n} (raw: ({y:2}))\n\n") | |
0 ms | Jenkins > TestComponentManager::test_script_serialization Error: Expected (std::string(debugStream.str()) == std::string("rng: \"78606\"\nentities:\n- id: 1\n TestScript1_values:\n comp: {\n \"x\": 1234,\n \"str\": \"this is a string\",\n \"things\": {\n \"a\": 1,\n \"b\": \"2\",\n \"c\": [\n 3,\n \"4\",\n [\n 5,\n []\n ]\n ]\n }\n}\n\n- id: 2\n TestScript1_entity:\n comp: {}\n\n- id: 3\n TestScript1_nontree:\n comp: ({x:[[2], [2], [], {y:[2]}]})\n\n- id: 4\n TestScript1_custom:\n comp: {\n \"c\": 1\n} (raw: ({y:2}))\n\n")), found ("rng: \"78606\"\nentities:\n- id: 1\n TestScript1_values:\n comp: {\n \"x\": 1234,\n \"str\": \"this is a string\",\n \"things\": {\n \"a\": 1,\n \"b\": \"2\",\n \"c\": [\n 3,\n \"4\",\n [\n 5,\n []\n ]\n ]\n }\n}\n\n- id: 2\n TestScript1_entity:\n comp: {}\n\n- id: 3\n TestScript1_nontree:\n comp: ({x:[[2], [2], [], {y:[2]}]})\n\n- id: 4\n TestScript1_custom:\n comp: {\n \"c\": 1\n}\n\n" != "rng: \"78606\"\nentities:\n- id: 1\n TestScript1_values:\n comp: {\n \"x\": 1234,\n \"str\": \"this is a string\",\n \"things\": {\n \"a\": 1,\n \"b\": \"2\",\n \"c\": [\n 3,\n \"4\",\n [\n 5,\n []\n ]\n ]\n }\n}\n\n- id: 2\n TestScript1_entity:\n comp: {}\n\n- id: 3\n TestScript1_nontree:\n comp: ({x:[[2], [2], [], {y:[2]}]})\n\n- id: 4\n TestScript1_custom:\n comp: {\n \"c\": 1\n} (raw: ({y:2}))\n\n") | |
0 ms | Jenkins > TestComponentManager::test_script_serialization Error: Expected (std::string(debugStream.str()) == std::string("rng: \"78606\"\nentities:\n- id: 1\n TestScript1_values:\n comp: {\n \"x\": 1234,\n \"str\": \"this is a string\",\n \"things\": {\n \"a\": 1,\n \"b\": \"2\",\n \"c\": [\n 3,\n \"4\",\n [\n 5,\n []\n ]\n ]\n }\n}\n\n- id: 2\n TestScript1_entity:\n comp: {}\n\n- id: 3\n TestScript1_nontree:\n comp: ({x:[[2], [2], [], {y:[2]}]})\n\n- id: 4\n TestScript1_custom:\n comp: {\n \"c\": 1\n} (raw: ({y:2}))\n\n")), found ("rng: \"78606\"\nentities:\n- id: 1\n TestScript1_values:\n comp: {\n \"x\": 1234,\n \"str\": \"this is a string\",\n \"things\": {\n \"a\": 1,\n \"b\": \"2\",\n \"c\": [\n 3,\n \"4\",\n [\n 5,\n []\n ]\n ]\n }\n}\n\n- id: 2\n TestScript1_entity:\n comp: {}\n\n- id: 3\n TestScript1_nontree:\n comp: ({x:[[2], [2], [], {y:[2]}]})\n\n- id: 4\n TestScript1_custom:\n comp: {\n \"c\": 1\n}\n\n" != "rng: \"78606\"\nentities:\n- id: 1\n TestScript1_values:\n comp: {\n \"x\": 1234,\n \"str\": \"this is a string\",\n \"things\": {\n \"a\": 1,\n \"b\": \"2\",\n \"c\": [\n 3,\n \"4\",\n [\n 5,\n []\n ]\n ]\n }\n}\n\n- id: 2\n TestScript1_entity:\n comp: {}\n\n- id: 3\n TestScript1_nontree:\n comp: ({x:[[2], [2], [], {y:[2]}]})\n\n- id: 4\n TestScript1_custom:\n comp: {\n \"c\": 1\n} (raw: ({y:2}))\n\n") | |
0 ms | Jenkins > TestAllocators::Debug: Test / test_da | |
View Full Test Results (4 Failed · 1,388 Passed) |
Event Timeline
Build has FAILED
builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framewor
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2861/display/redirect
See console output for more information: https://jenkins.wildfiregames.com/job/macos-differential/2861/display/redirectconsole
Build has FAILED
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3949/display/redirect
See console output for more information: https://jenkins.wildfiregames.com/job/vs2015-differential/3949/display/redirectconsole
Build has FAILED
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/4520/display/redirect
See console output for more information: https://jenkins.wildfiregames.com/job/docker-differential/4520/display/redirectconsole
Build is green
builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui_dbg.a(precompiled.o) has no symbols ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library fi
See https://jenkins.wildfiregames.com/job/macos-differential/2870/display/redirect for more details.