Lobbybots: update readme to reflect mod_ipstamp being optional
ClosedPublic
Actions

Authored by wraitii on Jan 25 2021, 1:49 PM.

Details

Reviewers

user1
Dunedan

Commits

rP24857: Lobbybots: update readme to reflect mod_ipstamp being optional

Trac Tickets

#5913

Summary

Following #5913, and once D3490 gets merge, the mod_ipstamp extension to ejabberd will no longer be required for the lobby, but only optional. If not installed, users must host with STUN.

This updates the readme to reflect that, and cleans up a few other things.

Test Plan

Review

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jan 25 2021, 1:49 PM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framewor

See https://jenkins.wildfiregames.com/job/macos-differential/3055/display/redirect for more details.

Harbormaster completed remote builds in B15406: Diff 15684.Jan 25 2021, 1:57 PM

wraitii requested review of this revision.Jan 25 2021, 1:57 PM

Silier added a subscriber: Silier.Jan 25 2021, 5:50 PM

Silier added inline comments.

source/tools/lobbybots/README.md
435 ↗	(On Diff #15684)	remove ipbots mention

Comments.

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/3069/display/redirect for more details.

Harbormaster completed remote builds in B15429: Diff 15707.Jan 26 2021, 6:00 PM

Needs to be modified if we merge D3490, because the XMPP server still needs to transfer the client IP to WFGBot, so that the latter can send the client his external IP (which they will then transmit to joiners). However, it would only be required for non-STUN hosts, so it's not as much of a requirement as before.

Ideally we could merge something cleaner later on, with perhaps the bot telling whether it has IP capabilities or something.

Update for D3490

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/3110/display/redirect for more details.

Harbormaster completed remote builds in B15480: Diff 15759.Jan 28 2021, 9:31 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2021, 3:22 PM

Closed by commit rP24857: Lobbybots: update readme to reflect mod_ipstamp being optional (authored by wraitii). · Explain Why

This revision was automatically updated to reflect the committed changes.

wraitii added a commit: rP24857: Lobbybots: update readme to reflect mod_ipstamp being optional.