Page MenuHomeWildfire Games

Dunedan
User

Projects

User Details

User Since
Aug 30 2017, 9:44 PM (66 w, 6 d)

Recent Activity

Nov 11 2018

Dunedan added a comment to D1661: lobby bots systemd service.

As already mentioned I don't see a benefit in using a sysvinit script. I'd just use one systemd service template for each bot and one systemd service instance per bot instance.
Such a systemd template would look like:

[Unit]
Description=XPartaMuPP Pyrogenesis/0 A.D. Lobby Bot %i
Documentation=https://trac.wildfiregames.com/
After=network.target ejabberd.service
Nov 11 2018, 10:11 AM

Nov 7 2018

Dunedan added a comment to D1661: lobby bots systemd service.

Why to use systemd services to call sysvinit init scripts? Why not just using systemd services? That'd make everything easier.

Nov 7 2018, 11:00 PM
Dunedan added a comment to D1659: Correct and complete lobby server readme.
In D1659#65939, @elexis wrote:

We need two bots per room, not two bots per server.

Nov 7 2018, 10:59 PM
Dunedan added a comment to D1659: Correct and complete lobby server readme.
In D1659#65912, @elexis wrote:

The pid/logfile is handled by systemd.
There is one logfile and pidfile per bot, at least one bot per room, but one systemd service handling all bots.
I don't see a better place to put them rather than the directory for that room for that bot, do you know one?
(Every bot instance needs an own code copy to provide the correct version for everyroom).

Nov 7 2018, 8:23 PM

Nov 6 2018

Dunedan added a comment to D1659: Correct and complete lobby server readme.
In D1659#65867, @elexis wrote:

Perhaps it makes sense to have the bots in the same python installation package.

Nov 6 2018, 7:39 PM

Nov 3 2018

Dunedan added a comment to D1659: Correct and complete lobby server readme.
In D1659#65858, @elexis wrote:

A folder named XpartaMuPP should not contain EcheLOn.
I propose to use a separate folder for XPartaMupp and EcheLOn. The directory is becoming quite messy. Not going to upload a diff with moved files, but I do propose:

Nov 3 2018, 7:28 PM

Sep 30 2018

Dunedan added a comment to rP21719: Send rating related requests directly to EcheLOn..

@user1: Do you have any more details regarding this?

Sep 30 2018, 7:28 PM

Jul 8 2018

Dunedan accepted D1570: Fix typo in lobby server README.
Jul 8 2018, 8:17 PM
Dunedan added inline comments to D1525: Add a lobby server port config option .
Jul 8 2018, 2:20 PM

Mar 31 2018

Dunedan added a comment to D1177: Send rating related requests directly to EcheLOn.
In D1177#58260, @elexis wrote:

Does this throw any kind of error if EcheLOn is offline? (Guess not, given how few code this diff changes)

Mar 31 2018, 1:22 PM
Dunedan updated the diff for D1177: Send rating related requests directly to EcheLOn.

Rebased to account for some lobby changes in SVN.

Mar 31 2018, 12:46 PM

Mar 17 2018

Dunedan awarded D1366: Don't add the period outside a translated string a Like token.
Mar 17 2018, 9:42 PM

Mar 11 2018

Dunedan created D1378: Address concerns of rP20321.
Mar 11 2018, 6:49 PM

Feb 3 2018

Dunedan accepted D897: Secure lobby authentication - prevent joins as a different player.
In D897#52116, @Imarok wrote:

If we recieve an unexpected lobbyauth token, we should just ignore it. Everything else will be far too complicated for no benefit.

Feb 3 2018, 8:05 PM
Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.
In D897#51842, @Imarok wrote:

Reply with an empty result.

Feb 3 2018, 1:35 PM

Jan 27 2018

Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.
In D897#51174, @Imarok wrote:

So this would be ok for you?:

The stanza currently sent will become a request of the type set.
The servers xmpp client will respond over xmpp with an ack or whatever that the receiver will just accept and ignore.

Jan 27 2018, 10:45 PM

Jan 26 2018

Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.
In D897#50538, @Dunedan wrote:
  • The child element of IQ-stanzas should be named query, instead of auth.
Jan 26 2018, 8:46 AM

Jan 24 2018

Dunedan added a comment to D978: Add XSDs for the custom XMPP IQ stanzas.

Easy to answer:

  • I wasn't aware that there are already other schemas for XML documents in 0ad (I might have searched for XSD only).
  • XMPP extensions are usually defined using XSD (e.g. here is a random example: https://xmpp.org/extensions/xep-0092.html#schema)
Jan 24 2018, 6:22 PM
Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.
In D897#50757, @Imarok wrote:

Could you show me the part of the standard that says a response always must be a answer to a query? I couldn' t find it the last time I looked into it.

Jan 24 2018, 6:17 PM
Dunedan planned changes to D978: Add XSDs for the custom XMPP IQ stanzas.

XSD for game results is still missing.

Jan 24 2018, 1:36 PM

Jan 23 2018

Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.
In D897#50646, @Imarok wrote:

Then most of our code is not valid. I think it's valid enough...

Jan 23 2018, 8:27 PM
Dunedan requested changes to D897: Secure lobby authentication - prevent joins as a different player.
Jan 23 2018, 8:01 PM
Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.

It's intended that he stanza sent is a response and not a request. Exactly to follow this request-response rule. (With the exception, that the request from the server wasn't sent via xmpp but via enet)

Jan 23 2018, 7:57 PM

Jan 22 2018

Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.
In D897#50427, @Imarok wrote:

It's missing cause the stanza is printed before gloox adds it.

Jan 22 2018, 9:44 PM

Jan 21 2018

Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.
In D897#50124, @Imarok wrote:

Edit: This is how an iq-stanza sent for lobby auth should look like:

SendIqLobbyAuth [<iq to='imarok@lobby.wildfiregames.com/0ad' id='uid-1f75c630-00000005' type='result'><auth xmlns='jabber:iq:lobbyauth'><token>CABE93B117739A47</token></auth></iq>]
Jan 21 2018, 6:09 PM

Jan 15 2018

Dunedan added a comment to D791: Lobby reconnect dialog on disconnected.

An alternative is to connect using a regular XMPP client instead of a second instance of 0ad. As the second XMPP client uses another resource identifier it's not causing any problems.

Jan 15 2018, 10:20 PM
Dunedan added a comment to D791: Lobby reconnect dialog on disconnected.
In D791#49737, @mapkoc wrote:

Dunedan, I see a problem with that. If you open a second window and join multiplayer, both windows would fight to auto reconnect. Maybe it's best to give the user the decision.

Jan 15 2018, 8:38 PM
Dunedan updated the diff for D1182: Make XMPP-bots work with newer SleekXMPP versions.

For whatever reason the changes for EcheLOn were missing. This update to the patch adds them

Jan 15 2018, 7:23 PM

Jan 14 2018

Dunedan added a comment to D791: Lobby reconnect dialog on disconnected.

Why showing a dialog in the first place at all and not automatically reconnecting in the background (with exponential back-off, ...) and only showing a dialog of that continues to fail?

Jan 14 2018, 8:27 PM
Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.

For me this patch doesn't work applied to current master. When setting up a new game with enabled "Require lobby authentication" the game setup page never opens and instead it gets stuck at the "Registering with server" dialog. What I can see in the background is that there is a IQ-stanza sent via XMPP, but this stanza doesn't even contain a recipient (and might have some other problems, but more on that once it works). For me it looks like the game tries to authenticate the hosting player as well. Is that intented?

Jan 14 2018, 6:07 PM
Dunedan created D1222: Fix crash in lobby.
Jan 14 2018, 4:04 PM

Jan 12 2018

Dunedan added a comment to D628: Escape underscore(and other characters) in like clauses in echelon ratings bot..

Step 1. Apply the patch and install python3-sqlalchemy-utils on the server.

Jan 12 2018, 6:34 PM

Jan 9 2018

Dunedan added a comment to D1208: Update mod_ipstamp for current ejabberd versions.
In D1208#49232, @Itms wrote:

I'm facing a blocking issue before even testing this: I cannot install ejabberd from the backports on a fresh Debian VM...

Jan 9 2018, 11:02 PM

Jan 8 2018

Dunedan updated the summary of D1208: Update mod_ipstamp for current ejabberd versions.
Jan 8 2018, 8:20 PM
Dunedan created D1208: Update mod_ipstamp for current ejabberd versions.
Jan 8 2018, 8:19 PM

Jan 7 2018

Dunedan accepted D280: Convert Lobby README to markdown.

@Itms: Apparently there is already a note in the README about the supported ejabberd versions. Enough for you to continue to review or even approve this patch?

Jan 7 2018, 8:51 PM
Dunedan added inline comments to D206: Lobby Bot Optimizations and Upgrade to SleekXMPP 1.3.1+ (Merge from github branch).
Jan 7 2018, 7:15 PM
Dunedan added a comment to D280: Convert Lobby README to markdown.

I feel like this patch is in some kind of dead-lock right now.

Jan 7 2018, 3:12 PM

Jan 6 2018

Dunedan updated the diff for D1197: Fix timestamps in lobby for delayed messages with microseconds.

Improved docstrings

Jan 6 2018, 5:00 PM
Dunedan updated the diff for D1197: Fix timestamps in lobby for delayed messages with microseconds.

Fix diff

Jan 6 2018, 8:42 AM
Dunedan updated the diff for D1197: Fix timestamps in lobby for delayed messages with microseconds.

As suggested changed the if to a for loop.

Jan 6 2018, 8:40 AM

Jan 5 2018

Dunedan added a comment to D1197: Fix timestamps in lobby for delayed messages with microseconds.
In D1197#48522, @elexis wrote:

Can you try to take a look to unify that, preferably by just updating the pattern?

Jan 5 2018, 9:12 PM
Dunedan added a comment to D1197: Fix timestamps in lobby for delayed messages with microseconds.
In D1197#48513, @elexis wrote:

XEP numbers and links should be documented in the code (see ticket, see documentation of the function).

Jan 5 2018, 8:28 PM
Dunedan created D1197: Fix timestamps in lobby for delayed messages with microseconds.
Jan 5 2018, 6:51 PM

Jan 3 2018

Dunedan added a comment to D1153: Optional lobby chat presence brightness and dot, player ratings.

I like the idea of optional message for created/finished games, but I'm not a big fan of the other two. What I'd rather like to see a brightness change get used for is for the message backlog when joining the room.
I think the dots and brightness per status add to much clutter to the chat window, especially as they dynamically adjust to the current player status. They also don't provide any information which isn't already available from the nick list.

Jan 3 2018, 9:40 PM

Jan 1 2018

Dunedan added a comment to D1188: Allow different ingame name with real username revelation.

I tried it out and it works as advertised. While I like the idea in general I find the two-names-per-chat-message a bit too much. What about showing the lobby-username only in the summary screen and using the multiplayer name for the chat messages, no matter how the multiplayer game was set up?

Jan 1 2018, 2:32 PM

Dec 30 2017

Dunedan awarded D1162: Gather near dropsite rather than current position after finishing construction a Yellow Medal token.
Dec 30 2017, 8:23 AM

Dec 29 2017

Dunedan added a comment to D280: Convert Lobby README to markdown.
In D280#47719, @elexis wrote:

Dunedan if you have any code updates, please upload them.

Dec 29 2017, 10:08 AM

Dec 28 2017

Dunedan created D1182: Make XMPP-bots work with newer SleekXMPP versions.
Dec 28 2017, 2:48 PM
Dunedan added a comment to D280: Convert Lobby README to markdown.

The README instructions are correct for ejabberd version 2.x but not later. I think we can start work on that in a trac ticket discussing changes (code and readme changes) needed for upgrading ejabberd.

Dec 28 2017, 10:54 AM
Dunedan accepted D828: Unselect lobby game if the selected player isn't present in any game.

I tried it out and it works like a charm. A little, but a really nice improvement. ๐Ÿ‘

Dec 28 2017, 9:14 AM

Dec 27 2017

Dunedan added a comment to D1010: Template organization: geology.

The following commands should work:

Dec 27 2017, 9:52 PM
Dunedan added a comment to D1009: Template organization: flora and fauna.

The following commands should work:

Dec 27 2017, 9:48 PM

Dec 26 2017

Dunedan created D1177: Send rating related requests directly to EcheLOn.
Dec 26 2017, 1:30 PM
Dunedan added a comment to D1172: Lobby chat spam filter.

+1 for min_message_interval for the lobby, because that does enforce such a limit on server side, thus not allowing a player to remove it.

Dec 26 2017, 12:29 PM

Oct 26 2017

Dunedan awarded D937: Town bell - use matching classes, add a market alert a Like token.
Oct 26 2017, 5:37 PM
Dunedan awarded D965: Show fauna silhouettes a Like token.
Oct 26 2017, 5:36 PM
Dunedan accepted D975: Fix typo in log message: occured.
Oct 26 2017, 5:35 PM
Dunedan accepted D973: Fix typo in log message.
Oct 26 2017, 5:34 PM
Dunedan accepted D974: Fix typo in log message: recieved.
Oct 26 2017, 5:33 PM

Oct 25 2017

Dunedan awarded rP14162: Increasing the generation speed of the maps: Unknown Land a Like token.
Oct 25 2017, 10:32 PM
Dunedan awarded rP14162: Increasing the generation speed of the maps: Unknown Land a Like token.
Oct 25 2017, 10:31 PM
Dunedan awarded rP14162: Increasing the generation speed of the maps: Unknown Land a Like token.
Oct 25 2017, 10:31 PM

Oct 22 2017

Dunedan created D978: Add XSDs for the custom XMPP IQ stanzas.
Oct 22 2017, 10:13 PM

Oct 21 2017

Dunedan updated the diff for D899: Add id for IQ stanzas.

Added myself to the credits.

Oct 21 2017, 8:49 AM

Oct 9 2017

Dunedan added a comment to D899: Add id for IQ stanzas.
In D899#37200, @Imarok wrote:

Ok, then wanna make a ticket about that?

Oct 9 2017, 8:12 PM
Dunedan added a comment to D899: Add id for IQ stanzas.
In D899#37194, @Imarok wrote:

As said in irc already, it should probably be checked before why we don't get back the correct id when sending iqs to the bot.

Oct 9 2017, 6:33 PM

Sep 13 2017

Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.

First: the PMs containing "secureLobbyAuth: " are filtered out, so no player will receive Thema.

Sep 13 2017, 7:52 AM

Sep 12 2017

Dunedan accepted D622: Use utf8 instead of iso-8859-1 in XML files.
  • The files included in the patch are the only XML-files in the whole 0ad-repo with encoding ISO-8859* (except for ./binaries/data/mods/public/gui/common/init.xml, which already got deleted in f2c16d1cdae273df86530a6b49b4a6c6cdee3549)
    • checked with: find ./ -iname '*.xml' -exec grep -l -i -E 'encoding=.*iso-8859' {} \;
  • None of the files above contains non-ASCII-characters:
    • checked with: for f in $(find ./ -iname '*.xml' -exec grep -l -i -E 'encoding=.*iso-8859' {} \;); do grep --color='auto' -H -P -n '[\x80-\xFF]' $f; done
Sep 12 2017, 10:29 PM
Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.

A custom iq stanza would be the cleanest way to implement it (and avoid the secureLobbyAuth: string), but sounds like work.

Sep 12 2017, 4:21 PM
elexis awarded D899: Add id for IQ stanzas a Like token.
Sep 12 2017, 3:15 PM

Sep 10 2017

Dunedan created D899: Add id for IQ stanzas.
Sep 10 2017, 5:39 PM
Dunedan awarded D879: Trade gain related to the current map size a Like token.
Sep 10 2017, 12:52 PM

Sep 9 2017

Dunedan added a comment to D897: Secure lobby authentication - prevent joins as a different player.

I've no knowledge of the background of this, so please bear with me that's a stupid question, but why is there the need for a separate handshake, when each player is already authenticated to the lobby with its unique XMPP JID? Can't that, or something derived from it, be used as GUID?

Sep 9 2017, 4:40 PM