Differential D357

Don't tag an entity as packing when the packing is completed.
ClosedPublic
Actions

Authored by fatherbushido on Apr 18 2017, 11:42 AM.

Details

Reviewers

leper

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP19429: Don't tag an entity as packing when the packing is completed. Reviewed by leper.

Summary

Splitted from D143

Test Plan

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fatherbushido created this revision.Apr 18 2017, 11:42 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/808/ for more details.

Harbormaster completed remote builds in B1172: Diff 1328.Apr 18 2017, 12:42 PM

leper accepted this revision.Apr 18 2017, 8:20 PM

This revision is now accepted and ready to land.Apr 18 2017, 8:20 PM

Closed by commit rP19429: Don't tag an entity as packing when the packing is completed. Reviewed by leper. (authored by fatherbushido). · Explain WhyApr 18 2017, 9:45 PM

This revision was automatically updated to reflect the committed changes.

leper mentioned this in D143: Don't regenerate status bars for destroyed entities..Apr 23 2017, 12:22 AM